97249 2012-09-20 12:19:32 -0700 Web Inspector: [REGRESSION] Cmd-Shift-C doesn't enable element inspection mode when inspector hidden 2012-09-24 04:55:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paulirish apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 724749 0 paulirish 2012-09-20 12:19:32 -0700 I believe we have a slight regression here, cmd-shift-c does start element inspection when inspector is visible, however when it's still hidden it only opens the inspector. this is different behavior than what cmd-shift-c did previously. 725360 1 apavlov 2012-09-21 03:10:16 -0700 The code was broken in http://trac.webkit.org/changeset/125871 725376 2 165108 apavlov 2012-09-21 03:28:18 -0700 Created attachment 165108 Patch 726560 3 apavlov 2012-09-24 04:55:30 -0700 Committed r129348: <http://trac.webkit.org/changeset/129348> 165108 2012-09-21 03:28:18 -0700 2012-09-24 04:34:48 -0700 Patch bug-97249-20120921142742.patch text/plain 3094 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDYxNWMyNTRjZGJmNWQ5 NzRmNjY2NWY2Mzg1OTg1MjI3NmYyNDBlNS4uNDdhMjgwZTZiNThhZjJjOTBmMmRhZDhjMzJkZTQ0 NmQzMDRiN2M0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTIxICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW1JFR1JFU1NJT05dIENtZC1TaGlmdC1DIGRvZXNuJ3QgZW5hYmxlIGVsZW1lbnQgaW5z cGVjdGlvbiBtb2RlIHdoZW4gaW5zcGVjdG9yIGhpZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggcmVncmVzc2lvbiBmcm9tIHIxMjU4NzEuCisK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvckZyb250ZW5kQVBJLmpzOgor ICAgICAgICAoSW5zcGVjdG9yRnJvbnRlbmRBUEkuZW50ZXJJbnNwZWN0RWxlbWVudE1vZGUpOgor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLl9jcmVhdGVHbG9iYWxTdGF0dXNCYXJJdGVtcyk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuZG9jdW1lbnRLZXlEb3duKToKKwogMjAxMi0wOS0yMSAgS2Vpc2hpIEhhdHRvcmkgIDxr ZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgZGF0YWxpc3Qgc3VnZ2VzdGlvbnMgaW50 byBEYXRlVGltZUNob29zZXJQYXJhbWV0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvckZyb250ZW5kQVBJLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbnNwZWN0b3JGcm9udGVuZEFQSS5qcwppbmRleCBiYWI1 MjllZjBkZDA0NzA0YWU0OGVlZTRhZjM0NjQzMDJjMjM5MjcyLi4wNjM2Mzk4NmU3NDM1YjlhZDg5 ZTllYTY1YmQ3YjQ5M2I0ZTNmMTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0luc3BlY3RvckZyb250ZW5kQVBJLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yRnJvbnRlbmRBUEkuanMKQEAgLTEwMSw3ICsx MDEsNyBAQCBJbnNwZWN0b3JGcm9udGVuZEFQSSA9IHsKIAogICAgIGVudGVySW5zcGVjdEVsZW1l bnRNb2RlOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWwoImVs ZW1lbnRzIikudG9nZ2xlU2VhcmNoaW5nRm9yTm9kZSgpOworICAgICAgICBXZWJJbnNwZWN0b3Iu dG9nZ2xlU2VhcmNoaW5nRm9yTm9kZSgpOwogICAgIH0sCiAKICAgICBzYXZlZFVSTDogZnVuY3Rp b24odXJsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5qcwppbmRleCBhYjY3YzQ3NGM0ZGE0YWRkZjZjMmE0ZjQzOTQ4ZjBjNjFkZDFkMjkyLi5lNzdh OTBiZmE3YmFmNmM2ZDRlYWYzMWI2M2FlOWY4MjExNTkxY2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtODYsNyArODYsNyBAQCB2 YXIgV2ViSW5zcGVjdG9yID0gewogCiAgICAgICAgIGlmICghV2ViSW5zcGVjdG9yLldvcmtlck1h bmFnZXIuaXNXb3JrZXJGcm9udGVuZCgpKSB7CiAgICAgICAgICAgICB0aGlzLl9ub2RlU2VhcmNo QnV0dG9uID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJTZWxlY3QgYW4gZWxlbWVudCBpbiB0aGUgcGFnZSB0byBpbnNwZWN0IGl0LiIpLCAi bm9kZS1zZWFyY2gtc3RhdHVzLWJhci1pdGVtIik7Ci0gICAgICAgICAgICB0aGlzLl9ub2RlU2Vh cmNoQnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fdG9nZ2xlU2VhcmNoaW5n Rm9yTm9kZSwgdGhpcyk7CisgICAgICAgICAgICB0aGlzLl9ub2RlU2VhcmNoQnV0dG9uLmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy50b2dnbGVTZWFyY2hpbmdGb3JOb2RlLCB0aGlzKTsK ICAgICAgICAgICAgIG1haW5TdGF0dXNCYXIuaW5zZXJ0QmVmb3JlKHRoaXMuX25vZGVTZWFyY2hC dXR0b24uZWxlbWVudCwgYm90dG9tU3RhdHVzQmFyQ29udGFpbmVyKTsKICAgICAgICAgfQogCkBA IC0zNTYsNyArMzU2LDcgQEAgdmFyIFdlYkluc3BlY3RvciA9IHsKICAgICAgICAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0LnNldFpvb21GYWN0b3IoTWF0aC5wb3coMS4yLCB0aGlzLl96b29tTGV2ZWwp KTsKICAgICB9LAogCi0gICAgX3RvZ2dsZVNlYXJjaGluZ0Zvck5vZGU6IGZ1bmN0aW9uKCkKKyAg ICB0b2dnbGVTZWFyY2hpbmdGb3JOb2RlOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIg ZW5hYmxlZCA9ICF0aGlzLl9ub2RlU2VhcmNoQnV0dG9uLnRvZ2dsZWQ7CiAgICAgICAgIC8qKgpA QCAtODYyLDcgKzg2Miw3IEBAIFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24gPSBmdW5jdGlv bihldmVudCkKICAgICAgICAgICAgIHZhciBpc05vZGVTZWFyY2hLZXkgPSBldmVudC5jdHJsS2V5 ICYmICFldmVudC5tZXRhS2V5ICYmICFldmVudC5hbHRLZXkgJiYgZXZlbnQuc2hpZnRLZXk7CiAK ICAgICAgICAgaWYgKGlzTm9kZVNlYXJjaEtleSkgewotICAgICAgICAgICAgdGhpcy5fdG9nZ2xl U2VhcmNoaW5nRm9yTm9kZSgpOworICAgICAgICAgICAgdGhpcy50b2dnbGVTZWFyY2hpbmdGb3JO b2RlKCk7CiAgICAgICAgICAgICBldmVudC5jb25zdW1lKHRydWUpOwogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9Cg==