97230 2012-09-20 10:06:17 -0700 [Chromium] Switch back to a fixed fifo path for Android 2012-09-21 07:25:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97227 1 peter peter tony oldest_to_newest 724590 0 peter 2012-09-20 10:06:17 -0700 We *may* switch to using a fixed path to the fifo files rather than relying on the sd-card, considering not all external storage will be formatted with a file system that supports creating fifos. While there is a small chance this will never have to land, I'd like to request review so we can re-enable running layout tests after that lands on the Chromium side and is pulled in to WebKit. This is, in a way, a preemptive layout-test-running fix. 724592 1 164936 peter 2012-09-20 10:08:42 -0700 Created attachment 164936 Patch 724645 2 164936 tony 2012-09-20 10:56:31 -0700 Comment on attachment 164936 Patch OK, but you'll probably need to rebase. 725502 3 peter 2012-09-21 07:25:00 -0700 Committed r129226: <http://trac.webkit.org/changeset/129226> 164936 2012-09-20 10:08:42 -0700 2012-09-20 10:56:31 -0700 Patch preemptive-fix.patch text/plain 4116 peter ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ODg5 MjcwLi43MjkyNTUwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTItMDktMjAgIFBldGVyIEJldmVybG9vICA8cGV0 ZXJAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtDaHJvbWl1bV0gU3dpdGNoIGJhY2sgdG8gYSBm aXhlZCBmaWZvIHBhdGggZm9yIEFuZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk3MjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBub3QgYWxsIGV4dGVybmFsIHN0b3JhZ2UgY2FyZHMg d2lsbCBiZSBmb3JtYXRlZCB1c2luZyBhIGZpbGUKKyAgICAgICAgc3lzdGVtIHRoYXQgc3VwcG9y dHMgbmFtZWQgcGlwZXMsIENocm9taXVtIGhhcyBiZWVuIGNoYW5nZWQgdG8gY3JlYXRpbmcKKyAg ICAgICAgdGhlIHBpcGVzIGluIGEgdGVtcG9yYXJ5IGZvbGRlciBvbiB0aGUgaW50ZXJuYWwgc3Rv cmFnZS4gQWRhcHQgdGhpcyBpbgorICAgICAgICBXZWJLaXQgc28gd2UgY2FuIGNvbnRpbnVlIHRv IHJ1biBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHk6CisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRE cml2ZXIuX19pbml0X18pOgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkRHJpdmVyLl9zZXR1cF90 ZXN0KToKKyAgICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fdXBkYXRlX3ZlcnNpb24pOgor CisyMDEyLTA5LTIwICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwogICAg ICAgICBMZXZlcmFnZSBDaHJvbWl1bSdzIGNvZGUgdG8gc2V0IHVwIEZJRk9zIGZvciBDaHJvbWl1 bSBBbmRyb2lkIGxheW91dCB0ZXN0cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTcyMjcKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CmluZGV4IDFhZjMw YzUuLjMxNGJhM2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKQEAgLTU2LDYgKzU2LDkgQEAg Q09NTUFORF9MSU5FX0ZJTEUgPSBERVZJQ0VfU09VUkNFX1JPT1RfRElSICsgJ2Nocm9tZS1uYXRp dmUtdGVzdHMtY29tbWFuZC1saW5lJwogREVWSUNFX0RSVF9ESVIgPSBERVZJQ0VfU09VUkNFX1JP T1RfRElSICsgJ2RydC8nCiBERVZJQ0VfRk9SV0FSREVSX1BBVEggPSBERVZJQ0VfRFJUX0RJUiAr ICdmb3J3YXJkZXInCiAKKyMgUGF0aCBvbiB0aGUgZGV2aWNlIHdoZXJlIHRoZSB0ZXN0IGZyYW1l d29yayB3aWxsIGNyZWF0ZSB0aGUgZmlmbyBwaXBlcy4KK0RFVklDRV9GSUZPX1BBVEggPSBERVZJ Q0VfU09VUkNFX1JPT1RfRElSICsgJ25hdGl2ZV90ZXN0cy8nCisKIERSVF9BUFBfUEFDS0FHRSA9 ICdvcmcuY2hyb21pdW0ubmF0aXZlX3Rlc3QnCiBEUlRfQUNUSVZJVFlfRlVMTF9OQU1FID0gRFJU X0FQUF9QQUNLQUdFICsgJy8uQ2hyb21lTmF0aXZlVGVzdEFjdGl2aXR5JwogRFJUX0FQUF9DQUNI RV9ESVIgPSBERVZJQ0VfRFJUX0RJUiArICdjYWNoZS8nCkBAIC0zMTEsOSArMzE0LDkgQEAgY2xh c3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogICAgIGRlZiBfX2luaXRf XyhzZWxmLCBwb3J0LCB3b3JrZXJfbnVtYmVyLCBwaXhlbF90ZXN0cywgbm9fdGltZW91dD1GYWxz ZSk6CiAgICAgICAgIHN1cGVyKENocm9taXVtQW5kcm9pZERyaXZlciwgc2VsZikuX19pbml0X18o cG9ydCwgd29ya2VyX251bWJlciwgcGl4ZWxfdGVzdHMsIG5vX3RpbWVvdXQpCiAgICAgICAgIHNl bGYuX2NtZF9saW5lID0gTm9uZQotICAgICAgICBzZWxmLl9pbl9maWZvX3BhdGggPSAnJwotICAg ICAgICBzZWxmLl9vdXRfZmlmb19wYXRoID0gJycKLSAgICAgICAgc2VsZi5fZXJyX2ZpZm9fcGF0 aCA9ICcnCisgICAgICAgIHNlbGYuX2luX2ZpZm9fcGF0aCA9IERFVklDRV9GSUZPX1BBVEggKyAn c3RkaW4uZmlmbycKKyAgICAgICAgc2VsZi5fb3V0X2ZpZm9fcGF0aCA9IERFVklDRV9GSUZPX1BB VEggKyAndGVzdC5maWZvJworICAgICAgICBzZWxmLl9lcnJfZmlmb19wYXRoID0gREVWSUNFX0ZJ Rk9fUEFUSCArICdzdGRlcnIuZmlmbycKICAgICAgICAgc2VsZi5fcmVhZF9zdGRvdXRfcHJvY2Vz cyA9IE5vbmUKICAgICAgICAgc2VsZi5fcmVhZF9zdGRlcnJfcHJvY2VzcyA9IE5vbmUKICAgICAg ICAgc2VsZi5fZm9yd2FyZGVyX3Byb2Nlc3MgPSBOb25lCkBAIC0zMjEsNyArMzI0LDYgQEAgY2xh c3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogICAgICAgICBzZWxmLl9v cmlnaW5hbF9nb3Zlcm5vcnMgPSB7fQogICAgICAgICBzZWxmLl9kZXZpY2Vfc2VyaWFsID0gcG9y dC5fZ2V0X2RldmljZV9zZXJpYWwod29ya2VyX251bWJlcikKICAgICAgICAgc2VsZi5fYWRiX2Nv bW1hbmQgPSBbJ2FkYicsICctcycsIHNlbGYuX2RldmljZV9zZXJpYWxdCi0gICAgICAgIHNlbGYu X2V4dGVybmFsX3N0b3JhZ2UgPSAnJwogCiAgICAgZGVmIF9fZGVsX18oc2VsZik6CiAgICAgICAg IHNlbGYuX3RlYXJkb3duX3BlcmZvcm1hbmNlKCkKQEAgLTM0MywxMSArMzQ1LDYgQEAgY2xhc3Mg Q2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogICAgICAgICBpZiBzZWxmLl9o YXNfc2V0dXA6CiAgICAgICAgICAgICByZXR1cm4KIAotICAgICAgICAjIFNldCB1cCB0aGUgZmlm byBwYXRocyB1c2VkIGZvciBnZXR0aW5nIER1bXBSZW5kZXJUcmVlJ3Mgb3V0cHV0LgotICAgICAg ICBzZWxmLl9pbl9maWZvX3BhdGggPSBzZWxmLl9nZXRfZXh0ZXJuYWxfc3RvcmFnZSgpICsgJy9u YXRpdmVfdGVzdHMvc3RkaW4uZmlmbycKLSAgICAgICAgc2VsZi5fb3V0X2ZpZm9fcGF0aCA9IHNl bGYuX2dldF9leHRlcm5hbF9zdG9yYWdlKCkgKyAnL25hdGl2ZV90ZXN0cy90ZXN0LmZpZm8nCi0g ICAgICAgIHNlbGYuX2Vycl9maWZvX3BhdGggPSBzZWxmLl9nZXRfZXh0ZXJuYWxfc3RvcmFnZSgp ICsgJy9uYXRpdmVfdGVzdHMvc3RkZXJyLmZpZm8nCi0KICAgICAgICAgc2VsZi5fc2V0dXBfbWQ1 c3VtX2FuZF9wdXNoX2RhdGFfaWZfbmVlZGVkKCkKICAgICAgICAgc2VsZi5faGFzX3NldHVwID0g VHJ1ZQogICAgICAgICBzZWxmLl9ydW5fYWRiX2NvbW1hbmQoWydyb290J10pCkBAIC00MjksMTIg KzQyNiw2IEBAIGNsYXNzIENocm9taXVtQW5kcm9pZERyaXZlcihkcml2ZXIuRHJpdmVyKToKICAg ICBkZWYgX3VwZGF0ZV92ZXJzaW9uKHNlbGYsIGRpciwgdmVyc2lvbik6CiAgICAgICAgIHNlbGYu X3J1bl9hZGJfY29tbWFuZChbJ3NoZWxsJywgJ2VjaG8gJWQgPiAlc1ZFUlNJT04nICUgKHZlcnNp b24sIGRpcildKQogCi0gICAgZGVmIF9nZXRfZXh0ZXJuYWxfc3RvcmFnZShzZWxmKToKLSAgICAg ICAgaWYgbm90IHNlbGYuX2V4dGVybmFsX3N0b3JhZ2U6Ci0gICAgICAgICAgICBzZWxmLl9leHRl cm5hbF9zdG9yYWdlID0gc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnZWNobycsICck RVhURVJOQUxfU1RPUkFHRSddKS5zcGxpdGxpbmVzKClbMF0KLSAgICAgICAgICAgIGFzc2VydCBz ZWxmLl9leHRlcm5hbF9zdG9yYWdlLCAnVW5hYmxlIHRvIGZpbmQgJEVYVEVSTkFMX1NUT1JBR0Un Ci0gICAgICAgIHJldHVybiBzZWxmLl9leHRlcm5hbF9zdG9yYWdlCi0KICAgICBkZWYgX3J1bl9h ZGJfY29tbWFuZChzZWxmLCBjbWQsIGlnbm9yZV9lcnJvcj1GYWxzZSk6CiAgICAgICAgIHNlbGYu X2xvZ19kZWJ1ZygnUnVuIGFkYiBjb21tYW5kOiAnICsgc3RyKGNtZCkpCiAgICAgICAgIGlmIGln bm9yZV9lcnJvcjoK