97218 2012-09-20 08:10:26 -0700 [CSS Regions] Enable css-regions by default in WebKit1 2013-06-12 04:02:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED WONTFIX P2 Normal --- 57312 1 alex webkit-unassigned mibalan mihnea mrobinson WebkitBugTracker oldest_to_newest 724530 0 alex 2012-09-20 08:10:26 -0700 We need to have the option to properly enable the feature. I'll open a different one for WebKit2 because disable this experimental feature by default probably makes sense. 725273 1 165079 alex 2012-09-21 01:42:54 -0700 Created attachment 165079 Proposed patch CSS regions is still an experimental feature, we can leave the unconditional compilation but we have to at least be able to disable it for the moment. And in webkit1 case even enable it for testing. 726128 2 alex 2012-09-22 04:45:01 -0700 After talking to Mihnea we are going to leave the decision to the WebKit Settings.cpp defaults, currently is set to false. So we are going to trust those defaults for these situations and just modify them for experimental features for the stable releases if we feel it is causing issues. 899496 3 alex 2013-06-12 04:02:25 -0700 Forgot this was still open, check implementation proposal using an experimental flag in this bug: https://bugs.webkit.org/show_bug.cgi?id=116611 165079 2012-09-21 01:42:54 -0700 2012-09-22 04:45:22 -0700 Proposed patch css_region_webkit1.patch text/plain 5401 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCA1N2NiOTRhLi4wY2Q3NTQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTItMDktMjEgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQWRkIGNzcy1yZWdpb25zIGVuYWJsZSBvcHRpb24g dG8gdGhlIHNldHRpbmdzIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTcyMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgY3NzLXJlZ2lvbnMgZW5hYmxlIHByb3BlcnR5IHNvIHdlIGNhbiBlbmFi bGUgaXQgZm9yIHRlc3RpbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB3ZSBhcmUgYWxyZWFk eSB0ZXN0aW5nIHJlZ2lvbnMuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Mu Y3BwOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19jbGFzc19pbml0KToKKyAgICAgICAg KHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KToKKyAgICAgICAgKHdlYmtpdF93ZWJf c2V0dGluZ3NfZ2V0X3Byb3BlcnR5KToKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGlu Z3Nwcml2YXRlLmg6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyk6CisgICAgICAgICh3ZWJraXRfd2Vi X3ZpZXdfc2V0dGluZ3Nfbm90aWZ5KToKKwogMjAxMi0wOS0xNCAgWmFuIERvYmVyc2VrICA8emFu ZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIENsZWFyIGFwcGxpY2F0aW9uIGNh Y2hlIGJldHdlZW4gdGVzdHMgaW4gRHVtcFJlbmRlclRyZWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCmluZGV4IGRiNzQ1MDcuLjNkNTA1YWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAt MTE5LDcgKzExOSw4IEBAIGVudW0gewogICAgIFBST1BfRU5BQkxFX1NNT09USF9TQ1JPTExJTkcs CiAgICAgUFJPUF9NRURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkUsCiAgICAgUFJP UF9NRURJQV9QTEFZQkFDS19BTExPV1NfSU5MSU5FLAotICAgIFBST1BfRU5BQkxFX0NTU19TSEFE RVJTCisgICAgUFJPUF9FTkFCTEVfQ1NTX1NIQURFUlMsCisgICAgUFJPUF9FTkFCTEVfQ1NTX1JF R0lPTlMKIH07CiAKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3NfZmluYWxpemUoR09i amVjdCogb2JqZWN0KTsKQEAgLTk2MSw2ICs5NjIsMjUgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl Yl9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFdlYlNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFM U0UsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmbGFncykpOwogCisgICAgLyoqCisgICAgKiBXZWJLaXRXZWJTZXR0aW5nczplbmFibGUt Y3NzLXJlZ2lvbnMKKyAgICAqCisgICAgKiBFbmFibGUgb3IgZGlzYWJsZSBzdXBwb3J0IGZvciBj c3MgcmVnaW9ucy4gVGhlIENTUyByZWdpb25zCisgICAgKiBtb2R1bGUgYWxsb3dzIGNvbnRlbnQg dG8gZmxvdyBhY3Jvc3MgbXVsdGlwbGUgYXJlYXMgY2FsbGVkCisgICAgKiByZWdpb25zLiBUaGlz IGlzIHN0aWxsIGFuIGV4cGVyaW1lbnRhbCBmZWF0dXJlLgorICAgICoKKyAgICAqIFNlZSBhbHNv IGh0dHA6Ly9kZXYudzMub3JnL2Nzc3dnL2NzczMtcmVnaW9ucy8uCisgICAgKgorICAgICogU2lu Y2U6IDIuMQorICAgICovCisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2Jq ZWN0X2NsYXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9FTkFC TEVfQ1NTX1JFR0lPTlMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3Bh cmFtX3NwZWNfYm9vbGVhbigiZW5hYmxlLWNzcy1yZWdpb25zIiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIkVuYWJsZSBDU1MgcmVn aW9ucyIpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXygiV2hldGhlciB0byBlbmFibGUgY3NzIHJlZ2lvbnMiKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxh Z3MpKTsKKwogfQogCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2luaXQoV2ViS2l0 V2ViU2V0dGluZ3MqIHdlYl9zZXR0aW5ncykKQEAgLTExNDIsNiArMTE2Miw5IEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3Vp bnQgcHJvcF9pZCwgY29uCiAgICAgY2FzZSBQUk9QX0VOQUJMRV9DU1NfU0hBREVSUzoKICAgICAg ICAgcHJpdi0+ZW5hYmxlQ1NTU2hhZGVycyA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwog ICAgICAgICBicmVhazsKKyAgICBjYXNlIFBST1BfRU5BQkxFX0NTU19SRUdJT05TOgorICAgICAg ICBwcml2LT5lbmFibGVDU1NSZWdpb25zID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7Cisg ICAgICAgIGJyZWFrOwogICAgIGNhc2UgUFJPUF9NRURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VS X0dFU1RVUkU6CiAgICAgICAgIHByaXYtPm1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJl ID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CiAgICAgICAgIGJyZWFrOwpAQCAtMTMxOSw2 ICsxMzQyLDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19nZXRfcHJvcGVydHko R09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBHVmEKICAgICBjYXNlIFBST1BfRU5BQkxF X0NTU19TSEFERVJTOgogICAgICAgICBnX3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5l bmFibGVDU1NTaGFkZXJzKTsKICAgICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX0VOQUJMRV9D U1NfUkVHSU9OUzoKKyAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+ZW5h YmxlQ1NTUmVnaW9ucyk7CisgICAgICAgIGJyZWFrOwogICAgIGNhc2UgUFJPUF9NRURJQV9QTEFZ QkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkU6CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4o dmFsdWUsIHByaXYtPm1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKTsKICAgICAgICAg YnJlYWs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0 dGluZ3Nwcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGlu Z3Nwcml2YXRlLmgKaW5kZXggZDhkZjhlZi4uYzEyNGRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZhdGUuaApAQCAtODIsNiArODIs NyBAQCBzdHJ1Y3QgX1dlYktpdFdlYlNldHRpbmdzUHJpdmF0ZSB7CiAgICAgZ2Jvb2xlYW4gZW5h YmxlQWNjZWxlcmF0ZWRDb21wb3NpdGluZzsKICAgICBnYm9vbGVhbiBlbmFibGVTbW9vdGhTY3Jv bGxpbmc7CiAgICAgZ2Jvb2xlYW4gZW5hYmxlQ1NTU2hhZGVyczsKKyAgICBnYm9vbGVhbiBlbmFi bGVDU1NSZWdpb25zOwogICAgIGdib29sZWFuIG1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0 dXJlOwogICAgIGdib29sZWFuIG1lZGlhUGxheWJhY2tBbGxvd3NJbmxpbmU7CiB9OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDBjYzhkOTYuLjA3MDE5 MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTM0 NDgsNiArMzQ0OCw4IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld191cGRhdGVfc2V0dGlu Z3MoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBjb3JlU2V0dGluZ3MtPnNldENTU0N1c3Rv bUZpbHRlckVuYWJsZWQoc2V0dGluZ3NQcml2YXRlLT5lbmFibGVDU1NTaGFkZXJzKTsKICNlbmRp ZgogCisgICAgY29yZVNldHRpbmdzLT5zZXRDU1NSZWdpb25zRW5hYmxlZChzZXR0aW5nc1ByaXZh dGUtPmVuYWJsZUNTU1JlZ2lvbnMpOworCiAgICAgLy8gVXNlIG1vY2sgc2Nyb2xsYmFycyBpZiBp biBEdW1wUmVuZGVyVHJlZSBtb2RlIChpLmUuIHRlc3RpbmcgbGF5b3V0IHRlc3RzKS4KICAgICBj b3JlU2V0dGluZ3MtPnNldE1vY2tTY3JvbGxiYXJzRW5hYmxlZChEdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGs6OmR1bXBSZW5kZXJUcmVlTW9kZUVuYWJsZWQoKSk7CiAKQEAgLTM1OTMsNiArMzU5NSw4 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19ub3RpZnkoV2ViS2l0V2Vi U2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyCiAgICAgZWxzZSBpZiAobmFtZSA9PSBnX2ludGVy bl9zdHJpbmcoImVuYWJsZS1jc3Mtc2hhZGVycyIpKQogICAgICAgICBzZXR0aW5ncy0+c2V0Q1NT Q3VzdG9tRmlsdGVyRW5hYmxlZChnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOwogI2VuZGlm CisgICAgZWxzZSBpZiAobmFtZSA9PSBnX2ludGVybl9zdHJpbmcoImVuYWJsZS1jc3MtcmVnaW9u cyIpKQorICAgICAgICBzZXR0aW5ncy0+c2V0Q1NTUmVnaW9uc0VuYWJsZWQoZ192YWx1ZV9nZXRf Ym9vbGVhbigmdmFsdWUpKTsKIAogICAgIGVsc2UgaWYgKCFnX29iamVjdF9jbGFzc19maW5kX3By b3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFTUyh3ZWJTZXR0aW5ncyksIG5hbWUpKQogICAgICAgICBn X3dhcm5pbmcoIlVuZXhwZWN0ZWQgc2V0dGluZyAnJXMnIiwgbmFtZSk7Cg==