97215 2012-09-20 08:04:13 -0700 [Qt] Make sure that desktop pages honour the devicePixelRatio 2012-09-25 08:49:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte kenneth webkit.review.bot oldest_to_newest 724523 0 jturcotte 2012-09-20 08:04:13 -0700 [Qt] Make sure that desktop pages honour the devicePixelRatio 724533 1 164921 jturcotte 2012-09-20 08:14:29 -0700 Created attachment 164921 Patch 725194 2 164921 kenneth 2012-09-20 23:33:13 -0700 Comment on attachment 164921 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164921&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:943 > + int minimumLayoutFallbackWidth = std::max(settings->layoutFallbackWidth(), int(m_viewportSize.width() / m_page->deviceScaleFactor())); so maybe ceil or lrint would make more sense? 725390 3 jturcotte 2012-09-21 03:43:06 -0700 (In reply to comment #2) > (From update of attachment 164921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164921&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:943 > > + int minimumLayoutFallbackWidth = std::max(settings->layoutFallbackWidth(), int(m_viewportSize.width() / m_page->deviceScaleFactor())); > > so maybe ceil or lrint would make more sense? Humm can't say, overall this is the desktop equivalent of the conversion to int did in WebPage::sendViewportAttributesChanged: setResizesToContentsUsingLayoutSize(IntSize(static_cast<int>(attr.layoutSize.width()), static_cast<int>(attr.layoutSize.height()))); So if we change one we should change the other. Overall this can mean a difference of 1 pixel to the layout size, which could give a 1.501 scale instead of 1.502, nothing noticeable by the user. 727680 4 164921 webkit.review.bot 2012-09-25 08:49:56 -0700 Comment on attachment 164921 Patch Clearing flags on attachment: 164921 Committed r129514: <http://trac.webkit.org/changeset/129514> 727681 5 webkit.review.bot 2012-09-25 08:49:59 -0700 All reviewed patches have been landed. Closing bug. 164921 2012-09-20 08:14:29 -0700 2012-09-25 08:49:56 -0700 Patch bug-97215-20120920171354.patch text/plain 2127 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4OTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGI5NDkwNzIxYWNlNWM2 MDJiZGFlYTAzYjgwZWZkMTU2NmI2MjE2My4uNGRlMDI3ZDZjZmYwZTk3OWNkMjVhYzc5N2E0NDQ0 OWRlNzY4NTAzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA5LTIwICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKKyAgICAgICAgW1F0 XSBNYWtlIHN1cmUgdGhhdCBkZXNrdG9wIHBhZ2VzIGhvbm91ciB0aGUgZGV2aWNlUGl4ZWxSYXRp bworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcyMTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZGVz a3RvcFdpZHRoIGdpdmVuIHRvIGNvbXB1dGVWaWV3cG9ydEF0dHJpYnV0ZXMgaXMgZXhwZWN0ZWQg dG8gYmUgcGl4ZWwtcmF0aW8gYWRqdXN0ZWQgYWxyZWFkeS4KKyAgICAgICAgV2UgbmVlZCB0byBt YWtlIHN1cmUgdGhhdCB0aGUgdmlld3BvcnQgc2l6ZSBpcyBkaXZpZGVkIGJ5IHRoZSBwaXhlbCBy YXRpbyB0byBwcmV2ZW50CisgICAgICAgIHRoZSBlcXVpdmFsZW50IG9mIGEgMS4wIGRldmljZVBp eGVsUmF0aW8gdG8gYmUgaW4gZWZmZWN0IG9uY2Ugdmlld3BvcnRTaXplLndpZHRoKCkgaXMgbGFy Z2VyCisgICAgICAgIHRoYW4gbGF5b3V0RmFsbGJhY2tXaWR0aC4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2Vu ZFZpZXdwb3J0QXR0cmlidXRlc0NoYW5nZWQpOgorCisyMDEyLTA5LTIwICBKb2NlbHluIFR1cmNv dHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CisKICAgICAgICAgW1F0XSBBYnN0cmFj dCBhcyBtdWNoIGRldmljZVBpeGVsUmF0aW8gbG9naWMgYXMgcG9zc2libGUgYmVoaW5kIFBhZ2VW aWV3cG9ydENvbnRyb2xsZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk3MjE0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcAppbmRleCA5MTUxNDBmOGQwMjU3ZTFkNzg2MTk0Zjg3YTVjYWNiNWNmZDJhODhi Li4yMDVlMDRkNTNhNTFiMmViYmRmYzYzMDhjZDlmM2NiYTBkZTUyMzNmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC05NDAsNyArOTQwLDcg QEAgdm9pZCBXZWJQYWdlOjpzZW5kVmlld3BvcnRBdHRyaWJ1dGVzQ2hhbmdlZCgpCiAgICAgLy8g UmVjYWxjdWxhdGUgdGhlIHJlY29tbWVuZGVkIGxheW91dCBzaXplLCB3aGVuIHRoZSBhdmFpbGFi bGUgc2l6ZSAoZGV2aWNlIHBpeGVsKSBjaGFuZ2VzLgogICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9 IG1fcGFnZS0+c2V0dGluZ3MoKTsKIAotICAgIGludCBtaW5pbXVtTGF5b3V0RmFsbGJhY2tXaWR0 aCA9IHN0ZDo6bWF4KHNldHRpbmdzLT5sYXlvdXRGYWxsYmFja1dpZHRoKCksIG1fdmlld3BvcnRT aXplLndpZHRoKCkpOworICAgIGludCBtaW5pbXVtTGF5b3V0RmFsbGJhY2tXaWR0aCA9IHN0ZDo6 bWF4KHNldHRpbmdzLT5sYXlvdXRGYWxsYmFja1dpZHRoKCksIGludChtX3ZpZXdwb3J0U2l6ZS53 aWR0aCgpIC8gbV9wYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpKSk7CiAKICAgICAvLyBJZiB1bnNl dCAgd2UgdXNlIHRoZSB2aWV3cG9ydCBkaW1lbnNpb25zLiBUaGlzIGZpdHMgd2l0aCB0aGUgYmVo YXZpb3Igb2YgZGVza3RvcCBicm93c2Vycy4KICAgICBpbnQgZGV2aWNlV2lkdGggPSAoc2V0dGlu Z3MtPmRldmljZVdpZHRoKCkgPiAwKSA/IHNldHRpbmdzLT5kZXZpY2VXaWR0aCgpIDogbV92aWV3 cG9ydFNpemUud2lkdGgoKTsK