97195 2012-09-20 04:30:37 -0700 [Qt] r129045 broke the ARM build 2012-09-20 06:24:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned fpizlo ggaren ossy webkit.review.bot zherczeg oldest_to_newest 724408 0 rgabor 2012-09-20 04:30:37 -0700 MacroAssemblerARM.h is missing some store8() implementations. 724420 1 164891 rgabor 2012-09-20 04:46:22 -0700 Created attachment 164891 Speculative fix 724427 2 zherczeg 2012-09-20 04:57:26 -0700 I suggest to use: move(TrustedImm32(reinterpret_cast<ARMWord>(address)), ARMRegisters::S0); The immediate does not need to unique. I saw there are other places where these unique constats are used, we should remove them later. 724452 3 164900 rgabor 2012-09-20 05:51:31 -0700 Created attachment 164900 Speculative fix 2 I made the change what Zoltan mentioned and deleted the unnecessary store8(RegisterID src, void* address) implementation. 724461 4 164900 zherczeg 2012-09-20 06:04:26 -0700 Comment on attachment 164900 Speculative fix 2 r=me 724479 5 164900 webkit.review.bot 2012-09-20 06:24:51 -0700 Comment on attachment 164900 Speculative fix 2 Clearing flags on attachment: 164900 Committed r129127: <http://trac.webkit.org/changeset/129127> 724480 6 webkit.review.bot 2012-09-20 06:24:54 -0700 All reviewed patches have been landed. Closing bug. 164891 2012-09-20 04:46:22 -0700 2012-09-20 05:51:31 -0700 Speculative fix store8.patch text/plain 1931 rgabor SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5MTE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA5LTIwICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAg ICAgICBbUXRdIHIxMjkwNDUgYnJva2UgdGhlIEFSTSBidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxOTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRpbmcgbWlzc2luZyBzdG9yZTgg ZnVuY3Rpb25zLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpzdG9yZTgpOgorICAgICAgICAoTWFjcm9B c3NlbWJsZXJBUk0pOgorCiAyMDEyLTA5LTE5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgT1NSIGV4aXQgc29tZXRpbWVzIG5lZ2xlY3RzIHRvIGNyZWF0ZSB0 aGUgYXJndW1lbnRzIG9iamVjdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkocmV2aXNpb24gMTI5MDk4KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCSh3b3JraW5n IGNvcHkpCkBAIC00NDUsNiArNDQ1LDE5IEBAIHB1YmxpYzoKICAgICAgICAgbV9hc3NlbWJsZXIu YmFzZUluZGV4VHJhbnNmZXIzMihBUk1Bc3NlbWJsZXI6OlN0b3JlVWludDgsIHNyYywgYWRkcmVz cy5iYXNlLCBhZGRyZXNzLmluZGV4LCBzdGF0aWNfY2FzdDxpbnQ+KGFkZHJlc3Muc2NhbGUpLCBh ZGRyZXNzLm9mZnNldCk7CiAgICAgfQogCisgICAgdm9pZCBzdG9yZTgoUmVnaXN0ZXJJRCBzcmMs IHZvaWQqIGFkZHJlc3MpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5sZHJVbmlxdWVJbW1l ZGlhdGUoQVJNUmVnaXN0ZXJzOjpTMCwgcmVpbnRlcnByZXRfY2FzdDxBUk1Xb3JkPihhZGRyZXNz KSk7CisgICAgICAgIG1fYXNzZW1ibGVyLmR0clVwKEFSTUFzc2VtYmxlcjo6U3RvcmVVaW50OCwg c3JjLCBBUk1SZWdpc3RlcnM6OlMwLCAwKTsKKyAgICB9CisKKyAgICB2b2lkIHN0b3JlOChUcnVz dGVkSW1tMzIgaW1tLCB2b2lkKiBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgbV9hc3NlbWJsZXIu bGRyVW5pcXVlSW1tZWRpYXRlKEFSTVJlZ2lzdGVyczo6UzAsIHJlaW50ZXJwcmV0X2Nhc3Q8QVJN V29yZD4oYWRkcmVzcykpOworICAgICAgICBtX2Fzc2VtYmxlci5tb3ZlSW1tKGltbS5tX3ZhbHVl LCBBUk1SZWdpc3RlcnM6OlMxKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuZHRyVXAoQVJNQXNzZW1i bGVyOjpTdG9yZVVpbnQ4LCBBUk1SZWdpc3RlcnM6OlMxLCBBUk1SZWdpc3RlcnM6OlMwLCAwKTsK KyAgICB9CisKICAgICB2b2lkIHN0b3JlMTYoUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRy ZXNzKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIuYmFzZUluZGV4VHJhbnNmZXIxNihBUk1B c3NlbWJsZXI6OlN0b3JlVWludDE2LCBzcmMsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5pbmRleCwg c3RhdGljX2Nhc3Q8aW50PihhZGRyZXNzLnNjYWxlKSwgYWRkcmVzcy5vZmZzZXQpOwo= 164900 2012-09-20 05:51:31 -0700 2012-09-20 06:24:51 -0700 Speculative fix 2 store8.patch text/plain 1679 rgabor SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5MTE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA5LTIwICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAg ICAgICBbUXRdIHIxMjkwNDUgYnJva2UgdGhlIEFSTSBidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxOTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnRpbmcgbWlzc2luZyBzdG9yZTgg ZnVuY3Rpb24uCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OnN0b3JlOCk6CisgICAgICAgIChNYWNyb0Fz c2VtYmxlckFSTSk6CisKIDIwMTItMDktMTkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxl LmNvbT4KIAogICAgICAgICBPU1IgZXhpdCBzb21ldGltZXMgbmVnbGVjdHMgdG8gY3JlYXRlIHRo ZSBhcmd1bWVudHMgb2JqZWN0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCShyZXZpc2lvbiAxMjkwOTgpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ0NSw2ICs0NDUsMTMgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5i YXNlSW5kZXhUcmFuc2ZlcjMyKEFSTUFzc2VtYmxlcjo6U3RvcmVVaW50OCwgc3JjLCBhZGRyZXNz LmJhc2UsIGFkZHJlc3MuaW5kZXgsIHN0YXRpY19jYXN0PGludD4oYWRkcmVzcy5zY2FsZSksIGFk ZHJlc3Mub2Zmc2V0KTsKICAgICB9CiAKKyAgICB2b2lkIHN0b3JlOChUcnVzdGVkSW1tMzIgaW1t LCB2b2lkKiBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIocmVpbnRl cnByZXRfY2FzdDxBUk1Xb3JkPihhZGRyZXNzKSksIEFSTVJlZ2lzdGVyczo6UzApOworICAgICAg ICBtX2Fzc2VtYmxlci5tb3ZlSW1tKGltbS5tX3ZhbHVlLCBBUk1SZWdpc3RlcnM6OlMxKTsKKyAg ICAgICAgbV9hc3NlbWJsZXIuZHRyVXAoQVJNQXNzZW1ibGVyOjpTdG9yZVVpbnQ4LCBBUk1SZWdp c3RlcnM6OlMxLCBBUk1SZWdpc3RlcnM6OlMwLCAwKTsKKyAgICB9CisKICAgICB2b2lkIHN0b3Jl MTYoUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRyZXNzKQogICAgIHsKICAgICAgICAgbV9h c3NlbWJsZXIuYmFzZUluZGV4VHJhbnNmZXIxNihBUk1Bc3NlbWJsZXI6OlN0b3JlVWludDE2LCBz cmMsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5pbmRleCwgc3RhdGljX2Nhc3Q8aW50PihhZGRyZXNz LnNjYWxlKSwgYWRkcmVzcy5vZmZzZXQpOwo=