97177 2012-09-19 23:33:29 -0700 [Forms] HTMLSelectElement should call formStateDidChange on both menulist and lisbox mode 2012-09-20 01:41:05 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin mifenton tkent webkit.review.bot oldest_to_newest 724209 0 yosin 2012-09-19 23:33:29 -0700 When HTMLSelectElement is menulist mode, it calls formStateDidChange(), however when it is listbox mode, it doesn't. There is a similar bug for multiple field time input UI: bug 97169 - [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed 724263 1 164857 yosin 2012-09-20 01:22:45 -0700 Created attachment 164857 Patch 1 724264 2 164857 yosin 2012-09-20 01:23:32 -0700 Comment on attachment 164857 Patch 1 Could you review this patch? Thanks in advance. 724270 3 164857 tkent 2012-09-20 01:33:23 -0700 Comment on attachment 164857 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=164857&action=review > Source/WebCore/html/HTMLSelectElement.cpp:635 > + notifyFormStateChanged(); Are there other places which should have notifyFromStateChanged()? I think calling notifyFromStateChanged() in listBoxOnChange() and dispatchChangeEventForMenuList() is more reliable. 724275 4 164857 tkent 2012-09-20 01:35:31 -0700 Comment on attachment 164857 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=164857&action=review >> Source/WebCore/html/HTMLSelectElement.cpp:635 >> + notifyFormStateChanged(); > > Are there other places which should have notifyFromStateChanged()? > > I think calling notifyFromStateChanged() in listBoxOnChange() and dispatchChangeEventForMenuList() is more reliable. > I think calling notifyFromStateChanged() in listBoxOnChange() and dispatchChangeEventForMenuList() is more reliable. Ah, no. If we do so, state change by JavaScript won't update the state. 724279 5 yosin 2012-09-20 01:40:10 -0700 (In reply to comment #4) > (From update of attachment 164857 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164857&action=review > > >> Source/WebCore/html/HTMLSelectElement.cpp:635 > >> + notifyFormStateChanged(); > > > > Are there other places which should have notifyFromStateChanged()? > > > > I think calling notifyFromStateChanged() in listBoxOnChange() and dispatchChangeEventForMenuList() is more reliable. > > > I think calling notifyFromStateChanged() in listBoxOnChange() and dispatchChangeEventForMenuList() is more reliable. > > Ah, no. If we do so, state change by JavaScript won't update the state. Agree, it seems notifyFormStateChanged() is called with setNeedValidityCheck() in other types. 724280 6 164857 yosin 2012-09-20 01:41:00 -0700 Comment on attachment 164857 Patch 1 Clearing flags on attachment: 164857 Committed r129107: <http://trac.webkit.org/changeset/129107> 724281 7 yosin 2012-09-20 01:41:05 -0700 All reviewed patches have been landed. Closing bug. 164857 2012-09-20 01:22:45 -0700 2012-09-20 01:41:00 -0700 Patch 1 bug-97177-20120920172206.patch text/plain 6812 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRmOGZlNzM3MjMxN2Jk OTY3OWE4OTc5OGJmZmI2ZmQxYmExNzdmNy4uNTg3ZjZlN2IyNzg1ZWJkZTkwYTFmYjk2Mzk1NmVj MDYwMTlmYThmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM0IEBACiAyMDEyLTA5LTE5ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW0Zvcm1zXSBIVE1M U2VsZWN0RWxlbWVudCBzaG91bGQgY2FsbCBmb3JtU3RhdGVEaWRDaGFuZ2Ugb24gYm90aCBtZW51 bGlzdCBhbmQgbGlzYm94IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk3MTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhpcyBwYXRjaCBtYWtlcyBsaXN0Ym94IG1vZGUgc2VsZWN0IGVsZW1lbnQg dG8gY2FsbCBmb3JtU3RhdGVEaWRDaGFuZ2UoKQorICAgICAgICB3aGVuIHNlbGVjdGVkIG9wdGlv bnMgYXJlIGNoYW5nZWQuCisKKyAgICAgICAgRm9yIHRoaXMgY2hhbmdlLCB0aGlzIHBhdGNoIG1v dmVzIG5vdGlmeUZvcm1TdGF0ZUNoYW5nZWQoKSB0bworICAgICAgICBIVE1MRm9ybUNvbnRyb2xF bGVtZW50V2l0aFN0YXRlIGNsYXNzIGZyb20gSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQKKyAg ICAgICAgZm9yIHNoYXJpbmcgY29kZSBIVE1MU2VsZWN0RWxlbWVudCBjbGFzcyBhbmQgSFRNTElu cHV0RWxlbWVudC9IVE1MVGV4dEFyZWFFbGVtZW50CisgICAgICAgIGRlcml2ZWQgZnJvbSBIVE1M VGV4dEZvcm1Db250cm9sRWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFdlIGNhbid0 IHRlc3QgdGhpcyBjaGFuZ2UgaW4gV2ViS2l0IHRlc3QgdG9vbHMuIFRlc3Qgc2NyaXB0CisgICAg ICAgIHdpbGwgYmUgaW1wbGVtZW50ZWQgaW4gQ2hyb21pdW0gc2lkZS4KKworICAgICAgICAqIGh0 bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlOjpub3RpZnlGb3JtU3RhdGVDaGFuZ2Vk KToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxl bWVudFdpdGhTdGF0ZS5oOiBNb3ZlZCBhIGRlY2xhcmF0aW9uIG9mIG5vdGlmeUZvcm1TdGF0ZUNo YW5nZWQoKSBmcm9tIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LgorICAgICAgICAoSFRNTEZv cm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZSk6IE1vdmVkIGFuIGltcGxlbWVudGVkIG9mIG5vdGlm eUZvcm1TdGF0ZUNoYW5nZWQoKSBmcm9tIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LgorICAg ICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFNlbGVjdEVsZW1lbnQ6OnNlbGVjdE9wdGlvbik6IENoYW5nZWQgdG8gY2FsbCBub3RpZnlGb3Jt U3RhdGVDaGFuZ2VkKCkgaW5zdGVhZCBvZiBmb3JtU3RhdGVEaWRDaGFuZ2UoKS4KKyAgICAgICAg KFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50Ojp1cGRhdGVMaXN0Qm94U2VsZWN0aW9uKTogQ2hh bmdlZCB0byBjYWxsIG5vdGlmeUZvcm1TdGF0ZUNoYW5nZWQoKS4KKyAgICAgICAgKiBodG1sL0hU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcDogTW92ZWQgYW4gaW1wbGVtZW50ZWQgb2Ygbm90 aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpIHRvIEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGUg Y2xhc3MuCisgICAgICAgICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5oOiBNb3Zl ZCBhIGRlY2xhcmF0aW9uIG9mIG5vdGlmeUZvcm1TdGF0ZUNoYW5nZWQoKSB0byBIVE1MRm9ybUNv bnRyb2xFbGVtZW50V2l0aFN0YXRlIGNsYXNzLgorCisyMDEyLTA5LTE5ICBZb3NoaWZ1bWkgSW5v dWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW0Zvcm1zXSBtdWx0aXBsZSBmaWVs ZHMgdGltZSBpbnB1dCBVSSBzaG91bGQgY2FsbCBub3RpZnlGb3JtU3RhdGVDaGFuZ2VkKCkgd2hl biB2YWx1ZSBvZiBmaWVsZCBpcyBjaGFuZ2VkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NzE2OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRoU3RhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlLmNwcAppbmRleCBmOTZkMjY0YzBm N2IzNTI0NzM3YThlM2RmZmYzODAzMDhmNjJmYTE2Li42NmYyMWIzNGU2NTdhNzUyNzAxOGRmZmJk ZDlhY2U3NzZhMmQ4MTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3Jt Q29udHJvbEVsZW1lbnRXaXRoU3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZS5jcHAKQEAgLTI1LDggKzI1LDEyIEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0 ZS5oIgogCisjaW5jbHVkZSAiQ2hyb21lLmgiCisjaW5jbHVkZSAiQ2hyb21lQ2xpZW50LmgiCiAj aW5jbHVkZSAiRm9ybUNvbnRyb2xsZXIuaCIKKyNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUg IkhUTUxGb3JtRWxlbWVudC5oIgorI2luY2x1ZGUgIlBhZ2UuaCIKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCkBAIC01Niw2ICs2MCwxNiBAQCBib29sIEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRo U3RhdGU6OnNob3VsZEF1dG9jb21wbGV0ZSgpIGNvbnN0CiAgICAgcmV0dXJuIGZvcm0oKS0+c2hv dWxkQXV0b2NvbXBsZXRlKCk7CiB9CiAKK3ZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhT dGF0ZTo6bm90aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpCit7CisgICAgRnJhbWUqIGZyYW1lID0gZG9j dW1lbnQoKS0+ZnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAg ICBpZiAoUGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCkpCisgICAgICAgIHBhZ2UtPmNocm9tZSgp LT5jbGllbnQoKS0+Zm9ybVN0YXRlRGlkQ2hhbmdlKHRoaXMpOworfQorCiBib29sIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnRXaXRoU3RhdGU6OnNob3VsZFNhdmVBbmRSZXN0b3JlRm9ybUNvbnRyb2xT dGF0ZSgpIGNvbnN0CiB7CiAgICAgLy8gV2UgZG9uJ3Qgc2F2ZS9yZXN0b3JlIGNvbnRyb2wgc3Rh dGUgaW4gYSBmb3JtIHdpdGggYXV0b2NvbXBsZXRlPW9mZi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudFdpdGhTdGF0ZS5oIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlLmgKaW5kZXggNWU3YmIx YWNkZDhiZmI4OGYwNjcxZGRlNDU2ZjYwYWRiN2M4MmI5MS4uOTIxNjVlNTJhYmU4NjNlNTk3Nzk3 Y2IyYzU4NmQ3NTFkMTQ0NTY0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Rm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlLmgKQEAgLTQwLDYgKzQwLDcgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgRm9ybUNvbnRyb2xTdGF0ZSBzYXZlRm9ybUNvbnRyb2xTdGF0ZSgpIGNv bnN0OwogICAgIC8vIFRoZSBzcGVjaWZpZWQgRm9ybUNvbnRyb2xTdGF0ZSBtdXN0IGhhdmUgYXQg bGVhc3Qgb25lIHN0cmluZyB2YWx1ZS4KICAgICB2aXJ0dWFsIHZvaWQgcmVzdG9yZUZvcm1Db250 cm9sU3RhdGUoY29uc3QgRm9ybUNvbnRyb2xTdGF0ZSYpIHsgfQorICAgIHZvaWQgbm90aWZ5Rm9y bVN0YXRlQ2hhbmdlZCgpOwogCiBwcm90ZWN0ZWQ6CiAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVu dFdpdGhTdGF0ZShjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCosIEhUTUxG b3JtRWxlbWVudCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0 RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApp bmRleCA5MjYxZDUyYjZkNDczZWUxOGEzMmRlNGM2NWY3ODRkNGQxMzI2YWRmLi45MTRiNTVkZTg4 YWFkN2UzM2UwZDJkOGJmMjI4ZTg0ZmJkZDVjZDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxTZWxlY3RFbGVtZW50LmNwcApAQCAtNjMyLDYgKzYzMiw3IEBAIHZvaWQgSFRNTFNlbGVjdEVs ZW1lbnQ6OnVwZGF0ZUxpc3RCb3hTZWxlY3Rpb24oYm9vbCBkZXNlbGVjdE90aGVyT3B0aW9ucykK IAogICAgIHNjcm9sbFRvU2VsZWN0aW9uKCk7CiAgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7 CisgICAgbm90aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpOwogfQogCiB2b2lkIEhUTUxTZWxlY3RFbGVt ZW50OjpsaXN0Qm94T25DaGFuZ2UoKQpAQCAtODY0LDggKzg2NSw3IEBAIHZvaWQgSFRNTFNlbGVj dEVsZW1lbnQ6OnNlbGVjdE9wdGlvbihpbnQgb3B0aW9uSW5kZXgsIFNlbGVjdE9wdGlvbkZsYWdz IGZsYWdzKQogICAgIH0KIAogICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOwotICAgIGlmIChG cmFtZSogZnJhbWUgPSBkb2N1bWVudCgpLT5mcmFtZSgpKQotICAgICAgICBmcmFtZS0+cGFnZSgp LT5jaHJvbWUoKS0+Y2xpZW50KCktPmZvcm1TdGF0ZURpZENoYW5nZSh0aGlzKTsKKyAgICBub3Rp ZnlGb3JtU3RhdGVDaGFuZ2VkKCk7CiB9CiAKIGludCBIVE1MU2VsZWN0RWxlbWVudDo6b3B0aW9u VG9MaXN0SW5kZXgoaW50IG9wdGlvbkluZGV4KSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCAyZWM1ZjA5YjFmZmM1 NWUxNzU1NGViMWMyZjA2OTUzNGQ2YjNmYzU1Li43MGMwNjE5MWVkNDU5NzJhMDQ0NTc4Y2RjMDM5 ZWJlOWZmMTYxMzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50LmNwcApAQCAtMjcsNyArMjcsNiBAQAogCiAjaW5jbHVkZSAiQVhPYmpl Y3RDYWNoZS5oIgogI2luY2x1ZGUgIkF0dHJpYnV0ZS5oIgotI2luY2x1ZGUgIkNocm9tZS5oIgog I2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVk ZSAiRXZlbnQuaCIKQEAgLTM4LDcgKzM3LDYgQEAKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50 LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiTm9kZVJlbmRlcmluZ0NvbnRl eHQuaCIKLSNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUmVuZGVyQm94LmgiCiAjaW5jbHVk ZSAiUmVuZGVyVGV4dENvbnRyb2wuaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgpAQCAtNDU5 LDE2ICs0NTcsNiBAQCB2b2lkIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpwYXJzZUF0dHJp YnV0ZShjb25zdCBBdHRyaWJ1dGUmIGF0dHJpYnV0ZSkKICAgICAgICAgSFRNTEZvcm1Db250cm9s RWxlbWVudFdpdGhTdGF0ZTo6cGFyc2VBdHRyaWJ1dGUoYXR0cmlidXRlKTsKIH0KIAotdm9pZCBI VE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6bm90aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpCi17Ci0g ICAgRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQoKS0+ZnJhbWUoKTsKLSAgICBpZiAoIWZyYW1lKQot ICAgICAgICByZXR1cm47Ci0KLSAgICBpZiAoUGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCkpCi0g ICAgICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+Zm9ybVN0YXRlRGlkQ2hhbmdlKHRoaXMp OwotfQotCiBib29sIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpsYXN0Q2hhbmdlV2FzVXNl ckVkaXQoKSBjb25zdAogewogICAgIGlmICghaXNUZXh0Rm9ybUNvbnRyb2woKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRleCA4ZWJl NjZhYzYxY2VhMjdjMzVmYTQxZmI0MjY5NjU4ZDgzYzlhYjgzLi5mODQzZDZkZWVlYWNkMDQ5Njkw ZTNhZDBlYjhkZDliYmM0YzZlMTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M VGV4dEZvcm1Db250cm9sRWxlbWVudC5oCkBAIC03Nyw3ICs3Nyw2IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIEhUTUxFbGVtZW50KiBpbm5lclRleHRFbGVtZW50KCkgY29uc3QgPSAwOwogCiAgICAg dm9pZCBzZWxlY3Rpb25DaGFuZ2VkKGJvb2wgdXNlclRyaWdnZXJlZCk7Ci0gICAgdm9pZCBub3Rp ZnlGb3JtU3RhdGVDaGFuZ2VkKCk7CiAgICAgYm9vbCBsYXN0Q2hhbmdlV2FzVXNlckVkaXQoKSBj b25zdDsKICAgICB2b2lkIHNldElubmVyVGV4dFZhbHVlKGNvbnN0IFN0cmluZyYpOwogICAgIFN0 cmluZyBpbm5lclRleHRWYWx1ZSgpIGNvbnN0Owo=