<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97172</bug_id>
          
          <creation_ts>2012-09-19 22:47:20 -0700</creation_ts>
          <short_desc>REGRESSION(r129007): It broke the build on the Qt bots (Requested by Ossy on #webkit).</short_desc>
          <delta_ts>2014-02-06 07:56:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="WebKit Review Bot">webkit.review.bot</reporter>
          <assigned_to name="Simon Hausmann">hausmann</assigned_to>
          <cc>hausmann</cc>
    
    <cc>loic.yhuel</cc>
    
    <cc>ossy</cc>
    
    <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>724170</commentid>
    <comment_count>0</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-19 22:47:20 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/129007 broke the build:
It broke the build on the Qt bots (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don&apos;t already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

&quot;Only you can prevent forest fires.&quot; -- Smokey the Bear</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724172</commentid>
    <comment_count>1</comment_count>
      <attachid>164844</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-19 22:47:50 -0700</bug_when>
    <thetext>Created attachment 164844
ROLLOUT of r129007

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724175</commentid>
    <comment_count>2</comment_count>
      <attachid>164844</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-09-19 22:50:03 -0700</bug_when>
    <thetext>Comment on attachment 164844
ROLLOUT of r129007

Clearing flags on attachment: 164844

Committed r129092: &lt;http://trac.webkit.org/changeset/129092&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724176</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-09-19 22:50:07 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724177</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-09-19 22:50:35 -0700</bug_when>
    <thetext>error:
cc1plus: error: to generate dependencies you must specify either -M or -MM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724262</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-09-20 01:21:57 -0700</bug_when>
    <thetext>Reopen, because the bug isn&apos;t fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729975</commentid>
    <comment_count>6</comment_count>
    <who name="Loïc Yhuel">loic.yhuel</who>
    <bug_when>2012-09-27 16:17:19 -0700</bug_when>
    <thetext>This patch deleted empty.cpp, instead of reverting to previous state (empty file), so now the gccdepends config test always fails.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>780011</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-30 04:49:00 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; This patch deleted empty.cpp, instead of reverting to previous state (empty file), so now the gccdepends config test always fails.

Ooops, I added empty empty.cpp back in r136226.

Simon, Tor Arne: Is the original bug still valid? 
Or can we close this as WONTFIX?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>780029</commentid>
    <comment_count>8</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2012-11-30 05:19:44 -0800</bug_when>
    <thetext>Barring the broken rollout, the original bug is now reintroduced. We should perhaps figure out how it broke the build so we can fix the original patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>780033</commentid>
    <comment_count>9</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-30 05:23:08 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Barring the broken rollout, the original bug is now reintroduced. We should perhaps figure out how it broke the build so we can fix the original patch.

The question is very good after 2 months .... Who remembers what happened that time. Let me try to find the bot history.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>780038</commentid>
    <comment_count>10</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-30 05:30:10 -0800</bug_when>
    <thetext>I checked 2-3 bots history ... but I can&apos;t find any useful information. :-/
I can&apos;t remember which bots / EWS were broken that time. Let&apos;s try to debug
it on monday.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>780048</commentid>
    <comment_count>11</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-30 05:48:36 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Barring the broken rollout, the original bug is now reintroduced.
It means that the &quot;GNUmake gcc_MD_depends&quot; case was always broken
with all-in-one files. But the accidentally missing empty.cpp simple 
disabled &quot;GNUmake gcc_MD_depends&quot; everywhere. That&apos;s why nobody noticed it.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>164844</attachid>
            <date>2012-09-19 22:47:50 -0700</date>
            <delta_ts>2012-09-19 22:50:03 -0700</delta_ts>
            <desc>ROLLOUT of r129007</desc>
            <filename>bug-97172-20120920055416.patch</filename>
            <type>text/plain</type>
            <size>2482</size>
            <attacher name="WebKit Review Bot">webkit.review.bot</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmY4OTcwYWVlYTIwMDcyODI4YTZlNmI3M2Q0M2YzMGFj
ZTMzMWM4Yy4uNzQ1Nzc3M2I3NDlhNjcxZTc0NGNkYjg5M2JmOTA4OTFjYjhhNDg1ZCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDEyLTA5LTE5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv
bT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTI5MDA3LgorICAgICAgICBo
dHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMjkwMDcKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MTcyCisKKyAgICAgICAgSXQgYnJva2Ug
dGhlIGJ1aWxkIG9uIHRoZSBRdCBib3RzIChSZXF1ZXN0ZWQgYnkgT3NzeSBvbgorICAgICAgICAj
d2Via2l0KS4KKworICAgICAgICAqIHFtYWtlL2NvbmZpZy50ZXN0cy9nY2NkZXBlbmRzL2VtcHR5
LmNwcDoKKyAgICAgICAgKiBxbWFrZS9jb25maWcudGVzdHMvZ2NjZGVwZW5kcy9nY2NkZXBlbmRz
LnBybzoKKyAgICAgICAgKiBxbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZjoK
KwogMjAxMi0wOS0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBydW4tcGVyZi10ZXN0cyBzaG91bGQgcmVjb3JkIGluZGl2aXN1YWwgdmFsdWUgaW5zdGVhZCBv
ZiBzdGF0aXN0aWNzCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9jb25maWcudGVzdHMvZ2NjZGVw
ZW5kcy9lbXB0eS5jcHAgYi9Ub29scy9xbWFrZS9jb25maWcudGVzdHMvZ2NjZGVwZW5kcy9lbXB0
eS5jcHAKaW5kZXggZDM4YWU4MWFmNjdmNzA3ZGUyYzNiN2MyMWUzYzM1YWRhMWQ1Y2YzYS4uZTY5
ZGUyOWJiMmQxZDY0MzRiOGIyOWFlNzc1YWQ4YzJlNDhjNTM5MSAxMDA2NDQKLS0tIGEvVG9vbHMv
cW1ha2UvY29uZmlnLnRlc3RzL2djY2RlcGVuZHMvZW1wdHkuY3BwCisrKyBiL1Rvb2xzL3FtYWtl
L2NvbmZpZy50ZXN0cy9nY2NkZXBlbmRzL2VtcHR5LmNwcApAQCAtMSwyICswLDAgQEAKLQotaW50
IG1haW4oKSB7IHJldHVybiAwOyB9CmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9jb25maWcudGVz
dHMvZ2NjZGVwZW5kcy9nY2NkZXBlbmRzLnBybyBiL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9n
Y2NkZXBlbmRzL2djY2RlcGVuZHMucHJvCmluZGV4IDc3NmU1NjQyOTA2OTE1MzlkM2Q3ZTU1ODJj
Y2NhNDc0ZDMxYjg4ZGYuLmNkMGE4MWEzMmZjZGM4NmY2ZmI1Yjg4N2VjZmM2OTMxZjliYzQ1ZDYg
MTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9nY2NkZXBlbmRzL2djY2RlcGVu
ZHMucHJvCisrKyBiL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9nY2NkZXBlbmRzL2djY2RlcGVu
ZHMucHJvCkBAIC0xLDggKzEsNiBAQAotVEVNUExBVEUgPSBhcHAKK1RFTVBMQVRFID0gYXV4CiBP
QkpFQ1RTX0RJUiA9IG9iagotQ09ORklHICs9IEdOVW1ha2UgZ2NjX01EX2RlcGVuZHMKLVFNQUtF
X0NYWEZMQUdTICs9IC1NUAotVEFSR0VUID0gZW1wdHkKK1FNQUtFX0NYWEZMQUdTICs9IC1NRAog
CiBiYXNlX2ZpbGVuYW1lID0gZW1wdHkKIG9iamVjdF9maWxlID0gJCRPQkpFQ1RTX0RJUi8kJHti
YXNlX2ZpbGVuYW1lfS5vCmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVz
L2RlZmF1bHRfcHJlLnByZiBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9w
cmUucHJmCmluZGV4IDlmYzljMGFlYTI2ZmNhMDQxNWM4MmQzYzZlMTUwMjIwMWNhNGZlNzQuLmJj
NDZiMjEyZGI4YTY3YzA2MzljNzUwZTIzYjE4NTRiMWVlZThkMGIgMTAwNjQ0Ci0tLSBhL1Rvb2xz
L3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCisrKyBiL1Rvb2xzL3FtYWtl
L21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCkBAIC04Nyw5ICs4Nyw2IEBAIHVuaXg6
Y29uZmlnX2djY2RlcGVuZHMgewogICAgICMgV2UgaGF2ZSBhIGNvbXBpbGVyIHRoYXQgc3VwcG9y
dHMgdGhlIC1NRCBvcHRpb24gKGFuZCBuZWl0aGVyCiAgICAgIyB0ZWFtYnVpbGRlciBub3IgaWNl
Y3JlYW0gaXMgbWVzc2luZyB1cCB0aGUgLmQgZmlsZSBvdXRwdXQpLgogICAgIENPTkZJRyArPSBH
TlVtYWtlIGdjY19NRF9kZXBlbmRzCi0gICAgIyBUaGlzIHNob3VsZCByZWFsbHkgYmUgYWRkZWQg
dG8gcW1ha2UsIGJ1dCBmb3Igbm93IHdlIGFkZCBpdCBoZXJlLgotICAgIFFNQUtFX0NYWEZMQUdT
ICs9IC1NUAotICAgIFFNQUtFX0NGTEFHUyArPSAtTVAKIH0KIAogIWhhdmVRdCg1KTohcmVjdXJz
aXZlX2luY2x1ZGU6IGVycm9yKCJCdWlsZGluZyBXZWJLaXQgd2l0aCBRdCB2ZXJzaW9ucyBvbGRl
ciB0aGFuIDUuMCBpcyBub3Qgc3VwcG9ydGVkLiIpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>