97169 2012-09-19 22:29:22 -0700 [Forms] multiple fields time input UI should call notifyFormStateChanged() when value of field is changed 2012-09-19 23:13:15 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin mifenton tkent webkit.review.bot oldest_to_newest 724159 0 yosin 2012-09-19 22:29:22 -0700 When we dispatch form control change event, other input types calls notifyFormStateChanged(). Time input UI should follow this protocol. This bug is found by: http://crbug.com/150745, Duplicating current tab is NOT preserving the **input time field data** in latest canary 724171 1 164843 yosin 2012-09-19 22:47:50 -0700 Created attachment 164843 Patch 1 724174 2 164843 yosin 2012-09-19 22:48:46 -0700 Comment on attachment 164843 Patch 1 Could you review this patch? Thanks in advance. 724183 3 164843 tkent 2012-09-19 23:02:06 -0700 Comment on attachment 164843 Patch 1 ok 724193 4 164843 yosin 2012-09-19 23:13:11 -0700 Comment on attachment 164843 Patch 1 Clearing flags on attachment: 164843 Committed r129095: <http://trac.webkit.org/changeset/129095> 724194 5 yosin 2012-09-19 23:13:15 -0700 All reviewed patches have been landed. Closing bug. 164843 2012-09-19 22:47:50 -0700 2012-09-19 23:13:11 -0700 Patch 1 bug-97169-20120920144715.patch text/plain 1791 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTA4Zjg0N2U0YzI5ZTUx Yjg2NzY1OTVlYzE4MGRiM2Q5MmFlNjQwOC4uM2M0MTk1MjIwMGNlNTIxZTQyMGYzMTFhNTc0OTli NzFiMDU0ZDIxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTE5ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBtdWx0 aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSSBzaG91bGQgY2FsbCBub3RpZnlGb3JtU3RhdGVDaGFu Z2VkKCkgd2hlbiB2YWx1ZSBvZiBmaWVsZCBpcyBjaGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzE2OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgbXVsdGlwbGUgZmll bGRzIHRpbWUgaW5wdXQgVUkgY2FsbHMgbm90aWZ5Rm9ybVN0YXRlQ2hhbmdlZCgpCisgICAgICAg IHdoZW4gZmllbGQgdmFsdWUgaXMgY2hhbmdlZCBhcyBvdGhlciBpbnB1dCB0eXBlcyBkby4KKwor ICAgICAgICBUaGlzIHBhdGNoIGFmZmVjdHMgcG9ydHMgd2hpY2ggZW5hYmxlIGJvdGggRU5BQkxF X0lOUFVUX1RZUEVfVElNRSBhbmQKKyAgICAgICAgRU5BQkxFX0lOUFVUX1RZUEVfVElNRV9NVUxU SVBMRV9GSUVMRFMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBXZSBjYW4ndCB0ZXN0IHRoaXMg Y2hhbmdlIGluIFdlYktpdCB0ZXN0IHRvb2xzLiBUZXN0IHNjcmlwdAorICAgICAgICB3aWxsIGJl IGltcGxlbWVudGVkIGluIENocm9taXVtIHNpZGUuCisKKyAgICAgICAgKiBodG1sL1RpbWVJbnB1 dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGltZUlucHV0VHlwZTo6RGF0ZVRpbWVFZGl0 Q29udHJvbE93bmVySW1wbDo6ZWRpdENvbnRyb2xWYWx1ZUNoYW5nZWQpOgorCiAyMDEyLTA5LTE5 ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFRo ZSBjb2xsYXBzaW5nIGJvcmRlciBjb2RlIG5lZWRzIGRpcmVjdGlvbi1hd2FyZSBib3JkZXIgZ2V0 dGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UaW1lSW5wdXRUeXBlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvVGltZUlucHV0VHlwZS5jcHAKaW5kZXggODgwZTQ0NzE5ODJk ZDM1ZWRiMWYwMTIwNmRkNjZjYTQ3YzhiNjJlMi4uYzE1OTdlY2JiYWJkYzY2ODQ5NzIxODE1NjNk MzBlNjBmYjA1OTEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UaW1lSW5wdXRU eXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RpbWVJbnB1dFR5cGUuY3BwCkBAIC0x NTIsNiArMTUyLDcgQEAgdm9pZCBUaW1lSW5wdXRUeXBlOjpEYXRlVGltZUVkaXRDb250cm9sT3du ZXJJbXBsOjplZGl0Q29udHJvbFZhbHVlQ2hhbmdlZCgpCiAgICAgaW5wdXQtPnNldE5lZWRzU3R5 bGVSZWNhbGMoKTsKICAgICBpbnB1dC0+ZGlzcGF0Y2hGb3JtQ29udHJvbElucHV0RXZlbnQoKTsK ICAgICBpbnB1dC0+ZGlzcGF0Y2hGb3JtQ29udHJvbENoYW5nZUV2ZW50KCk7CisgICAgaW5wdXQt Pm5vdGlmeUZvcm1TdGF0ZUNoYW5nZWQoKTsKIH0KIAogYm9vbCBUaW1lSW5wdXRUeXBlOjpoYXND dXN0b21Gb2N1c0xvZ2ljKCkgY29uc3QK