97149 2012-09-19 16:51:32 -0700 Fix IndexedDB unit tests 2012-09-20 14:45:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan alecflett jsbell tony webkit.review.bot oldest_to_newest 723969 0 dgrogan 2012-09-19 16:51:32 -0700 Fix IndexedDB unit tests 723976 1 164804 dgrogan 2012-09-19 16:57:54 -0700 Created attachment 164804 Patch 723978 2 dgrogan 2012-09-19 16:58:18 -0700 Josh, could you take a look at this? 723986 3 164804 jsbell 2012-09-19 17:09:29 -0700 Comment on attachment 164804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164804&action=review > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:450 > + if (m_version == NoStringVersion && m_intVersion == IDBDatabaseMetadata::NoIntVersion && m_transactionCoordinator) { I'm uncomfortable with this. This is basically using m_transactionCoordinator as an "if null, I'm in test mode, so behave differently" flag which doesn't make for a good unit test; the behavior change has nothing to do with the coordinator itself (e.g. skipping a call, etc) It looks like this introduces a way for tests to bypass the open/upgradeneeded pattern to simplify the test. Could the test call openConnectionWithVersion(cb1, cb2, 0) and get the behavior that way? 724053 4 164804 dgrogan 2012-09-19 18:39:45 -0700 Comment on attachment 164804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164804&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:450 >> + if (m_version == NoStringVersion && m_intVersion == IDBDatabaseMetadata::NoIntVersion && m_transactionCoordinator) { > > I'm uncomfortable with this. This is basically using m_transactionCoordinator as an "if null, I'm in test mode, so behave differently" flag which doesn't make for a good unit test; the behavior change has nothing to do with the coordinator itself (e.g. skipping a call, etc) > > It looks like this introduces a way for tests to bypass the open/upgradeneeded pattern to simplify the test. Could the test call openConnectionWithVersion(cb1, cb2, 0) and get the behavior that way? So, the behavior change was at least slightly related to the coordinator - it was the null transaction coordinator that caused an invalid memory access if an int version transaction was run. But you're right about openConnectionWithVersion, it's possible to get the desired behavior by changing just test code, which seems a lot safer. 724057 5 164818 dgrogan 2012-09-19 18:41:28 -0700 Created attachment 164818 Patch 724098 6 jsbell 2012-09-19 19:43:22 -0700 (In reply to comment #4) > > So, the behavior change was at least slightly related to the coordinator - it was the null transaction coordinator that caused an invalid memory access if an int version transaction was run. Thanks - I didn't trace it all the way through. > But you're right about openConnectionWithVersion, it's possible to get the desired behavior by changing just test code, which seems a lot safer. Cool - I wasn't sure. New patch LGTM (although the -1 magic number might catch someone's attention...) 724834 7 164977 dgrogan 2012-09-20 13:59:13 -0700 Created attachment 164977 Patch 724840 8 dgrogan 2012-09-20 14:06:59 -0700 Nate, could you review this? jsbell@ gave it the LGTM in c6 724846 9 dgrogan 2012-09-20 14:09:48 -0700 Nate, never mind, just noticed you're gardening. Tony, could you review this? 724884 10 164977 webkit.review.bot 2012-09-20 14:45:34 -0700 Comment on attachment 164977 Patch Clearing flags on attachment: 164977 Committed r129170: <http://trac.webkit.org/changeset/129170> 724885 11 webkit.review.bot 2012-09-20 14:45:38 -0700 All reviewed patches have been landed. Closing bug. 164804 2012-09-19 16:57:54 -0700 2012-09-19 18:41:27 -0700 Patch bug-97149-20120919165720.patch text/plain 3643 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDk3ODFiZDNjOGYxNWYy ZTg1NzIzOTAyNGQwYmVjMmZhMjAzODViOS4uOWY0YWNhNjg5YjYyM2QzNWVhOTQ3ZTI2YzU4MmNm YmY4MGNmZjllYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTE5ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggSW5kZXhlZERC IHVuaXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk3MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdHM6IHdlYmtpdF91bml0X3Rlc3RzCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRk Yi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFi YXNlQmFja2VuZEltcGw6Om9wZW5Db25uZWN0aW9uKToKKyAgICAgICAgSWYgYSB1bml0IHRlc3Qg Y2FsbHMgb3BlbiB3aXRoIG5vIHZlcnNpb24gYW5kIG5vIHRyYW5zYWN0aW9uCisgICAgICAgIGNv b3JkaW5hdG9yLCB3ZSBhc3N1bWUgaXQganVzdCB3YW50cyB0byBvcGVuIGEgY29ubmVjdGlvbiBp bnN0ZWFkIG9mCisgICAgICAgIHRyaWdnZXJpbmcgYW55IHZlcnNpb24gY2hhbmdlIHRyYW5zYWN0 aW9ucy4KKwogMjAxMi0wOS0xOSAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBIYXJmQnV6elNoYXBlciBzaG91bGQgdGFrZSBpbnRv IGFjY291bnQgY29tYmluaW5nIGNoYXJhY3RlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5k ZXggNTU5M2MwMGRkODkyNzZmNzg2YThjOWI1MjI5N2M0MTJkMzhkZGQ5Yy4uYTdmODdmMjlhNWI4 YTAxZjk4NmNjMzc4NTVmYjNmZDQyYzdlNzQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cK QEAgLTEsNSArMSwxNCBAQAogMjAxMi0wOS0xOSAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJv bWl1bS5vcmc+CiAKKyAgICAgICAgRml4IEluZGV4ZWREQiB1bml0IHRlc3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzE0OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvSURCRGF0YWJhc2VC YWNrZW5kVGVzdC5jcHA6CisKKzIwMTItMDktMTkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hy b21pdW0ub3JnPgorCiAgICAgICAgIERpc2FibGUgc29tZSBmYWlsaW5nIElEQiB0ZXN0cwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxMzUKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFz ZUJhY2tlbmRJbXBsLmNwcAppbmRleCA0M2MwNDZiZThiMDc3NDk4YzdkNWFmNzE2MGU4M2EwMzM5 NDk4NjkzLi43ZjUwZmNjMmViNzhiZTg3NzYxMjVjOGYyNmYzOTY4OGI3ZTJhNDQ2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJ bXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFz ZUJhY2tlbmRJbXBsLmNwcApAQCAtNDQ2LDcgKzQ0Niw4IEBAIHZvaWQgSURCRGF0YWJhc2VCYWNr ZW5kSW1wbDo6b3BlbkNvbm5lY3Rpb24oUGFzc1JlZlB0cjxJREJDYWxsYmFja3M+IGNhbGxiYWNr cywKICAgICAgICAgY2FsbGJhY2tzLT5vbkVycm9yKElEQkRhdGFiYXNlRXJyb3I6OmNyZWF0ZShJ REJEYXRhYmFzZUV4Y2VwdGlvbjo6VU5LTk9XTl9FUlIsICJJbnRlcm5hbCBlcnJvci4iKSk7CiAg ICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgaWYgKG1fdmVyc2lvbiA9PSBOb1N0cmluZ1ZlcnNp b24gJiYgbV9pbnRWZXJzaW9uID09IElEQkRhdGFiYXNlTWV0YWRhdGE6Ok5vSW50VmVyc2lvbikg eworICAgIC8vIG1fdHJhbnNhY3Rpb25Db29yZGluYXRvciBzaG91bGQgb25seSBiZSBudWxsIGlu IHVuaXQgdGVzdHMuCisgICAgaWYgKG1fdmVyc2lvbiA9PSBOb1N0cmluZ1ZlcnNpb24gJiYgbV9p bnRWZXJzaW9uID09IElEQkRhdGFiYXNlTWV0YWRhdGE6Ok5vSW50VmVyc2lvbiAmJiBtX3RyYW5z YWN0aW9uQ29vcmRpbmF0b3IpIHsKICAgICAgICAgLy8gU3BlYyBzYXlzOiBJZiBubyB2ZXJzaW9u IGlzIHNwZWNpZmllZCBhbmQgbm8gZGF0YWJhc2UgZXhpc3RzLCBzZXQKICAgICAgICAgLy8gZGF0 YWJhc2UgdmVyc2lvbiB0byAxLiBXZSBpbmZlciB0aGF0IHRoZSBkYXRhYmFzZSBkaWRuJ3QgZXhp c3QgZnJvbQogICAgICAgICAvLyBpdHMgbGFjayBvZiBlaXRoZXIgdHlwZSBvZiB2ZXJzaW9uLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJEYXRhYmFzZUJhY2tl bmRUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCRGF0YWJhc2VCYWNr ZW5kVGVzdC5jcHAKaW5kZXggNjc3MGJmZThhYjZiNDgyMGEyODBkOGNlNzc2ZmZmODA3MTRjN2Ni OS4uY2I5NDI0M2QwNmFmZjIwOTljOTlhOGVlNmJhNDYwZjVmMzIxZGVlYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJEYXRhYmFzZUJhY2tlbmRUZXN0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQkRhdGFiYXNlQmFja2VuZFRlc3Qu Y3BwCkBAIC0xMTMsNyArMTEzLDcgQEAgcHJpdmF0ZToKICAgICBGYWtlSURCRGF0YWJhc2VDYWxs YmFja3MoKSB7IH0KIH07CiAKLVRFU1QoSURCRGF0YWJhc2VCYWNrZW5kVGVzdCwgRElTQUJMRURf Q29ubmVjdGlvbkxpZmVjeWNsZSkKK1RFU1QoSURCRGF0YWJhc2VCYWNrZW5kVGVzdCwgQ29ubmVj dGlvbkxpZmVjeWNsZSkKIHsKICAgICBSZWZQdHI8SURCRmFrZUJhY2tpbmdTdG9yZT4gYmFja2lu Z1N0b3JlID0gYWRvcHRSZWYobmV3IElEQkZha2VCYWNraW5nU3RvcmUoKSk7CiAgICAgRVhQRUNU X1RSVUUoYmFja2luZ1N0b3JlLT5oYXNPbmVSZWYoKSk7CkBAIC0xNzIsNyArMTcyLDcgQEAgcHJp dmF0ZToKICAgICBXZWJJREJEYXRhYmFzZUltcGwmIG1fd2ViRGF0YWJhc2U7CiB9OwogCi1URVNU KElEQkRhdGFiYXNlQmFja2VuZFRlc3QsIERJU0FCTEVEX0ZvcmNlZENsb3NlKQorVEVTVChJREJE YXRhYmFzZUJhY2tlbmRUZXN0LCBGb3JjZWRDbG9zZSkKIHsKICAgICBSZWZQdHI8SURCRmFrZUJh Y2tpbmdTdG9yZT4gYmFja2luZ1N0b3JlID0gYWRvcHRSZWYobmV3IElEQkZha2VCYWNraW5nU3Rv cmUoKSk7CiAgICAgRVhQRUNUX1RSVUUoYmFja2luZ1N0b3JlLT5oYXNPbmVSZWYoKSk7Cg== 164818 2012-09-19 18:41:28 -0700 2012-09-20 13:59:11 -0700 Patch bug-97149-20120919184054.patch text/plain 2912 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkxYTgxOTk2YTE4MGRhZDQ4ODNmMjRmOGRlNmRkNjdjYjkwYjM3MjkuLmU4ZmU2YmQ1NzA1NGNm MjllZDViNGQ1ZDJkNjE1YTYwZDdjZTBlNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMTkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEZpeCBJbmRleGVkREIgdW5pdCB0ZXN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxNDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL0lEQkRhdGFiYXNlQmFj a2VuZFRlc3QuY3BwOgorICAgICAgICBTcGVjaWZ5IGEgZGVzaXJlZCB2ZXJzaW9uIG9mIC0xIHNv IHRoYXQgbm8gdmVyc2lvbiBjaGFuZ2UgdHJhbnNhY3Rpb24KKyAgICAgICAgaXMgcnVuLgorCiAy MDEyLTA5LTE5ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg SW5kZXhlZERCOiBSZW1vdmUgImN1cnJlbnQgdHJhbnNhY3Rpb24iIGNvbmNlcHQgZnJvbSBiYWNr aW5nIHN0b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQkRh dGFiYXNlQmFja2VuZFRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJE YXRhYmFzZUJhY2tlbmRUZXN0LmNwcAppbmRleCA2NzcwYmZlOGFiNmI0ODIwYTI4MGQ4Y2U3NzZm ZmY4MDcxNGM3Y2I5Li4xNDc3Yzg1NTBmNGE5YTMzNWQ0YzQ2YmUyNjI3ZWI1N2U3ZDc2YmE3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lEQkRhdGFiYXNlQmFja2Vu ZFRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvSURCRGF0YWJhc2VC YWNrZW5kVGVzdC5jcHAKQEAgLTExMyw3ICsxMTMsNyBAQCBwcml2YXRlOgogICAgIEZha2VJREJE YXRhYmFzZUNhbGxiYWNrcygpIHsgfQogfTsKIAotVEVTVChJREJEYXRhYmFzZUJhY2tlbmRUZXN0 LCBESVNBQkxFRF9Db25uZWN0aW9uTGlmZWN5Y2xlKQorVEVTVChJREJEYXRhYmFzZUJhY2tlbmRU ZXN0LCBDb25uZWN0aW9uTGlmZWN5Y2xlKQogewogICAgIFJlZlB0cjxJREJGYWtlQmFja2luZ1N0 b3JlPiBiYWNraW5nU3RvcmUgPSBhZG9wdFJlZihuZXcgSURCRmFrZUJhY2tpbmdTdG9yZSgpKTsK ICAgICBFWFBFQ1RfVFJVRShiYWNraW5nU3RvcmUtPmhhc09uZVJlZigpKTsKQEAgLTEyNSwxMSAr MTI1LDExIEBAIFRFU1QoSURCRGF0YWJhc2VCYWNrZW5kVGVzdCwgRElTQUJMRURfQ29ubmVjdGlv bkxpZmVjeWNsZSkKIAogICAgIFJlZlB0cjxNb2NrSURCQ2FsbGJhY2tzPiByZXF1ZXN0MSA9IE1v Y2tJREJDYWxsYmFja3M6OmNyZWF0ZSgpOwogICAgIFJlZlB0cjxGYWtlSURCRGF0YWJhc2VDYWxs YmFja3M+IGNvbm5lY3Rpb24xID0gRmFrZUlEQkRhdGFiYXNlQ2FsbGJhY2tzOjpjcmVhdGUoKTsK LSAgICBkYi0+b3BlbkNvbm5lY3Rpb24ocmVxdWVzdDEsIGNvbm5lY3Rpb24xKTsKKyAgICBkYi0+ b3BlbkNvbm5lY3Rpb25XaXRoVmVyc2lvbihyZXF1ZXN0MSwgY29ubmVjdGlvbjEsIC0xKTsKIAog ICAgIFJlZlB0cjxNb2NrSURCQ2FsbGJhY2tzPiByZXF1ZXN0MiA9IE1vY2tJREJDYWxsYmFja3M6 OmNyZWF0ZSgpOwogICAgIFJlZlB0cjxGYWtlSURCRGF0YWJhc2VDYWxsYmFja3M+IGNvbm5lY3Rp b24yID0gRmFrZUlEQkRhdGFiYXNlQ2FsbGJhY2tzOjpjcmVhdGUoKTsKLSAgICBkYi0+b3BlbkNv bm5lY3Rpb24ocmVxdWVzdDIsIGNvbm5lY3Rpb24yKTsKKyAgICBkYi0+b3BlbkNvbm5lY3Rpb25X aXRoVmVyc2lvbihyZXF1ZXN0MiwgY29ubmVjdGlvbjIsIC0xKTsKIAogICAgIGRiLT5jbG9zZShj b25uZWN0aW9uMSk7CiAgICAgRVhQRUNUX0dUKGJhY2tpbmdTdG9yZS0+cmVmQ291bnQoKSwgMSk7 CkBAIC0xNzIsNyArMTcyLDcgQEAgcHJpdmF0ZToKICAgICBXZWJJREJEYXRhYmFzZUltcGwmIG1f d2ViRGF0YWJhc2U7CiB9OwogCi1URVNUKElEQkRhdGFiYXNlQmFja2VuZFRlc3QsIERJU0FCTEVE X0ZvcmNlZENsb3NlKQorVEVTVChJREJEYXRhYmFzZUJhY2tlbmRUZXN0LCBGb3JjZWRDbG9zZSkK IHsKICAgICBSZWZQdHI8SURCRmFrZUJhY2tpbmdTdG9yZT4gYmFja2luZ1N0b3JlID0gYWRvcHRS ZWYobmV3IElEQkZha2VCYWNraW5nU3RvcmUoKSk7CiAgICAgRVhQRUNUX1RSVUUoYmFja2luZ1N0 b3JlLT5oYXNPbmVSZWYoKSk7CkBAIC0xODgsNyArMTg4LDcgQEAgVEVTVChJREJEYXRhYmFzZUJh Y2tlbmRUZXN0LCBESVNBQkxFRF9Gb3JjZWRDbG9zZSkKIAogICAgIFJlZlB0cjxNb2NrSURCRGF0 YWJhc2VCYWNrZW5kUHJveHk+IHByb3h5ID0gTW9ja0lEQkRhdGFiYXNlQmFja2VuZFByb3h5Ojpj cmVhdGUod2ViRGF0YWJhc2UpOwogICAgIFJlZlB0cjxNb2NrSURCQ2FsbGJhY2tzPiByZXF1ZXN0 ID0gTW9ja0lEQkNhbGxiYWNrczo6Y3JlYXRlKCk7Ci0gICAgYmFja2VuZC0+b3BlbkNvbm5lY3Rp b24ocmVxdWVzdCwgY29ubmVjdGlvblByb3h5KTsKKyAgICBiYWNrZW5kLT5vcGVuQ29ubmVjdGlv bldpdGhWZXJzaW9uKHJlcXVlc3QsIGNvbm5lY3Rpb25Qcm94eSwgLTEpOwogCiAgICAgU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IDA7CiAgICAgUmVmUHRyPElEQkRhdGFiYXNlPiBp ZGJEYXRhYmFzZSA9IElEQkRhdGFiYXNlOjpjcmVhdGUoY29udGV4dCwgcHJveHksIGNvbm5lY3Rp b24pOwo= 164977 2012-09-20 13:59:13 -0700 2012-09-20 14:45:34 -0700 Patch bug-97149-20120920135838.patch text/plain 3015 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGU2MzRjYWRiMzAxNjllZDU2ZDlkNTkxOThkMDUwOTIwNTMyMDAwODAuLmYwMzQ4OGZkNzYzZjQz OTY2NzJkN2U3ZmNjOGQ5MTI4NzI4YjY4ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMTkgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEZpeCBJbmRleGVkREIgdW5pdCB0ZXN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxNDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL0lEQkRhdGFiYXNlQmFj a2VuZFRlc3QuY3BwOgorICAgICAgICBTcGVjaWZ5IGEgZGVzaXJlZCB2ZXJzaW9uIG9mIC0xIHNv IHRoYXQgbm8gdmVyc2lvbiBjaGFuZ2UgdHJhbnNhY3Rpb24KKyAgICAgICAgaXMgcnVuLgorCiAy MDEyLTA5LTIwICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBSZW1vdmUgdW51c2VkIGNvcHkgb2YgY2hyb21pdW0gY29tcG9zaXRvciBp bXBsZW1lbnRhdGlvbiBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9JREJEYXRhYmFzZUJhY2tlbmRUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvSURCRGF0YWJhc2VCYWNrZW5kVGVzdC5jcHAKaW5kZXggNjc3MGJmZThhYjZiNDgyMGEy ODBkOGNlNzc2ZmZmODA3MTRjN2NiOS4uNDU5ZGQ0Yjk3M2Y5ZmUwOWVlOWJmMjA5NGQxYzVkNDE2 NTc0YWMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9JREJEYXRh YmFzZUJhY2tlbmRUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0lE QkRhdGFiYXNlQmFja2VuZFRlc3QuY3BwCkBAIC0xMTMsNyArMTEzLDcgQEAgcHJpdmF0ZToKICAg ICBGYWtlSURCRGF0YWJhc2VDYWxsYmFja3MoKSB7IH0KIH07CiAKLVRFU1QoSURCRGF0YWJhc2VC YWNrZW5kVGVzdCwgRElTQUJMRURfQ29ubmVjdGlvbkxpZmVjeWNsZSkKK1RFU1QoSURCRGF0YWJh c2VCYWNrZW5kVGVzdCwgQ29ubmVjdGlvbkxpZmVjeWNsZSkKIHsKICAgICBSZWZQdHI8SURCRmFr ZUJhY2tpbmdTdG9yZT4gYmFja2luZ1N0b3JlID0gYWRvcHRSZWYobmV3IElEQkZha2VCYWNraW5n U3RvcmUoKSk7CiAgICAgRVhQRUNUX1RSVUUoYmFja2luZ1N0b3JlLT5oYXNPbmVSZWYoKSk7CkBA IC0xMjUsMTEgKzEyNSwxMSBAQCBURVNUKElEQkRhdGFiYXNlQmFja2VuZFRlc3QsIERJU0FCTEVE X0Nvbm5lY3Rpb25MaWZlY3ljbGUpCiAKICAgICBSZWZQdHI8TW9ja0lEQkNhbGxiYWNrcz4gcmVx dWVzdDEgPSBNb2NrSURCQ2FsbGJhY2tzOjpjcmVhdGUoKTsKICAgICBSZWZQdHI8RmFrZUlEQkRh dGFiYXNlQ2FsbGJhY2tzPiBjb25uZWN0aW9uMSA9IEZha2VJREJEYXRhYmFzZUNhbGxiYWNrczo6 Y3JlYXRlKCk7Ci0gICAgZGItPm9wZW5Db25uZWN0aW9uKHJlcXVlc3QxLCBjb25uZWN0aW9uMSk7 CisgICAgZGItPm9wZW5Db25uZWN0aW9uV2l0aFZlcnNpb24ocmVxdWVzdDEsIGNvbm5lY3Rpb24x LCBJREJEYXRhYmFzZU1ldGFkYXRhOjpOb0ludFZlcnNpb24pOwogCiAgICAgUmVmUHRyPE1vY2tJ REJDYWxsYmFja3M+IHJlcXVlc3QyID0gTW9ja0lEQkNhbGxiYWNrczo6Y3JlYXRlKCk7CiAgICAg UmVmUHRyPEZha2VJREJEYXRhYmFzZUNhbGxiYWNrcz4gY29ubmVjdGlvbjIgPSBGYWtlSURCRGF0 YWJhc2VDYWxsYmFja3M6OmNyZWF0ZSgpOwotICAgIGRiLT5vcGVuQ29ubmVjdGlvbihyZXF1ZXN0 MiwgY29ubmVjdGlvbjIpOworICAgIGRiLT5vcGVuQ29ubmVjdGlvbldpdGhWZXJzaW9uKHJlcXVl c3QyLCBjb25uZWN0aW9uMiwgSURCRGF0YWJhc2VNZXRhZGF0YTo6Tm9JbnRWZXJzaW9uKTsKIAog ICAgIGRiLT5jbG9zZShjb25uZWN0aW9uMSk7CiAgICAgRVhQRUNUX0dUKGJhY2tpbmdTdG9yZS0+ cmVmQ291bnQoKSwgMSk7CkBAIC0xNzIsNyArMTcyLDcgQEAgcHJpdmF0ZToKICAgICBXZWJJREJE YXRhYmFzZUltcGwmIG1fd2ViRGF0YWJhc2U7CiB9OwogCi1URVNUKElEQkRhdGFiYXNlQmFja2Vu ZFRlc3QsIERJU0FCTEVEX0ZvcmNlZENsb3NlKQorVEVTVChJREJEYXRhYmFzZUJhY2tlbmRUZXN0 LCBGb3JjZWRDbG9zZSkKIHsKICAgICBSZWZQdHI8SURCRmFrZUJhY2tpbmdTdG9yZT4gYmFja2lu Z1N0b3JlID0gYWRvcHRSZWYobmV3IElEQkZha2VCYWNraW5nU3RvcmUoKSk7CiAgICAgRVhQRUNU X1RSVUUoYmFja2luZ1N0b3JlLT5oYXNPbmVSZWYoKSk7CkBAIC0xODgsNyArMTg4LDcgQEAgVEVT VChJREJEYXRhYmFzZUJhY2tlbmRUZXN0LCBESVNBQkxFRF9Gb3JjZWRDbG9zZSkKIAogICAgIFJl ZlB0cjxNb2NrSURCRGF0YWJhc2VCYWNrZW5kUHJveHk+IHByb3h5ID0gTW9ja0lEQkRhdGFiYXNl QmFja2VuZFByb3h5OjpjcmVhdGUod2ViRGF0YWJhc2UpOwogICAgIFJlZlB0cjxNb2NrSURCQ2Fs bGJhY2tzPiByZXF1ZXN0ID0gTW9ja0lEQkNhbGxiYWNrczo6Y3JlYXRlKCk7Ci0gICAgYmFja2Vu ZC0+b3BlbkNvbm5lY3Rpb24ocmVxdWVzdCwgY29ubmVjdGlvblByb3h5KTsKKyAgICBiYWNrZW5k LT5vcGVuQ29ubmVjdGlvbldpdGhWZXJzaW9uKHJlcXVlc3QsIGNvbm5lY3Rpb25Qcm94eSwgSURC RGF0YWJhc2VNZXRhZGF0YTo6Tm9JbnRWZXJzaW9uKTsKIAogICAgIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQqIGNvbnRleHQgPSAwOwogICAgIFJlZlB0cjxJREJEYXRhYmFzZT4gaWRiRGF0YWJhc2Ug PSBJREJEYXRhYmFzZTo6Y3JlYXRlKGNvbnRleHQsIHByb3h5LCBjb25uZWN0aW9uKTsK