97120 2012-09-19 10:41:47 -0700 Web Inspector: yellow on-hover pop-up won't go if another pane asynchronously opens 2012-09-25 09:22:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin mbudaes apavlov bweinstein joepeck keishi loislo mbudaes mibalan pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 723650 0 prybin 2012-09-19 10:41:47 -0700 General steps: - in Sources tab provoke yellow inspect pop-up window by hovering over some variable in text - in previous step learn the timing for hover to trigger evaluation - manage to provoke inspect evaluation, but open ||> drawer (sources list) before the pop-up actually appears - yellow pop-up appears above ||> drawer Expected: pointing away from pop-up makes it go Actual: the pop-up remains fixed as long as you move mouse inside the opened ||> drawer. User have to learn that not only he has to point away from the pop-up, but also point to the original half-visible pane of source text. This is pretty much unintuitive. Hints for reproducing Enable pause on exceptions. Open http://design.ru Execution will stop on widgets.js with TypeError. A "window" variable is references in left-top corner of the text, which is handy for starting heavy evaluate and making it to open ||> 724301 1 mbudaes 2012-09-20 02:00:22 -0700 I will try looking into this bug. 726690 2 165388 mbudaes 2012-09-24 08:29:07 -0700 Created attachment 165388 Add mouseout event listener on popover element. 727395 3 165388 apavlov 2012-09-25 01:16:52 -0700 Comment on attachment 165388 Add mouseout event listener on popover element. View in context: https://bugs.webkit.org/attachment.cgi?id=165388&action=review > Source/WebCore/ChangeLog:3 > + Fix for bug 97210 Please remove this auto-added line > Source/WebCore/inspector/front-end/Popover.js:242 > + if (event.target === this._hoverElement || WebKit has no limit for the line length, so the entire condition can be placed on a single line. And we definitely do not observe closing parentheses on a separate line. > Source/WebCore/inspector/front-end/Popover.js:243 > + (this.isPopoverVisible() && !event.toElement.isSelfOrDescendant(this._popover._contentDiv)) IIRC, event.toElement can be null/undefined if you are moving the pointer outside the browser window quickly (which is confirmed by http://trac.webkit.org/browser/trunk/Source/WebCore/dom/MouseEvent.cpp#L137). Also, "toElement" is an MSIE extension. The spec'ed way is "event.relatedTarget". 727413 4 165556 mbudaes 2012-09-25 01:46:42 -0700 Created attachment 165556 Update the patch based on the review. 727502 5 165556 apavlov 2012-09-25 04:28:17 -0700 Comment on attachment 165556 Update the patch based on the review. View in context: https://bugs.webkit.org/attachment.cgi?id=165556&action=review > Source/WebCore/ChangeLog:3 > + Fix for bug 97210 Hmm, please remove this auto-generated line... > Source/WebCore/inspector/front-end/Popover.js:242 > + if (event.target === this._hoverElement || (this.isPopoverVisible() && !event.relatedTarget.isSelfOrDescendant(this._popover._contentDiv))) Please check event.relatedTarget for null-ity to avoid throwing a JS exception. 727677 6 165619 mbudaes 2012-09-25 08:44:40 -0700 Created attachment 165619 New patch update 727682 7 165619 apavlov 2012-09-25 08:53:11 -0700 Comment on attachment 165619 New patch update View in context: https://bugs.webkit.org/attachment.cgi?id=165619&action=review Two small nits to fix, and the patch will be ready to land > Source/WebCore/inspector/front-end/Popover.js:244 > + && event.relatedTarget !== null WebKit coding style guidelines require that null/0/undefined/whatever checks be performed by casting to a bool (e.g. ... && event.relatedTarget && ...) unless we need to disambiguate the actual value (e.g. null vs. undefined vs. "" vs. 0) - see http://www.webkit.org/coding/coding-style.html#zero-comparison > Source/WebCore/inspector/front-end/Popover.js:246 > + if (event.target === this._hoverElement || isPopoverMouseOut ) Extraneous whitespace before ')' 727686 8 165621 mbudaes 2012-09-25 09:01:48 -0700 Created attachment 165621 Address review comments 727688 9 165621 apavlov 2012-09-25 09:03:18 -0700 Comment on attachment 165621 Address review comments r=me 727702 10 165621 webkit.review.bot 2012-09-25 09:22:37 -0700 Comment on attachment 165621 Address review comments Clearing flags on attachment: 165621 Committed r129516: <http://trac.webkit.org/changeset/129516> 727703 11 webkit.review.bot 2012-09-25 09:22:41 -0700 All reviewed patches have been landed. Closing bug. 165388 2012-09-24 08:29:07 -0700 2012-09-25 01:16:52 -0700 Add mouseout event listener on popover element. b97120.patch text/plain 2035 mbudaes ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTBiOWRlLi41N2YzNDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDktMjQgIG1pcmUgIDxtYnVkYWVzQGFkb2JlLmNvbT4KKworICAgICAgICBGaXgg Zm9yIGJ1ZyA5NzIxMAorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHllbGxvdyBvbi1ob3ZlciBw b3AtdXAgd29uJ3QgZ28gaWYgYW5vdGhlciBwYW5lIGFzeW5jaHJvbm91c2x5IG9wZW5zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzEyMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtb3VzZW91dCBl dmVudCBsaXN0ZW5lciB0byBwb3BvdmVyIGVsZW1lbnQgc28gdGhhdCB0aGUgcG9wLXVwIHdpbGwg Z28gd2hlbiBtb3ZpbmcgdG8gYW5vdGhlciBwYW5lbC4KKworICAgICAgICBObyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuUG9wb3Zlci5wcm90b3R5cGUuc2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUuX21vdXNlT3V0KToKKwogMjAxMi0wOS0yNCAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZW1v dmUgQml0TG9ja2VyU2tpYS4gSXQncyBhcHBhcmVudGx5IG5vdCB1c2VkLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzCmluZGV4IDVkZmIzM2YuLjFiYzNh MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zl ci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMK QEAgLTc0LDggKzc0LDEwIEBAIFdlYkluc3BlY3Rvci5Qb3BvdmVyLnByb3RvdHlwZSA9IHsKICAg ICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCh0aGlzLmVsZW1lbnQpOwogICAgICAgICB0 aGlzLl9wb3NpdGlvbkVsZW1lbnQoYW5jaG9yLCBwcmVmZXJyZWRXaWR0aCwgcHJlZmVycmVkSGVp Z2h0KTsKICAgICAgICAgdGhpcy5fdmlzaWJsZSA9IHRydWU7Ci0gICAgICAgIGlmICh0aGlzLl9w b3BvdmVySGVscGVyKQorICAgICAgICBpZiAodGhpcy5fcG9wb3ZlckhlbHBlcikgewogICAgICAg ICAgICAgY29udGVudEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhpcy5f cG9wb3ZlckhlbHBlci5fa2lsbEhpZGVQb3BvdmVyVGltZXIuYmluZCh0aGlzLl9wb3BvdmVySGVs cGVyKSwgdHJ1ZSk7CisgICAgICAgICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi bW91c2VvdXQiLCB0aGlzLl9wb3BvdmVySGVscGVyLl9tb3VzZU91dC5iaW5kKHRoaXMuX3BvcG92 ZXJIZWxwZXIpLCB0cnVlKTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBoaWRlOiBmdW5jdGlv bigpCkBAIC0yMzcsNyArMjM5LDkgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90 eXBlID0gewogCiAgICAgX21vdXNlT3V0OiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAg IGlmIChldmVudC50YXJnZXQgPT09IHRoaXMuX2hvdmVyRWxlbWVudCkKKyAgICAgICAgaWYgKGV2 ZW50LnRhcmdldCA9PT0gdGhpcy5faG92ZXJFbGVtZW50IHx8IAorICAgICAgICAgICAgKHRoaXMu aXNQb3BvdmVyVmlzaWJsZSgpICYmICFldmVudC50b0VsZW1lbnQuaXNTZWxmT3JEZXNjZW5kYW50 KHRoaXMuX3BvcG92ZXIuX2NvbnRlbnREaXYpKQorICAgICAgICAgICApCiAgICAgICAgICAgICB0 aGlzLl9zdGFydEhpZGVQb3BvdmVyVGltZXIoKTsKICAgICB9LAogCg== 165556 2012-09-25 01:46:42 -0700 2012-09-25 04:28:17 -0700 Update the patch based on the review. b97120.patch text/plain 2012 mbudaes ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTBiOWRlLi41N2YzNDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDktMjQgIG1pcmUgIDxtYnVkYWVzQGFkb2JlLmNvbT4KKworICAgICAgICBGaXgg Zm9yIGJ1ZyA5NzIxMAorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHllbGxvdyBvbi1ob3ZlciBw b3AtdXAgd29uJ3QgZ28gaWYgYW5vdGhlciBwYW5lIGFzeW5jaHJvbm91c2x5IG9wZW5zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzEyMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtb3VzZW91dCBl dmVudCBsaXN0ZW5lciB0byBwb3BvdmVyIGVsZW1lbnQgc28gdGhhdCB0aGUgcG9wLXVwIHdpbGwg Z28gd2hlbiBtb3ZpbmcgdG8gYW5vdGhlciBwYW5lbC4KKworICAgICAgICBObyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuUG9wb3Zlci5wcm90b3R5cGUuc2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUuX21vdXNlT3V0KToKKwogMjAxMi0wOS0yNCAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZW1v dmUgQml0TG9ja2VyU2tpYS4gSXQncyBhcHBhcmVudGx5IG5vdCB1c2VkLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzCmluZGV4IDVkZmIzM2YuLmE0NDU3 OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9wb3Zl ci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMK QEAgLTc0LDggKzc0LDEwIEBAIFdlYkluc3BlY3Rvci5Qb3BvdmVyLnByb3RvdHlwZSA9IHsKICAg ICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCh0aGlzLmVsZW1lbnQpOwogICAgICAgICB0 aGlzLl9wb3NpdGlvbkVsZW1lbnQoYW5jaG9yLCBwcmVmZXJyZWRXaWR0aCwgcHJlZmVycmVkSGVp Z2h0KTsKICAgICAgICAgdGhpcy5fdmlzaWJsZSA9IHRydWU7Ci0gICAgICAgIGlmICh0aGlzLl9w b3BvdmVySGVscGVyKQorICAgICAgICBpZiAodGhpcy5fcG9wb3ZlckhlbHBlcikgewogICAgICAg ICAgICAgY29udGVudEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhpcy5f cG9wb3ZlckhlbHBlci5fa2lsbEhpZGVQb3BvdmVyVGltZXIuYmluZCh0aGlzLl9wb3BvdmVySGVs cGVyKSwgdHJ1ZSk7CisgICAgICAgICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi bW91c2VvdXQiLCB0aGlzLl9wb3BvdmVySGVscGVyLl9tb3VzZU91dC5iaW5kKHRoaXMuX3BvcG92 ZXJIZWxwZXIpLCB0cnVlKTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBoaWRlOiBmdW5jdGlv bigpCkBAIC0yMzcsNyArMjM5LDcgQEAgV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90 eXBlID0gewogCiAgICAgX21vdXNlT3V0OiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0gICAgICAg IGlmIChldmVudC50YXJnZXQgPT09IHRoaXMuX2hvdmVyRWxlbWVudCkKKyAgICAgICAgaWYgKGV2 ZW50LnRhcmdldCA9PT0gdGhpcy5faG92ZXJFbGVtZW50IHx8ICh0aGlzLmlzUG9wb3ZlclZpc2li bGUoKSAmJiAhZXZlbnQucmVsYXRlZFRhcmdldC5pc1NlbGZPckRlc2NlbmRhbnQodGhpcy5fcG9w b3Zlci5fY29udGVudERpdikpKQogICAgICAgICAgICAgdGhpcy5fc3RhcnRIaWRlUG9wb3ZlclRp bWVyKCk7CiAgICAgfSwKIAo= 165619 2012-09-25 08:44:40 -0700 2012-09-25 08:53:11 -0700 New patch update b97120.patch text/plain 2173 mbudaes ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTBiOWRlLi5kZWEwYWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMjQgIG1pcmUgIDxtYnVkYWVzQGFkb2JlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiB5ZWxsb3cgb24taG92ZXIgcG9wLXVwIHdvbid0IGdvIGlmIGFub3RoZXIgcGFu ZSBhc3luY2hyb25vdXNseSBvcGVucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTcxMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbW91c2VvdXQgZXZlbnQgbGlzdGVuZXIgdG8gcG9wb3ZlciBlbGVt ZW50IHNvIHRoYXQgdGhlIHBvcC11cCB3aWxsIGdvIHdoZW4gbW92aW5nIHRvIGFub3RoZXIgcGFu ZWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Qb3BvdmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXIucHJvdG90eXBl LnNob3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlLl9t b3VzZU91dCk6CisKIDIwMTItMDktMjQgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIEJpdExvY2tlclNraWEuIEl0J3MgYXBwYXJl bnRseSBub3QgdXNlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUG9wb3Zlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9w b3Zlci5qcwppbmRleCA1ZGZiMzNmLi5iY2I1YzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzCkBAIC03NCw4ICs3NCwxMCBAQCBXZWJJbnNwZWN0 b3IuUG9wb3Zlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQodGhpcy5lbGVtZW50KTsKICAgICAgICAgdGhpcy5fcG9zaXRpb25FbGVtZW50KGFuY2hvciwg cHJlZmVycmVkV2lkdGgsIHByZWZlcnJlZEhlaWdodCk7CiAgICAgICAgIHRoaXMuX3Zpc2libGUg PSB0cnVlOwotICAgICAgICBpZiAodGhpcy5fcG9wb3ZlckhlbHBlcikKKyAgICAgICAgaWYgKHRo aXMuX3BvcG92ZXJIZWxwZXIpIHsKICAgICAgICAgICAgIGNvbnRlbnRFbGVtZW50LmFkZEV2ZW50 TGlzdGVuZXIoIm1vdXNlbW92ZSIsIHRoaXMuX3BvcG92ZXJIZWxwZXIuX2tpbGxIaWRlUG9wb3Zl clRpbWVyLmJpbmQodGhpcy5fcG9wb3ZlckhlbHBlciksIHRydWUpOworICAgICAgICAgICAgdGhp cy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgdGhpcy5fcG9wb3ZlckhlbHBl ci5fbW91c2VPdXQuYmluZCh0aGlzLl9wb3BvdmVySGVscGVyKSwgdHJ1ZSk7CisgICAgICAgIH0K ICAgICB9LAogCiAgICAgaGlkZTogZnVuY3Rpb24oKQpAQCAtMjM3LDcgKzIzOSwxMSBAQCBXZWJJ bnNwZWN0b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUgPSB7CiAKICAgICBfbW91c2VPdXQ6IGZ1 bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKGV2ZW50LnRhcmdldCA9PT0gdGhpcy5f aG92ZXJFbGVtZW50KQorICAgICAgICAvLyBpc1BvcG92ZXJNb3VzZU91dCAtIGNoZWNrIHRoZSBt b3VzZSBpcyBvdXQgb2YgdGhlIHBvcG92ZXIgd2luZG93ICAgCisgICAgICAgIHZhciBpc1BvcG92 ZXJNb3VzZU91dCA9IHRoaXMuaXNQb3BvdmVyVmlzaWJsZSgpCisgICAgICAgICAgICAmJiBldmVu dC5yZWxhdGVkVGFyZ2V0ICE9PSBudWxsCisgICAgICAgICAgICAmJiAhZXZlbnQucmVsYXRlZFRh cmdldC5pc1NlbGZPckRlc2NlbmRhbnQodGhpcy5fcG9wb3Zlci5fY29udGVudERpdik7CisgICAg ICAgIGlmIChldmVudC50YXJnZXQgPT09IHRoaXMuX2hvdmVyRWxlbWVudCB8fCBpc1BvcG92ZXJN b3VzZU91dCApCiAgICAgICAgICAgICB0aGlzLl9zdGFydEhpZGVQb3BvdmVyVGltZXIoKTsKICAg ICB9LAogCg== 165621 2012-09-25 09:01:48 -0700 2012-09-25 09:22:37 -0700 Address review comments b97120.patch text/plain 2163 mbudaes ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTBiOWRlLi5kZWEwYWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMjQgIG1pcmUgIDxtYnVkYWVzQGFkb2JlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiB5ZWxsb3cgb24taG92ZXIgcG9wLXVwIHdvbid0IGdvIGlmIGFub3RoZXIgcGFu ZSBhc3luY2hyb25vdXNseSBvcGVucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTcxMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbW91c2VvdXQgZXZlbnQgbGlzdGVuZXIgdG8gcG9wb3ZlciBlbGVt ZW50IHNvIHRoYXQgdGhlIHBvcC11cCB3aWxsIGdvIHdoZW4gbW92aW5nIHRvIGFub3RoZXIgcGFu ZWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Qb3BvdmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXIucHJvdG90eXBl LnNob3cpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIucHJvdG90eXBlLl9t b3VzZU91dCk6CisKIDIwMTItMDktMjQgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIEJpdExvY2tlclNraWEuIEl0J3MgYXBwYXJl bnRseSBub3QgdXNlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUG9wb3Zlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUG9w b3Zlci5qcwppbmRleCA1ZGZiMzNmLi5jZTFlMTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1BvcG92ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Qb3BvdmVyLmpzCkBAIC03NCw4ICs3NCwxMCBAQCBXZWJJbnNwZWN0 b3IuUG9wb3Zlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQodGhpcy5lbGVtZW50KTsKICAgICAgICAgdGhpcy5fcG9zaXRpb25FbGVtZW50KGFuY2hvciwg cHJlZmVycmVkV2lkdGgsIHByZWZlcnJlZEhlaWdodCk7CiAgICAgICAgIHRoaXMuX3Zpc2libGUg PSB0cnVlOwotICAgICAgICBpZiAodGhpcy5fcG9wb3ZlckhlbHBlcikKKyAgICAgICAgaWYgKHRo aXMuX3BvcG92ZXJIZWxwZXIpIHsKICAgICAgICAgICAgIGNvbnRlbnRFbGVtZW50LmFkZEV2ZW50 TGlzdGVuZXIoIm1vdXNlbW92ZSIsIHRoaXMuX3BvcG92ZXJIZWxwZXIuX2tpbGxIaWRlUG9wb3Zl clRpbWVyLmJpbmQodGhpcy5fcG9wb3ZlckhlbHBlciksIHRydWUpOworICAgICAgICAgICAgdGhp cy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgdGhpcy5fcG9wb3ZlckhlbHBl ci5fbW91c2VPdXQuYmluZCh0aGlzLl9wb3BvdmVySGVscGVyKSwgdHJ1ZSk7CisgICAgICAgIH0K ICAgICB9LAogCiAgICAgaGlkZTogZnVuY3Rpb24oKQpAQCAtMjM3LDcgKzIzOSwxMSBAQCBXZWJJ bnNwZWN0b3IuUG9wb3ZlckhlbHBlci5wcm90b3R5cGUgPSB7CiAKICAgICBfbW91c2VPdXQ6IGZ1 bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKGV2ZW50LnRhcmdldCA9PT0gdGhpcy5f aG92ZXJFbGVtZW50KQorICAgICAgICAvLyBpc1BvcG92ZXJNb3VzZU91dCAtIGNoZWNrIHRoZSBt b3VzZSBpcyBvdXQgb2YgdGhlIHBvcG92ZXIgd2luZG93ICAgCisgICAgICAgIHZhciBpc1BvcG92 ZXJNb3VzZU91dCA9IHRoaXMuaXNQb3BvdmVyVmlzaWJsZSgpCisgICAgICAgICAgICAmJiBldmVu dC5yZWxhdGVkVGFyZ2V0CisgICAgICAgICAgICAmJiAhZXZlbnQucmVsYXRlZFRhcmdldC5pc1Nl bGZPckRlc2NlbmRhbnQodGhpcy5fcG9wb3Zlci5fY29udGVudERpdik7CisgICAgICAgIGlmIChl dmVudC50YXJnZXQgPT09IHRoaXMuX2hvdmVyRWxlbWVudCB8fCBpc1BvcG92ZXJNb3VzZU91dCkK ICAgICAgICAgICAgIHRoaXMuX3N0YXJ0SGlkZVBvcG92ZXJUaW1lcigpOwogICAgIH0sCiAK