97116 2012-09-19 10:15:00 -0700 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport 2012-09-19 10:53:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth fishd haraken japhet webkit.review.bot oldest_to_newest 723631 0 pilgrim 2012-09-19 10:15:00 -0700 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport 723632 1 164751 pilgrim 2012-09-19 10:15:45 -0700 Created attachment 164751 Patch 723634 2 pilgrim 2012-09-19 10:17:19 -0700 Routing call from WebCore/bindings/v8/V8Binding through FrameLoaderClient instead of PlatformSupport. 723636 3 164751 abarth 2012-09-19 10:19:57 -0700 Comment on attachment 164751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164751&action=review > Source/WebKit/chromium/src/FrameLoaderClientImpl.h:64 > + // Script in the page tried to allocate too much memory. I'd skip this comment. 723660 4 164751 webkit.review.bot 2012-09-19 10:53:25 -0700 Comment on attachment 164751 Patch Clearing flags on attachment: 164751 Committed r129020: <http://trac.webkit.org/changeset/129020> 723661 5 webkit.review.bot 2012-09-19 10:53:29 -0700 All reviewed patches have been landed. Closing bug. 164751 2012-09-19 10:15:45 -0700 2012-09-19 10:53:25 -0700 Patch bug-97116-20120919131510.patch text/plain 6468 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTAxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTE5ICBNYXJrIFBp bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE1vdmUg bm90aWZ5SlNPdXRPZk1lbW9yeSBvdXQgb2YgUGxhdGZvcm1TdXBwb3J0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzExNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhcnQgb2YgYSByZWZhY3RvcmluZyBz ZXJpZXMuIFNlZSB0cmFja2luZyBidWcgODI5NDguCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OEJpbmRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aGFuZGxlT3V0T2ZNZW1vcnkpOgorICAg ICAgICAqIGxvYWRlci9GcmFtZUxvYWRlckNsaWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVMb2FkZXJDbGllbnQ6OmRpZEV4aGF1c3RNZW1vcnlBdmFpbGFibGVGb3JTY3JpcHQpOgorICAg ICAgICAoRnJhbWVMb2FkZXJDbGllbnQpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Bs YXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoUGxhdGZvcm1TdXBwb3J0KToKKwogMjAxMi0wOS0x OSAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAg ICAgICAgIFtCbGFja0JlcnJ5XSBBZGQgZnVuY3Rpb24gcGxheWVySWQoKSBpbiBjbGFzcyBQYWdl Q2xpZW50QmxhY2tCZXJyeQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRp bmcuY3BwCShyZXZpc2lvbiAxMjkwMTApCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw4IEBACiAjaW5jbHVkZSAi RE9NU3RyaW5nTGlzdC5oIgogI2luY2x1ZGUgIkVsZW1lbnQuaCIKICNpbmNsdWRlICJGcmFtZS5o IgotI2luY2x1ZGUgIlBsYXRmb3JtU3VwcG9ydC5oIgorI2luY2x1ZGUgIkZyYW1lTG9hZGVyLmgi CisjaW5jbHVkZSAiRnJhbWVMb2FkZXJDbGllbnQuaCIKICNpbmNsdWRlICJRdWFsaWZpZWROYW1l LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJWOERPTVN0cmluZ0xpc3QuaCIK QEAgLTMzMiw3ICszMzMsNyBAQCBib29sIGhhbmRsZU91dE9mTWVtb3J5KCkKICAgICBmcmFtZS0+ c2NyaXB0KCktPndpbmRvd1NoZWxsKCktPmRlc3Ryb3lHbG9iYWwoKTsKIAogI2lmIFBMQVRGT1JN KENIUk9NSVVNKQotICAgIFBsYXRmb3JtU3VwcG9ydDo6bm90aWZ5SlNPdXRPZk1lbW9yeShmcmFt ZSk7CisgICAgZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKS0+ZGlkRXhoYXVzdE1lbW9yeUF2YWls YWJsZUZvclNjcmlwdCgpOwogI2VuZGlmCiAKICAgICBpZiAoU2V0dGluZ3MqIHNldHRpbmdzID0g ZnJhbWUtPnNldHRpbmdzKCkpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXJDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXJDbGllbnQuaAkocmV2aXNpb24gMTI5MDEwKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyQ2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3OCw2ICsyNzgsOCBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkb2N1bWVudEVsZW1lbnRBdmFp bGFibGUoKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRQZXJmb3JtRmlyc3ROYXZpZ2F0 aW9uKCkgY29uc3QgPSAwOyAvLyAiTmF2aWdhdGlvbiIgaGVyZSBtZWFucyBhIHRyYW5zaXRpb24g ZnJvbSBvbmUgcGFnZSB0byBhbm90aGVyIHRoYXQgZW5kcyB1cCBpbiB0aGUgYmFjay9mb3J3YXJk IGxpc3QuCiAKKyAgICAgICAgdmlydHVhbCB2b2lkIGRpZEV4aGF1c3RNZW1vcnlBdmFpbGFibGVG b3JTY3JpcHQoKSB7IH07CisKICNpZiBVU0UoVjgpCiAgICAgICAgIHZpcnR1YWwgdm9pZCBkaWRD cmVhdGVTY3JpcHRDb250ZXh0KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+LCBpbnQgZXh0ZW5zaW9u R3JvdXAsIGludCB3b3JsZElkKSA9IDA7CiAgICAgICAgIHZpcnR1YWwgdm9pZCB3aWxsUmVsZWFz ZVNjcmlwdENvbnRleHQodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4sIGludCB3b3JsZElkKSA9IDA7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9y bVN1cHBvcnQuaAkocmV2aXNpb24gMTI5MDEwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUGxhdGZvcm1TdXBwb3J0LmgJKHdvcmtpbmcgY29weSkKQEAgLTExMyw5ICsxMTMs NiBAQCBwdWJsaWM6CiAgICAgLy8gSW5kZXhlZERCIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJ REJGYWN0b3J5QmFja2VuZEludGVyZmFjZT4gaWRiRmFjdG9yeSgpOwogCi0gICAgLy8gSmF2YVNj cmlwdCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KLSAgICBzdGF0aWMgdm9pZCBub3RpZnlKU091dE9mTWVtb3J5KEZyYW1lKik7Ci0KICAg ICAvLyBQbHVnaW4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogICAgIHN0YXRpYyBib29sIHBsdWdpbnMoYm9vbCByZWZyZXNoLCBW ZWN0b3I8UGx1Z2luSW5mbz4qKTsKICAgICBzdGF0aWMgTlBPYmplY3QqIHBsdWdpblNjcmlwdGFi bGVPYmplY3QoV2lkZ2V0Kik7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNp b24gMTI5MDEyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wOS0xOSAgTWFyayBQaWxncmltICA8cGlsZ3Jp bUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBNb3ZlIG5vdGlmeUpTT3V0T2ZN ZW1vcnkgb3V0IG9mIFBsYXRmb3JtU3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQYXJ0IG9mIGEgcmVmYWN0b3Jpbmcgc2VyaWVzLiBTZWUgdHJh Y2tpbmcgYnVnIDgyOTQ4LgorICAgICAgICAKKyAgICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGll bnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpkaWRF eGhhdXN0TWVtb3J5QXZhaWxhYmxlRm9yU2NyaXB0KToKKyAgICAgICAgKFdlYktpdCk6CisgICAg ICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5oOgorICAgICAgICAoRnJhbWVMb2FkZXJD bGllbnRJbXBsKToKKyAgICAgICAgKiBzcmMvUGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAg KFdlYkNvcmUpOgorCiAyMDEyLTA5LTE5ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbQ2hyb21pdW1dIEZpeCBjcmFzaCBpbiBXZWJGcmFtZUltcGw6OmxvYWRI aXN0b3J5SXRlbQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJD bGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9G cmFtZUxvYWRlckNsaWVudEltcGwuY3BwCShyZXZpc2lvbiAxMjkwMTApCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDIsNiArMTQyLDEyIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpkb2N1bWVu dEVsZW0KICAgICAgICAgbV93ZWJGcmFtZS0+Y2xpZW50KCktPmRpZENyZWF0ZURvY3VtZW50RWxl bWVudChtX3dlYkZyYW1lKTsKIH0KIAordm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpZEV4 aGF1c3RNZW1vcnlBdmFpbGFibGVGb3JTY3JpcHQoKQoreworICAgIGlmIChtX3dlYkZyYW1lLT5j bGllbnQoKSkKKyAgICAgICAgbV93ZWJGcmFtZS0+Y2xpZW50KCktPmRpZEV4aGF1c3RNZW1vcnlB dmFpbGFibGVGb3JTY3JpcHQobV93ZWJGcmFtZSk7Cit9CisKICNpZiBVU0UoVjgpCiB2b2lkIEZy YW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlkQ3JlYXRlU2NyaXB0Q29udGV4dCh2ODo6SGFuZGxlPHY4 OjpDb250ZXh0PiBjb250ZXh0LCBpbnQgZXh0ZW5zaW9uR3JvdXAsIGludCB3b3JsZElkKQogewpJ bmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGll bnRJbXBsLmgJKHJldmlzaW9uIDEyOTAxMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02MSw2ICs2MSw5IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2hEaWRDbGVhcldpbmRvd09iamVjdElu V29ybGQoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkKik7CiAgICAgdmlydHVhbCB2b2lkIGRvY3Vt ZW50RWxlbWVudEF2YWlsYWJsZSgpOwogCisgICAgLy8gU2NyaXB0IGluIHRoZSBwYWdlIHRyaWVk IHRvIGFsbG9jYXRlIHRvbyBtdWNoIG1lbW9yeS4KKyAgICB2aXJ0dWFsIHZvaWQgZGlkRXhoYXVz dE1lbW9yeUF2YWlsYWJsZUZvclNjcmlwdCgpOworCiAjaWYgVVNFKFY4KQogICAgIHZpcnR1YWwg dm9pZCBkaWRDcmVhdGVTY3JpcHRDb250ZXh0KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+LCBpbnQg ZXh0ZW5zaW9uR3JvdXAsIGludCB3b3JsZElkKTsKICAgICB2aXJ0dWFsIHZvaWQgd2lsbFJlbGVh c2VTY3JpcHRDb250ZXh0KHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+LCBpbnQgd29ybGRJZCk7Cklu ZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAJ KHJldmlzaW9uIDEyOTAxMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3Jt U3VwcG9ydC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5OSwxNyArNDk5LDYgQEAgdm9pZCBQbGF0 Zm9ybVN1cHBvcnQ6OnBhaW50VGhlbWVQYXJ0KAogLy8gR2x1ZSBsYXllci4gT25jZSB0aGUgR2x1 ZSBsYXllciBtb3ZlcyBlbnRpcmVseSBpbnRvIHRoZSBXZWJLaXQgbGF5ZXIsIHRoZXNlCiAvLyBt ZXRob2RzIHdpbGwgYmUgZGVsZXRlZC4KIAotdm9pZCBQbGF0Zm9ybVN1cHBvcnQ6Om5vdGlmeUpT T3V0T2ZNZW1vcnkoRnJhbWUqIGZyYW1lKQotewotICAgIGlmICghZnJhbWUpCi0gICAgICAgIHJl dHVybjsKLQotICAgIFdlYkZyYW1lSW1wbCogd2ViRnJhbWUgPSBXZWJGcmFtZUltcGw6OmZyb21G cmFtZShmcmFtZSk7Ci0gICAgaWYgKCF3ZWJGcmFtZS0+Y2xpZW50KCkpCi0gICAgICAgIHJldHVy bjsKLSAgICB3ZWJGcmFtZS0+Y2xpZW50KCktPmRpZEV4aGF1c3RNZW1vcnlBdmFpbGFibGVGb3JT Y3JpcHQod2ViRnJhbWUpOwotfQotCiBpbnQgUGxhdGZvcm1TdXBwb3J0OjpzY3JlZW5Ib3Jpem9u dGFsRFBJKFdpZGdldCogd2lkZ2V0KQogewogICAgIFdlYldpZGdldENsaWVudCogY2xpZW50ID0g dG9XZWJXaWRnZXRDbGllbnQod2lkZ2V0KTsK