97111 2012-09-19 07:22:11 -0700 [WTR] Memory leaks in TestRunner::deliverWebIntent() 2012-09-19 10:57:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez kenneth webkit.review.bot oldest_to_newest 723550 0 naginenis 2012-09-19 07:22:11 -0700 Valgrind reports the following memory leaks in Web intents testing code. ==22718== 68 (24 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 4,193 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x1887A707: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:694) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) ==22718== 64 (24 direct, 40 indirect) bytes in 1 blocks are definitely lost in loss record 4,184 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x1887A73F: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:695) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) ==22718== ==22718== 64 (24 direct, 40 indirect) bytes in 1 blocks are definitely lost in loss record 4,185 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x1887A777: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:696) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) ==22718== 68 (24 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 4,194 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x541C904: WKBundleIntentCreate (WKBundleIntent.cpp:55) ==22718== by 0x1887A7A8: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:698) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) ==22718== ==22718== 64 (24 direct, 40 indirect) bytes in 1 blocks are definitely lost in loss record 4,186 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x541C96B: WKBundleIntentCreate (WKBundleIntent.cpp:57) ==22718== by 0x1887A7A8: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:698) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) ==22718== 64 (24 direct, 40 indirect) bytes in 1 blocks are definitely lost in loss record 4,187 of 5,550 ==22718== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==22718== by 0x9011AFE: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==22718== by 0x52E8DDA: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==22718== by 0x5334315: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==22718== by 0x5333F15: WKStringCreateWithUTF8CString (WKString.cpp:41) ==22718== by 0x541C9D2: WKBundleIntentCreate (WKBundleIntent.cpp:59) ==22718== by 0x1887A7A8: WTR::TestRunner::deliverWebIntent(OpaqueJSString*, OpaqueJSString*, OpaqueJSString*) (TestRunner.cpp:698) ==22718== by 0x1888A88F: WTR::JSTestRunner::deliverWebIntent(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (JSTestRunner.cpp:1124) 723566 1 164738 naginenis 2012-09-19 07:47:59 -0700 Created attachment 164738 Patch 723575 2 164738 cdumez 2012-09-19 08:17:05 -0700 Comment on attachment 164738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164738&action=review LGTM. Thanks for fixing this. > Tools/ChangeLog:9 > + created with WKStringCreateWtyUTF8CString(). nit: WKStringCreateWithUTF8CString() 723585 3 164742 naginenis 2012-09-19 08:34:08 -0700 Created attachment 164742 Patch Fixed nit. 723662 4 164742 webkit.review.bot 2012-09-19 10:57:09 -0700 Comment on attachment 164742 Patch Clearing flags on attachment: 164742 Committed r129022: <http://trac.webkit.org/changeset/129022> 723663 5 webkit.review.bot 2012-09-19 10:57:12 -0700 All reviewed patches have been landed. Closing bug. 164738 2012-09-19 07:47:59 -0700 2012-09-19 08:34:08 -0700 Patch 97111.patch text/plain 4900 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YTg4ZTUxLi5lYjJlYzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMTkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW1dUUl0gTWVtb3J5IGxlYWtzIGluIFRlc3RSdW5uZXI6OmRl bGl2ZXJXZWJJbnRlbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTcxMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggbWVtb3J5IGxlYWtzIGluIFdLQnVuZGxlSW50ZW50Q3JlYXRlKCkgYnkgYWRv cHRpbmcgc3RyaW5ncworICAgICAgICBjcmVhdGVkIHdpdGggV0tTdHJpbmdDcmVhdGVXaXRoVVRG OENTdHJpbmcoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2Mv V0tCdW5kbGVJbnRlbnQuY3BwOgorICAgICAgICAoV0tCdW5kbGVJbnRlbnRDcmVhdGUpOgorCiAy MDEyLTA5LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBBZGQgQVBJIHRvIGdldC9zZXQgdGhlIHNlY3VyaXR5IHBvbGljeSBvZiBh IGdpdmVuIFVSSSBzY2hlbWUgdG8gV2ViS2l0MiBHVEsrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSW50ZW50LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVJ bnRlbnQuY3BwCmluZGV4IDU2MWE1MTQuLmRjMTNjNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVJbnRlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVJbnRlbnQuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSAiV0tBUElDYXN0LmgiCiAj aW5jbHVkZSAiV0tCdW5kbGVBUElDYXN0LmgiCiAjaW5jbHVkZSAiV0tEaWN0aW9uYXJ5LmgiCisj aW5jbHVkZSAiV0tSZXRhaW5QdHIuaCIKICNpbmNsdWRlICJXS1N0cmluZy5oIgogI2luY2x1ZGUg IldlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5oIgogCkBAIC01MiwxMSArNTMsMTQgQEAgV0tUeXBl SUQgV0tCdW5kbGVJbnRlbnRHZXRUeXBlSUQoKQogV0tCdW5kbGVJbnRlbnRSZWYgV0tCdW5kbGVJ bnRlbnRDcmVhdGUoV0tEaWN0aW9uYXJ5UmVmIGRpY3Rpb25hcnlSZWYpCiB7CiAjaWYgRU5BQkxF KFdFQl9JTlRFTlRTKQotICAgIFdLU3RyaW5nUmVmIGFjdGlvbiA9IHN0YXRpY19jYXN0PFdLU3Ry aW5nUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGRpY3Rpb25hcnlSZWYsIFdLU3RyaW5n Q3JlYXRlV2l0aFVURjhDU3RyaW5nKCJhY3Rpb24iKSkpOworICAgIFdLUmV0YWluUHRyPFdLU3Ry aW5nUmVmPiBhY3Rpb25LZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmco ImFjdGlvbiIpKTsKKyAgICBXS1N0cmluZ1JlZiBhY3Rpb24gPSBzdGF0aWNfY2FzdDxXS1N0cmlu Z1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCBhY3Rpb25LZXku Z2V0KCkpKTsKICAgICBBU1NFUlQoYWN0aW9uKTsKLSAgICBXS1N0cmluZ1JlZiB0eXBlID0gc3Rh dGljX2Nhc3Q8V0tTdHJpbmdSZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkoZGljdGlvbmFy eVJlZiwgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoInR5cGUiKSkpOworICAgIFdLUmV0 YWluUHRyPFdLU3RyaW5nUmVmPiB0eXBlS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVU RjhDU3RyaW5nKCJ0eXBlIikpOworICAgIFdLU3RyaW5nUmVmIHR5cGUgPSBzdGF0aWNfY2FzdDxX S1N0cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCB0eXBl S2V5LmdldCgpKSk7CiAgICAgQVNTRVJUKHR5cGUpOwotICAgIFdLU2VyaWFsaXplZFNjcmlwdFZh bHVlUmVmIGRhdGEgPSBzdGF0aWNfY2FzdDxXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZj4oV0tE aWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCBXS1N0cmluZ0NyZWF0ZVdpdGhV VEY4Q1N0cmluZygiZGF0YSIpKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGRhdGFL ZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImRhdGEiKSk7CisgICAg V0tTZXJpYWxpemVkU2NyaXB0VmFsdWVSZWYgZGF0YSA9IHN0YXRpY19jYXN0PFdLU2VyaWFsaXpl ZFNjcmlwdFZhbHVlUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGRpY3Rpb25hcnlSZWYs IGRhdGFLZXkuZ2V0KCkpKTsKICAgICBNZXNzYWdlUG9ydEFycmF5IGR1bW15UG9ydHM7CiAgICAg RXhjZXB0aW9uQ29kZSBlYzsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMv Q2hhbmdlTG9nCmluZGV4IGMwMTUwZDUuLmFhYzU3MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0xOSAg U3VkYXJzYW5hIE5hZ2luZW5pICA8c3VkYXJzYW5hLm5hZ2luZW5pQGludGVsLmNvbT4KKworICAg ICAgICBbV1RSXSBNZW1vcnkgbGVha3MgaW4gVGVzdFJ1bm5lcjo6ZGVsaXZlcldlYkludGVudCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzExMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBtZW1v cnkgbGVha3MgaW4gZGVsaXZlcldlYkludGVudCgpIGJ5IGFkb3B0aW5nIHN0cmluZ3MKKyAgICAg ICAgY3JlYXRlZCB3aXRoIFdLU3RyaW5nQ3JlYXRlV3R5VVRGOENTdHJpbmcoKS4KKworICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHA6CisgICAg ICAgIChXVFI6OlRlc3RSdW5uZXI6OmRlbGl2ZXJXZWJJbnRlbnQpOgorCiAyMDEyLTA5LTE5ICBS aWNrIEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBEbyB0b3VjaCBhZGp1 c3RtZW50IG9uIEdlc3R1cmVUYXBEb3duCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAppbmRleCA4OTJiYzIxLi42MTk3YTc5IDEw MDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5u ZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1 bm5lci5jcHAKQEAgLTY5MSw5ICs2OTEsMTQgQEAgdm9pZCBUZXN0UnVubmVyOjpkZWxpdmVyV2Vi SW50ZW50KEpTU3RyaW5nUmVmIGFjdGlvbiwgSlNTdHJpbmdSZWYgdHlwZSwgSlNTdHJpbmcKICAg ICBXS1JldGFpblB0cjxXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZj4gZGF0YVdLKEFkb3B0V0ss IFdLU2VyaWFsaXplZFNjcmlwdFZhbHVlQ3JlYXRlKGNvbnRleHQsIEpTVmFsdWVNYWtlU3RyaW5n KGNvbnRleHQsIGRhdGEpLCAwKSk7CiAKICAgICBXS1JldGFpblB0cjxXS011dGFibGVEaWN0aW9u YXJ5UmVmPiBpbnRlbnRJbml0RGljdChBZG9wdFdLLCBXS011dGFibGVEaWN0aW9uYXJ5Q3JlYXRl KCkpOwotICAgIFdLRGljdGlvbmFyeUFkZEl0ZW0oaW50ZW50SW5pdERpY3QuZ2V0KCksIFdLU3Ry aW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJhY3Rpb24iKSwgYWN0aW9uV0suZ2V0KCkpOwotICAg IFdLRGljdGlvbmFyeUFkZEl0ZW0oaW50ZW50SW5pdERpY3QuZ2V0KCksIFdLU3RyaW5nQ3JlYXRl V2l0aFVURjhDU3RyaW5nKCJ0eXBlIiksIHR5cGVXSy5nZXQoKSk7Ci0gICAgV0tEaWN0aW9uYXJ5 QWRkSXRlbShpbnRlbnRJbml0RGljdC5nZXQoKSwgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJp bmcoImRhdGEiKSwgZGF0YVdLLmdldCgpKTsKKyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4g YWN0aW9uS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJhY3Rpb24i KSk7CisgICAgV0tEaWN0aW9uYXJ5QWRkSXRlbShpbnRlbnRJbml0RGljdC5nZXQoKSwgYWN0aW9u S2V5LmdldCgpLCBhY3Rpb25XSy5nZXQoKSk7CisKKyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1Jl Zj4gdHlwZUtleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygidHlwZSIp KTsKKyAgICBXS0RpY3Rpb25hcnlBZGRJdGVtKGludGVudEluaXREaWN0LmdldCgpLCB0eXBlS2V5 LmdldCgpLCB0eXBlV0suZ2V0KCkpOworCisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGRh dGFLZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImRhdGEiKSk7Cisg ICAgV0tEaWN0aW9uYXJ5QWRkSXRlbShpbnRlbnRJbml0RGljdC5nZXQoKSwgZGF0YUtleS5nZXQo KSwgZGF0YVdLLmdldCgpKTsKIAogICAgIFdLUmV0YWluUHRyPFdLQnVuZGxlSW50ZW50UmVmPiB3 a0ludGVudChBZG9wdFdLLCBXS0J1bmRsZUludGVudENyZWF0ZShpbnRlbnRJbml0RGljdC5nZXQo KSkpOwogICAgIFdLQnVuZGxlUGFnZURlbGl2ZXJJbnRlbnRUb0ZyYW1lKEluamVjdGVkQnVuZGxl OjpzaGFyZWQoKS5wYWdlKCktPnBhZ2UoKSwgbWFpbkZyYW1lLCB3a0ludGVudC5nZXQoKSk7Cg== 164742 2012-09-19 08:34:08 -0700 2012-09-19 10:57:09 -0700 Patch 97111.patch text/plain 4902 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YTg4ZTUxLi5lYjJlYzA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMTkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW1dUUl0gTWVtb3J5IGxlYWtzIGluIFRlc3RSdW5uZXI6OmRl bGl2ZXJXZWJJbnRlbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTcxMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggbWVtb3J5IGxlYWtzIGluIFdLQnVuZGxlSW50ZW50Q3JlYXRlKCkgYnkgYWRv cHRpbmcgc3RyaW5ncworICAgICAgICBjcmVhdGVkIHdpdGggV0tTdHJpbmdDcmVhdGVXaXRoVVRG OENTdHJpbmcoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2Mv V0tCdW5kbGVJbnRlbnQuY3BwOgorICAgICAgICAoV0tCdW5kbGVJbnRlbnRDcmVhdGUpOgorCiAy MDEyLTA5LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBBZGQgQVBJIHRvIGdldC9zZXQgdGhlIHNlY3VyaXR5IHBvbGljeSBvZiBh IGdpdmVuIFVSSSBzY2hlbWUgdG8gV2ViS2l0MiBHVEsrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSW50ZW50LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVJ bnRlbnQuY3BwCmluZGV4IDU2MWE1MTQuLmRjMTNjNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVJbnRlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5k bGVJbnRlbnQuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSAiV0tBUElDYXN0LmgiCiAj aW5jbHVkZSAiV0tCdW5kbGVBUElDYXN0LmgiCiAjaW5jbHVkZSAiV0tEaWN0aW9uYXJ5LmgiCisj aW5jbHVkZSAiV0tSZXRhaW5QdHIuaCIKICNpbmNsdWRlICJXS1N0cmluZy5oIgogI2luY2x1ZGUg IldlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5oIgogCkBAIC01MiwxMSArNTMsMTQgQEAgV0tUeXBl SUQgV0tCdW5kbGVJbnRlbnRHZXRUeXBlSUQoKQogV0tCdW5kbGVJbnRlbnRSZWYgV0tCdW5kbGVJ bnRlbnRDcmVhdGUoV0tEaWN0aW9uYXJ5UmVmIGRpY3Rpb25hcnlSZWYpCiB7CiAjaWYgRU5BQkxF KFdFQl9JTlRFTlRTKQotICAgIFdLU3RyaW5nUmVmIGFjdGlvbiA9IHN0YXRpY19jYXN0PFdLU3Ry aW5nUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGRpY3Rpb25hcnlSZWYsIFdLU3RyaW5n Q3JlYXRlV2l0aFVURjhDU3RyaW5nKCJhY3Rpb24iKSkpOworICAgIFdLUmV0YWluUHRyPFdLU3Ry aW5nUmVmPiBhY3Rpb25LZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmco ImFjdGlvbiIpKTsKKyAgICBXS1N0cmluZ1JlZiBhY3Rpb24gPSBzdGF0aWNfY2FzdDxXS1N0cmlu Z1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCBhY3Rpb25LZXku Z2V0KCkpKTsKICAgICBBU1NFUlQoYWN0aW9uKTsKLSAgICBXS1N0cmluZ1JlZiB0eXBlID0gc3Rh dGljX2Nhc3Q8V0tTdHJpbmdSZWY+KFdLRGljdGlvbmFyeUdldEl0ZW1Gb3JLZXkoZGljdGlvbmFy eVJlZiwgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoInR5cGUiKSkpOworICAgIFdLUmV0 YWluUHRyPFdLU3RyaW5nUmVmPiB0eXBlS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVU RjhDU3RyaW5nKCJ0eXBlIikpOworICAgIFdLU3RyaW5nUmVmIHR5cGUgPSBzdGF0aWNfY2FzdDxX S1N0cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCB0eXBl S2V5LmdldCgpKSk7CiAgICAgQVNTRVJUKHR5cGUpOwotICAgIFdLU2VyaWFsaXplZFNjcmlwdFZh bHVlUmVmIGRhdGEgPSBzdGF0aWNfY2FzdDxXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZj4oV0tE aWN0aW9uYXJ5R2V0SXRlbUZvcktleShkaWN0aW9uYXJ5UmVmLCBXS1N0cmluZ0NyZWF0ZVdpdGhV VEY4Q1N0cmluZygiZGF0YSIpKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGRhdGFL ZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImRhdGEiKSk7CisgICAg V0tTZXJpYWxpemVkU2NyaXB0VmFsdWVSZWYgZGF0YSA9IHN0YXRpY19jYXN0PFdLU2VyaWFsaXpl ZFNjcmlwdFZhbHVlUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGRpY3Rpb25hcnlSZWYs IGRhdGFLZXkuZ2V0KCkpKTsKICAgICBNZXNzYWdlUG9ydEFycmF5IGR1bW15UG9ydHM7CiAgICAg RXhjZXB0aW9uQ29kZSBlYzsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMv Q2hhbmdlTG9nCmluZGV4IGMwMTUwZDUuLjgzNGNmMzdjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMTkg IFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAg ICAgICAgW1dUUl0gTWVtb3J5IGxlYWtzIGluIFRlc3RSdW5uZXI6OmRlbGl2ZXJXZWJJbnRlbnQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcxMTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbWVt b3J5IGxlYWtzIGluIGRlbGl2ZXJXZWJJbnRlbnQoKSBieSBhZG9wdGluZyBzdHJpbmdzCisgICAg ICAgIGNyZWF0ZWQgd2l0aCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygpLgorCisgICAg ICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcDoKKyAg ICAgICAgKFdUUjo6VGVzdFJ1bm5lcjo6ZGVsaXZlcldlYkludGVudCk6CisKIDIwMTItMDktMTkg IFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIERvIHRvdWNoIGFk anVzdG1lbnQgb24gR2VzdHVyZVRhcERvd24KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1bm5lci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwCmluZGV4IDg5MmJjMjEuLjYxOTdhNzkg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvVGVzdFJ1 bm5lci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0 UnVubmVyLmNwcApAQCAtNjkxLDkgKzY5MSwxNCBAQCB2b2lkIFRlc3RSdW5uZXI6OmRlbGl2ZXJX ZWJJbnRlbnQoSlNTdHJpbmdSZWYgYWN0aW9uLCBKU1N0cmluZ1JlZiB0eXBlLCBKU1N0cmluZwog ICAgIFdLUmV0YWluUHRyPFdLU2VyaWFsaXplZFNjcmlwdFZhbHVlUmVmPiBkYXRhV0soQWRvcHRX SywgV0tTZXJpYWxpemVkU2NyaXB0VmFsdWVDcmVhdGUoY29udGV4dCwgSlNWYWx1ZU1ha2VTdHJp bmcoY29udGV4dCwgZGF0YSksIDApKTsKIAogICAgIFdLUmV0YWluUHRyPFdLTXV0YWJsZURpY3Rp b25hcnlSZWY+IGludGVudEluaXREaWN0KEFkb3B0V0ssIFdLTXV0YWJsZURpY3Rpb25hcnlDcmVh dGUoKSk7Ci0gICAgV0tEaWN0aW9uYXJ5QWRkSXRlbShpbnRlbnRJbml0RGljdC5nZXQoKSwgV0tT dHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImFjdGlvbiIpLCBhY3Rpb25XSy5nZXQoKSk7Ci0g ICAgV0tEaWN0aW9uYXJ5QWRkSXRlbShpbnRlbnRJbml0RGljdC5nZXQoKSwgV0tTdHJpbmdDcmVh dGVXaXRoVVRGOENTdHJpbmcoInR5cGUiKSwgdHlwZVdLLmdldCgpKTsKLSAgICBXS0RpY3Rpb25h cnlBZGRJdGVtKGludGVudEluaXREaWN0LmdldCgpLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0 cmluZygiZGF0YSIpLCBkYXRhV0suZ2V0KCkpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVm PiBhY3Rpb25LZXkoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoImFjdGlv biIpKTsKKyAgICBXS0RpY3Rpb25hcnlBZGRJdGVtKGludGVudEluaXREaWN0LmdldCgpLCBhY3Rp b25LZXkuZ2V0KCksIGFjdGlvbldLLmdldCgpKTsKKworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5n UmVmPiB0eXBlS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJ0eXBl IikpOworICAgIFdLRGljdGlvbmFyeUFkZEl0ZW0oaW50ZW50SW5pdERpY3QuZ2V0KCksIHR5cGVL ZXkuZ2V0KCksIHR5cGVXSy5nZXQoKSk7CisKKyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4g ZGF0YUtleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiZGF0YSIpKTsK KyAgICBXS0RpY3Rpb25hcnlBZGRJdGVtKGludGVudEluaXREaWN0LmdldCgpLCBkYXRhS2V5Lmdl dCgpLCBkYXRhV0suZ2V0KCkpOwogCiAgICAgV0tSZXRhaW5QdHI8V0tCdW5kbGVJbnRlbnRSZWY+ IHdrSW50ZW50KEFkb3B0V0ssIFdLQnVuZGxlSW50ZW50Q3JlYXRlKGludGVudEluaXREaWN0Lmdl dCgpKSk7CiAgICAgV0tCdW5kbGVQYWdlRGVsaXZlckludGVudFRvRnJhbWUoSW5qZWN0ZWRCdW5k bGU6OnNoYXJlZCgpLnBhZ2UoKS0+cGFnZSgpLCBtYWluRnJhbWUsIHdrSW50ZW50LmdldCgpKTsK