97092 2012-09-19 03:04:03 -0700 [GTK] REGRESSION(r128907): it broke several WebKit2 API tests 2012-09-19 07:00:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned alex oldest_to_newest 723421 0 cgarcia 2012-09-19 03:04:03 -0700 The problem is in RedirectedXCompositeWindow implementation. Every WebView creates a RedirectedXCompositeWindow of size 1,1. At the end of the constructor resize and resizeLater function are called: resize(size); resizeLater(); // Force update of the usable area. resize always schedules a resizeLater call because m_usableSize is uninitialized (0, 0) and is always smaller than size (1, 1). The first resizeLater, called right after resize() resets the m_pendingResizeSourceId. If the window is destroyed before the second resizeLater is called (called from the main loop), the destructor won't remove the source, because it has been reset by the first resizeLater and after the objects is freed, the second resizeLater will be called by the main loop with an already freed RedirectedXCompositeWindow. This happens often in unit tests where web view are created and destroyed quickly. Instead of calling resizeLater from the constructor to initialize m_usableSize, we could just initialize it to the given size. 723423 1 164704 cgarcia 2012-09-19 03:07:30 -0700 Created attachment 164704 Patch 723493 2 164704 mrobinson 2012-09-19 06:10:40 -0700 Comment on attachment 164704 Patch Thanks! 723534 3 cgarcia 2012-09-19 07:00:33 -0700 Committed r128996: <http://trac.webkit.org/changeset/128996> 164704 2012-09-19 03:07:30 -0700 2012-09-19 06:10:39 -0700 Patch wk2-ac-crash.diff text/plain 1905 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YzBlODg3Li45MjcyMmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDktMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjEyODkwNyk6IGl0IGJyb2tlIHNldmVyYWwg V2ViS2l0MiBBUEkgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk3MDkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2FsbGluZyByZXNpemVMYXRlcigpIGZyb20gdGhlIGNvbnN0cnVjdG9yIG9mCisg ICAgICAgIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93IGNhbiBjYXVzZSB0aGUgY2FsbGJhY2sg dG8gYmUgY2FsbGVkCisgICAgICAgIGxhdGVyIGJ5IHRoZSBtYWluIGxvb3AgYWZ0ZXIgdGhlIFJl ZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93IG9iamVjdAorICAgICAgICBoYXMgYmVlbiBkZXN0cm95 ZWQuIEluc3RlYWQgb2YgY2FsbGluZyByZXNpemVMYXRlcigpLCBpbml0aWFsaXplCisgICAgICAg IHRoZSB1c2FibGUgc2l6ZSB0byB0aGUgZ2l2ZW4gaW5pdGlhbCBzaXplLgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpSZWRpcmVjdGVkWENvbXBvc2l0ZVdp bmRvdyk6CisKIDIwMTItMDktMTggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFtXZWJLaXQyXSBVc2UgWENvbXBvc2l0ZSB3aW5kb3cgZm9y IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcAppbmRleCA2NzBiMjEx Li44OGJhNmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAKQEAgLTQzLDcgKzQzLDggQEAgUGFzc093 blB0cjxSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdz4gUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5k b3c6OmNyZWF0ZShjb25zdAogfQogCiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6UmVkaXJl Y3RlZFhDb21wb3NpdGVXaW5kb3coY29uc3QgSW50U2l6ZSYgc2l6ZSkKLSAgICA6IG1fd2luZG93 KDApCisgICAgOiBtX3VzYWJsZVNpemUoc2l6ZSkKKyAgICAsIG1fd2luZG93KDApCiAgICAgLCBt X3BhcmVudFdpbmRvdygwKQogICAgICwgbV9waXhtYXAoMCkKICAgICAsIG1fc3VyZmFjZSgwKQpA QCAtOTAsNyArOTEsNiBAQCBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6UmVkaXJlY3RlZFhD b21wb3NpdGVXaW5kb3coY29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICBYQ29tcG9zaXRlUmVkaXJl Y3RXaW5kb3coZGlzcGxheSwgbV93aW5kb3csIENvbXBvc2l0ZVJlZGlyZWN0TWFudWFsKTsKIAog ICAgIHJlc2l6ZShzaXplKTsKLSAgICByZXNpemVMYXRlcigpOyAvLyBGb3JjZSB1cGRhdGUgb2Yg dGhlIHVzYWJsZSBhcmVhLgogfQogCiBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6flJlZGly ZWN0ZWRYQ29tcG9zaXRlV2luZG93KCkK