97087 2012-09-19 02:17:43 -0700 [EFL][DRT]DumpRenderTree needs to reset focus state when test starts. 2012-09-20 03:16:18 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 mpakulavelrutka webkit-unassigned g.czajkowski gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 723400 0 mpakulavelrutka 2012-09-19 02:17:43 -0700 When running layout tests in editing/undo category in WebKit1 editing/undo/undo-indent and editing/undo/undo-misspellings have flaky results, as editing delegates does not match expected one. However if those test where ran separately, results where as expected. The difference comes from running editing/undo/undo-iframe-location-change before tests mentioned above: this test leaves frame in unfocused state and proper delegates are not triggered. 723417 1 164701 mpakulavelrutka 2012-09-19 02:50:27 -0700 Created attachment 164701 proposed patch The patch adds main frame focusing similar to WebKit-GTK's DumpRenderTree view focusing in dump() function. Then tests will start with main frame focused regardless of earlier test's frame focus state. 723428 2 g.czajkowski 2012-09-19 03:14:08 -0700 LGTM. Just wondering, did you try to set the frame focus in DumpRenderTreeChrome::resetDefaultsToConsistentValues()? IMHO it's good place to restore the original settings before running test. 723450 3 mpakulavelrutka 2012-09-19 04:33:55 -0700 (In reply to comment #2) > LGTM. > > Just wondering, did you try to set the frame focus in DumpRenderTreeChrome::resetDefaultsToConsistentValues()? IMHO it's good place to restore the original settings before running test. I checked and it also fixes the problem. I will check if it does not introduce any regressions, and then post a new patch. 723601 4 164746 mpakulavelrutka 2012-09-19 09:08:30 -0700 Created attachment 164746 setting focus moved into resetDefaultsToConsistentValues 724211 5 164746 g.czajkowski 2012-09-19 23:41:08 -0700 Comment on attachment 164746 setting focus moved into resetDefaultsToConsistentValues View in context: https://bugs.webkit.org/attachment.cgi?id=164746&action=review Thanks for your verification of newly proposed approach and changes. Looks better. > LayoutTests/ChangeLog:8 > + Remove two flaky tests from TestExpectations. Please add a note that after setting frame focus the tests are passing now. > Tools/ChangeLog:8 > + Add focusing a main frame on each test dump. on each test dump -> on settings reset? 724266 6 164859 mpakulavelrutka 2012-09-20 01:28:10 -0700 Created attachment 164859 change log fixes 724278 7 164859 gyuyoung.kim 2012-09-20 01:39:33 -0700 Comment on attachment 164859 change log fixes View in context: https://bugs.webkit.org/attachment.cgi?id=164859&action=review > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:291 > ewk_view_text_direction_set(mainView(), EWK_TEXT_DIRECTION_DEFAULT); It would be good if you add a new line to here. 724302 8 164864 mpakulavelrutka 2012-09-20 02:09:14 -0700 Created attachment 164864 moved focusing function below 724303 9 164864 gyuyoung.kim 2012-09-20 02:11:19 -0700 Comment on attachment 164864 moved focusing function below Looks fine. 724328 10 164864 g.czajkowski 2012-09-20 02:53:51 -0700 Comment on attachment 164864 moved focusing function below LGTM. Thanks. 724347 11 164864 webkit.review.bot 2012-09-20 03:16:14 -0700 Comment on attachment 164864 moved focusing function below Clearing flags on attachment: 164864 Committed r129110: <http://trac.webkit.org/changeset/129110> 724348 12 webkit.review.bot 2012-09-20 03:16:18 -0700 All reviewed patches have been landed. Closing bug. 164701 2012-09-19 02:50:27 -0700 2012-09-19 09:08:30 -0700 proposed patch focus.diff text/plain 2589 mpakulavelrutka ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxMTg4MDNhLi40MDJmZmNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDkt MTkgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdRHVtcFJlbmRlclRyZWUgbmVlZHMgdG8gcmVzZXQgZm9jdXMgc3Rh dGUgd2hlbiB0ZXN0IGVuZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSB0d28gZmxha3kgdGVzdHMgZnJvbSBUZXN0RXhwZWN0YXRpb25zLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA5 LTE5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTI4OTc2LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDJlMWQ5MTYuLjY1M2Y5MmYgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM4LDkg KzM4LDYgQEAgQlVHV0szMDcyNCBERUJVRyA6IGZhc3QvbG9hZGVyL29wYXF1ZS1iYXNlLXVybC5o dG1sID0gQ1JBU0gKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogCiAvLyBUZXN0 IHBhc3NlcywgYnV0IGVkaXRpbmcgZGVsZWdhdGVzIGRvZXMgbm90IG1hdGNoIGV4cGVjdGVkIG9u ZXMKLUJVR1dLRUZMIDogZWRpdGluZy91bmRvL3VuZG8taW5kZW50Lmh0bWwgPSBURVhUIFBBU1MK LUJVR1dLRUZMIDogZWRpdGluZy91bmRvL3VuZG8tbWlzc3BlbGxpbmdzLmh0bWwgPSBURVhUIFBB U1MKLQogQlVHV0s5NjY0MSA6IG1lZGlhL3ZpZGVvLXNlZWstcGFzdC1lbmQtcGxheWluZy5odG1s ID0gVEVYVCBQQVNTCiBCVUdXSzk2NjQyIDogbG9hZGVyL2dvLWJhY2stdG8tZGlmZmVyZW50LXdp bmRvdy1zaXplLmh0bWwgPSBURVhUIFBBU1MKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM4MWY0N2UuLjdhODU0MWYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx Mi0wOS0xOSAgTWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtFRkxdW0RSVF1EdW1wUmVuZGVyVHJlZSBuZWVkcyB0byByZXNldCBmb2N1 cyBzdGF0ZSB3aGVuIHRlc3QgZW5kcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk3MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGZvY3VzaW5nIGEgbWFpbiBmcmFtZSBvbiBlYWNoIHRlc3QgZHVt cC4KKyAgICAgICAgQWZ0ZXIgZWRpdGluZy91bmRvL3VuZG8taWZyYW1lLWxvY2F0aW9uLWNoYW5n ZSB3YXMgZXhlY3V0ZWQgYSBmcmFtZQorICAgICAgICB3YXMgbGVmdCBpbiB1bmZvY3VzZWQgc3Rh dGUuIFRoaXMgY2F1c2VkIGZsYWtpbmVzcyBpbiB0d28gdGVzdHMgcmVzdWx0cy4KKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChkdW1w KToKKwogMjAxMi0wOS0xOCAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW1dLMl1bV1RSXSBDb2RlR2VuZXJhdG9yVGVzdFJ1bm5lciBjb3VsZCBrZWVwIG9y aWdpbmFsIGNvcHlyaWdodC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9E dW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWUuY3BwCmluZGV4IGMxZTQ4MDEuLmNjOGM3YjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMzkzLDYgKzM5Myw4IEBAIHZvaWQgZHVtcCgpCiAK ICAgICBpbnZhbGlkYXRlQW55UHJldmlvdXNXYWl0VG9EdW1wV2F0Y2hkb2coKTsKIAorICAgIGV3 a19mcmFtZV9mZWVkX2ZvY3VzX2luKGZyYW1lKTsKKwogICAgIGlmIChkdW1wVHJlZSkgewogICAg ICAgICBhZGp1c3RPdXRwdXRUeXBlQnlNaW1lVHlwZShmcmFtZSk7CiAgICAgICAgIGR1bXBGcmFt ZUNvbnRlbnRzQXNUZXh0KGZyYW1lKTsK 164746 2012-09-19 09:08:30 -0700 2012-09-20 01:28:10 -0700 setting focus moved into resetDefaultsToConsistentValues focus4.diff text/plain 2827 mpakulavelrutka ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4OWEwNWNmLi42M2ZjZmFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDkt MTkgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdRHVtcFJlbmRlclRyZWUgbmVlZHMgdG8gcmVzZXQgZm9jdXMgc3Rh dGUgd2hlbiB0ZXN0IGVuZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSB0d28gZmxha3kgdGVzdHMgZnJvbSBUZXN0RXhwZWN0YXRpb25zLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA5 LTE5ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMS9U ZXN0RXhwZWN0YXRpb25zCmluZGV4IDJlMWQ5MTYuLjY1M2Y5MmYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM4LDkgKzM4LDYgQEAgQlVH V0szMDcyNCBERUJVRyA6IGZhc3QvbG9hZGVyL29wYXF1ZS1iYXNlLXVybC5odG1sID0gQ1JBU0gK IC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogCiAvLyBUZXN0IHBhc3NlcywgYnV0 IGVkaXRpbmcgZGVsZWdhdGVzIGRvZXMgbm90IG1hdGNoIGV4cGVjdGVkIG9uZXMKLUJVR1dLRUZM IDogZWRpdGluZy91bmRvL3VuZG8taW5kZW50Lmh0bWwgPSBURVhUIFBBU1MKLUJVR1dLRUZMIDog ZWRpdGluZy91bmRvL3VuZG8tbWlzc3BlbGxpbmdzLmh0bWwgPSBURVhUIFBBU1MKLQogQlVHV0s5 NjY0MSA6IG1lZGlhL3ZpZGVvLXNlZWstcGFzdC1lbmQtcGxheWluZy5odG1sID0gVEVYVCBQQVNT CiBCVUdXSzk2NjQyIDogbG9hZGVyL2dvLWJhY2stdG8tZGlmZmVyZW50LXdpbmRvdy1zaXplLmh0 bWwgPSBURVhUIFBBU1MKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IDc1OWQ4YmYuLmMxM2ViNDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOS0xOSAgTWlj aGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdW0RSVF1EdW1wUmVuZGVyVHJlZSBuZWVkcyB0byByZXNldCBmb2N1cyBzdGF0ZSB3aGVu IHRlc3QgZW5kcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk3MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGZvY3VzaW5nIGEgbWFpbiBmcmFtZSBvbiBlYWNoIHRlc3QgZHVtcC4KKyAgICAgICAg QWZ0ZXIgZWRpdGluZy91bmRvL3VuZG8taWZyYW1lLWxvY2F0aW9uLWNoYW5nZSB3YXMgZXhlY3V0 ZWQgYSBmcmFtZQorICAgICAgICB3YXMgbGVmdCBpbiB1bmZvY3VzZWQgc3RhdGUuIFRoaXMgY2F1 c2VkIGZsYWtpbmVzcyBpbiB0d28gdGVzdHMgcmVzdWx0cy4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHA6CisgICAgICAgIChEdW1wUmVuZGVy VHJlZUNocm9tZTo6cmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcyk6CisKIDIwMTItMDkt MTkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAg IFtRdF0gRml4IGluY3JlbWVudGFsIGJ1aWxkcyB3aXRoIGFsbC1pbi1vbmUtZmlsZXMgYW5kIGdj Y2RlcGVuZHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZUNocm9tZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVD aHJvbWUuY3BwCmluZGV4IDAzMGZkOWEuLmIzOTc2NTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcApAQCAtMjg5LDYgKzI4OSw3IEBA IHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1 ZXMoKQogICAgIGV3a192aWV3X3RleHRfem9vbV9zZXQobWFpblZpZXcoKSwgMS4wKTsKICAgICBl d2tfdmlld192aXNpYmlsaXR5X3N0YXRlX3NldChtYWluVmlldygpLCBFV0tfUEFHRV9WSVNJQklM SVRZX1NUQVRFX1ZJU0lCTEUsIHRydWUpOwogICAgIGV3a192aWV3X3RleHRfZGlyZWN0aW9uX3Nl dChtYWluVmlldygpLCBFV0tfVEVYVF9ESVJFQ1RJT05fREVGQVVMVCk7CisgICAgZXdrX2ZyYW1l X2ZlZWRfZm9jdXNfaW4obWFpbkZyYW1lKCkpOwogCiAgICAgZXdrX2hpc3RvcnlfY2xlYXIoZXdr X3ZpZXdfaGlzdG9yeV9nZXQobWFpblZpZXcoKSkpOwogCg== 164859 2012-09-20 01:28:10 -0700 2012-09-20 02:09:14 -0700 change log fixes focus5.diff text/plain 2917 mpakulavelrutka ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZDU1MGU1Li4yMzVjMTIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDkt MjAgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdRHVtcFJlbmRlclRyZWUgbmVlZHMgdG8gcmVzZXQgZm9jdXMgc3Rh dGUgd2hlbiB0ZXN0IHN0YXJ0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk3MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIHR3byBmbGFreSB0ZXN0cyBmcm9tIFRlc3RFeHBlY3RhdGlvbnMg YXMgdGhleSBwYXNzIGFmdGVyIHNldHRpbmcgZm9jdXMKKyAgICAgICAgb24gc2V0dGluZ3MgcmVz ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTItMDktMjAgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+ CiAKICAgICAgICAgW1F0XSBBZGQgZXZlbnRTZW5kZXIuZ2VzdHVyZVRhcApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDAxZWRlMWEuLjdlYTYz MTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTM4LDkgKzM4LDYgQEAgd2Via2l0Lm9yZy9iLzMwNzI0IFsgRGVidWcgXSBmYXN0L2xvYWRl ci9vcGFxdWUtYmFzZS11cmwuaHRtbCBbIENyYXNoIF0KICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vCiAKICMgVGVzdCBwYXNzZXMsIGJ1dCBlZGl0aW5nIGRlbGVnYXRlcyBkb2VzIG5v dCBtYXRjaCBleHBlY3RlZCBvbmVzCi1CdWcoRUZMKSBlZGl0aW5nL3VuZG8vdW5kby1pbmRlbnQu aHRtbCBbIEZhaWx1cmUgUGFzcyBdCi1CdWcoRUZMKSBlZGl0aW5nL3VuZG8vdW5kby1taXNzcGVs bGluZ3MuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi0KIHdlYmtpdC5vcmcvYi85NjY0MSBtZWRpYS92 aWRlby1zZWVrLXBhc3QtZW5kLXBsYXlpbmcuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiB3ZWJraXQu b3JnL2IvOTY2NDIgbG9hZGVyL2dvLWJhY2stdG8tZGlmZmVyZW50LXdpbmRvdy1zaXplLmh0bWwg WyBGYWlsdXJlIFBhc3MgXQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggYWY1MTg2Mi4uMjIwNDBjMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBN aWNoYcWCIFBha3XFgmEgdmVsIFJ1dGthICA8bS5wYWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF1bRFJUXUR1bXBSZW5kZXJUcmVlIG5lZWRzIHRvIHJlc2V0IGZvY3VzIHN0YXRlIHdo ZW4gdGVzdCBzdGFydHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBmb2N1c2luZyBhIG1haW4gZnJhbWUgb24gc2V0dGluZ3MgcmVzZXQuCisgICAg ICAgIEFmdGVyIGVkaXRpbmcvdW5kby91bmRvLWlmcmFtZS1sb2NhdGlvbi1jaGFuZ2Ugd2FzIGV4 ZWN1dGVkIGEgZnJhbWUKKyAgICAgICAgd2FzIGxlZnQgaW4gdW5mb2N1c2VkIHN0YXRlLiBUaGlz IGNhdXNlZCBmbGFraW5lc3MgaW4gdHdvIHRlc3RzIHJlc3VsdHMuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJl bmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDEy LTA5LTIwICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgog CiAgICAgICAgIFtRdF0gQWRkIGV2ZW50U2VuZGVyLmdlc3R1cmVUYXAKZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCmluZGV4IDAzMGZkOWEu LmIzOTc2NTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU cmVlQ2hyb21lLmNwcApAQCAtMjg5LDYgKzI4OSw3IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJv bWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIGV3a192aWV3X3RleHRf em9vbV9zZXQobWFpblZpZXcoKSwgMS4wKTsKICAgICBld2tfdmlld192aXNpYmlsaXR5X3N0YXRl X3NldChtYWluVmlldygpLCBFV0tfUEFHRV9WSVNJQklMSVRZX1NUQVRFX1ZJU0lCTEUsIHRydWUp OwogICAgIGV3a192aWV3X3RleHRfZGlyZWN0aW9uX3NldChtYWluVmlldygpLCBFV0tfVEVYVF9E SVJFQ1RJT05fREVGQVVMVCk7CisgICAgZXdrX2ZyYW1lX2ZlZWRfZm9jdXNfaW4obWFpbkZyYW1l KCkpOwogCiAgICAgZXdrX2hpc3RvcnlfY2xlYXIoZXdrX3ZpZXdfaGlzdG9yeV9nZXQobWFpblZp ZXcoKSkpOwogCg== 164864 2012-09-20 02:09:14 -0700 2012-09-20 03:16:14 -0700 moved focusing function below focus6.diff text/plain 2805 mpakulavelrutka ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZDU1MGU1Li4yMzVjMTIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDkt MjAgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtEUlRdRHVtcFJlbmRlclRyZWUgbmVlZHMgdG8gcmVzZXQgZm9jdXMgc3Rh dGUgd2hlbiB0ZXN0IHN0YXJ0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk3MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlIHR3byBmbGFreSB0ZXN0cyBmcm9tIFRlc3RFeHBlY3RhdGlvbnMg YXMgdGhleSBwYXNzIGFmdGVyIHNldHRpbmcgZm9jdXMKKyAgICAgICAgb24gc2V0dGluZ3MgcmVz ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTItMDktMjAgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+ CiAKICAgICAgICAgW1F0XSBBZGQgZXZlbnRTZW5kZXIuZ2VzdHVyZVRhcApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDAxZWRlMWEuLjdlYTYz MTEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTM4LDkgKzM4LDYgQEAgd2Via2l0Lm9yZy9iLzMwNzI0IFsgRGVidWcgXSBmYXN0L2xvYWRl ci9vcGFxdWUtYmFzZS11cmwuaHRtbCBbIENyYXNoIF0KICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vCiAKICMgVGVzdCBwYXNzZXMsIGJ1dCBlZGl0aW5nIGRlbGVnYXRlcyBkb2VzIG5v dCBtYXRjaCBleHBlY3RlZCBvbmVzCi1CdWcoRUZMKSBlZGl0aW5nL3VuZG8vdW5kby1pbmRlbnQu aHRtbCBbIEZhaWx1cmUgUGFzcyBdCi1CdWcoRUZMKSBlZGl0aW5nL3VuZG8vdW5kby1taXNzcGVs bGluZ3MuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi0KIHdlYmtpdC5vcmcvYi85NjY0MSBtZWRpYS92 aWRlby1zZWVrLXBhc3QtZW5kLXBsYXlpbmcuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiB3ZWJraXQu b3JnL2IvOTY2NDIgbG9hZGVyL2dvLWJhY2stdG8tZGlmZmVyZW50LXdpbmRvdy1zaXplLmh0bWwg WyBGYWlsdXJlIFBhc3MgXQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggYWY1MTg2Mi4uMjIwNDBjMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBN aWNoYcWCIFBha3XFgmEgdmVsIFJ1dGthICA8bS5wYWt1bGFAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF1bRFJUXUR1bXBSZW5kZXJUcmVlIG5lZWRzIHRvIHJlc2V0IGZvY3VzIHN0YXRlIHdo ZW4gdGVzdCBzdGFydHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NzA4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBmb2N1c2luZyBhIG1haW4gZnJhbWUgb24gc2V0dGluZ3MgcmVzZXQuCisgICAg ICAgIEFmdGVyIGVkaXRpbmcvdW5kby91bmRvLWlmcmFtZS1sb2NhdGlvbi1jaGFuZ2Ugd2FzIGV4 ZWN1dGVkIGEgZnJhbWUKKyAgICAgICAgd2FzIGxlZnQgaW4gdW5mb2N1c2VkIHN0YXRlLiBUaGlz IGNhdXNlZCBmbGFraW5lc3MgaW4gdHdvIHRlc3RzIHJlc3VsdHMuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJl bmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDEy LTA5LTIwICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgog CiAgICAgICAgIFtRdF0gQWRkIGV2ZW50U2VuZGVyLmdlc3R1cmVUYXAKZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCmluZGV4IDAzMGZkOWEu LjA5ZDdkNDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJU cmVlQ2hyb21lLmNwcApAQCAtMjkyLDYgKzI5Miw4IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJv bWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogCiAgICAgZXdrX2hpc3Rvcnlf Y2xlYXIoZXdrX3ZpZXdfaGlzdG9yeV9nZXQobWFpblZpZXcoKSkpOwogCisgICAgZXdrX2ZyYW1l X2ZlZWRfZm9jdXNfaW4obWFpbkZyYW1lKCkpOworCiAgICAgZXdrX2Nvb2tpZXNfY2xlYXIoKTsK ICAgICBld2tfY29va2llc19wb2xpY3lfc2V0KEVXS19DT09LSUVfSkFSX0FDQ0VQVF9OT19USElS RF9QQVJUWSk7CiAK