97070 2012-09-18 22:38:13 -0700 [BlackBerry] remove static_cast which will cause video crash 2012-09-19 07:11:28 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jonathan.dong.webkit jonathan.dong.webkit charles.wei mfeil mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 723277 0 jonathan.dong.webkit 2012-09-18 22:38:13 -0700 RIM PR: 187543 In some cases (e.g. test case media/video-size.html) we haven't had a chance to call load() to create a real media player before we use it, so the MediaPlayer->m_private is still pointing to a NullMediaPlayerPrivate, but we use static_cast to cast it to a (BlackBerry)MediaPlayerPrivate. This is a layering violation and will cause a runtime crash. 723292 1 164665 jonathan.dong.webkit 2012-09-18 22:56:55 -0700 Created attachment 164665 Patch 723545 2 164665 webkit.review.bot 2012-09-19 07:11:25 -0700 Comment on attachment 164665 Patch Clearing flags on attachment: 164665 Committed r129001: <http://trac.webkit.org/changeset/129001> 723546 3 webkit.review.bot 2012-09-19 07:11:28 -0700 All reviewed patches have been landed. Closing bug. 164665 2012-09-18 22:56:55 -0700 2012-09-19 07:11:25 -0700 Patch bug-97070-20120919135620.patch text/plain 2646 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q2ZjgzNTQ4ZTMwYjYw Yjg3NTY3M2UyNzA5MzVlOGJlN2I4OTg1OC4uMDhlNzE4MDE0OTJiYzVhOTM2NDhhNDRiMGQwNTc2 M2NjODM0YzE5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA5LTE4ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIHJlbW92ZSBzdGF0aWNfY2FzdCB3aGljaCB3aWxsIGNhdXNlIHZpZGVvIGNy YXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzA3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZWQgdGhlIHN0YXRpY19jYXN0IHRvIGF2b2lkIGxheWVyaW5nIHZpb2xhdGlvbiB3aGljaAorICAg ICAgICB3aWxsIGNhdXNlIGEgcnVudGltZSBjcmFzaC4KKyAgICAgICAgV2Ugd29uJ3QgY3JlYXRl IGEgcmVhbCBNZWRpYVBsYXllclByaXZhdGUgb2JqZWN0IGJlZm9yZSB3ZSBjYWxsCisgICAgICAg IE1lZGlhUGxheWVyOjpsb2FkKCksIHNvIGlmIHdlIHVzZSBwbGF5ZXIoKS0+aW1wbGVtZW50YXRp b24oKQorICAgICAgICBiZWZvcmUgY2FsbGluZyBsb2FkKCkgaW4gc29tZSBjYXNlcywgaXQgcG9p bnRzIHRvIGEKKyAgICAgICAgTnVsbE1lZGlhUGxheWVyUHJpdmF0ZSBvYmplY3QuIEhlcmUgd2Ug c2hvdWxkIG5vdCB1c2Ugc3RhdGljX2Nhc3QsCisgICAgICAgIGluc3RlYWQgd2Ugc2hvdWxkIHVz ZSBIVE1MTWVkaWFFbGVtZW50OjpwZXJjZW50TG9hZGVkKCkgdG8KKyAgICAgICAgYXZvaWQgbGF5 ZXJpbmcgdmlvbGF0aW9uIGFzIHdlIGRvbid0IGhhdmUgdGhlIGJ1ZmZlcmluZyBidWcgd2hpY2gK KyAgICAgICAgdGhlIGRlbGV0ZWQgY29tbWVudCByZWZlcnMgdG8uCisKKyAgICAgICAgSW50ZXJu YWxseSByZXZpZXdlZCBieSBNYXggRmVpbC4KKworICAgICAgICBUZXN0IGNhc2U6IG1lZGlhL3Zp ZGVvLXNpemUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVt ZUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVCbGFja0JlcnJ5 OjpwYWludE1lZGlhU2xpZGVyVHJhY2spOgorCiAyMDEyLTA5LTE4ICBLZW5pY2hpIElzaGliYXNo aSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIERvbid0IHRyZWF0 IHRhYiBhcyBzcGFjZXMgZm9yIHdvcmQtZW5kIGluIEhhcmZCdXp6U2hhcGVyCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJy eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxh Y2tCZXJyeS5jcHAKaW5kZXggMDY4OGRhODQ3ZGYwOTg3YzYyMTc1MWVkODk2ODAxYTM5ODdjZGJl Zi4uYjY3M2FmOTA0NjBiYzlkMTY2MTc5ODBjOWZlNGY0M2JiNWQ5OTc3OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnku Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVC bGFja0JlcnJ5LmNwcApAQCAtOTIxLDEyICs5MjEsNyBAQCBib29sIFJlbmRlclRoZW1lQmxhY2tC ZXJyeTo6cGFpbnRNZWRpYVNsaWRlclRyYWNrKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQ YQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBmbG9hdCBmdWxsU2NyZWVuTXVsdGlwbGll ciA9IGRldGVybWluZUZ1bGxTY3JlZW5NdWx0aXBsaWVyKG1lZGlhRWxlbWVudCk7Ci0gICAgZmxv YXQgbG9hZGVkID0gMDsKLSAgICAvLyBGSVhNRTogcmVwbGFjZSBsb2FkZWQgd2l0aCBjb21tZW50 ZWQgb3V0IG9uZSB3aGVuIGJ1ZmZlciBidWcgaXMgZml4ZWQgKHNlZSBjb21tZW50IGluCi0gICAg Ly8gTWVkaWFQbGF5ZXJQcml2YXRlTU1yZW5kZXJlcjo6cGVyY2VudExvYWRlZCkuCi0gICAgLy8g bG9hZGVkID0gbWVkaWFFbGVtZW50LT5wZXJjZW50TG9hZGVkKCk7Ci0gICAgaWYgKG1lZGlhRWxl bWVudC0+cGxheWVyKCkgJiYgbWVkaWFFbGVtZW50LT5wbGF5ZXIoKS0+aW1wbGVtZW50YXRpb24o KSkKLSAgICAgICAgbG9hZGVkID0gc3RhdGljX2Nhc3Q8TWVkaWFQbGF5ZXJQcml2YXRlICo+KG1l ZGlhRWxlbWVudC0+cGxheWVyKCktPmltcGxlbWVudGF0aW9uKCkpLT5wZXJjZW50TG9hZGVkKCk7 CisgICAgZmxvYXQgbG9hZGVkID0gbWVkaWFFbGVtZW50LT5wZXJjZW50TG9hZGVkKCk7CiAgICAg ZmxvYXQgcG9zaXRpb24gPSBtZWRpYUVsZW1lbnQtPmR1cmF0aW9uKCkgPiAwID8gKG1lZGlhRWxl bWVudC0+Y3VycmVudFRpbWUoKSAvIG1lZGlhRWxlbWVudC0+ZHVyYXRpb24oKSkgOiAwOwogCiAg ICAgaW50IHggPSBjZWlsKHJlY3QueCgpICsgMiAqIGZ1bGxTY3JlZW5NdWx0aXBsaWVyIC0gZnVs bFNjcmVlbk11bHRpcGxpZXIgLyAyKTsK