97068 2012-09-18 21:46:21 -0700 [Chromium] Don't treat tab as spaces for word-end in HarfBuzzShaper 2012-09-19 10:12:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tony webkit.review.bot yutak oldest_to_newest 723255 0 bashi 2012-09-18 21:46:21 -0700 On harfbuzz-ng enabled chromium linux, fast/text/wide-zero-width-space.html is failing. We can fix it by not treating tab as spaces, like https://bugs.webkit.org/show_bug.cgi?id=94010. 723258 1 164657 bashi 2012-09-18 21:52:27 -0700 Created attachment 164657 Patch 723260 2 bashi 2012-09-18 22:00:33 -0700 Yuta-san, Could you rubber-stamp? 723262 3 164657 yutak 2012-09-18 22:08:54 -0700 Comment on attachment 164657 Patch Looks legit. 723265 4 164657 bashi 2012-09-18 22:11:25 -0700 Comment on attachment 164657 Patch Thanks! 723269 5 164657 webkit.review.bot 2012-09-18 22:25:53 -0700 Comment on attachment 164657 Patch Clearing flags on attachment: 164657 Committed r128965: <http://trac.webkit.org/changeset/128965> 723270 6 webkit.review.bot 2012-09-18 22:25:56 -0700 All reviewed patches have been landed. Closing bug. 723628 7 164657 tony 2012-09-19 10:12:33 -0700 Comment on attachment 164657 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164657&action=review > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:158 > + // Don't normalize tabs as they are not treated as spaces for word-end Nit: Please end comments with a period. 164657 2012-09-18 21:52:27 -0700 2012-09-19 10:12:33 -0700 Patch bug-97068-20120919135153.patch text/plain 1782 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc4MTNjMGM2M2M2NDM3 OGZmNjA3NzY0ZjcxNjM3MjY2Y2RjMmVlZC4uNTY0MWNiMTcwNTNjMGY3ZWU2Y2MzNGNiN2VkODBk MWI3YjE1MGExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTE4ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1d IERvbid0IHRyZWF0IHRhYiBhcyBzcGFjZXMgZm9yIHdvcmQtZW5kIGluIEhhcmZCdXp6U2hhcGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzA2OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gZmFzdC90ZXh0L3dpZGUtemVyby13aWR0aC1zcGFjZS5odG1sIHNob3VsZCBjb3ZlciB0 aGlzIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hh cmZCdXp6U2hhcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om5vcm1hbGl6ZUNoYXJhY3RlcnMp OiBEb24ndCB0cmVhdCB0YWIgYXMgc3BhY2UuCisKIDIwMTItMDktMTggIEpvaG4gTWVsbG9yICA8 am9obm1lQGNocm9taXVtLm9yZz4KIAogICAgICAgICBUZXh0IEF1dG9zaXppbmc6IElnbm9yZSBj b25zdHJhaW5lZCBoZWlnaHRzIGluIGNlcnRhaW4gY2lyY3Vtc3RhbmNlcy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hh cGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hh cmZCdXp6U2hhcGVyLmNwcAppbmRleCA0ZTMyN2ZjYWE2ZjBhMmI0ODc3OGNkMjY0NjMzNmMyMGNm NzdjZmNlLi4wZmFjMzJjOGIyYTQ5Nzc0MGEwODcxMWUzZmFkOGVkYmQ2ZDM2ZThlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6 elNoYXBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1 enovbmcvSGFyZkJ1enpTaGFwZXIuY3BwCkBAIC0xNTUsNyArMTU1LDggQEAgc3RhdGljIHZvaWQg bm9ybWFsaXplQ2hhcmFjdGVycyhjb25zdCBVQ2hhciogc291cmNlLCBVQ2hhciogZGVzdGluYXRp b24sIGludCBsZW4KICAgICAgICAgVUNoYXIzMiBjaGFyYWN0ZXI7CiAgICAgICAgIGludCBuZXh0 UG9zaXRpb24gPSBwb3NpdGlvbjsKICAgICAgICAgVTE2X05FWFQoc291cmNlLCBuZXh0UG9zaXRp b24sIGxlbmd0aCwgY2hhcmFjdGVyKTsKLSAgICAgICAgaWYgKEZvbnQ6OnRyZWF0QXNTcGFjZShj aGFyYWN0ZXIpKQorICAgICAgICAvLyBEb24ndCBub3JtYWxpemUgdGFicyBhcyB0aGV5IGFyZSBu b3QgdHJlYXRlZCBhcyBzcGFjZXMgZm9yIHdvcmQtZW5kCisgICAgICAgIGlmIChGb250Ojp0cmVh dEFzU3BhY2UoY2hhcmFjdGVyKSAmJiBjaGFyYWN0ZXIgIT0gJ1x0JykKICAgICAgICAgICAgIGNo YXJhY3RlciA9ICcgJzsKICAgICAgICAgZWxzZSBpZiAoRm9udDo6dHJlYXRBc1plcm9XaWR0aFNw YWNlSW5Db21wbGV4U2NyaXB0KGNoYXJhY3RlcikpCiAgICAgICAgICAgICBjaGFyYWN0ZXIgPSB6 ZXJvV2lkdGhTcGFjZTsK