97061 2012-09-18 19:37:23 -0700 [EFL][WK2] Add log macros for EINA_LOG_DOM_XXX series 2012-09-18 20:33:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song gyuyoung.kim kangil.han lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 723197 0 jinwoo7.song 2012-09-18 19:37:23 -0700 EFL Webkit2 is using the EINA_LOG_DOM_XXX series in several places to log a message on the specified domain and format. This patch adds log macros to simplify these logging codes. 723200 1 164644 jinwoo7.song 2012-09-18 19:39:53 -0700 Created attachment 164644 patch 723203 2 164646 jinwoo7.song 2012-09-18 19:45:45 -0700 Created attachment 164646 patch include ewk_private.h in the ewk_main.cpp 723211 3 164646 gyuyoung.kim 2012-09-18 19:56:21 -0700 Comment on attachment 164646 patch Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ? 723212 4 kangil.han 2012-09-18 20:02:23 -0700 Looks neat. Thanks! 723220 5 jinwoo7.song 2012-09-18 20:23:26 -0700 (In reply to comment #3) > (From update of attachment 164646 [details]) > Looks good to me. Could you notify this macro usage to webkit-efl mailing list after landing this patch ? Sure, I'll do it. 723230 6 164646 webkit.review.bot 2012-09-18 20:33:13 -0700 Comment on attachment 164646 patch Clearing flags on attachment: 164646 Committed r128962: <http://trac.webkit.org/changeset/128962> 723231 7 webkit.review.bot 2012-09-18 20:33:17 -0700 All reviewed patches have been landed. Closing bug. 164644 2012-09-18 19:39:53 -0700 2012-09-18 19:45:45 -0700 patch eina_log.patch text/plain 3392 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ZjVlNWNiLi44YmJlYTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDktMTggIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gQWRkIGxvZyBtYWNyb3MgZm9yIEVJTkFfTE9HX0RPTV9YWFgg c2VyaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NzA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVG TCBXZWJraXQyIGlzIHVzaW5nIHRoZSBFSU5BX0xPR19ET01fWFhYIHNlcmllcyBpbiBzZXZlcmFs IHBsYWNlcyB0byBsb2cgYSBtZXNzYWdlIG9uIHRoZSBzcGVjaWZpZWQgZG9tYWluIGFuZCBmb3Jt YXQuCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBsb2cgbWFjcm9zIHRvIHNpbXBsaWZ5IHRoZXNl IGxvZ2dpbmcgY29kZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5j cHA6CisgICAgICAgIChld2tfaW5pdCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChld2tfdmlld193ZWJwcm9jZXNzX2NyYXNoZWQpOgorCiAyMDEyLTA5LTE3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGV4cGVyaW1lbnRhbCBjb2Rl IHRvIGVudGVyIGEgc2FuZGJveCBmb3IgYSBwbHVnLWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCmluZGV4IDBkMDE5MjQuLjdkMDFlODUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAKQEAgLTUzLDI0 ICs1MywyNCBAQCBpbnQgZXdrX2luaXQodm9pZCkKICAgICB9CiAKICAgICBpZiAoIWV2YXNfaW5p dCgpKSB7Ci0gICAgICAgIEVJTkFfTE9HX0RPTV9DUklUKF9ld2tfbG9nX2RvbSwgImNvdWxkIG5v dCBpbml0IGV2YXMuIik7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgaW5pdCBldmFzLiIp OwogICAgICAgICBnb3RvIGVycm9yX2V2YXM7CiAgICAgfQogCiAgICAgaWYgKCFlY29yZV9pbml0 KCkpIHsKLSAgICAgICAgRUlOQV9MT0dfRE9NX0NSSVQoX2V3a19sb2dfZG9tLCAiY291bGQgbm90 IGluaXQgZWNvcmUuIik7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3QgaW5pdCBlY29yZS4i KTsKICAgICAgICAgZ290byBlcnJvcl9lY29yZTsKICAgICB9CiAKICAgICBpZiAoIWVjb3JlX2V2 YXNfaW5pdCgpKSB7Ci0gICAgICAgIEVJTkFfTE9HX0RPTV9DUklUKF9ld2tfbG9nX2RvbSwgImNv dWxkIG5vdCBpbml0IGVjb3JlX2V2YXMuIik7CisgICAgICAgIENSSVRJQ0FMKCJjb3VsZCBub3Qg aW5pdCBlY29yZV9ldmFzLiIpOwogICAgICAgICBnb3RvIGVycm9yX2Vjb3JlX2V2YXM7CiAgICAg fQogCiAgICAgZ190eXBlX2luaXQoKTsKIAogICAgIGlmICghZWNvcmVfbWFpbl9sb29wX2dsaWJf aW50ZWdyYXRlKCkpIHsKLSAgICAgICAgRUlOQV9MT0dfRE9NX1dBUk4oX2V3a19sb2dfZG9tLCAi RWNvcmUgd2FzIG5vdCBjb21waWxlZCB3aXRoIEdMaWIgc3VwcG9ydCwgc29tZSBwbHVnaW5zIHdp bGwgbm90ICIKKyAgICAgICAgV1JOKCJFY29yZSB3YXMgbm90IGNvbXBpbGVkIHdpdGggR0xpYiBz dXBwb3J0LCBzb21lIHBsdWdpbnMgd2lsbCBub3QgIgogICAgICAgICAgICAgIndvcmsgKGllOiBB ZG9iZSBGbGFzaCkiKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfcHJpdmF0ZS5oCmluZGV4IDk2NjExZTIuLmJkZWVhYWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ByaXZhdGUuaApAQCAtMzMsNCArMzMsMTAg QEAKIAogZXh0ZXJuIGludCBfZXdrX2xvZ19kb207CiAKKyNkZWZpbmUgQ1JJVElDQUwoLi4uKSBF SU5BX0xPR19ET01fQ1JJVChfZXdrX2xvZ19kb20sIF9fVkFfQVJHU19fKQorI2RlZmluZSBFUlIo Li4uKSBFSU5BX0xPR19ET01fRVJSKF9ld2tfbG9nX2RvbSwgX19WQV9BUkdTX18pCisjZGVmaW5l IFdSTiguLi4pIEVJTkFfTE9HX0RPTV9XQVJOKF9ld2tfbG9nX2RvbSwgX19WQV9BUkdTX18pCisj ZGVmaW5lIElORiguLi4pIEVJTkFfTE9HX0RPTV9JTkZPKF9ld2tfbG9nX2RvbSwgX19WQV9BUkdT X18pCisjZGVmaW5lIERCRyguLi4pIEVJTkFfTE9HX0RPTV9EQkcoX2V3a19sb2dfZG9tLCBfX1ZB X0FSR1NfXykKKwogI2VuZGlmIC8vIGV3a19wcml2YXRlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCA3MjdlYWJhLi5jNjVlMWU2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC0xNjQw LDcgKzE2NDAsNyBAQCB2b2lkIGV3a192aWV3X3dlYnByb2Nlc3NfY3Jhc2hlZChFdmFzX09iamVj dCogZXdrVmlldykKIAogICAgIGlmICghaGFuZGxlZCkgewogICAgICAgICBDU3RyaW5nIHVybCA9 IHByaXYtPnBhZ2VQcm94eS0+dXJsQXRQcm9jZXNzRXhpdCgpLnV0ZjgoKTsKLSAgICAgICAgRUlO QV9MT0dfRE9NX1dBUk4oX2V3a19sb2dfZG9tLCAiV0FSTklORzogVGhlIHdlYiBwcm9jZXNzIGV4 cGVyaWVuY2VkIGEgY3Jhc2ggb24gJyVzJy5cbiIsIHVybC5kYXRhKCkpOworICAgICAgICBXUk4o IldBUk5JTkc6IFRoZSB3ZWIgcHJvY2VzcyBleHBlcmllbmNlZCBhIGNyYXNoIG9uICclcycuXG4i LCB1cmwuZGF0YSgpKTsKIAogICAgICAgICAvLyBEaXNwbGF5IGFuIGVycm9yIHBhZ2UKICAgICAg ICAgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZChld2tWaWV3LCAiVGhlIHdlYiBwcm9jZXNzIGhh cyBjcmFzaGVkLiIsIDAsIHVybC5kYXRhKCkpOwo= 164646 2012-09-18 19:45:45 -0700 2012-09-18 20:33:13 -0700 patch eina_log.patch text/plain 3546 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ZjVlNWNiLi44YmJlYTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDktMTggIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gQWRkIGxvZyBtYWNyb3MgZm9yIEVJTkFfTE9HX0RPTV9YWFgg c2VyaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NzA2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVG TCBXZWJraXQyIGlzIHVzaW5nIHRoZSBFSU5BX0xPR19ET01fWFhYIHNlcmllcyBpbiBzZXZlcmFs IHBsYWNlcyB0byBsb2cgYSBtZXNzYWdlIG9uIHRoZSBzcGVjaWZpZWQgZG9tYWluIGFuZCBmb3Jt YXQuCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBsb2cgbWFjcm9zIHRvIHNpbXBsaWZ5IHRoZXNl IGxvZ2dpbmcgY29kZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5j cHA6CisgICAgICAgIChld2tfaW5pdCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChld2tfdmlld193ZWJwcm9jZXNzX2NyYXNoZWQpOgorCiAyMDEyLTA5LTE3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGV4cGVyaW1lbnRhbCBjb2Rl IHRvIGVudGVyIGEgc2FuZGJveCBmb3IgYSBwbHVnLWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCmluZGV4IDBkMDE5MjQuLmY3ZGFmZTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAKQEAgLTIyLDYg KzIyLDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJld2tfbWFpbi5oIgogCisj aW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlIDxFY29yZS5oPgogI2luY2x1ZGUgPEVj b3JlX0V2YXMuaD4KICNpbmNsdWRlIDxFZGplLmg+CkBAIC01MywyNCArNTQsMjQgQEAgaW50IGV3 a19pbml0KHZvaWQpCiAgICAgfQogCiAgICAgaWYgKCFldmFzX2luaXQoKSkgewotICAgICAgICBF SU5BX0xPR19ET01fQ1JJVChfZXdrX2xvZ19kb20sICJjb3VsZCBub3QgaW5pdCBldmFzLiIpOwor ICAgICAgICBDUklUSUNBTCgiY291bGQgbm90IGluaXQgZXZhcy4iKTsKICAgICAgICAgZ290byBl cnJvcl9ldmFzOwogICAgIH0KIAogICAgIGlmICghZWNvcmVfaW5pdCgpKSB7Ci0gICAgICAgIEVJ TkFfTE9HX0RPTV9DUklUKF9ld2tfbG9nX2RvbSwgImNvdWxkIG5vdCBpbml0IGVjb3JlLiIpOwor ICAgICAgICBDUklUSUNBTCgiY291bGQgbm90IGluaXQgZWNvcmUuIik7CiAgICAgICAgIGdvdG8g ZXJyb3JfZWNvcmU7CiAgICAgfQogCiAgICAgaWYgKCFlY29yZV9ldmFzX2luaXQoKSkgewotICAg ICAgICBFSU5BX0xPR19ET01fQ1JJVChfZXdrX2xvZ19kb20sICJjb3VsZCBub3QgaW5pdCBlY29y ZV9ldmFzLiIpOworICAgICAgICBDUklUSUNBTCgiY291bGQgbm90IGluaXQgZWNvcmVfZXZhcy4i KTsKICAgICAgICAgZ290byBlcnJvcl9lY29yZV9ldmFzOwogICAgIH0KIAogICAgIGdfdHlwZV9p bml0KCk7CiAKICAgICBpZiAoIWVjb3JlX21haW5fbG9vcF9nbGliX2ludGVncmF0ZSgpKSB7Ci0g ICAgICAgIEVJTkFfTE9HX0RPTV9XQVJOKF9ld2tfbG9nX2RvbSwgIkVjb3JlIHdhcyBub3QgY29t cGlsZWQgd2l0aCBHTGliIHN1cHBvcnQsIHNvbWUgcGx1Z2lucyB3aWxsIG5vdCAiCisgICAgICAg IFdSTigiRWNvcmUgd2FzIG5vdCBjb21waWxlZCB3aXRoIEdMaWIgc3VwcG9ydCwgc29tZSBwbHVn aW5zIHdpbGwgbm90ICIKICAgICAgICAgICAgICJ3b3JrIChpZTogQWRvYmUgRmxhc2gpIik7CiAg ICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf cHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ByaXZhdGUu aAppbmRleCA5NjYxMWUyLi5iZGVlYWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19wcml2YXRlLmgKQEAgLTMzLDQgKzMzLDEwIEBACiAKIGV4dGVybiBpbnQg X2V3a19sb2dfZG9tOwogCisjZGVmaW5lIENSSVRJQ0FMKC4uLikgRUlOQV9MT0dfRE9NX0NSSVQo X2V3a19sb2dfZG9tLCBfX1ZBX0FSR1NfXykKKyNkZWZpbmUgRVJSKC4uLikgRUlOQV9MT0dfRE9N X0VSUihfZXdrX2xvZ19kb20sIF9fVkFfQVJHU19fKQorI2RlZmluZSBXUk4oLi4uKSBFSU5BX0xP R19ET01fV0FSTihfZXdrX2xvZ19kb20sIF9fVkFfQVJHU19fKQorI2RlZmluZSBJTkYoLi4uKSBF SU5BX0xPR19ET01fSU5GTyhfZXdrX2xvZ19kb20sIF9fVkFfQVJHU19fKQorI2RlZmluZSBEQkco Li4uKSBFSU5BX0xPR19ET01fREJHKF9ld2tfbG9nX2RvbSwgX19WQV9BUkdTX18pCisKICNlbmRp ZiAvLyBld2tfcHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlldy5jcHAKaW5kZXggNzI3ZWFiYS4uYzY1ZTFlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAtMTY0MCw3ICsxNjQwLDcgQEAgdm9p ZCBld2tfdmlld193ZWJwcm9jZXNzX2NyYXNoZWQoRXZhc19PYmplY3QqIGV3a1ZpZXcpCiAKICAg ICBpZiAoIWhhbmRsZWQpIHsKICAgICAgICAgQ1N0cmluZyB1cmwgPSBwcml2LT5wYWdlUHJveHkt PnVybEF0UHJvY2Vzc0V4aXQoKS51dGY4KCk7Ci0gICAgICAgIEVJTkFfTE9HX0RPTV9XQVJOKF9l d2tfbG9nX2RvbSwgIldBUk5JTkc6IFRoZSB3ZWIgcHJvY2VzcyBleHBlcmllbmNlZCBhIGNyYXNo IG9uICclcycuXG4iLCB1cmwuZGF0YSgpKTsKKyAgICAgICAgV1JOKCJXQVJOSU5HOiBUaGUgd2Vi IHByb2Nlc3MgZXhwZXJpZW5jZWQgYSBjcmFzaCBvbiAnJXMnLlxuIiwgdXJsLmRhdGEoKSk7CiAK ICAgICAgICAgLy8gRGlzcGxheSBhbiBlcnJvciBwYWdlCiAgICAgICAgIGV3a192aWV3X2h0bWxf c3RyaW5nX2xvYWQoZXdrVmlldywgIlRoZSB3ZWIgcHJvY2VzcyBoYXMgY3Jhc2hlZC4iLCAwLCB1 cmwuZGF0YSgpKTsK