97060 2012-09-18 19:28:54 -0700 [V8] Remove WorkerContextExecutionProxy::runScript() 2012-09-19 17:08:45 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97057 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 723193 0 haraken 2012-09-18 19:28:54 -0700 To kill WorkerContextExecutionProxy, we can remove WorkerContextExecutionProxy::runScript(). 723201 1 164645 haraken 2012-09-18 19:40:30 -0700 Created attachment 164645 Patch 723686 2 164645 abarth 2012-09-19 11:31:15 -0700 Comment on attachment 164645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review > Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274 > - if (script.IsEmpty()) > - return v8::Local<v8::Value>(); This check is missing from ScriptRunner::runCompiledScript. I guess its not needed? 723700 3 164645 webkit.review.bot 2012-09-19 11:51:56 -0700 Comment on attachment 164645 Patch Clearing flags on attachment: 164645 Committed r129026: <http://trac.webkit.org/changeset/129026> 723701 4 webkit.review.bot 2012-09-19 11:52:00 -0700 All reviewed patches have been landed. Closing bug. 723985 5 164645 haraken 2012-09-19 17:08:45 -0700 Comment on attachment 164645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164645&action=review >> Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:-274 >> - return v8::Local<v8::Value>(); > > This check is missing from ScriptRunner::runCompiledScript. I guess its not needed? It's not needed in ScriptRunner::runCompiledScript, but was needed in WorkerContextExecutionProxy::runScript (because line 267 can generate an empty script). 164645 2012-09-18 19:40:30 -0700 2012-09-19 17:08:45 -0700 Patch bug-97060-20120919113956.patch text/plain 6323 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMwMmI4MWQ1MWFjMjk2 YTg5M2Y3NjExNmE5OTNmZDhlNjY4MGEyYi4uNzYyNzJhZDNlZTE3ZGUzN2NhNzhiZGVjN2Y2NThi MDk0OGEyNGI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA5LTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBX b3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OnJ1blNjcmlwdCgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzA2MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtpbGwgV29ya2VyQ29udGV4dEV4ZWN1 dGlvblByb3h5LCB0aGlzIHBhdGNoIHJlbW92ZXMKKyAgICAgICAgV29ya2VyQ29udGV4dEV4ZWN1 dGlvblByb3h5OjpydW5TY3JpcHQoKSBieSByZXBsYWNpbmcgaXQKKyAgICAgICAgd2l0aCBTY3Jp cHRSdW5uZXI6OnJ1bkNvbXBpbGVkU2NyaXB0KCkuCisKKyAgICAgICAgRm9yIHRoZSByZXBsYWNl bWVudCwgdGhpcyBwYXRjaCBtb3ZlcyBUcnlDYXRjaCBsb2dpYyBpbgorICAgICAgICBydW5Db21w aWxlZFNjcmlwdCgpIHRvIHRoZSBjYWxsZXIgc2lkZS4gVGhlIHJlYXNvbiB3aHkKKyAgICAgICAg d2UgaGF2ZSB0byBhdm9pZCBuZXN0aW5nIFRyeUNhdGNoZXMgaXMgYSBWOCBidWc6CisgICAgICAg IGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC92OC9pc3N1ZXMvZGV0YWlsP2lkPTIxNjYKKworICAg ICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGlu Z3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250 cm9sbGVyOjpjb21waWxlQW5kUnVuU2NyaXB0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3Jp cHRSdW5uZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0UnVubmVyOjpydW5Db21waWxl ZFNjcmlwdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblBy b3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6 ZXZhbHVhdGUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eS5oOgorICAgICAgICAoV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5KToKKwogMjAxMi0w OS0xNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRXhwb3J0 IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzTGFuZ0F0dHJpYnV0ZUF3YXJlRm9ybUNvbnRyb2xV SUVuYWJsZWQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Njcmlw dENvbnRyb2xsZXIuY3BwCmluZGV4IGZiOWQ1NTdlOTJiNDY1MDk3ODM5MGMxMzFlMDgzOTI5OWEz MWRmNjMuLjQ4MDBhZGU5MTRlMjAyMThjZTliZjM4N2FiMWVkN2FmNTI5OTVmZTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC0yODEs NiArMjgxLDcgQEAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gU2NyaXB0Q29udHJvbGxlcjo6Y29tcGls ZUFuZFJ1blNjcmlwdChjb25zdCBTY3JpcHRTb3VyY2VDb2QKICAgICAgICAgLy8gS2VlcCBGcmFt ZSAoYW5kIHRoZXJlZm9yZSBTY3JpcHRDb250cm9sbGVyKSBhbGl2ZS4KICAgICAgICAgUmVmUHRy PEZyYW1lPiBwcm90ZWN0KG1fZnJhbWUpOwogICAgICAgICByZXN1bHQgPSBTY3JpcHRSdW5uZXI6 OnJ1bkNvbXBpbGVkU2NyaXB0KHNjcmlwdCwgbV9mcmFtZS0+ZG9jdW1lbnQoKSk7CisgICAgICAg IEFTU0VSVCghdHJ5Q2F0Y2guSGFzQ2F1Z2h0KCkgfHwgcmVzdWx0LklzRW1wdHkoKSk7CiAgICAg fQogCiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpkaWRFdmFsdWF0ZVNjcmlwdChjb29r aWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UnVubmVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFJ1bm5lci5jcHAKaW5kZXgg MDRmOGVhMzA0NzkyYmJiZWM0YWQwYTBmNTc3MzMxZTE0NzFkYzlmNS4uYjQ1M2JhYTBiNDVjYTNh ZmMyZjI0Nzk5MjNiZTIwNGEwM2U2MzIxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvU2NyaXB0UnVubmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHRSdW5uZXIuY3BwCkBAIC00Nyw4ICs0Nyw2IEBAIHY4OjpMb2NhbDx2ODo6VmFsdWU+ IFNjcmlwdFJ1bm5lcjo6cnVuQ29tcGlsZWRTY3JpcHQodjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBz Y3JpCiAKICAgICAvLyBSdW4gdGhlIHNjcmlwdCBhbmQga2VlcCB0cmFjayBvZiB0aGUgY3VycmVu dCByZWN1cnNpb24gZGVwdGguCiAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcmVzdWx0OwotICAg IHY4OjpUcnlDYXRjaCB0cnlDYXRjaDsKLSAgICB0cnlDYXRjaC5TZXRWZXJib3NlKHRydWUpOwog ICAgIHsKICAgICAgICAgVjhSZWN1cnNpb25TY29wZSByZWN1cnNpb25TY29wZShjb250ZXh0KTsK ICAgICAgICAgcmVzdWx0ID0gc2NyaXB0LT5SdW4oKTsKQEAgLTU3LDEyICs1NSw2IEBAIHY4OjpM b2NhbDx2ODo6VmFsdWU+IFNjcmlwdFJ1bm5lcjo6cnVuQ29tcGlsZWRTY3JpcHQodjg6OkhhbmRs ZTx2ODo6U2NyaXB0PiBzY3JpCiAgICAgaWYgKGhhbmRsZU91dE9mTWVtb3J5KCkpCiAgICAgICAg IEFTU0VSVChyZXN1bHQuSXNFbXB0eSgpKTsKIAotICAgIC8vIEhhbmRsZSBWOCBpbnRlcm5hbCBl cnJvciBzaXR1YXRpb24uCi0gICAgaWYgKHRyeUNhdGNoLkhhc0NhdWdodCgpKSB7Ci0gICAgICAg IEFTU0VSVChyZXN1bHQuSXNFbXB0eSgpKTsKLSAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6 VmFsdWU+KCk7Ci0gICAgfQotCiAgICAgaWYgKHJlc3VsdC5Jc0VtcHR5KCkpCiAgICAgICAgIHJl dHVybiB2ODo6TG9jYWw8djg6OlZhbHVlPigpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcAppbmRleCA2 NzZmYWVkMDY4MjYzOTJiNDM0YWVmNjA5YTZkNTgzMzg2ZDk3NjI4Li45NjExZDQ3ZjM3YTM5NDNk N2YwY2NjMjkwNzMyZGI5MDRjY2E1NjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHAKQEAgLTM4LDYg KzM4LDcgQEAKICNpbmNsdWRlICJEZWRpY2F0ZWRXb3JrZXJDb250ZXh0LmgiCiAjaW5jbHVkZSAi RXZlbnQuaCIKICNpbmNsdWRlICJTY3JpcHRDYWxsU3RhY2suaCIKKyNpbmNsdWRlICJTY3JpcHRS dW5uZXIuaCIKICNpbmNsdWRlICJTY3JpcHRTb3VyY2VDb2RlLmgiCiAjaW5jbHVkZSAiU2hhcmVk V29ya2VyLmgiCiAjaW5jbHVkZSAiU2hhcmVkV29ya2VyQ29udGV4dC5oIgpAQCAtMjIzLDcgKzIy NCw3IEBAIFNjcmlwdFZhbHVlIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6ZXZhbHVhdGUo Y29uc3QgU3RyaW5nJiBzY3JpcHQsIGNvbnN0IFN0CiAKICAgICB2ODo6TG9jYWw8djg6OlN0cmlu Zz4gc2NyaXB0U3RyaW5nID0gdjhFeHRlcm5hbFN0cmluZyhzY3JpcHQpOwogICAgIHY4OjpIYW5k bGU8djg6OlNjcmlwdD4gY29tcGlsZWRTY3JpcHQgPSBTY3JpcHRTb3VyY2VDb2RlOjpjb21waWxl U2NyaXB0KHNjcmlwdFN0cmluZywgZmlsZU5hbWUsIHNjcmlwdFN0YXJ0UG9zaXRpb24pOwotICAg IHY4OjpMb2NhbDx2ODo6VmFsdWU+IHJlc3VsdCA9IHJ1blNjcmlwdChjb21waWxlZFNjcmlwdCk7 CisgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcmVzdWx0ID0gU2NyaXB0UnVubmVyOjpydW5Db21w aWxlZFNjcmlwdChjb21waWxlZFNjcmlwdCwgbV93b3JrZXJDb250ZXh0KTsKIAogICAgIGlmICgh ZXhjZXB0aW9uQ2F0Y2hlci5DYW5Db250aW51ZSgpKSB7CiAgICAgICAgIG1fd29ya2VyQ29udGV4 dC0+c2NyaXB0KCktPmZvcmJpZEV4ZWN1dGlvbigpOwpAQCAtMjU2LDM3ICsyNTcsNiBAQCB2b2lk IFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6c2V0RXZhbEFsbG93ZWQoYm9vbCBlbmFibGUp CiAgICAgbV9kaXNhYmxlRXZhbFBlbmRpbmcgPSAhZW5hYmxlOwogfQogCi12ODo6TG9jYWw8djg6 OlZhbHVlPiBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OnJ1blNjcmlwdCh2ODo6SGFuZGxl PHY4OjpTY3JpcHQ+IHNjcmlwdCkKLXsKLSAgICBpZiAoc2NyaXB0LklzRW1wdHkoKSkKLSAgICAg ICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6VmFsdWU+KCk7Ci0KLSAgICAvLyBDb21wdXRlIHRoZSBz b3VyY2Ugc3RyaW5nIGFuZCBwcmV2ZW50IGFnYWluc3QgaW5maW5pdGUgcmVjdXJzaW9uLgotICAg IGlmIChWOFJlY3Vyc2lvblNjb3BlOjpyZWN1cnNpb25MZXZlbCgpID49IGtNYXhSZWN1cnNpb25E ZXB0aCkgewotICAgICAgICB2ODo6TG9jYWw8djg6OlN0cmluZz4gY29kZSA9IHY4RXh0ZXJuYWxT dHJpbmcoInRocm93IFJhbmdlRXJyb3IoJ1JlY3Vyc2lvbiB0b28gZGVlcCcpIik7Ci0gICAgICAg IHNjcmlwdCA9IFNjcmlwdFNvdXJjZUNvZGU6OmNvbXBpbGVTY3JpcHQoY29kZSwgIiIsIFRleHRQ b3NpdGlvbjo6bWluaW11bVBvc2l0aW9uKCkpOwotICAgIH0KLQotICAgIGlmIChoYW5kbGVPdXRP Zk1lbW9yeSgpKQotICAgICAgICBBU1NFUlQoc2NyaXB0LklzRW1wdHkoKSk7Ci0KLSAgICBpZiAo c2NyaXB0LklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHY4OjpMb2NhbDx2ODo6VmFsdWU+KCk7 Ci0KLSAgICAvLyBSdW4gdGhlIHNjcmlwdCBhbmQga2VlcCB0cmFjayBvZiB0aGUgY3VycmVudCBy ZWN1cnNpb24gZGVwdGguCi0gICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gcmVzdWx0OwotICAgIHsK LSAgICAgICAgVjhSZWN1cnNpb25TY29wZSByZWN1cnNpb25TY29wZShtX3dvcmtlckNvbnRleHQp OwotICAgICAgICByZXN1bHQgPSBzY3JpcHQtPlJ1bigpOwotICAgIH0KLQotICAgIC8vIEhhbmRs ZSBWOCBpbnRlcm5hbCBlcnJvciBzaXR1YXRpb24gKE91dC1vZi1tZW1vcnkpLgotICAgIGlmIChy ZXN1bHQuSXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpWYWx1ZT4oKTsK LQotICAgIHJldHVybiByZXN1bHQ7Ci19Ci0KIHZvaWQgV29ya2VyQ29udGV4dEV4ZWN1dGlvblBy b3h5Ojp0cmFja0V2ZW50KEV2ZW50KiBldmVudCkKIHsKICAgICBtX2V2ZW50cy5hcHBlbmQoZXZl bnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4 dEV4ZWN1dGlvblByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250 ZXh0RXhlY3V0aW9uUHJveHkuaAppbmRleCA4MTI4YWI4N2FlNjY1YTRlZDZiMGY1ZWQxZTdlOGYz NTgyMzNiMDVjLi41Y2UzZjJjYTRmODllNTAxYTk5YTYyNzYzZWU2YzM4ZjVlYWE5MTVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9u UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhl Y3V0aW9uUHJveHkuaApAQCAtODIsOSArODIsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIGJvb2wgaW5pdGlhbGl6ZUlmTmVlZGVkKCk7CiAgICAgICAgIHZvaWQgZGlzcG9zZSgpOwog Ci0gICAgICAgIC8vIFJ1biBhbiBhbHJlYWR5IGNvbXBpbGVkIHNjcmlwdC4KLSAgICAgICAgdjg6 OkxvY2FsPHY4OjpWYWx1ZT4gcnVuU2NyaXB0KHY4OjpIYW5kbGU8djg6OlNjcmlwdD4pOwotCiAg ICAgICAgIHN0YXRpYyBib29sIGZvcmdldFY4RXZlbnRPYmplY3QoRXZlbnQqKTsKIAogICAgICAg ICBzdGF0aWMgY29uc3QgaW50IGtXb3JrZXJNYXhTdGFja1NpemUgPSA1MDAgKiAxMDI0Owo=