97048 2012-09-18 15:01:25 -0700 Check settings before registering AVFoundation media engine. 2012-09-18 21:21:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 723073 0 eric.carlson 2012-09-18 15:01:25 -0700 r122676 mistakenly enabled the AVFoundation media engine without regard to the preference. 723082 1 164626 eric.carlson 2012-09-18 15:16:07 -0700 Created attachment 164626 Proposed patch 723083 2 eric.carlson 2012-09-18 15:17:05 -0700 <rdar://problem/12313594> 723086 3 164628 eric.carlson 2012-09-18 15:19:54 -0700 Created attachment 164628 Patch 723246 4 164628 webkit.review.bot 2012-09-18 21:21:28 -0700 Comment on attachment 164628 Patch Clearing flags on attachment: 164628 Committed r128964: <http://trac.webkit.org/changeset/128964> 723247 5 webkit.review.bot 2012-09-18 21:21:31 -0700 All reviewed patches have been landed. Closing bug. 164626 2012-09-18 15:16:07 -0700 2012-09-18 15:19:54 -0700 Proposed patch check_preferences_patch_1.txt text/plain 1365 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODkzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHNldHRpbmdz IGJlZm9yZSByZWdpc3RlcmluZyBBVkZvdW5kYXRpb24gbWVkaWEgZW5naW5lLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcwNDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIGJ1ZyBpbnRyb2R1 Y2VkIGluIHIxMjI2NzYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXll ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbnN0YWxsZWRNZWRpYUVuZ2luZXMpOiBVbmNvbW1l bnQgdGhlIGNhbGwgdG8gY2hlY2sgQVZGb3VuZGF0aW9uIHNldHRpbmdzLgorCiAyMDEyLTA5LTE4 ICBKb2huIE1lbGxvciAgPGpvaG5tZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVGV4dCBBdXRv c2l6aW5nOiBJZ25vcmUgY29uc3RyYWluZWQgaGVpZ2h0cyBpbiBjZXJ0YWluIGNpcmN1bXN0YW5j ZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQ bGF5ZXIuY3BwCShyZXZpc2lvbiAxMjg5MzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMCw3ICsyMTAsNyBA QCBzdGF0aWMgVmVjdG9yPE1lZGlhUGxheWVyRmFjdG9yeSo+JiBpbnN0CiAgICAgICAgIGVuZ2lu ZXNRdWVyaWVkID0gdHJ1ZTsKIAogI2lmIFVTRShBVkZPVU5EQVRJT04pCi0gICAgICAgIGlmICgx IC8qIEBAU2V0dGluZ3M6OmlzQVZGb3VuZGF0aW9uRW5hYmxlZCgpIEBAICovKSB7CisgICAgICAg IGlmIChTZXR0aW5nczo6aXNBVkZvdW5kYXRpb25FbmFibGVkKCkpIHsKICNpZiBQTEFURk9STShN QUMpCiAgICAgICAgICAgICBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpyZWdp c3Rlck1lZGlhRW5naW5lKGFkZE1lZGlhRW5naW5lKTsKICNlbGlmIFBMQVRGT1JNKFdJTikK 164628 2012-09-18 15:19:54 -0700 2012-09-18 21:21:28 -0700 Patch check_preferences_patch_1.txt text/plain 1400 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODkzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIHNldHRpbmdz IGJlZm9yZSByZWdpc3RlcmluZyBBVkZvdW5kYXRpb24gbWVkaWEgZW5naW5lLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcwNDgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzEyMzEzNTk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB0aGUgYnVnIGludHJvZHVjZWQgaW4gcjEyMjY3Ni4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Omluc3RhbGxlZE1lZGlhRW5naW5lcyk6IFVuY29tbWVudCB0aGUgY2FsbCB0byBjaGVjayBB VkZvdW5kYXRpb24gc2V0dGluZ3MuCisKIDIwMTItMDktMTggIEpvaG4gTWVsbG9yICA8am9obm1l QGNocm9taXVtLm9yZz4KIAogICAgICAgICBUZXh0IEF1dG9zaXppbmc6IElnbm9yZSBjb25zdHJh aW5lZCBoZWlnaHRzIGluIGNlcnRhaW4gY2lyY3Vtc3RhbmNlcy4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAJKHJldmlzaW9uIDEy ODkzNCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjEwLDcgKzIxMCw3IEBAIHN0YXRpYyBWZWN0b3I8TWVkaWFQ bGF5ZXJGYWN0b3J5Kj4mIGluc3QKICAgICAgICAgZW5naW5lc1F1ZXJpZWQgPSB0cnVlOwogCiAj aWYgVVNFKEFWRk9VTkRBVElPTikKLSAgICAgICAgaWYgKDEgLyogQEBTZXR0aW5nczo6aXNBVkZv dW5kYXRpb25FbmFibGVkKCkgQEAgKi8pIHsKKyAgICAgICAgaWYgKFNldHRpbmdzOjppc0FWRm91 bmRhdGlvbkVuYWJsZWQoKSkgewogI2lmIFBMQVRGT1JNKE1BQykKICAgICAgICAgICAgIE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnJlZ2lzdGVyTWVkaWFFbmdpbmUoYWRkTWVk aWFFbmdpbmUpOwogI2VsaWYgUExBVEZPUk0oV0lOKQo=