97047 2012-09-18 14:47:22 -0700 NRWT crashes on too many timeouts 2012-10-10 10:30:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED NRWT P2 Normal --- 1 don.olmstead dpranke abarth dpranke ojan simon.fraser slewis thorton tony webkit.review.bot oldest_to_newest 723068 0 don.olmstead 2012-09-18 14:47:22 -0700 NRWT crashes with an OSError, [Errno 24] Too many open files, if there were too many timeouts. Full stack trace at https://gist.github.com/3746082 Steps to recreate - Modify MockDRT in mock_drt.py to infinite loop in run. def run(self): while True: i = 1 - Run new-run-webkit-tests --platform=mock-chromium --no-build 725663 1 simon.fraser 2012-09-21 11:33:35 -0700 I tried to reproduce this, and wasn't able to easily do so. Mountain Lion. I was using 'lsof' to list open files, and did not see the list of open files increasing as the tests timed out. 12$ $ python --version Python 2.7.2 725723 2 don.olmstead 2012-09-21 12:50:01 -0700 The OSError was encountered on Linux. Ubuntu 11.04 using Python 2.7.1+ Going to give it a go on Windows 7 x64 using Python 2.7.2. 725998 3 don.olmstead 2012-09-21 17:21:39 -0700 Didn't see the OSError under Windows, but the processes we're still present in Task Manager. 738344 4 167878 dpranke 2012-10-09 17:12:49 -0700 Created attachment 167878 Patch 738353 5 dpranke 2012-10-09 17:20:35 -0700 This did reproduce on Chromium LInux for me ... 738428 6 ojan 2012-10-09 19:00:44 -0700 Looks fine to me. Tony, WDYT? 739077 7 167878 webkit.review.bot 2012-10-10 10:30:51 -0700 Comment on attachment 167878 Patch Clearing flags on attachment: 167878 Committed r130922: <http://trac.webkit.org/changeset/130922> 739079 8 webkit.review.bot 2012-10-10 10:30:55 -0700 All reviewed patches have been landed. Closing bug. 167878 2012-10-09 17:12:49 -0700 2012-10-10 10:30:51 -0700 Patch bug-97047-20121009171150.patch text/plain 3546 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTNkNjA3MTQ2Mjc5MmQyMWJkMmVlZGJhMWFkZjk0MzYy MjU2MDVjMi4uMWUyNGEzNWYwZDAyYjE2ZTQzYTk2YjBmMTkwNzNiYjU1NGRiMTQ3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIE5SV1QgY3Jhc2hlcyBvbiB0b28gbWFueSB0aW1lb3V0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTcwNDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcHBhcmVudGx5IGlmIHlvdSBraWxsIGEg c3VicHJvY2VzcyBkaXJlY3RseSBweXRob24gZG9lc24ndAorICAgICAgICBhdXRvLWNsb3NlIHRo ZSBmaWxlIGRlc2NyaXB0b3JzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3MuX3Jl c2V0KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZl cl9wcm9jZXNzX3VuaXR0ZXN0LnB5OgorCiAyMDEyLTEwLTA4ICBEaXJrIFByYW5rZSAgPGRwcmFu a2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlc3VsdHMuaHRtbCBhbmQgZ2FyZGVuLW8tbWF0 aWMgYXJlIGlnbm9yaW5nIElNQUdFIGZhaWx1cmVzIHdoZW4gZXhwZWN0ZWQgdG8gRkFJTApkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJf cHJvY2Vzcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2Vy dmVyX3Byb2Nlc3MucHkKaW5kZXggYmZhNmFhYjgwODY0MjYyY2E3MzI2Yzg4ZGQ4YjI0MGEzYTg2 MGU3ZC4uNDhmZWRhOTY4NmE4YWE0NjUxYzE5NWFkMGRlZDFlNzRlZjdhN2ZkMiAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vz cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZl cl9wcm9jZXNzLnB5CkBAIC04NCw2ICs4NCwxNyBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVj dCk6CiAgICAgICAgIHJldHVybiBzZWxmLl9waWQKIAogICAgIGRlZiBfcmVzZXQoc2VsZik6Cisg ICAgICAgIGlmIGdldGF0dHIoc2VsZiwgJ19wcm9jJywgTm9uZSk6CisgICAgICAgICAgICBpZiBz ZWxmLl9wcm9jLnN0ZGluOgorICAgICAgICAgICAgICAgIHNlbGYuX3Byb2Muc3RkaW4uY2xvc2Uo KQorICAgICAgICAgICAgICAgIHNlbGYuX3Byb2Muc3RkaW4gPSBOb25lCisgICAgICAgICAgICBp ZiBzZWxmLl9wcm9jLnN0ZG91dDoKKyAgICAgICAgICAgICAgICBzZWxmLl9wcm9jLnN0ZG91dC5j bG9zZSgpCisgICAgICAgICAgICAgICAgc2VsZi5fcHJvYy5zdGRvdXQgPSBOb25lCisgICAgICAg ICAgICBpZiBzZWxmLl9wcm9jLnN0ZGVycjoKKyAgICAgICAgICAgICAgICBzZWxmLl9wcm9jLnN0 ZGVyci5jbG9zZSgpCisgICAgICAgICAgICAgICAgc2VsZi5fcHJvYy5zdGRlcnIgPSBOb25lCisK ICAgICAgICAgc2VsZi5fcHJvYyA9IE5vbmUKICAgICAgICAgc2VsZi5fb3V0cHV0ID0gc3RyKCkg ICMgYnl0ZXNhcnJheSgpIG9uY2Ugd2UgcmVxdWlyZSBQeXRob24gMi42CiAgICAgICAgIHNlbGYu X2Vycm9yID0gc3RyKCkgICMgYnl0ZXNhcnJheSgpIG9uY2Ugd2UgcmVxdWlyZSBQeXRob24gMi42 CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Nl cnZlcl9wcm9jZXNzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191bml0dGVzdC5weQppbmRleCA0OGM0MWU2ZjI4N2Rk NWM1ODViNmRkMjZlZDBkZDkwN2RjMjFlZWFjLi43YTVhYzQ1ZDRkNjgyMzQwZjE2MGQwNWUxOWJm NGQ5ZDAxMDg3YWExIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHkKQEAg LTU3LDYgKzU3LDcgQEAgY2xhc3MgVHJpdmlhbE1vY2tQb3J0KG9iamVjdCk6CiBjbGFzcyBNb2Nr RmlsZShvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBzZXJ2ZXJfcHJvY2Vzcyk6CiAg ICAgICAgIHNlbGYuX3NlcnZlcl9wcm9jZXNzID0gc2VydmVyX3Byb2Nlc3MKKyAgICAgICAgc2Vs Zi5jbG9zZWQgPSBGYWxzZQogCiAgICAgZGVmIGZpbGVubyhzZWxmKToKICAgICAgICAgcmV0dXJu IDEKQEAgLTY2LDcgKzY3LDcgQEAgY2xhc3MgTW9ja0ZpbGUob2JqZWN0KToKICAgICAgICAgcmFp c2UgSU9FcnJvcgogCiAgICAgZGVmIGNsb3NlKHNlbGYpOgotICAgICAgICBwYXNzCisgICAgICAg IHNlbGYuY2xvc2VkID0gVHJ1ZQogCiAKIGNsYXNzIE1vY2tQcm9jKG9iamVjdCk6CkBAIC04Nyw2 ICs4OCw4IEBAIGNsYXNzIEZha2VTZXJ2ZXJQcm9jZXNzKHNlcnZlcl9wcm9jZXNzLlNlcnZlclBy b2Nlc3MpOgogICAgIGRlZiBfc3RhcnQoc2VsZik6CiAgICAgICAgIHNlbGYuX3Byb2MgPSBNb2Nr UHJvYyhzZWxmKQogICAgICAgICBzZWxmLnN0ZGluID0gc2VsZi5fcHJvYy5zdGRpbgorICAgICAg ICBzZWxmLnN0ZG91dCA9IHNlbGYuX3Byb2Muc3Rkb3V0CisgICAgICAgIHNlbGYuc3RkZXJyID0g c2VsZi5fcHJvYy5zdGRlcnIKICAgICAgICAgc2VsZi5fcGlkID0gc2VsZi5fcHJvYy5waWQKICAg ICAgICAgc2VsZi5icm9rZW5fcGlwZXMgPSBbXQogCkBAIC0xMjEsNiArMTI0LDE1IEBAIGNsYXNz IFRlc3RTZXJ2ZXJQcm9jZXNzKHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogICAgICAgICBwcm9jLnN0 b3AoMCkKIAorICAgIGRlZiB0ZXN0X2NsZWFudXAoc2VsZik6CisgICAgICAgIHBvcnRfb2JqID0g VHJpdmlhbE1vY2tQb3J0KCkKKyAgICAgICAgc2VydmVyX3Byb2Nlc3MgPSBGYWtlU2VydmVyUHJv Y2Vzcyhwb3J0X29iaj1wb3J0X29iaiwgbmFtZT0idGVzdCIsIGNtZD1bInRlc3QiXSkKKyAgICAg ICAgc2VydmVyX3Byb2Nlc3MuX3N0YXJ0KCkKKyAgICAgICAgc2VydmVyX3Byb2Nlc3Muc3RvcCgp CisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShzZXJ2ZXJfcHJvY2Vzcy5zdGRpbi5jbG9zZWQpCisg ICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShzZXJ2ZXJfcHJvY2Vzcy5zdGRvdXQuY2xvc2VkKQorICAg ICAgICBzZWxmLmFzc2VydFRydWUoc2VydmVyX3Byb2Nlc3Muc3RkZXJyLmNsb3NlZCkKKwogICAg IGRlZiB0ZXN0X2Jyb2tlbl9waXBlKHNlbGYpOgogICAgICAgICBwb3J0X29iaiA9IFRyaXZpYWxN b2NrUG9ydCgpCiAK