97016 2012-09-18 07:05:09 -0700 Web Inspector: setPropertyValue does not work for non-finite numbers 2012-09-20 05:44:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey aandrey apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 722749 0 aandrey 2012-09-18 07:05:09 -0700 Patch to follow. 722752 1 164552 aandrey 2012-09-18 07:08:22 -0700 Created attachment 164552 Patch 722835 2 164552 vsevik 2012-09-18 09:05:02 -0700 Comment on attachment 164552 Patch This looks like a hack. I think this should be fixed on a lower (protocol) level as a workaround for JSON.stringify/JSON.parse not supporting infinite values. 723570 3 aandrey 2012-09-19 07:56:39 -0700 Otherwise we should hack the public remote debugging protocol API. As discussed with Pavel, we decided to live with this workaround for now. 724446 4 164552 webkit.review.bot 2012-09-20 05:44:29 -0700 Comment on attachment 164552 Patch Clearing flags on attachment: 164552 Committed r129122: <http://trac.webkit.org/changeset/129122> 724447 5 webkit.review.bot 2012-09-20 05:44:32 -0700 All reviewed patches have been landed. Closing bug. 164552 2012-09-18 07:08:22 -0700 2012-09-20 05:44:29 -0700 Patch bug-97016-20120918180748.patch text/plain 5503 aandrey U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY3ZjViYWUyMzVhODlk YjFlODljYzQzYWUwYzM3ODczMjk1ZjE1Yi4uMzk1YTQ5OWVmOTY5YTk2YWZiZjQ5NzFlZWMyZjE5 NmZkMGRiY2U1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTE4ICBBbmRy ZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNldFByb3BlcnR5VmFsdWUgZG9lcyBub3Qgd29yayBmb3Igbm9uLWZpbml0ZSBudW1iZXJz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzAxNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeDogc2V0 dGluZyBhIHByb3BlcnR5IHRvIE5hTiwgSW5maW5pdHkgb3IgLUluZmluaXR5IG51bWJlcnMgZGlk IG5vdCB3b3JrLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZW1vdGVPYmplY3Qu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVtb3RlT2JqZWN0LnByb3RvdHlwZS5zZXRQcm9w ZXJ0eVZhbHVlKToKKwogMjAxMi0wOS0xNyAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTk1JOiBub3cgd2hlbiB3ZSBjYW4g ZGV0ZWN0IGluc3RydW1lbnRlZCBjbGFzc2VzIHdlIGNhbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZW1vdGVPYmplY3QuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1JlbW90ZU9iamVjdC5qcwppbmRleCBmNTM4NzM4ZTExN2Jh ZmFkODY3NmM0ZmNlZDBlMGRmY2ZiNzBjN2EzLi4zMjRmNGVkYjVhMGE5OWJkODBhM2E2MjVkZjk5 Njk4NDQ1NDBhOTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1JlbW90ZU9iamVjdC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1JlbW90ZU9iamVjdC5qcwpAQCAtMjQxLDEzICsyNDEsMTQgQEAgV2ViSW5zcGVjdG9yLlJl bW90ZU9iamVjdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICAgICAgfQogCi0gICAgICAgICAgICBmdW5jdGlvbiBzZXRQcm9wZXJ0eVZhbHVlKHByb3BlcnR5 TmFtZSwgcHJvcGVydHlWYWx1ZSkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICB0aGlz W3Byb3BlcnR5TmFtZV0gPSBwcm9wZXJ0eVZhbHVlOwotICAgICAgICAgICAgfQorICAgICAgICAg ICAgdmFyIHNldFByb3BlcnR5VmFsdWVGdW5jdGlvbiA9ICJmdW5jdGlvbihhLCBiKSB7IHRoaXNb YV0gPSBiOyB9IjsKKworICAgICAgICAgICAgLy8gU3BlY2lhbCBjYXNlIGZvciBOYU4sIEluZmlu aXR5IGFuZCAtSW5maW5pdHkKKyAgICAgICAgICAgIGlmIChyZXN1bHQudHlwZSA9PT0gIm51bWJl ciIgJiYgdHlwZW9mIHJlc3VsdC52YWx1ZSAhPT0gIm51bWJlciIpCisgICAgICAgICAgICAgICAg c2V0UHJvcGVydHlWYWx1ZUZ1bmN0aW9uID0gImZ1bmN0aW9uKGEpIHsgdGhpc1thXSA9ICIgKyBy ZXN1bHQuZGVzY3JpcHRpb24gKyAiOyB9IjsKIAogICAgICAgICAgICAgZGVsZXRlIHJlc3VsdC5k ZXNjcmlwdGlvbjsgLy8gT3B0aW1pemUgb24gdHJhZmZpYy4KLSAgICAgICAgICAgIFJ1bnRpbWVB Z2VudC5jYWxsRnVuY3Rpb25Pbih0aGlzLl9vYmplY3RJZCwgc2V0UHJvcGVydHlWYWx1ZS50b1N0 cmluZygpLCBbeyB2YWx1ZTpuYW1lIH0sIHJlc3VsdF0sIHRydWUsIHVuZGVmaW5lZCwgcHJvcGVy dHlTZXRDYWxsYmFjay5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIFJ1bnRpbWVBZ2VudC5jYWxs RnVuY3Rpb25Pbih0aGlzLl9vYmplY3RJZCwgc2V0UHJvcGVydHlWYWx1ZUZ1bmN0aW9uLCBbeyB2 YWx1ZTpuYW1lIH0sIHJlc3VsdF0sIHRydWUsIHVuZGVmaW5lZCwgcHJvcGVydHlTZXRDYWxsYmFj ay5iaW5kKHRoaXMpKTsKICAgICAgICAgICAgIGlmIChyZXN1bHQuX29iamVjdElkKQogICAgICAg ICAgICAgICAgIFJ1bnRpbWVBZ2VudC5yZWxlYXNlT2JqZWN0KHJlc3VsdC5fb2JqZWN0SWQpOwog ICAgICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNDdmNDEzNTJhOTM0NDFhMjIxNDA4ZDgwN2FjYTE5M2YzNzAwOTUz NC4uOWFiNTQzNzc3OWFmOTUzNTdiODRlODc3YmM5MGE3MjkyZGQ2ODRiZSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA5LTE4ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNldFByb3BlcnR5VmFsdWUgZG9lcyBub3Qg d29yayBmb3Igbm9uLWZpbml0ZSBudW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NzAxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEV4cGFuZHMgdGhlIHRlc3Qgd2l0aCBub24tZmluaXRlIG51bWJl cnMgY2FzZS4KKworICAgICAgICAqIGluc3BlY3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVy dHlWYWx1ZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3J1bnRpbWUvcnVudGlt ZS1zZXRQcm9wZXJ0eVZhbHVlLmh0bWw6CisKIDIwMTItMDktMTcgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1RvdWNoQWRqdXN0bWVu dF0gQWRqdXN0ZWQgcG9pbnQgb3V0c2lkZSBib3VuZHMgZm9yIG5vbi1yZWN0aWxpbmVhciB0YXJn ZXRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcnVudGltZS9ydW50aW1lLXNl dFByb3BlcnR5VmFsdWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3J1bnRp bWUvcnVudGltZS1zZXRQcm9wZXJ0eVZhbHVlLWV4cGVjdGVkLnR4dAppbmRleCA2MjZmNjM1MGMy MzIxMjU0OGRlNGM3ZDc0ZWFkZGFhZGY5ZmZmNzA0Li5mYjcwYzk2ZTExYTVhYzQzZTc2NzU5YjBh YzZjZjY5NjgwYWI2MjY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcnVudGlt ZS9ydW50aW1lLXNldFByb3BlcnR5VmFsdWUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci9ydW50aW1lL3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS1leHBlY3RlZC50eHQK QEAgLTIyLDYgKzIyLDkgQEAgQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEzOgogQ09OU09MRSBNRVNT QUdFOiBsaW5lIDExOiA9PT09PSBTZXQgZXhjZXB0aW9uID09PT09CiBDT05TT0xFIE1FU1NBR0U6 IGxpbmUgMTI6IHsiZm9vIjoiIn0KIENPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogCitDT05TT0xF IE1FU1NBR0U6IGxpbmUgMTE6ID09PT09IFNldCBub24tZmluaXRlIG51bWJlcnMgPT09PT0KK0NP TlNPTEUgTUVTU0FHRTogbGluZSAxMjogeyJmb28iOiJOYU4iLCJmb28xIjoiSW5maW5pdHkiLCJm b28yIjoiLUluZmluaXR5In0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogCiBUZXN0cyBXZWJJ bnNwZWN0b3IuUmVtb3ZlT2JqZWN0LnNldFByb3BlcnR5VmFsdWUgaW1wbGVtZW50YXRpb24uCiAK IApAQCAtNDIsMyArNDUsNSBAQCBSdW5uaW5nOiB0ZXN0U2V0RW1wdHlTdHJpbmcKIFJ1bm5pbmc6 IHRlc3RTZXRFeGNlcHRpb24KIGV4Y2VwdGlvbgogCitSdW5uaW5nOiB0ZXN0U2V0Tm9uRmluaXRl TnVtYmVycworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcnVudGltZS9ydW50 aW1lLXNldFByb3BlcnR5VmFsdWUuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1l L3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sCmluZGV4IDY0NjQ4ZWUyNjI2ZWI4YjlhNTc1 Mzc0NTJjMzEyOTY0ZWNlZjg3NjUuLjYwYzNjMWM3OGJlYjdjZTBmOGExZmI0MTBiZWY2ZjUyOTA0 NjU5YTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1lL3J1bnRpbWUt c2V0UHJvcGVydHlWYWx1ZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9ydW50aW1l L3J1bnRpbWUtc2V0UHJvcGVydHlWYWx1ZS5odG1sCkBAIC05LDggKzksMTUgQEAgdmFyIG9iamVj dDIgPSB7IGJhcjogMiB9OwogZnVuY3Rpb24gZHVtcE9iamVjdChsYWJlbCkKIHsKICAgICBjb25z b2xlLmxvZygiPT09PT0gIiArIGxhYmVsICsgIiA9PT09PSIpOwotICAgIGNvbnNvbGUubG9nKEpT T04uc3RyaW5naWZ5KG9iamVjdDEpKTsKKyAgICBjb25zb2xlLmxvZyhKU09OLnN0cmluZ2lmeShv YmplY3QxLCByZXBsYWNlcikpOwogICAgIGNvbnNvbGUubG9nKCIiKTsKKworICAgIGZ1bmN0aW9u IHJlcGxhY2VyKGtleSwgdmFsdWUpCisgICAgeworICAgICAgICBpZiAodHlwZW9mIHZhbHVlID09 PSAibnVtYmVyIiAmJiAhaXNGaW5pdGUodmFsdWUpKQorICAgICAgICAgICAgcmV0dXJuIFN0cmlu Zyh2YWx1ZSk7CisgICAgICAgIHJldHVybiB2YWx1ZTsKKyAgICB9CiB9CiAKIGZ1bmN0aW9uIHRl c3QoKQpAQCAtMTA5LDYgKzExNiwyNiBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdChlcnJvcik7CiAgICAgICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZHVtcE9iamVjdCgnU2V0IGV4Y2VwdGlvbicpIiwgbmV4 dCk7CiAgICAgICAgICAgICB9CisgICAgICAgIH0sCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdFNl dE5vbkZpbml0ZU51bWJlcnMobmV4dCkKKyAgICAgICAgeworICAgICAgICAgICAgb2JqMS5zZXRQ cm9wZXJ0eVZhbHVlKCJmb28iLCAiTmFOIiwgc3RlcDEpOworCisgICAgICAgICAgICBmdW5jdGlv biBzdGVwMShlcnJvcikKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBvYmoxLnNldFBy b3BlcnR5VmFsdWUoImZvbzEiLCAiSW5maW5pdHkiLCBzdGVwMik7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGZ1bmN0aW9uIHN0ZXAyKGVycm9yKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIG9iajEuc2V0UHJvcGVydHlWYWx1ZSgiZm9vMiIsICItSW5maW5pdHkiLCBzdGVw Myk7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHN0ZXAzKGVycm9yKQor ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBh Z2UoImR1bXBPYmplY3QoJ1NldCBub24tZmluaXRlIG51bWJlcnMnKSIsIG5leHQpOworICAgICAg ICAgICAgfQogICAgICAgICB9CiAgICAgXSk7CiB9Cg==