97015 2012-09-18 06:44:47 -0700 [EFL][WK2] Implement PageClientImpl::isViewFocused. 2012-09-18 18:32:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 722741 0 ryuan.choi 2012-09-18 06:44:47 -0700 In WebKit2/Efl, PageClientImpl::isViewFocused always return true. So contents can not receive window.onblur although webview lost focus. 722746 1 164550 ryuan.choi 2012-09-18 07:00:05 -0700 Created attachment 164550 Patch 722750 2 164550 cdumez 2012-09-18 07:05:18 -0700 Comment on attachment 164550 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review Can you unskip any test with this fix? > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45 > + void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; } Why do we need this? > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57 > + virtual bool isViewFocused() { return m_isViewFocused; } evas_object_focus_get(m_viewWidget) ? > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122 > + bool m_isViewFocused; Why do we need a new member? We can certainly get focused state from m_viewWidget, right? 723149 3 164639 ryuan.choi 2012-09-18 17:36:03 -0700 Created attachment 164639 Patch 723151 4 ryuan.choi 2012-09-18 17:38:02 -0700 (In reply to comment #2) > (From update of attachment 164550 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164550&action=review > > Can you unskip any test with this fix? My results are same with this. > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:45 > > + void setViewFocused(bool isFocused) { m_isViewFocused = isFocused; } > > Why do we need this? > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:57 > > + virtual bool isViewFocused() { return m_isViewFocused; } > > evas_object_focus_get(m_viewWidget) ? > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.h:122 > > + bool m_isViewFocused; > > Why do we need a new member? We can certainly get focused state from m_viewWidget, right? yes, it is enough. Fixed. 723172 5 164639 gyuyoung.kim 2012-09-18 18:23:02 -0700 Comment on attachment 164639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review > Source/WebKit2/ChangeLog:9 > + So window.onblur events will not be generated when webview lost focus. lost -> losts ? 723173 6 164639 gyuyoung.kim 2012-09-18 18:25:31 -0700 Comment on attachment 164639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164639&action=review >> Source/WebKit2/ChangeLog:9 >> + So window.onblur events will not be generated when webview lost focus. > > lost -> losts ? No ? 723176 7 164639 webkit.review.bot 2012-09-18 18:32:41 -0700 Comment on attachment 164639 Patch Clearing flags on attachment: 164639 Committed r128958: <http://trac.webkit.org/changeset/128958> 723177 8 webkit.review.bot 2012-09-18 18:32:45 -0700 All reviewed patches have been landed. Closing bug. 164550 2012-09-18 07:00:05 -0700 2012-09-18 17:35:57 -0700 Patch bug-97015-20120918225930.patch text/plain 4003 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQzNzg3NzVkNWIyMzJk MWIxNjBmZGVkODAxY2Q4OGNhOTc1ZGQ5ZS4uYjIyMzg2M2Y1MTQ5MDJmYjljZDk3MjUzMGVhYTg5 MDg1YjU4NTFiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTE4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIElt cGxlbWVudCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3Rm9jdXNlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MDE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0Mi9FZmwgYWx3YXlzIHJldHVybnMg dHJ1ZSBmb3IgUGFnZUNsaWVudEltcGw6OmlzVmlld0ZvY3VzZWQuCisgICAgICAgIFNvIHdpbmRv dy5vbmJsdXIgZXZlbnRzIHdpbGwgbm90IGJlIGdlbmVyYXRlZCB3aGVuIHdlYnZpZXcgbG9zdCBm b2N1cy4KKworICAgICAgICBUaGlzIHBhdGNoIGltcGxlbWVudHMgaXNWaWV3Rm9jdXNlZCB0byBy ZXR1cm4gdGhlIGN1cnJlbnQgZm9jdXMgb2Ygd2Vidmlldy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVu dEltcGw6OlBhZ2VDbGllbnRJbXBsKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9QYWdl Q2xpZW50SW1wbC5oOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6c2V0Vmlld0Zv Y3VzZWQpOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6aXNWaWV3Rm9jdXNlZCk6 CisgICAgICAgIChQYWdlQ2xpZW50SW1wbCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3NtYXJ0X2ZvY3VzX2luKToKKyAgICAg ICAgKF9ld2tfdmlld19zbWFydF9mb2N1c19vdXQpOgorCiAyMDEyLTA5LTE4ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTZXQgdGhl IGFyZWEgb2YgdG9vbHRpcHMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IGY4NTE5Y2U2YmZiNThmYzdk NDU1MmFhNzBhZGZjMTBhMTU5MGZjOTYuLjVkYTEzNTIzOGVkNWUyYmQ2Yjg4NmJjNTYyODU0OWEz YzE1YjcxZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1Bh Z2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Q YWdlQ2xpZW50SW1wbC5jcHAKQEAgLTQ4LDYgKzQ4LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAK IFBhZ2VDbGllbnRJbXBsOjpQYWdlQ2xpZW50SW1wbChFdmFzX09iamVjdCogdmlld1dpZGdldCkK ICAgICA6IG1fdmlld1dpZGdldCh2aWV3V2lkZ2V0KQorICAgICwgbV9pc1ZpZXdGb2N1c2VkKGZh bHNlKQogewogfQogCkBAIC04NywxMiArODgsNiBAQCBib29sIFBhZ2VDbGllbnRJbXBsOjppc1Zp ZXdXaW5kb3dBY3RpdmUoKQogICAgIHJldHVybiB0cnVlOwogfQogCi1ib29sIFBhZ2VDbGllbnRJ bXBsOjppc1ZpZXdGb2N1c2VkKCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVy biB0cnVlOwotfQotCiBib29sIFBhZ2VDbGllbnRJbXBsOjppc1ZpZXdWaXNpYmxlKCkKIHsKICAg ICBub3RJbXBsZW1lbnRlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvUGFnZUNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL1BhZ2VDbGllbnRJbXBsLmgKaW5kZXggOGYwM2IwOWY0ZjQwYmRhZjg5ZDM3Y2EyNTYwZjI5 Y2QzYWM1ZGExMi4uNzVhZDM2NzJmNzljNjUzMDIwYzkyNTg5MzI5NDlhZDFkZWY5MWUwNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5o CkBAIC00Miw2ICs0Miw3IEBAIHB1YmxpYzoKIAogICAgIEV2YXNfT2JqZWN0KiB2aWV3V2lkZ2V0 KCkgY29uc3QgeyByZXR1cm4gbV92aWV3V2lkZ2V0OyB9CiAKKyAgICB2b2lkIHNldFZpZXdGb2N1 c2VkKGJvb2wgaXNGb2N1c2VkKSB7IG1faXNWaWV3Rm9jdXNlZCA9IGlzRm9jdXNlZDsgfQogCiBw cml2YXRlOgogICAgIGV4cGxpY2l0IFBhZ2VDbGllbnRJbXBsKEV2YXNfT2JqZWN0Kik7CkBAIC01 Myw3ICs1NCw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbFZpZXcoY29uc3Qg V2ViQ29yZTo6SW50UmVjdCYsIGNvbnN0IFdlYkNvcmU6OkludFNpemUmKTsKICAgICB2aXJ0dWFs IFdlYkNvcmU6OkludFNpemUgdmlld1NpemUoKTsKICAgICB2aXJ0dWFsIGJvb2wgaXNWaWV3V2lu ZG93QWN0aXZlKCk7Ci0gICAgdmlydHVhbCBib29sIGlzVmlld0ZvY3VzZWQoKTsKKyAgICB2aXJ0 dWFsIGJvb2wgaXNWaWV3Rm9jdXNlZCgpIHsgcmV0dXJuIG1faXNWaWV3Rm9jdXNlZDsgfQogICAg IHZpcnR1YWwgYm9vbCBpc1ZpZXdWaXNpYmxlKCk7CiAgICAgdmlydHVhbCBib29sIGlzVmlld0lu V2luZG93KCk7CiAKQEAgLTExNyw2ICsxMTgsOCBAQCBwcml2YXRlOgogcHJpdmF0ZToKICAgICBF dmFzX09iamVjdCogbV92aWV3V2lkZ2V0OwogICAgIERlZmF1bHRVbmRvQ29udHJvbGxlciBtX3Vu ZG9Db250cm9sbGVyOworCisgICAgYm9vbCBtX2lzVmlld0ZvY3VzZWQ7CiB9OwogCiB9IC8vIG5h bWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192 aWV3LmNwcAppbmRleCAzNDJlM2U5MmI0YjZkZGEzZjc5MzEyMDIyMTBkOGQwMzM5M2MxYTU2Li42 Nzc3OGJmYzk1YzdkZjUzNTYxOGI4MTI2YjIyOWMwNTM4Y2E1ODEwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC0yMTYsNiArMjE2LDcgQEAg c3RhdGljIEVpbmFfQm9vbCBfZXdrX3ZpZXdfc21hcnRfZm9jdXNfaW4oRXdrX1ZpZXdfU21hcnRf RGF0YSogc21hcnREYXRhKQogewogICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFy dERhdGEsIHByaXYsIGZhbHNlKTsKIAorICAgIHByaXYtPnBhZ2VDbGllbnQtPnNldFZpZXdGb2N1 c2VkKHRydWUpOwogICAgIHByaXYtPnBhZ2VQcm94eS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBh Z2VQcm94eTo6Vmlld0lzRm9jdXNlZCB8IFdlYlBhZ2VQcm94eTo6Vmlld1dpbmRvd0lzQWN0aXZl KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTIyNCw2ICsyMjUsNyBAQCBzdGF0aWMgRWluYV9C b29sIF9ld2tfdmlld19zbWFydF9mb2N1c19vdXQoRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnRE YXRhKQogewogICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHByaXYs IGZhbHNlKTsKIAorICAgIHByaXYtPnBhZ2VDbGllbnQtPnNldFZpZXdGb2N1c2VkKGZhbHNlKTsK ICAgICBwcml2LT5wYWdlUHJveHktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZp ZXdJc0ZvY3VzZWQgfCBXZWJQYWdlUHJveHk6OlZpZXdXaW5kb3dJc0FjdGl2ZSk7CiAgICAgcmV0 dXJuIHRydWU7CiB9Cg== 164639 2012-09-18 17:36:03 -0700 2012-09-18 18:32:41 -0700 Patch bug-97015-20120919093530.patch text/plain 1516 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4OTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTY1NDljNzUyMTU0ZmE0 OWY2MzYzOWUzZWMwMGI3MWMyZjRhNjliZS4uMTBiZmU4Yzc2ZWRiN2YxNTY4MmZjMGYzMTgyODI4 YWVlYTcxN2UzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTE4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIElt cGxlbWVudCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3Rm9jdXNlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MDE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0Mi9FZmwgYWx3YXlzIHJldHVybnMg dHJ1ZSBmb3IgUGFnZUNsaWVudEltcGw6OmlzVmlld0ZvY3VzZWQuCisgICAgICAgIFNvIHdpbmRv dy5vbmJsdXIgZXZlbnRzIHdpbGwgbm90IGJlIGdlbmVyYXRlZCB3aGVuIHdlYnZpZXcgbG9zdCBm b2N1cy4KKworICAgICAgICBUaGlzIHBhdGNoIGltcGxlbWVudHMgaXNWaWV3Rm9jdXNlZCB0byBy ZXR1cm4gdGhlIGN1cnJlbnQgZm9jdXMgb2Ygd2Vidmlldy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVu dEltcGw6OmlzVmlld0ZvY3VzZWQpOgorCiAyMDEyLTA5LTE4ICBCeXVuZ3dvbyBMZWUgIDxidzgw LmxlZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBUaXRsZSBzdHJpbmcgc2hvdWxkIGJlIGNoYW5n ZWQgd2hlbiBkb2N1bWVudC50aXRsZSBpcyBzZXQgdG8gJycuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggZjg1MTljZTZi ZmI1OGZjN2Q0NTUyYWE3MGFkZmMxMGExNTkwZmM5Ni4uYzhjZTA5ZmJmYzI3OGQ3NTcxZDE1MmE2 ZmI4ZTQ5MDA2MTFjMTM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtODksOCArODksNyBAQCBib29sIFBhZ2VDbGll bnRJbXBsOjppc1ZpZXdXaW5kb3dBY3RpdmUoKQogCiBib29sIFBhZ2VDbGllbnRJbXBsOjppc1Zp ZXdGb2N1c2VkKCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiB0cnVlOwor ICAgIHJldHVybiBldmFzX29iamVjdF9mb2N1c19nZXQobV92aWV3V2lkZ2V0KTsKIH0KIAogYm9v bCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3VmlzaWJsZSgpCg==