97014 2012-09-18 06:38:33 -0700 [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively 2012-09-18 08:00:26 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov cdumez gyuyoung.kim kenneth webkit.review.bot oldest_to_newest 722733 0 mikhail.pozdnyakov 2012-09-18 06:38:33 -0700 According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall be used for literals rather than WTF::StringBuilder::append(). 722735 1 164547 mikhail.pozdnyakov 2012-09-18 06:41:08 -0700 Created attachment 164547 patch 722736 2 164547 cdumez 2012-09-18 06:41:49 -0700 Comment on attachment 164547 patch LGTM. 722789 3 164547 webkit.review.bot 2012-09-18 08:00:22 -0700 Comment on attachment 164547 patch Clearing flags on attachment: 164547 Committed r128895: <http://trac.webkit.org/changeset/128895> 722790 4 webkit.review.bot 2012-09-18 08:00:26 -0700 All reviewed patches have been landed. Closing bug. 164547 2012-09-18 06:41:08 -0700 2012-09-18 08:00:21 -0700 patch bug97014 text/plain 2010 mikhail.pozdnyakov Y29tbWl0IDJmMzcyZGRiMjA3MGE5YmQxODJkMDExZDMxNGQ5ODM5NzRhY2E1MDEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIFNlcCAxOCAxNjozOTo1MSAyMDEyICswMzAwCgogICAgYnVnOTcwMTQKCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmU3ODlmYy4uNDBjMzUz ZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDEyLTA5LTE4ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJdW1dUUl0gSW5qZWN0ZWRCdW5kbGU6 OmJvb2xlYW5Gb3JLZXkoKSBzaG91bGQgaGFuZGxlIGxpdGVyYWxzIGVmZmVjdGl2ZWx5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzAxNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byBo dHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvRWZmaWNpZW50U3RyaW5ncyBXVEY6OlN0cmluZ0J1 aWxkZXI6OmFwcGVuZExpdGVyYWwoKSBzaGFsbAorICAgICAgICBiZSB1c2VkIGZvciBsaXRlcmFs cyByYXRoZXIgdGhhbiBXVEY6OlN0cmluZ0J1aWxkZXI6OmFwcGVuZCgpLgorCisgICAgICAgICog V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAg ICAgIChXVFI6OkluamVjdGVkQnVuZGxlOjpib29sZWFuRm9yS2V5KToKKwogMjAxMi0wOS0xNyAg WmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIGZh c3QvbG9hZGVyL2Rpc3BsYXktaW1hZ2UtdW5zZXQtY2FuLWJsb2NrLWltYWdlLWFuZC1jYW4tcmVs b2FkLWluLXBsYWNlLmh0bWwgZmFpbGluZyBhZnRlciByMTI4NjQ1CmRpZmYgLS1naXQgYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcCBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCmlu ZGV4IDRlM2JlOTEuLjZjMzQ1YzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCkBAIC0yMDksOSArMjA5LDkg QEAgYm9vbCBJbmplY3RlZEJ1bmRsZTo6Ym9vbGVhbkZvcktleShXS0RpY3Rpb25hcnlSZWYgZGlj dGlvbmFyeSwgY29uc3QgY2hhcioga2V5KQogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB3 a0tleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhrZXkpKTsKICAgICBX S1R5cGVSZWYgdmFsdWUgPSBXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KGRpY3Rpb25hcnksIHdr S2V5LmdldCgpKTsKICAgICBpZiAoV0tHZXRUeXBlSUQodmFsdWUpICE9IFdLQm9vbGVhbkdldFR5 cGVJRCgpKSB7Ci0gICAgICAgIHN0cmluZ0J1aWxkZXIoKS0+YXBwZW5kKCJCb29sZWFuIHZhbHVl IGZvciBrZXkgXCIiKTsKKyAgICAgICAgc3RyaW5nQnVpbGRlcigpLT5hcHBlbmRMaXRlcmFsKCJC b29sZWFuIHZhbHVlIGZvciBrZXkgXCIiKTsKICAgICAgICAgc3RyaW5nQnVpbGRlcigpLT5hcHBl bmQoa2V5KTsKLSAgICAgICAgc3RyaW5nQnVpbGRlcigpLT5hcHBlbmQoIlwiIG5vdCBmb3VuZCBp biBkaWN0aW9uYXJ5XG4iKTsKKyAgICAgICAgc3RyaW5nQnVpbGRlcigpLT5hcHBlbmRMaXRlcmFs KCJcIiBub3QgZm91bmQgaW4gZGljdGlvbmFyeVxuIik7CiAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICB9CiAgICAgcmV0dXJuIFdLQm9vbGVhbkdldFZhbHVlKHN0YXRpY19jYXN0PFdLQm9vbGVh blJlZj4odmFsdWUpKTsK