97012 2012-09-18 06:25:07 -0700 Web Inspector: [Extensions API] postpone requests to add extensions until extension server is initialized 2012-09-18 07:14:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck johnjbarton keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 722728 0 caseq 2012-09-18 06:25:07 -0700 Currently, requests to add extensions may arrive before we actually request extensions list in ExtensionServer.initExtensions(). One reason for that is chromium (InspectorExtensionsRegistry.getExtensionsAsync() is a no-op, we always send the extension list from the browser), another potential code path is remote front-end extensions using window.addExtension(). This may lead to extensions sending requests before extension subsystem is initialized (i.e. we install event listeners etc). Thanks to johnjbarton@chromium.org for investigating this. 722729 1 164544 caseq 2012-09-18 06:28:36 -0700 Created attachment 164544 Patch 722755 2 caseq 2012-09-18 07:14:01 -0700 Committed r128892: <http://trac.webkit.org/changeset/128892> 164544 2012-09-18 06:28:36 -0700 2012-09-18 07:07:39 -0700 Patch bug-97012-20120918172803.patch text/plain 2958 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI3ZTVmMzEwYjM1ZGNk MzI4NjdmN2Y3ODRkNmIzNDdhOGQwMzIwMC4uZjliZTE1MDcxMDM5YTNhMjhkYjJmMTczOTc5M2Yz MzQ5OWIzYjY4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogW0V4dGVuc2lvbnMgQVBJXSBwb3N0cG9uZSByZXF1ZXN0cyB0byBhZGQgZXh0ZW5zaW9ucyB1 bnRpbCBleHRlbnNpb24gc2VydmVyIGlzIGluaXRpYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzAxMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gcXVldWUgZXh0ZW5zaW9ucyBiZWluZyBhZGRl ZCB1bmxlc3MgaW5pdGlhbGl6YXRpb24gaXMgY29tcGxldGU7CisgICAgICAgIC0gYWRkIHF1ZXVl ZCBleHRlbnNpb25zIHVwb24gY29tcGxldGlvbiBvZiBpbml0aWFsaXphdGlvbjsKKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uU2VydmVyLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUuaW5pdEV4dGVuc2lvbnMpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUuX2FkZEV4dGVuc2lv bnMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUuX2Fk ZEV4dGVuc2lvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uU2VydmVyLnByb3Rv dHlwZS5faW5uZXJBZGRFeHRlbnNpb24pOgorCiAyMDEyLTA5LTE0ICBBbmRyZXkgS29zeWFrb3Yg IDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW0V4dGVuc2lv bnMgQVBJXSBleHBsaWNpdGx5IG1hbmFnZSBleHRlbnNpb24gYXVkaXQgcHJvZ3Jlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uU2VydmVy LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIu anMKaW5kZXggM2I2NjBkMGFiYmZlYmRmOGU5Y2VjMzFkODk3MjJjMDE2NjllOGE1ZS4uYmJiZTlh ZDUwNjM5MzBlN2EyYTc0N2JlYjJmNzRmNjA3OWFhN2VlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanMKQEAgLTYxMSw2 ICs2MTEsMTEgQEAgV2ViSW5zcGVjdG9yLkV4dGVuc2lvblNlcnZlci5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICB0aGlzLl9pbnNwZWN0ZWRVUkxDaGFuZ2VkLCB0aGlzKTsKICAgICAgICAgV2Vi SW5zcGVjdG9yLnJlc291cmNlVHJlZU1vZGVsLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9y LlJlc291cmNlVHJlZU1vZGVsLkV2ZW50VHlwZXMuTWFpbkZyYW1lTmF2aWdhdGVkLCB0aGlzLl9t YWluRnJhbWVOYXZpZ2F0ZWQsIHRoaXMpOwogICAgICAgICBJbnNwZWN0b3JFeHRlbnNpb25SZWdp c3RyeS5nZXRFeHRlbnNpb25zQXN5bmMoKTsKKyAgICAgICAgdGhpcy5faW5pdERvbmUgPSB0cnVl OworICAgICAgICBpZiAodGhpcy5fcGVuZGluZ0V4dGVuc2lvbnMpIHsKKyAgICAgICAgICAgIHRo aXMuX3BlbmRpbmdFeHRlbnNpb25zLmZvckVhY2godGhpcy5faW5uZXJBZGRFeHRlbnNpb24sIHRo aXMpOworICAgICAgICAgICAgZGVsZXRlIHRoaXMuX3BlbmRpbmdFeHRlbnNpb25zOworICAgICAg ICB9CiAgICAgfSwKIAogICAgIF9ub3RpZnlDb25zb2xlTWVzc2FnZUFkZGVkOiBmdW5jdGlvbihl dmVudCkKQEAgLTY1MiwxMiArNjU3LDIzIEBAIFdlYkluc3BlY3Rvci5FeHRlbnNpb25TZXJ2ZXIu cHJvdG90eXBlID0gewogICAgICAqLwogICAgIF9hZGRFeHRlbnNpb25zOiBmdW5jdGlvbihleHRl bnNpb25zKQogICAgIHsKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBleHRlbnNpb25zLmxl bmd0aDsgKytpKQotICAgICAgICAgICAgdGhpcy5fYWRkRXh0ZW5zaW9uKGV4dGVuc2lvbnNbaV0p OworICAgICAgICBleHRlbnNpb25zLmZvckVhY2godGhpcy5fYWRkRXh0ZW5zaW9uLCB0aGlzKTsK ICAgICB9LAogCiAgICAgX2FkZEV4dGVuc2lvbjogZnVuY3Rpb24oZXh0ZW5zaW9uSW5mbykKICAg ICB7CisgICAgICAgIGlmICh0aGlzLl9pbml0RG9uZSkgeworICAgICAgICAgICAgdGhpcy5faW5u ZXJBZGRFeHRlbnNpb24oZXh0ZW5zaW9uSW5mbyk7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKyAgICAgICAgaWYgKHRoaXMuX3BlbmRpbmdFeHRlbnNpb25zKQorICAgICAgICAgICAg dGhpcy5fcGVuZGluZ0V4dGVuc2lvbnMucHVzaChleHRlbnNpb25JbmZvKTsKKyAgICAgICAgZWxz ZQorICAgICAgICAgICAgdGhpcy5fcGVuZGluZ0V4dGVuc2lvbnMgPSBbZXh0ZW5zaW9uSW5mb107 CisgICAgfSwKKworICAgIF9pbm5lckFkZEV4dGVuc2lvbjogZnVuY3Rpb24oZXh0ZW5zaW9uSW5m bykKKyAgICB7CiAgICAgICAgIGNvbnN0IHVybE9yaWdpblJlZ0V4cCA9IG5ldyBSZWdFeHAoIihb XjpdKzpcL1wvW14vXSopXC8iKTsgLy8gQ2FuJ3QgdXNlIHJlZ2V4cCBsaXRlcmFsIGhlcmUsIE1p bkpTIGNob2tlcyBvbiBpdC4KICAgICAgICAgdmFyIHN0YXJ0UGFnZSA9IGV4dGVuc2lvbkluZm8u c3RhcnRQYWdlOwogICAgICAgICB2YXIgbmFtZSA9IGV4dGVuc2lvbkluZm8ubmFtZTsK