97000 2012-09-18 04:54:30 -0700 [EFL] Rebaseline several test cases in Skipped list 2012-09-18 08:30:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez d-r eric.carlson feature-media-reviews gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 722666 0 cdumez 2012-09-18 04:54:30 -0700 Several test cases can be unskipped with simple rebaseline. 722667 1 164533 cdumez 2012-09-18 04:57:07 -0700 Created attachment 164533 Patch Could someone please cq+ ? 722670 2 164533 cdumez 2012-09-18 05:03:55 -0700 Comment on attachment 164533 Patch Mistakenly updated a global expectation. Clearing cq until fix. 722677 3 164535 cdumez 2012-09-18 05:12:15 -0700 Created attachment 164535 Patch Fix the patch so that it only adds EFL expectations, not global ones. Sorry about that. Could someone please cq+ ? 722713 4 164535 webkit.review.bot 2012-09-18 06:08:03 -0700 Comment on attachment 164535 Patch Clearing flags on attachment: 164535 Committed r128882: <http://trac.webkit.org/changeset/128882> 722714 5 webkit.review.bot 2012-09-18 06:08:07 -0700 All reviewed patches have been landed. Closing bug. 722769 6 rakuco 2012-09-18 07:45:36 -0700 fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. 722793 7 cdumez 2012-09-18 08:07:20 -0700 (In reply to comment #6) > fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later. We don't add tests to the Skipped file anymore, even if it is easier. 722815 8 rakuco 2012-09-18 08:30:26 -0700 (In reply to comment #7) > (In reply to comment #6) > > fast/events/dont-loose-last-event.html still fails here and on the bots, so I have skipped it again in <http://trac.webkit.org/changeset/128893>. > > If you move fast/events/dont-loose-last-event.html back the the Skipped list, the same wrong unskipping is likely to happen again. A bug report should be filed with the diff on the bot and the test should be added to TestExpectations with that bug number. This will make sure the test does not get unskipped by mistake and it will be much easier to fix it later. > > We don't add tests to the Skipped file anymore, even if it is easier. https://bugs.webkit.org/show_bug.cgi?id=97021 164533 2012-09-18 04:57:07 -0700 2012-09-18 05:12:15 -0700 Patch 97000_gardening.patch text/plain 0 cdumez 164535 2012-09-18 05:12:15 -0700 2012-09-18 06:08:03 -0700 Patch 97000_gardening.patch text/plain 0 cdumez