96998 2012-09-18 04:08:44 -0700 [GTK] run-webkit-tests unable to find TestExpectations for WK2 2012-09-18 11:07:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar abarth dpranke ojan pnormand rniwa svillar webkit.review.bot oldest_to_newest 722644 0 svillar 2012-09-18 04:08:44 -0700 [GTK] run-webkit-tests unable to find TestExpectations for WK2 722646 1 164530 svillar 2012-09-18 04:12:15 -0700 Created attachment 164530 Patch 722656 2 164530 svillar 2012-09-18 04:32:39 -0700 Comment on attachment 164530 Patch Clearing flags on attachment: 164530 Committed r128874: <http://trac.webkit.org/changeset/128874> 722657 3 svillar 2012-09-18 04:32:43 -0700 All reviewed patches have been landed. Closing bug. 722875 4 164530 dpranke 2012-09-18 10:09:29 -0700 Comment on attachment 164530 Patch We should probably just make this the default implementation in base.py; it looks like no one is using that implementation anymore, and this clones the implementation in apple.py. Qt, Chromium, and Efl all use different logic. 722912 5 svillar 2012-09-18 11:07:01 -0700 (In reply to comment #4) > (From update of attachment 164530 [details]) > We should probably just make this the default implementation in base.py; it looks like no one is using that implementation anymore, and this clones the implementation in apple.py. Qt, Chromium, and Efl all use different logic. Good point Dirk, I didn't review the other ports implementation when dealing with this issue. I can open a new bug moving the port specific implementations to the base class. 164530 2012-09-18 04:12:15 -0700 2012-09-18 10:09:29 -0700 Patch bug-96998-20120918131142.patch text/plain 1645 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMzYWZiMTY1ZjU0ZDM1ZWZlZWE1Yjc4M2FiYThlYzgx MjUwNDQ0My4uNWYzOGQ3ZmM5OTZiMmRlYjBhMWQxYjNmNmJhY2ViY2M0ZjU4MzkzOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA5LTE4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIHJ1bi13ZWJraXQtdGVzdHMgdW5hYmxlIHRvIGZpbmQgVGVzdEV4 cGVjdGF0aW9ucyBmb3IgV0syCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05Njk5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIHNob3VsZCBsb29rIGZvciBUZXN0RXhwZWN0YXRpb25zIGZpbGVzIGluIGFs bCB0aGUgbG9jYXRpb25zIHdoZXJlCisgICAgICAgIHdlIGN1cnJlbnRseSBsb29rIGZvciBTa2lw cGVkIGZpbGVzLiBUaGlzIHdpbGwgYWxsb3cKKyAgICAgICAgcnVuLXdlYmtpdC10ZXN0cyB0byBs b29rIGZvciBUZXN0RXhwZWN0YXRpb25zIGZpbGVzIGluCisgICAgICAgIHBsYXRmb3JtL2d0ay13 azIgYW5kIHBsYXRmb3JtL3drMiBpZiB0aGUgIi0yIiBmbGFnIGlzIHVzZWQuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weToKKyAgICAgICAgKEd0 a1BvcnQuZXhwZWN0YXRpb25zX2ZpbGVzKToKKwogMjAxMi0wOS0xNCAgRGlyayBQcmFua2UgIDxk cHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0OiAtLWFkZGl0aW9uYWwtcGxhdGZv cm0tZGlyIGlzIGJyb2tlbiBvbiBjaHJvbWl1bSBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQppbmRleCAzY2MwZWE1NjZhNDg5YjBiY2M1 ODMwZTZhMTdhOGM5M2NlMmZlMTJkLi5mMDJkMTQ4MTkyZGI0Mzc3OWQyNTVhZTcwNTJlMDI5Yzkz MThlZjUxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2d0ay5weQpAQCAtMzgsNiArMzgsOSBAQCBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0 Lnh2ZmJkcml2ZXIgaW1wb3J0IFh2ZmJEcml2ZXIKIGNsYXNzIEd0a1BvcnQoUG9ydCwgUHVsc2VB dWRpb1Nhbml0aXplcik6CiAgICAgcG9ydF9uYW1lID0gImd0ayIKIAorICAgIGRlZiBleHBlY3Rh dGlvbnNfZmlsZXMoc2VsZik6CisgICAgICAgIHJldHVybiBbc2VsZi5fZmlsZXN5c3RlbS5qb2lu KHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKGQpLCAnVGVzdEV4cGVjdGF0aW9ucycpIGZvciBk IGluIHNlbGYuX3NraXBwZWRfZmlsZV9zZWFyY2hfcGF0aHMoKV0KKwogICAgIGRlZiBfcG9ydF9m bGFnX2Zvcl9zY3JpcHRzKHNlbGYpOgogICAgICAgICByZXR1cm4gIi0tZ3RrIgogCg==