96997 2012-09-18 03:56:46 -0700 [Qt][WK2] Focus out is not handled properly 2012-09-25 06:16:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 0 hepaajan michael.bruning abecsi allan.jensen cmarcelo menard michael.bruning pnormand webkit.review.bot zoltan oldest_to_newest 722637 0 hepaajan 2012-09-18 03:56:46 -0700 When (qml) WebView looses focus the focus status is not updated correctly to WebProcess. QtWebPageEventHandler::handleFocusOutEvent calls WebPageProxy::viewStateDidChange which then checks the focus from QtPageClient::isViewFocused. QtPageClient::isViewFocused returns QQuickWebView::hasFocus but the actual "focus" property value has not changed yet and thus it returns true. This can be seen e.g. in MiniBrowser by clicking address bar after launching as the caret is left blinking on google search front page text input. 723595 1 michael.bruning 2012-09-19 08:58:17 -0700 I'll check this. 725537 2 165137 michael.bruning 2012-09-21 08:37:01 -0700 Created attachment 165137 Patch 725538 3 michael.bruning 2012-09-21 08:38:09 -0700 The solution here might be a bit "hacky", but it seems to be the least complicated way. Better suggestions are welcome as always :) 725575 4 allan.jensen 2012-09-21 09:39:07 -0700 Would it possible to set the focus value on the UIProcess side as soon as the event is send to the WebProcess? Focus out shouldn't be an event the WebProcess can block anyway. 726639 5 michael.bruning 2012-09-24 07:31:11 -0700 (In reply to comment #4) > Would it possible to set the focus value on the UIProcess side as soon as the event is send to the WebProcess? Focus out shouldn't be an event the WebProcess can block anyway. It's not really the WebProcess "blocking" the focus, it's the UI process feeding it with the wrong value and hence the FocusController doesn't set the focus on the text element correctly. Anyway, after digging through the focus event handling etc, I have found that virtual void QQuickItem::itemChange(ItemChange change, const ItemChangeData &value); is the right method to override here as also e.g. the QQuickTextInput uses that for deciding about lost focus (gaining focus seems to work...). Updated patch coming soon... 726645 6 165379 michael.bruning 2012-09-24 07:36:55 -0700 Created attachment 165379 Patch 726672 7 michael.bruning 2012-09-24 08:11:20 -0700 As already correctly noted by Simon on irc, the call to QQuickItem::itemChange() will be changed to QQuickFlickable::itemChange(). 727417 8 165559 michael.bruning 2012-09-25 01:55:54 -0700 Created attachment 165559 Patch 727549 9 165592 michael.bruning 2012-09-25 05:40:35 -0700 Created attachment 165592 Patch 727568 10 165592 webkit.review.bot 2012-09-25 06:16:05 -0700 Comment on attachment 165592 Patch Clearing flags on attachment: 165592 Committed r129496: <http://trac.webkit.org/changeset/129496> 727570 11 webkit.review.bot 2012-09-25 06:16:08 -0700 All reviewed patches have been landed. Closing bug. 165137 2012-09-21 08:37:01 -0700 2012-09-24 07:36:51 -0700 Patch bug-96997-20120921173625.patch text/plain 4541 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWQ0YWJhODZmNDllYjFm Yjk2NTAyNGQyNzk5Njg4NGMxOTk2NzUyZC4uNDQ1MjU5ZDNkZTc1Zjc0NDM3MTViZmFiZjhhMGEx Mjc1OTY3NWRhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA5LTIxICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gRm9jdXMgb3V0IGlzIG5vdCBoYW5kbGVkIHByb3Blcmx5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY5OTcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIGEgYm9vbGVhbiBwbHVzIGFjY2Vz c29yIHRvIFFRdWlja1dlYlZpZXcgdG8ga2VlcCB0cmFjaworICAgICAgICB3aGV0aGVyIGEgZm9j dXNPdXRFdmVudCBpcyBiZWluZyBwcm9jZXNzZWQgdG8gYmUgYWJsZSB0byBzZW5kCisgICAgICAg IHRoZSBjb3JyZWN0IGZvY3VzIGluZm9ybWF0aW9uIHRvIHRoZSBXZWJQcm9jZXNzLiBUaGlzIGlz IGEgYml0CisgICAgICAgIGhhY2t5LCBidXQgc2VlbXMgdG8gYmUgdGhlIGxlYXN0IGNvbXBsaWNh dGVkIC8gZXJyb3IgcHJvbmUgd2F5CisgICAgICAgIHRvIGRvIHRoaXMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmll d1ByaXZhdGU6OlFRdWlja1dlYlZpZXdQcml2YXRlKToKKyAgICAgICAgKFFRdWlja1dlYlZpZXc6 OmZvY3VzT3V0RXZlbnQpOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6aXNQcm9jZXNzaW5nRm9j dXNPdXRFdmVudCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3Au aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmg6CisgICAg ICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0UGFn ZUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0UGFnZUNsaWVudDo6aXNWaWV3Rm9jdXNl ZCk6CisKIDIwMTItMDktMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBXZWJLaXRXZWJWaWV3OmlzLWxvYWRpbmcgcHJvcGVy dHkgdG8gV2ViS2l0MiBHVEsrIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggODBmMWJhN2YwYjkxNWE2ZTJjMTFhNGVhMWNj OTA0YmQ4Njk0ZTE3NC4uZmM1ZmYyYWRjOGJhMjczZjAxYzJmMTUzYjU4ZmY5YTQ1OTlhNTI0ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcu Y3BwCkBAIC0yNzQsNiArMjc0LDcgQEAgUVF1aWNrV2ViVmlld1ByaXZhdGU6OlFRdWlja1dlYlZp ZXdQcml2YXRlKFFRdWlja1dlYlZpZXcqIHZpZXdwb3J0KQogICAgICwgbV9hbGxvd0FueUhUVFBT Q2VydGlmaWNhdGVGb3JMb2NhbEhvc3QoZmFsc2UpCiAgICAgLCBtX2N1c3RvbURldmljZVBpeGVs UmF0aW8oMCkKICAgICAsIG1fbG9hZFByb2dyZXNzKDApCisgICAgLCBtX2lzUHJvY2Vzc2luZ0Zv Y3VzT3V0RXZlbnQoZmFsc2UpCiB7CiAgICAgdmlld3BvcnQtPnNldENsaXAodHJ1ZSk7CiAgICAg dmlld3BvcnQtPnNldFBpeGVsQWxpZ25lZCh0cnVlKTsKQEAgLTE4NjAsNyArMTg2MSw5IEBAIHZv aWQgUVF1aWNrV2ViVmlldzo6Zm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50KiBldmVudCkKIHZvaWQg UVF1aWNrV2ViVmlldzo6Zm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCogZXZlbnQpCiB7CiAgICAg UV9EKFFRdWlja1dlYlZpZXcpOworICAgIGQtPm1faXNQcm9jZXNzaW5nRm9jdXNPdXRFdmVudCA9 IHRydWU7CiAgICAgZC0+cGFnZVZpZXctPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVGb2N1c091dEV2 ZW50KGV2ZW50KTsKKyAgICBkLT5tX2lzUHJvY2Vzc2luZ0ZvY3VzT3V0RXZlbnQgPSBmYWxzZTsK IH0KIAogdm9pZCBRUXVpY2tXZWJWaWV3Ojp0b3VjaEV2ZW50KFFUb3VjaEV2ZW50KiBldmVudCkK QEAgLTIwNzQsNiArMjA3NywxMiBAQCB2b2lkIFFRdWlja1dlYlZpZXc6OnNldEFsbG93QW55SFRU UFNDZXJ0aWZpY2F0ZUZvckxvY2FsSG9zdChib29sIGFsbG93KQogICAgIGQtPm1fYWxsb3dBbnlI VFRQU0NlcnRpZmljYXRlRm9yTG9jYWxIb3N0ID0gYWxsb3c7CiB9CiAKK2Jvb2wgUVF1aWNrV2Vi Vmlldzo6aXNQcm9jZXNzaW5nRm9jdXNPdXRFdmVudCgpIGNvbnN0Cit7CisgICAgUV9EKGNvbnN0 IFFRdWlja1dlYlZpZXcpOworICAgIHJldHVybiBkLT5tX2lzUHJvY2Vzc2luZ0ZvY3VzT3V0RXZl bnQ7Cit9CisKIC8qIQogICAgIFxxbWxzaWduYWwgV2ViVmlldzo6b25Mb2FkaW5nQ2hhbmdlZChs b2FkUmVxdWVzdCkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3X3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlld19wLmgKaW5kZXggNWZlYjRiNDVhNDIxNDM3OTU4NjIyY2ZmYWJlMGU1MDYwNjg1 NzAyNi4uMTU2YjdhODkzYWVmYjVkNGFiMzYzYTRjOTlkZDlmMmY2ZTI3MzQ5NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCkBAIC0x NTEsNiArMTUxLDcgQEAgcHVibGljOgogICAgIC8vIFVzZWQgdG8gYXV0b21hdGljYWxseSBhY2Nl cHQgdGhlIEhUVFBTIGNlcnRpZmljYXRlIGluIFdUUi4gTm8gb3RoZXIgdXNlIGludGVuZGVkLgog ICAgIGJvb2wgYWxsb3dBbnlIVFRQU0NlcnRpZmljYXRlRm9yTG9jYWxIb3N0KCkgY29uc3Q7CiAg ICAgdm9pZCBzZXRBbGxvd0FueUhUVFBTQ2VydGlmaWNhdGVGb3JMb2NhbEhvc3QoYm9vbCBhbGxv dyk7CisgICAgYm9vbCBpc1Byb2Nlc3NpbmdGb2N1c091dEV2ZW50KCkgY29uc3Q7CiAKIHB1Ymxp YyBRX1NMT1RTOgogICAgIHZvaWQgbG9hZEh0bWwoY29uc3QgUVN0cmluZyYgaHRtbCwgY29uc3Qg UVVybCYgYmFzZVVybCA9IFFVcmwoKSwgY29uc3QgUVVybCYgdW5yZWFjaGFibGVVcmwgPSBRVXJs KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3X3BfcC5oCmluZGV4IGExNTRkYThmNWQwMWI1ZmNhMDk3Nzk1ZmE0ZTljYTg3ODkwZWUxMDcu LjRlYzUwODYyMTMzOTQ1NzY0NTk3NGVkODAyZjMzYjQ2YjNhOTBiNmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKQEAgLTE5 OCw2ICsxOTgsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgV1RGOjpTdHJpbmcgbV9pY29uVXJsOwogICAg IGludCBtX2xvYWRQcm9ncmVzczsKICAgICBXVEY6OlN0cmluZyBtX2N1cnJlbnRVcmw7CisgICAg Ym9vbCBtX2lzUHJvY2Vzc2luZ0ZvY3VzT3V0RXZlbnQ7CiB9OwogCiBjbGFzcyBRUXVpY2tXZWJW aWV3TGVnYWN5UHJpdmF0ZSA6IHB1YmxpYyBRUXVpY2tXZWJWaWV3UHJpdmF0ZSB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3BwCmluZGV4IGQ1YTVmN2VjZTM3 MDQzOTEwZjdkNzc5MDE0ZTNmMzFjYzEzOTUwYWUuLjA1OTAzNTM5NzA1ZWE0MTY5ZDhjNWY4MTgz NjQ4MzM0NjgzNDM5MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFBhZ2VDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VD bGllbnQuY3BwCkBAIC0yNzgsNyArMjc4LDcgQEAgYm9vbCBRdFBhZ2VDbGllbnQ6OmlzVmlld0Zv Y3VzZWQoKQogewogICAgIGlmICghbV93ZWJWaWV3KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgcmV0dXJuIG1fd2ViVmlldy0+aGFzRm9jdXMoKTsKKyAgICByZXR1cm4gbV93ZWJWaWV3LT5o YXNGb2N1cygpICYmICFtX3dlYlZpZXctPmlzUHJvY2Vzc2luZ0ZvY3VzT3V0RXZlbnQoKTsKIH0K IAogYm9vbCBRdFBhZ2VDbGllbnQ6OmlzVmlld1Zpc2libGUoKQo= 165379 2012-09-24 07:36:55 -0700 2012-09-25 01:55:49 -0700 Patch bug-96997-20120924163616.patch text/plain 2624 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDllZWE0NDI2MWFjNGUx NzUzZTYwNjEzNmY4NTY2MWM1YWFlNjFkMS4uYWI0ODg0NWM5YjZkNTgzYTAzNzI4NDgzNzc5NDg4 YWYwN2Q4MWQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTI0ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gRm9jdXMgb3V0IGlzIG5vdCBoYW5kbGVkIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBoYW5kbGVyIGZvciB0aGUgaXRl bUNoYW5nZSBldmVudCB0aGF0IGlzIHNlbnQgdG8gCisgICAgICAgIFFRdWlja0l0ZW0gd2hlbiBm b2N1cyBoYXMgYmVlbiB1cGRhdGVkLiBUaGlzIGZpeGVzIHRoZSBwcm9ibGVtCisgICAgICAgIGJl Y2F1c2UgdGhlIGZvY3VzIGhhcyBhbHJlYWR5IGJlZW4gdXBkYXRlZCB3aGVuIHRoZSBldmVudCBp cyBzZW50CisgICAgICAgIGFzIG9wcG9zZWQgdG8gaGFuZGxpbmcgdGhlIGluIHRoZSBmb2N1c091 dEV2ZW50IGhhbmRsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZp ZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6aXRlbUNoYW5nZSk6IEFkZGVkLgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmg6CisKIDIwMTItMDktMjMg IFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3b25Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1b V0syXSBBZGQgc2V0dGluZyB0byB0b2dnbGUgZGV2ZWxvcGVyIGV4dGVuc2lvbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IDgw ZjFiYTdmMGI5MTVhNmUyYzExYTRlYTFjYzkwNGJkODY5NGUxNzQuLjhjZTkxZWViMDQ5ZTExMTBl MGJlNjk0ODc1NGE5Yjg0ZGU1NGMyMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtMTg2Myw2ICsxODYzLDE3IEBAIHZvaWQg UVF1aWNrV2ViVmlldzo6Zm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCogZXZlbnQpCiAgICAgZC0+ cGFnZVZpZXctPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVGb2N1c091dEV2ZW50KGV2ZW50KTsKIH0K IAordm9pZCBRUXVpY2tXZWJWaWV3OjppdGVtQ2hhbmdlKEl0ZW1DaGFuZ2UgY2hhbmdlLCBjb25z dCBJdGVtQ2hhbmdlRGF0YSAmdmFsdWUpCit7CisgICAgUV9EKFFRdWlja1dlYlZpZXcpOworICAg IGlmIChjaGFuZ2UgPT0gSXRlbUFjdGl2ZUZvY3VzSGFzQ2hhbmdlZCkgeworICAgICAgICBib29s IGZvY3VzID0gdmFsdWUuYm9vbFZhbHVlOworICAgICAgICBpZiAoIWZvY3VzKQorICAgICAgICAg ICAgZC0+cGFnZVZpZXctPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVGb2N1c091dEV2ZW50KDApOwor ICAgIH0KKyAgICBRUXVpY2tJdGVtOjppdGVtQ2hhbmdlKGNoYW5nZSwgdmFsdWUpOworfQorCiB2 b2lkIFFRdWlja1dlYlZpZXc6OnRvdWNoRXZlbnQoUVRvdWNoRXZlbnQqIGV2ZW50KQogewogICAg IFFfRChRUXVpY2tXZWJWaWV3KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXdfcC5oCmluZGV4IDVmZWI0YjQ1YTQyMTQzNzk1ODYyMmNmZmFiZTBl NTA2MDY4NTcwMjYuLmY1MjliNDU2ODg0MWU3NTMyZjExMzkyOTY2YjdjNzQwNGFhMzljMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19w LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3Au aApAQCAtMTc5LDYgKzE3OSw3IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgaW5wdXRN ZXRob2RFdmVudChRSW5wdXRNZXRob2RFdmVudCopOwogICAgIHZpcnR1YWwgdm9pZCBmb2N1c0lu RXZlbnQoUUZvY3VzRXZlbnQqKTsKICAgICB2aXJ0dWFsIHZvaWQgZm9jdXNPdXRFdmVudChRRm9j dXNFdmVudCopOworICAgIHZpcnR1YWwgdm9pZCBpdGVtQ2hhbmdlKEl0ZW1DaGFuZ2UgY2hhbmdl LCBjb25zdCBJdGVtQ2hhbmdlRGF0YSAmdmFsdWUpOwogICAgIHZpcnR1YWwgdm9pZCB0b3VjaEV2 ZW50KFFUb3VjaEV2ZW50Kik7CiAgICAgdmlydHVhbCB2b2lkIG1vdXNlUHJlc3NFdmVudChRTW91 c2VFdmVudCopOwogICAgIHZpcnR1YWwgdm9pZCBtb3VzZU1vdmVFdmVudChRTW91c2VFdmVudCop Owo= 165559 2012-09-25 01:55:54 -0700 2012-09-25 05:40:30 -0700 Patch bug-96997-20120925105514.patch text/plain 2652 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTQ4MTQwNTY2YWYyMjM5 MTdmNGVkNzljY2U0NWI5OWIzMjRhMjM5Zi4uY2Q5MDU2NTVkYjYxNjA5ZTFhMmEwOGZiMGYxZWM1 ZDhjZmRiNjhiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTI0ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gRm9jdXMgb3V0IGlzIG5vdCBoYW5kbGVkIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBoYW5kbGVyIGZvciB0aGUgaXRl bUNoYW5nZSBldmVudCB0aGF0IGlzIHNlbnQgdG8gYQorICAgICAgICBRUXVpY2tJdGVtIHdoZW4g aXRzIGZvY3VzIGhhcyBiZWVuIHVwZGF0ZWQuIFRoaXMgZml4ZXMgdGhlIHByb2JsZW0KKyAgICAg ICAgYmVjYXVzZSB0aGUgZm9jdXMgaGFzIGFscmVhZHkgYmVlbiB1cGRhdGVkIHdoZW4gdGhlIGV2 ZW50IGlzIHNlbnQKKyAgICAgICAgYXMgb3Bwb3NlZCB0byBoYW5kbGluZyB0aGUgaW4gdGhlIGZv Y3VzT3V0RXZlbnQgaGFuZGxlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3OjppdGVtQ2hhbmdlKTogQWRkZWQu CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaDoKKwogMjAxMi0w OS0yNCAgQm8gTGl1ICA8Ym9saXVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbGFuZCAiQWRk IGluLXBsYWNlIHJlbG9hZCBiZWhhdmlvciB0byBJbWFnZXNFbmFibGVkIHNldHRpbmciIHdpdGgg b3B0aW1pemF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHAKaW5kZXggODBmMWJhN2YwYjkxNWE2ZTJjMTFhNGVhMWNjOTA0YmQ4Njk0 ZTE3NC4uYjY1NGMyMjAzNzcxM2QxNzUzMmViOWFkZmUxM2UxOGQ2MGVjNDUxZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0x ODYzLDYgKzE4NjMsMTcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3Ojpmb2N1c091dEV2ZW50KFFGb2N1 c0V2ZW50KiBldmVudCkKICAgICBkLT5wYWdlVmlldy0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZUZv Y3VzT3V0RXZlbnQoZXZlbnQpOwogfQogCit2b2lkIFFRdWlja1dlYlZpZXc6Oml0ZW1DaGFuZ2Uo SXRlbUNoYW5nZSBjaGFuZ2UsIGNvbnN0IEl0ZW1DaGFuZ2VEYXRhICZ2YWx1ZSkKK3sKKyAgICBR X0QoUVF1aWNrV2ViVmlldyk7CisgICAgaWYgKGNoYW5nZSA9PSBJdGVtQWN0aXZlRm9jdXNIYXND aGFuZ2VkKSB7CisgICAgICAgIGJvb2wgZm9jdXMgPSB2YWx1ZS5ib29sVmFsdWU7CisgICAgICAg IGlmICghZm9jdXMpCisgICAgICAgICAgICBkLT5wYWdlVmlldy0+ZXZlbnRIYW5kbGVyKCktPmhh bmRsZUZvY3VzT3V0RXZlbnQoMCk7CisgICAgfQorICAgIFFRdWlja0ZsaWNrYWJsZTo6aXRlbUNo YW5nZShjaGFuZ2UsIHZhbHVlKTsKK30KKwogdm9pZCBRUXVpY2tXZWJWaWV3Ojp0b3VjaEV2ZW50 KFFUb3VjaEV2ZW50KiBldmVudCkKIHsKICAgICBRX0QoUVF1aWNrV2ViVmlldyk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaAppbmRleCA1 ZmViNGI0NWE0MjE0Mzc5NTg2MjJjZmZhYmUwZTUwNjA2ODU3MDI2Li5mNTI5YjQ1Njg4NDFlNzUz MmYxMTM5Mjk2NmI3Yzc0MDRhYTM5YzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmgKQEAgLTE3OSw2ICsxNzksNyBAQCBwcm90ZWN0 ZWQ6CiAgICAgdmlydHVhbCB2b2lkIGlucHV0TWV0aG9kRXZlbnQoUUlucHV0TWV0aG9kRXZlbnQq KTsKICAgICB2aXJ0dWFsIHZvaWQgZm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50Kik7CiAgICAgdmly dHVhbCB2b2lkIGZvY3VzT3V0RXZlbnQoUUZvY3VzRXZlbnQqKTsKKyAgICB2aXJ0dWFsIHZvaWQg aXRlbUNoYW5nZShJdGVtQ2hhbmdlIGNoYW5nZSwgY29uc3QgSXRlbUNoYW5nZURhdGEgJnZhbHVl KTsKICAgICB2aXJ0dWFsIHZvaWQgdG91Y2hFdmVudChRVG91Y2hFdmVudCopOwogICAgIHZpcnR1 YWwgdm9pZCBtb3VzZVByZXNzRXZlbnQoUU1vdXNlRXZlbnQqKTsKICAgICB2aXJ0dWFsIHZvaWQg bW91c2VNb3ZlRXZlbnQoUU1vdXNlRXZlbnQqKTsK 165592 2012-09-25 05:40:35 -0700 2012-09-25 06:16:05 -0700 Patch bug-96997-20120925143954.patch text/plain 4577 michael.bruning U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTQ4MTQwNTY2YWYyMjM5 MTdmNGVkNzljY2U0NWI5OWIzMjRhMjM5Zi4uMGMzMjMxMmJjZDg3MWVjYzg5MDQzOWM0OWM1MTQ4 MzgxNGVkNGQ0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA5LTI1ICBNaWNo YWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KKworICAgICAgICBbUXRd W1dLMl0gRm9jdXMgb3V0IGlzIG5vdCBoYW5kbGVkIHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBoYW5kbGVyIGZvciBRUXVpY2tX ZWJWaWV3OjppdGVtQ2hhbmdlIGV2ZW50IHRoYXQgaXMgc2VudCB0bworICAgICAgICBRUXVpY2tJ dGVtcyB3aGVuIHRoZWlyIGZvY3VzIGhhcyBiZWVuIGNoYW5nZWQgdG8gcmVwbGFjZSBmb2N1c091 dEV2ZW50LgorCisgICAgICAgIFRoaXMgZml4ZXMgdGhlIHByb2JsZW0gYmVjYXVzZSB0aGUgZm9j dXMgaGFzIGJlZW4gdXBkYXRlZCB3aGVuCisgICAgICAgIGl0ZW1DaGFuZ2UgaXMgY2FsbGVkLCB3 aGlsZSBpdCBpcyBub3QgeWV0IHVwZGF0ZSB3aGVuIGZvY3VzT3V0RXZlbnQKKyAgICAgICAgaXMg Y2FsbGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcDog UmVtb3ZlZCBmb2N1c091dEV2ZW50LgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6aXRlbUNoYW5n ZSk6IEFkZGVkIGluIHBsYWNlIG9mIGZvY3VzT3V0RXZlbnQuCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQ YWdlRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRXZWJQYWdlRXZlbnRIYW5k bGVyOjpoYW5kbGVGb2N1c0xvc3QpOiBSZW5hbWVkIGZyb20gaGFuZGxlRm9jdXNPdXRFdmVudCwg cGFyYW1ldGVyIHJlbW92ZWQuCisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50 SGFuZGxlci5oOgorICAgICAgICAoUXRXZWJQYWdlRXZlbnRIYW5kbGVyKToKKwogMjAxMi0wOS0y NCAgQm8gTGl1ICA8Ym9saXVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbGFuZCAiQWRkIGlu LXBsYWNlIHJlbG9hZCBiZWhhdmlvciB0byBJbWFnZXNFbmFibGVkIHNldHRpbmciIHdpdGggb3B0 aW1pemF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x cXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlldy5jcHAKaW5kZXggODBmMWJhN2YwYjkxNWE2ZTJjMTFhNGVhMWNjOTA0YmQ4Njk0ZTE3 NC4uZWUwZmY5NWFjNzY0NTdiODk5M2ZlZTI3MWMyMzQ3NWMzZmJkYzg5NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC0xODU3 LDEwICsxODU3LDE1IEBAIHZvaWQgUVF1aWNrV2ViVmlldzo6Zm9jdXNJbkV2ZW50KFFGb2N1c0V2 ZW50KiBldmVudCkKICAgICBkLT5wYWdlVmlldy0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZUZvY3Vz SW5FdmVudChldmVudCk7CiB9CiAKLXZvaWQgUVF1aWNrV2ViVmlldzo6Zm9jdXNPdXRFdmVudChR Rm9jdXNFdmVudCogZXZlbnQpCit2b2lkIFFRdWlja1dlYlZpZXc6Oml0ZW1DaGFuZ2UoSXRlbUNo YW5nZSBjaGFuZ2UsIGNvbnN0IEl0ZW1DaGFuZ2VEYXRhICZ2YWx1ZSkKIHsKICAgICBRX0QoUVF1 aWNrV2ViVmlldyk7Ci0gICAgZC0+cGFnZVZpZXctPmV2ZW50SGFuZGxlcigpLT5oYW5kbGVGb2N1 c091dEV2ZW50KGV2ZW50KTsKKyAgICBpZiAoY2hhbmdlID09IEl0ZW1BY3RpdmVGb2N1c0hhc0No YW5nZWQpIHsKKyAgICAgICAgYm9vbCBmb2N1cyA9IHZhbHVlLmJvb2xWYWx1ZTsKKyAgICAgICAg aWYgKCFmb2N1cykKKyAgICAgICAgICAgIGQtPnBhZ2VWaWV3LT5ldmVudEhhbmRsZXIoKS0+aGFu ZGxlRm9jdXNMb3N0KCk7CisgICAgfQorICAgIFFRdWlja0ZsaWNrYWJsZTo6aXRlbUNoYW5nZShj aGFuZ2UsIHZhbHVlKTsKIH0KIAogdm9pZCBRUXVpY2tXZWJWaWV3Ojp0b3VjaEV2ZW50KFFUb3Vj aEV2ZW50KiBldmVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlld19wLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Fx dWlja3dlYnZpZXdfcC5oCmluZGV4IDVmZWI0YjQ1YTQyMTQzNzk1ODYyMmNmZmFiZTBlNTA2MDY4 NTcwMjYuLmU4YjFiZjdhMTBiYzkzZjUyNmEwODI3NDhlYmIwMTk4ZmI2YmM4ZTggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaApAQCAt MTc4LDcgKzE3OCw3IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQga2V5UmVsZWFzZUV2 ZW50KFFLZXlFdmVudCopOwogICAgIHZpcnR1YWwgdm9pZCBpbnB1dE1ldGhvZEV2ZW50KFFJbnB1 dE1ldGhvZEV2ZW50Kik7CiAgICAgdmlydHVhbCB2b2lkIGZvY3VzSW5FdmVudChRRm9jdXNFdmVu dCopOwotICAgIHZpcnR1YWwgdm9pZCBmb2N1c091dEV2ZW50KFFGb2N1c0V2ZW50Kik7CisgICAg dmlydHVhbCB2b2lkIGl0ZW1DaGFuZ2UoSXRlbUNoYW5nZSBjaGFuZ2UsIGNvbnN0IEl0ZW1DaGFu Z2VEYXRhICZ2YWx1ZSk7CiAgICAgdmlydHVhbCB2b2lkIHRvdWNoRXZlbnQoUVRvdWNoRXZlbnQq KTsKICAgICB2aXJ0dWFsIHZvaWQgbW91c2VQcmVzc0V2ZW50KFFNb3VzZUV2ZW50Kik7CiAgICAg dmlydHVhbCB2b2lkIG1vdXNlTW92ZUV2ZW50KFFNb3VzZUV2ZW50Kik7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCmluZGV4 IDY0YmNkYmRmOWY0ZGUzNmM4ZTBiOGQ0NGU1ZjdmYjM1MzI5M2Q4MTkuLjgxOWQ0YTBhMmI4ZWIy MDE0NmI3OWZkYmViNzVjNDMxZmZiZGYwY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwCkBAIC0zMDAsNyArMzAwLDcg QEAgdm9pZCBRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OmhhbmRsZUZvY3VzSW5FdmVudChRRm9jdXNF dmVudCopCiAgICAgbV93ZWJQYWdlUHJveHktPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJv eHk6OlZpZXdJc0ZvY3VzZWQgfCBXZWJQYWdlUHJveHk6OlZpZXdXaW5kb3dJc0FjdGl2ZSk7CiB9 CiAKLXZvaWQgUXRXZWJQYWdlRXZlbnRIYW5kbGVyOjpoYW5kbGVGb2N1c091dEV2ZW50KFFGb2N1 c0V2ZW50KikKK3ZvaWQgUXRXZWJQYWdlRXZlbnRIYW5kbGVyOjpoYW5kbGVGb2N1c0xvc3QoKQog ewogICAgIG1fd2ViUGFnZVByb3h5LT52aWV3U3RhdGVEaWRDaGFuZ2UoV2ViUGFnZVByb3h5OjpW aWV3SXNGb2N1c2VkIHwgV2ViUGFnZVByb3h5OjpWaWV3V2luZG93SXNBY3RpdmUpOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxl ci5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5o CmluZGV4IDg3MjRmMmVkZTliMDA4ZDdmNjRhYmJkZDQwYTkxMWY4YzY4Y2EyZDUuLjA0Yzc1YWIz ZjRmMDYzYTRmMzQ5Njg4NjQ4ZTYxOTBhNjYyNmNmMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmgKQEAgLTYxLDcgKzYxLDcg QEAgcHVibGljOgogICAgIHZvaWQgaGFuZGxlS2V5UHJlc3NFdmVudChRS2V5RXZlbnQqKTsKICAg ICB2b2lkIGhhbmRsZUtleVJlbGVhc2VFdmVudChRS2V5RXZlbnQqKTsKICAgICB2b2lkIGhhbmRs ZUZvY3VzSW5FdmVudChRRm9jdXNFdmVudCopOwotICAgIHZvaWQgaGFuZGxlRm9jdXNPdXRFdmVu dChRRm9jdXNFdmVudCopOworICAgIHZvaWQgaGFuZGxlRm9jdXNMb3N0KCk7CiAgICAgdm9pZCBo YW5kbGVNb3VzZU1vdmVFdmVudChRTW91c2VFdmVudCopOwogICAgIHZvaWQgaGFuZGxlTW91c2VQ cmVzc0V2ZW50KFFNb3VzZUV2ZW50Kik7CiAgICAgdm9pZCBoYW5kbGVNb3VzZVJlbGVhc2VFdmVu dChRTW91c2VFdmVudCopOwo=