96996 2012-09-18 03:38:43 -0700 [GTK] Build is broken without option --enable-unstable-features 2012-09-20 10:56:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia zan mrobinson pnormand zan oldest_to_newest 722632 0 cgarcia 2012-09-18 03:38:43 -0700 It seems that for some reason -DENABLE_VIDEO=1 is not passed to WebCore CPP flags, even though it's enabled in configure. Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:84:5: error: ‘GStreamerGWorld’ in namespace ‘WebCore’ does not name a type 722633 1 pnormand 2012-09-18 03:41:22 -0700 This happens with non-build-webkit builds 722659 2 cgarcia 2012-09-18 04:41:10 -0700 (In reply to comment #1) > This happens with non-build-webkit builds Because build-webkit always uses --enable-unstable-features 722684 3 zan 2012-09-18 05:19:26 -0700 I'll see into it. 722734 4 164546 jay.bhaskar 2012-09-18 06:40:22 -0700 Created attachment 164546 this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags Build will pass without --enable-unstable-features by this one line changes in Source/WebCore/GNUmakefile.am 722844 5 164574 zan 2012-09-18 09:11:23 -0700 Created attachment 164574 Patch 722850 6 zan 2012-09-18 09:15:43 -0700 (In reply to comment #5) > Created an attachment (id=164574) [details] > Patch The problem was that with unstable features disabled, ENABLE_VIDEO_TRACK was located in the feature_defines_unstable variable. The ENABLE_VIDEO define was then erroneously found in feature_defines_unstable but the pattern was not possible to obtain from it, so ENABLE_VIDEO feature define was not present in feature_defines nor webcore_cppflags. The fix is simple, when searching for the feature define in overriding variables, we should search for the bare define followed by the equal sign, for instance ENABLE_VIDEO= (which will not match in ENABLE_VIDEO_TRACK anymore). 722890 7 164574 zan 2012-09-18 10:42:33 -0700 Comment on attachment 164574 Patch Clearing flags on attachment: 164574 Committed r128905: <http://trac.webkit.org/changeset/128905> 722891 8 zan 2012-09-18 10:42:38 -0700 All reviewed patches have been landed. Closing bug. 724646 9 164546 pnormand 2012-09-20 10:56:56 -0700 Comment on attachment 164546 this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags Zan fixed this bug. Pulling out obsolete patch out of review queue 164546 2012-09-18 06:40:22 -0700 2012-09-20 10:56:55 -0700 this is a simple patch which passes ENABLE_VIDEO=1 in webore_cpp flags patch text/plain 439 jay.bhaskar SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiAxMjg4NjUpCisrKyBTb3VyY2UvV2Vi Q29yZS9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5KQpAQCAtMTcyLDYgKzE3Miw3IEBAIGVu ZGlmICMgRU5EIFVTRV9MRVZFTERCCiAjIC0tLS0KIGlmIEVOQUJMRV9WSURFTwogZmVhdHVyZV9k ZWZpbmVzX292ZXJyaWRlcyArPSBFTkFCTEVfVklERU89MQord2ViY29yZV9jcHBmbGFncyArPSAt REVOQUJMRV9WSURFTz0xCiBpZiBVU0VfR1NUUkVBTUVSCiBpZiBFTkFCTEVfREVCVUcKIHdlYmNv cmVfY3BwZmxhZ3MgKz0gLURHU1RfRElTQUJMRV9ERVBSRUNBVEVECg== 164574 2012-09-18 09:11:23 -0700 2012-09-18 10:42:33 -0700 Patch bug-96996-20120918091050.patch text/plain 1920 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IwYjc1ZjEwMjEyMjVi MGFmOTNiMmNmOTlhY2NiODhlMDBmZjYyZS4uZjFkMjdmYzhlNjJiNjExMTYwODhkNDc5YmRjNjYy YmYwMGQyNTY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE4ICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gQnVpbGQg aXMgYnJva2VuIHdpdGhvdXQgb3B0aW9uIC0tZW5hYmxlLXVuc3RhYmxlLWZlYXR1cmVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk5NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gc2VhcmNoaW5n IGZvciB0aGUgYmFyZSBmZWF0dXJlIGRlZmluZSBpbiBmZWF0dXJlX2RlZmluZXNfdW5zdGFibGUg b3IKKyAgICAgICAgZmVhdHVyZV9kZWZpbmVzX292ZXJyaWRlcywgc2VhcmNoIGZvciB0aGUgYmFy ZSBkZWZpbmUgZm9sbG93ZWQgYnkgPSBjaGFyYWN0ZXIuCisgICAgICAgIFRoaXMgYXZvaWRzIGlu Y29ycmVjdGx5IG1hdGNoaW5nIHRoZSBFTkFCTEVfVklERU8gZGVmaW5lIHRvIHRoZSBFTkFCTEVf VklERU9fVFJBQ0sKKyAgICAgICAgb3ZlcnJpZGluZyBkZWZpbmUgKGFuZCB3b3JrcyBhcyB3ZWxs IGZvciBvdGhlciBzaW1pbGFybHkgbmFtZWQgZmVhdHVyZSBkZWZpbmVzKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgLSBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIEdOVW1ha2Vm aWxlLmFtOgorCiAyMDEyLTA5LTE4ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRp Z2lhLmNvbT4KIAogICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBRdCA1IG9uIE1lZUdvIDEu MiBIYXJtYXR0YW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIv U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggNjFmMmQ5ZWQ0YzQ4MjQwZjNjOGQ2 M2ZjMzdkN2Q1ZmRkY2JhNGVjZS4uZTFjNjQ2MmYyNzRmMDkwMDRkYWRlMDJhNTEyN2M3MjRiZmQy NDNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291 cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KQEAgLTM2NSw5ICszNjUsOSBAQCBmZWF0dXJlX2Rl ZmluZXMgKz0gJChzdHJpcCAkKGZvcmVhY2ggYmFyZV9kZWZpbmUsIFwKIAkJCSQoaWYgJChmaW5k c3RyaW5nID0kKGZ2YWx1ZSksJChkZWZpbmUpKSwkKHBhdHN1YnN0ICU9JChmdmFsdWUpLCUsJChk ZWZpbmUpKSkgXAogCQkpIFwKIAkpLCBcCi0JJChpZiAkKGZpbmRzdHJpbmcgJChiYXJlX2RlZmlu ZSksICQoZmVhdHVyZV9kZWZpbmVzX3Vuc3RhYmxlKSksIFwKKwkkKGlmICQoZmluZHN0cmluZyAk KGJhcmVfZGVmaW5lKT0sICQoZmVhdHVyZV9kZWZpbmVzX3Vuc3RhYmxlKSksIFwKIAkJJChmaWx0 ZXIgJChiYXJlX2RlZmluZSk9JSwkKGZlYXR1cmVfZGVmaW5lc191bnN0YWJsZSkpLCBcCi0JCSQo aWYgJChmaW5kc3RyaW5nICQoYmFyZV9kZWZpbmUpLCAkKGZlYXR1cmVfZGVmaW5lc19vdmVycmlk ZXMpKSwgXAorCQkkKGlmICQoZmluZHN0cmluZyAkKGJhcmVfZGVmaW5lKT0sICQoZmVhdHVyZV9k ZWZpbmVzX292ZXJyaWRlcykpLCBcCiAJCQkkKGZpbHRlciAkKGJhcmVfZGVmaW5lKT0lLCQoZmVh dHVyZV9kZWZpbmVzX292ZXJyaWRlcykpLCBcCiAJCQkkKGZpbHRlciAkKGJhcmVfZGVmaW5lKT0l LCQoZmVhdHVyZV9kZWZpbmVzX2RlZmF1bHRzKSkgXAogCQkpIFwK