96987 2012-09-18 00:43:02 -0700 DFGOperations doesn't use NativeCallFrameTracer in enough places 2012-09-18 08:22:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 96983 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver webkit.review.bot oldest_to_newest 722561 0 fpizlo 2012-09-18 00:43:02 -0700 Anything that may GC should use it. 722565 1 164508 fpizlo 2012-09-18 00:46:31 -0700 Created attachment 164508 the patch 722796 2 mhahnenberg 2012-09-18 08:16:52 -0700 r=me 722808 3 164508 webkit.review.bot 2012-09-18 08:22:06 -0700 Comment on attachment 164508 the patch Clearing flags on attachment: 164508 Committed r128898: <http://trac.webkit.org/changeset/128898> 722809 4 webkit.review.bot 2012-09-18 08:22:09 -0700 All reviewed patches have been landed. Closing bug. 164508 2012-09-18 00:46:31 -0700 2012-09-18 08:22:05 -0700 the patch nativecall_patch_1.diff text/plain 5798 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4ODU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA5LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHT3BlcmF0aW9ucyBkb2Vzbid0IHVzZSBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgaW4gZW5vdWdo IHBsYWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTY5ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bnl0aGluZyB0aGF0IGNhbiBHQyBzaG91bGQgdXNlIGl0LgorCisgICAgICAgICogZGZnL0RGR09w ZXJhdGlvbnMuY3BwOgorCiAyMDEyLTA5LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IHNsb3BweSBFbmdsaXNoIGluIGNvbW1lbnQu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJKHJl dmlzaW9uIDEyODgyNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9u cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOTMsOSArMTE5MywxMSBAQCB2b2lkIERGR19PUEVS QVRJT04gb3BlcmF0aW9uVGVhck9mZklubGluCiAKIEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJ T04gb3BlcmF0aW9uR2V0QXJndW1lbnRzTGVuZ3RoKEV4ZWNTdGF0ZSogZXhlYywgaW50MzJfdCBh cmd1bWVudHNSZWdpc3RlcikKIHsKKyAgICBKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEgPSBleGVj LT5nbG9iYWxEYXRhKCk7CisgICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcigmZ2xvYmFs RGF0YSwgZXhlYyk7CiAgICAgLy8gSGVyZSB3ZSBjYW4gYXNzdW1lIHRoYXQgdGhlIGFyZ3VtZXJu dHMgd2VyZSBjcmVhdGVkLiBCZWNhdXNlIG90aGVyd2lzZSB0aGUgSklUIGNvZGUgd291bGQKICAg ICAvLyBoYXZlIG5vdCBtYWRlIHRoaXMgY2FsbC4KLSAgICBJZGVudGlmaWVyIGlkZW50KCZleGVj LT5nbG9iYWxEYXRhKCksICJsZW5ndGgiKTsKKyAgICBJZGVudGlmaWVyIGlkZW50KCZnbG9iYWxE YXRhLCAibGVuZ3RoIik7CiAgICAgSlNWYWx1ZSBiYXNlVmFsdWUgPSBleGVjLT51bmNoZWNrZWRS KGFyZ3VtZW50c1JlZ2lzdGVyKS5qc1ZhbHVlKCk7CiAgICAgUHJvcGVydHlTbG90IHNsb3QoYmFz ZVZhbHVlKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGJhc2VWYWx1ZS5nZXQoZXhlYywg aWRlbnQsIHNsb3QpKTsKQEAgLTEyMDMsNiArMTIwNSw5IEBAIEVuY29kZWRKU1ZhbHVlIERGR19P UEVSQVRJT04gb3BlcmF0aW9uR2UKIAogRW5jb2RlZEpTVmFsdWUgREZHX09QRVJBVElPTiBvcGVy YXRpb25HZXRBcmd1bWVudEJ5VmFsKEV4ZWNTdGF0ZSogZXhlYywgaW50MzJfdCBhcmd1bWVudHNS ZWdpc3RlciwgaW50MzJfdCBpbmRleCkKIHsKKyAgICBKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEg PSBleGVjLT5nbG9iYWxEYXRhKCk7CisgICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcigm Z2xvYmFsRGF0YSwgZXhlYyk7CisKICAgICBKU1ZhbHVlIGFyZ3VtZW50c1ZhbHVlID0gZXhlYy0+ dW5jaGVja2VkUihhcmd1bWVudHNSZWdpc3RlcikuanNWYWx1ZSgpOwogICAgIAogICAgIC8vIElm IHRoZXJlIGFyZSBubyBhcmd1bWVudHMsIGFuZCB3ZSdyZSBhY2Nlc3Npbmcgb3V0IG9mIGJvdW5k cywgdGhlbiB3ZSBoYXZlIHRvIGNyZWF0ZSB0aGUKQEAgLTEyMTYsNiArMTIyMSw5IEBAIEVuY29k ZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gb3BlcmF0aW9uR2UKIEVuY29kZWRKU1ZhbHVlIERGR19P UEVSQVRJT04gb3BlcmF0aW9uR2V0SW5saW5lZEFyZ3VtZW50QnlWYWwoCiAgICAgRXhlY1N0YXRl KiBleGVjLCBpbnQzMl90IGFyZ3VtZW50c1JlZ2lzdGVyLCBJbmxpbmVDYWxsRnJhbWUqIGlubGlu ZUNhbGxGcmFtZSwgaW50MzJfdCBpbmRleCkKIHsKKyAgICBKU0dsb2JhbERhdGEmIGdsb2JhbERh dGEgPSBleGVjLT5nbG9iYWxEYXRhKCk7CisgICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNl cigmZ2xvYmFsRGF0YSwgZXhlYyk7CisKICAgICBKU1ZhbHVlIGFyZ3VtZW50c1ZhbHVlID0gZXhl Yy0+dW5jaGVja2VkUihhcmd1bWVudHNSZWdpc3RlcikuanNWYWx1ZSgpOwogICAgIAogICAgIC8v IElmIHRoZXJlIGFyZSBubyBhcmd1bWVudHMsIGFuZCB3ZSdyZSBhY2Nlc3Npbmcgb3V0IG9mIGJv dW5kcywgdGhlbiB3ZSBoYXZlIHRvIGNyZWF0ZSB0aGUKQEAgLTEyMzksNiArMTI0NywxMCBAQCBK U0NlbGwqIERGR19PUEVSQVRJT04gb3BlcmF0aW9uTmV3RnVuY3RpCiBKU0NlbGwqIERGR19PUEVS QVRJT04gb3BlcmF0aW9uTmV3RnVuY3Rpb25FeHByZXNzaW9uKEV4ZWNTdGF0ZSogZXhlYywgSlND ZWxsKiBmdW5jdGlvbkV4ZWN1dGFibGVBc0NlbGwpCiB7CiAgICAgQVNTRVJUKGZ1bmN0aW9uRXhl Y3V0YWJsZUFzQ2VsbC0+aW5oZXJpdHMoJkZ1bmN0aW9uRXhlY3V0YWJsZTo6c19pbmZvKSk7CisK KyAgICBKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEgPSBleGVjLT5nbG9iYWxEYXRhKCk7CisgICAg TmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcigmZ2xvYmFsRGF0YSwgZXhlYyk7CisKICAgICBG dW5jdGlvbkV4ZWN1dGFibGUqIGZ1bmN0aW9uRXhlY3V0YWJsZSA9CiAgICAgICAgIHN0YXRpY19j YXN0PEZ1bmN0aW9uRXhlY3V0YWJsZSo+KGZ1bmN0aW9uRXhlY3V0YWJsZUFzQ2VsbCk7CiAgICAg cmV0dXJuIEpTRnVuY3Rpb246OmNyZWF0ZShleGVjLCBmdW5jdGlvbkV4ZWN1dGFibGUsIGV4ZWMt PnNjb3BlKCkpOwpAQCAtMTI1Nyw2ICsxMjY5LDggQEAgc2l6ZV90IERGR19PUEVSQVRJT04gb3Bl cmF0aW9uSXNGdW5jdGlvbgogdm9pZCBERkdfT1BFUkFUSU9OIG9wZXJhdGlvblJlYWxsb2NhdGVT dG9yYWdlQW5kRmluaXNoUHV0KEV4ZWNTdGF0ZSogZXhlYywgSlNPYmplY3QqIGJhc2UsIFN0cnVj dHVyZSogc3RydWN0dXJlLCBQcm9wZXJ0eU9mZnNldCBvZmZzZXQsIEVuY29kZWRKU1ZhbHVlIHZh bHVlKQogewogICAgIEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSA9IGV4ZWMtPmdsb2JhbERhdGEo KTsKKyAgICBOYXRpdmVDYWxsRnJhbWVUcmFjZXIgdHJhY2VyKCZnbG9iYWxEYXRhLCBleGVjKTsK KwogICAgIEFTU0VSVChzdHJ1Y3R1cmUtPm91dE9mTGluZUNhcGFjaXR5KCkgPiBiYXNlLT5zdHJ1 Y3R1cmUoKS0+b3V0T2ZMaW5lQ2FwYWNpdHkoKSk7CiAgICAgQVNTRVJUKCFnbG9iYWxEYXRhLmhl YXAuc3RvcmFnZUFsbG9jYXRvcigpLmZhc3RQYXRoU2hvdWxkU3VjY2VlZChzdHJ1Y3R1cmUtPm91 dE9mTGluZUNhcGFjaXR5KCkgKiBzaXplb2YoSlNWYWx1ZSkpKTsKICAgICBiYXNlLT5zZXRTdHJ1 Y3R1cmVBbmRSZWFsbG9jYXRlU3RvcmFnZUlmTmVjZXNzYXJ5KGdsb2JhbERhdGEsIHN0cnVjdHVy ZSk7CkBAIC0xMjY1LDI3ICsxMjc5LDM5IEBAIHZvaWQgREZHX09QRVJBVElPTiBvcGVyYXRpb25S ZWFsbG9jYXRlU3QKIAogY2hhciogREZHX09QRVJBVElPTiBvcGVyYXRpb25BbGxvY2F0ZVByb3Bl cnR5U3RvcmFnZVdpdGhJbml0aWFsQ2FwYWNpdHkoRXhlY1N0YXRlKiBleGVjKQogeworICAgIEpT R2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSA9IGV4ZWMtPmdsb2JhbERhdGEoKTsKKyAgICBOYXRpdmVD YWxsRnJhbWVUcmFjZXIgdHJhY2VyKCZnbG9iYWxEYXRhLCBleGVjKTsKKwogICAgIHJldHVybiBy ZWludGVycHJldF9jYXN0PGNoYXIqPigKLSAgICAgICAgQnV0dGVyZmx5OjpjcmVhdGVVbmluaXRp YWxpemVkKGV4ZWMtPmdsb2JhbERhdGEoKSwgMCwgaW5pdGlhbE91dE9mTGluZUNhcGFjaXR5LCBm YWxzZSwgMCkpOworICAgICAgICBCdXR0ZXJmbHk6OmNyZWF0ZVVuaW5pdGlhbGl6ZWQoZ2xvYmFs RGF0YSwgMCwgaW5pdGlhbE91dE9mTGluZUNhcGFjaXR5LCBmYWxzZSwgMCkpOwogfQogCiBjaGFy KiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKEV4ZWNTdGF0 ZSogZXhlYywgc2l6ZV90IG5ld1NpemUpCiB7CisgICAgSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRh ID0gZXhlYy0+Z2xvYmFsRGF0YSgpOworICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNlciB0cmFjZXIo Jmdsb2JhbERhdGEsIGV4ZWMpOworCiAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+ KAotICAgICAgICBCdXR0ZXJmbHk6OmNyZWF0ZVVuaW5pdGlhbGl6ZWQoZXhlYy0+Z2xvYmFsRGF0 YSgpLCAwLCBuZXdTaXplLCBmYWxzZSwgMCkpOworICAgICAgICBCdXR0ZXJmbHk6OmNyZWF0ZVVu aW5pdGlhbGl6ZWQoZ2xvYmFsRGF0YSwgMCwgbmV3U2l6ZSwgZmFsc2UsIDApKTsKIH0KIAogY2hh ciogREZHX09QRVJBVElPTiBvcGVyYXRpb25SZWFsbG9jYXRlQnV0dGVyZmx5VG9IYXZlUHJvcGVy dHlTdG9yYWdlV2l0aEluaXRpYWxDYXBhY2l0eShFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBv YmplY3QpCiB7CisgICAgSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhID0gZXhlYy0+Z2xvYmFsRGF0 YSgpOworICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNlciB0cmFjZXIoJmdsb2JhbERhdGEsIGV4ZWMp OworCiAgICAgQVNTRVJUKCFvYmplY3QtPnN0cnVjdHVyZSgpLT5vdXRPZkxpbmVDYXBhY2l0eSgp KTsKLSAgICBCdXR0ZXJmbHkqIHJlc3VsdCA9IG9iamVjdC0+Z3Jvd091dE9mTGluZVN0b3JhZ2Uo ZXhlYy0+Z2xvYmFsRGF0YSgpLCAwLCBpbml0aWFsT3V0T2ZMaW5lQ2FwYWNpdHkpOworICAgIEJ1 dHRlcmZseSogcmVzdWx0ID0gb2JqZWN0LT5ncm93T3V0T2ZMaW5lU3RvcmFnZShnbG9iYWxEYXRh LCAwLCBpbml0aWFsT3V0T2ZMaW5lQ2FwYWNpdHkpOwogICAgIG9iamVjdC0+c2V0QnV0dGVyZmx5 V2l0aG91dENoYW5naW5nU3RydWN0dXJlKHJlc3VsdCk7CiAgICAgcmV0dXJuIHJlaW50ZXJwcmV0 X2Nhc3Q8Y2hhcio+KHJlc3VsdCk7CiB9CiAKIGNoYXIqIERGR19PUEVSQVRJT04gb3BlcmF0aW9u UmVhbGxvY2F0ZUJ1dHRlcmZseVRvR3Jvd1Byb3BlcnR5U3RvcmFnZShFeGVjU3RhdGUqIGV4ZWMs IEpTT2JqZWN0KiBvYmplY3QsIHNpemVfdCBuZXdTaXplKQogewotICAgIEJ1dHRlcmZseSogcmVz dWx0ID0gb2JqZWN0LT5ncm93T3V0T2ZMaW5lU3RvcmFnZShleGVjLT5nbG9iYWxEYXRhKCksIG9i amVjdC0+c3RydWN0dXJlKCktPm91dE9mTGluZUNhcGFjaXR5KCksIG5ld1NpemUpOworICAgIEpT R2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSA9IGV4ZWMtPmdsb2JhbERhdGEoKTsKKyAgICBOYXRpdmVD YWxsRnJhbWVUcmFjZXIgdHJhY2VyKCZnbG9iYWxEYXRhLCBleGVjKTsKKworICAgIEJ1dHRlcmZs eSogcmVzdWx0ID0gb2JqZWN0LT5ncm93T3V0T2ZMaW5lU3RvcmFnZShnbG9iYWxEYXRhLCBvYmpl Y3QtPnN0cnVjdHVyZSgpLT5vdXRPZkxpbmVDYXBhY2l0eSgpLCBuZXdTaXplKTsKICAgICBvYmpl Y3QtPnNldEJ1dHRlcmZseVdpdGhvdXRDaGFuZ2luZ1N0cnVjdHVyZShyZXN1bHQpOwogICAgIHJl dHVybiByZWludGVycHJldF9jYXN0PGNoYXIqPihyZXN1bHQpOwogfQo=