96985 2012-09-18 00:11:21 -0700 Propose UNUSED_PARAMS macro 2013-01-03 03:00:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov benjamin gtk-ews gustavo gyuyoung.kim kenneth philn webkit.review.bot xan.lopez oldest_to_newest 722541 0 mikhail.pozdnyakov 2012-09-18 00:11:21 -0700 While being fixing compiler warnings about unused variables (bug96901) I found it useful to have UNUSED_PARAMS macro accepting a list of unused variables in order to safe some lines of code in case when we have to mark several arguments as unused (for instance in case of empty implementation of a method). 722545 1 164505 mikhail.pozdnyakov 2012-09-18 00:22:22 -0700 Created attachment 164505 patch 722570 2 164505 buildbot 2012-09-18 00:51:44 -0700 Comment on attachment 164505 patch Attachment 164505 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13898087 722596 3 164505 benjamin 2012-09-18 01:43:38 -0700 Comment on attachment 164505 patch This is not needed. Our policy is to not put the argument names when they are not used. There is also no need to update URLParser.h, that code will either be implemented or removed entirely. 722609 4 kenneth 2012-09-18 02:23:12 -0700 (In reply to comment #3) > (From update of attachment 164505 [details]) > This is not needed. > Our policy is to not put the argument names when they are not used. There is also no need to update URLParser.h, that code will either be implemented or removed entirely. That is not entirely true for headers through. They are normally added when they add more information. 722615 5 mikhail.pozdnyakov 2012-09-18 02:34:27 -0700 (In reply to comment #3) > (From update of attachment 164505 [details]) > This is not needed. > Our policy is to not put the argument names when they are not used. There is also no need to update URLParser.h, that code will either be implemented or removed entirely. Should than UNUSED_PARAM macro exist in WebKit in principal? or it should be considered as deprecated and will be deleted eventually? 722626 6 164526 mikhail.pozdnyakov 2012-09-18 03:28:29 -0700 Created attachment 164526 patch v2 Should build on gtk and mac 722636 7 164526 gtk-ews 2012-09-18 03:48:27 -0700 Comment on attachment 164526 patch v2 Attachment 164526 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13904118 722884 8 benjamin 2012-09-18 10:23:42 -0700 Unless you have a good use case, I don't think we should add this. Please _do not_ modify URLParser.h. My local version differ significantly. 722925 9 ap 2012-09-18 11:23:08 -0700 I agree with Benjamin. It's unlikely that we have many places to deploy this. 799325 10 mikhail.pozdnyakov 2013-01-03 03:00:05 -0800 close based on previous comments 164505 2012-09-18 00:22:22 -0700 2012-09-18 01:43:38 -0700 patch bug96985 text/plain 2338 mikhail.pozdnyakov Y29tbWl0IGQzYTkxMzc1ZjEwOThlNGM0YjY5YjBjY2ExODU0ZjMxYmUyYTM5MTMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIFNlcCAxOCAxMDoxNTo1MCAyMDEyICswMzAwCgogICAgYnVnOTY5ODUKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhiZjMy NjguLjc5NWMwNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDktMTggIE1pa2hhaWwgUG96 ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgUHJvcG9z ZSBVTlVTRURfUEFSQU1TIG1hY3JvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05Njk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVOVVNFRF9QQVJBTVMgbWFjcm8gYWNjZXB0cyBhIGxpc3Qgb2YgdW51c2Vk IHZhcmlhYmxlcyBhbmQgc2hvdWxkIGJlIHVzZWQgd2hlbiBzZXZlcmFsCisgICAgICAgIGFyZ3Vt ZW50cyBhcmUgdG8gYmUgbWFya2VkIGFzIHVudXNlZCBhdCBvbmNlIChmb3IgaW5zdGFuY2UgaW4g Y2FzZSBvZiBlbXB0eSBpbXBsZW1lbnRhdGlvbiBvZiBhIG1ldGhvZCkKKyAgICAgICAgaW4gb3Jk ZXIgdG8gc2FmZSBzb21lIGxpbmVzIG9mIGNvZGUuCisKKyAgICAgICAgKiB3dGYvVW51c2VkUGFy YW0uaDoKKyAgICAgICAgKHVudXNlZFBhcmFtcyk6CisgICAgICAgICogd3RmL3VybC9zcmMvVVJM UGFyc2VyLmg6IExpdHRsZSBleGFtcGxlIG9mIG5ldyBtYWNybyB1c2FnZS4KKyAgICAgICAgKFdU Rjo6VVJMUGFyc2VyOjpwYXJzZVVSTFdpdGhCYXNlKToKKwogMjAxMi0wOS0xNSAgQmVuamFtaW4g UG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHRoZSBidWlsZCB3 aXRoIFdURiBVUkwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1VudXNlZFBhcmFtLmggYi9T b3VyY2UvV1RGL3d0Zi9VbnVzZWRQYXJhbS5oCmluZGV4IDMxZDcwZTcuLmViN2MwOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1VudXNlZFBhcmFtLmgKKysrIGIvU291cmNlL1dURi93dGYv VW51c2VkUGFyYW0uaApAQCAtNDEsNCArNDEsNyBAQCBpbmxpbmUgdm9pZCB1bnVzZWRQYXJhbShU JiB4KSB7ICh2b2lkKXg7IH0KICNkZWZpbmUgVU5VU0VEX0xBQkVMKGxhYmVsKSBVTlVTRURfUEFS QU0oJiYgbGFiZWwpCiAjZW5kaWYKIAoraW5saW5lIHZvaWQgdW51c2VkUGFyYW1zKC4uLikgeyB9 CisjZGVmaW5lIFVOVVNFRF9QQVJBTVMoLi4uKSB1bnVzZWRQYXJhbXMoX19WQV9BUkdTX18pCisK ICNlbmRpZiAvKiBXVEZfVW51c2VkUGFyYW1faCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvdXJsL3NyYy9VUkxQYXJzZXIuaCBiL1NvdXJjZS9XVEYvd3RmL3VybC9zcmMvVVJMUGFyc2Vy LmgKaW5kZXggMmI0ZDU5OC4uZWFlMDVhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdXJs L3NyYy9VUkxQYXJzZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi91cmwvc3JjL1VSTFBhcnNlci5o CkBAIC0xNzUsMTMgKzE3NSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IEJhc2VDaGFyYWN0ZXJUeXBlKiBiYXNlU3RyaW5nU3BlYywgaW50IGJhc2VT dHJpbmdTcGVjTGVuZ3RoLCBjb25zdCBVUkxTZWdtZW50cyYgYmFzZVN0cmluZ1NlZ21lbnRzLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVVJMQnVmZmVyPGNoYXI+Jm91dHB1dEJ1 ZmZlciwgVVJMU2VnbWVudHMmIHBhcnNlZCkKICAgICB7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShi YXNlU3RyaW5nU3BlYyk7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShiYXNlU3RyaW5nU3BlY0xlbmd0 aCk7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShiYXNlU3RyaW5nU2VnbWVudHMpOwotICAgICAgICBV TlVTRURfUEFSQU0oc3BlYyk7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShzcGVjTGVuZ3RoKTsKLSAg ICAgICAgVU5VU0VEX1BBUkFNKG91dHB1dEJ1ZmZlcik7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShw YXJzZWQpOworICAgICAgICBVTlVTRURfUEFSQU1TKGJhc2VTdHJpbmdTcGVjLCBiYXNlU3RyaW5n U3BlY0xlbmd0aCwgYmFzZVN0cmluZ1NlZ21lbnRzLCBzcGVjLCBzcGVjTGVuZ3RoLCBvdXRwdXRC dWZmZXIsIHBhcnNlZCk7CiAgICAgICAgIC8vIEZJWE1FOiBUbyBpbXBsZW1lbnQuCiAgICAgfQog Cg== 164526 2012-09-18 03:28:29 -0700 2012-09-18 03:49:12 -0700 patch v2 bug96985_v2 text/plain 2405 mikhail.pozdnyakov Y29tbWl0IDczNDYyOTc1NDdlZGQ3ZjZhNTdhNTBkNDU5ZTcyYTVjZjEyMDAzOGUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIFNlcCAxOCAxMDoxNTo1MCAyMDEyICswMzAwCgogICAgYnVnOTY5ODUKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA4MzZj OGUuLjZjODVlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDktMTggIE1pa2hhaWwgUG96 ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgUHJvcG9z ZSBVTlVTRURfUEFSQU1TIG1hY3JvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05Njk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVOVVNFRF9QQVJBTVMgbWFjcm8gYWNjZXB0cyBhIGxpc3Qgb2YgdW51c2Vk IHZhcmlhYmxlcyBhbmQgc2hvdWxkIGJlIHVzZWQgd2hlbiBzZXZlcmFsCisgICAgICAgIGFyZ3Vt ZW50cyBhcmUgdG8gYmUgbWFya2VkIGFzIHVudXNlZCBhdCBvbmNlIChmb3IgaW5zdGFuY2UgaW4g Y2FzZSBvZiBlbXB0eSBpbXBsZW1lbnRhdGlvbiBvZiBhIG1ldGhvZCkKKyAgICAgICAgaW4gb3Jk ZXIgdG8gc2FmZSBzb21lIGxpbmVzIG9mIGNvZGUuCisKKyAgICAgICAgKiB3dGYvVW51c2VkUGFy YW0uaDoKKyAgICAgICAgKHVudXNlZFBhcmFtcyk6CisgICAgICAgICogd3RmL3VybC9zcmMvVVJM UGFyc2VyLmg6CisgICAgICAgIChXVEY6OlVSTFBhcnNlcjo6cGFyc2VVUkxXaXRoQmFzZSk6CisK IDIwMTItMDktMTcgIEdsZW5uIEFkYW1zICA8Z2xlbm5Ac2t5bmF2LmNvbT4KIAogICAgICAgICBJ bmNsdWRpbmcgSGV4TnVtYmVyLmggZmFpbHMgYnVpbGQgaWYgaGV4RGlnaXRzRm9yTW9kZSBpcyBu b3QgcmVmZXJlbmNlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVW51c2VkUGFyYW0uaCBi L1NvdXJjZS9XVEYvd3RmL1VudXNlZFBhcmFtLmgKaW5kZXggMzFkNzBlNy4uODhjODI0NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvVW51c2VkUGFyYW0uaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9VbnVzZWRQYXJhbS5oCkBAIC00MSw0ICs0MSw4IEBAIGlubGluZSB2b2lkIHVudXNlZFBhcmFt KFQmIHgpIHsgKHZvaWQpeDsgfQogI2RlZmluZSBVTlVTRURfTEFCRUwobGFiZWwpIFVOVVNFRF9Q QVJBTSgmJiBsYWJlbCkKICNlbmRpZgogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgoraW5saW5lIHZv aWQgdW51c2VkUGFyYW1zKFQmIHgsIC4uLikgeyBVTlVTRURfUEFSQU0oeCk7IH0KKyNkZWZpbmUg VU5VU0VEX1BBUkFNUyh2YXJpYWJsZSwgLi4uKSB1bnVzZWRQYXJhbXModmFyaWFibGUsIF9fVkFf QVJHU19fKQorCiAjZW5kaWYgLyogV1RGX1VudXNlZFBhcmFtX2ggKi8KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL3VybC9zcmMvVVJMUGFyc2VyLmggYi9Tb3VyY2UvV1RGL3d0Zi91cmwvc3Jj L1VSTFBhcnNlci5oCmluZGV4IDJiNGQ1OTguLmVhZTA1YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL3VybC9zcmMvVVJMUGFyc2VyLmgKKysrIGIvU291cmNlL1dURi93dGYvdXJsL3NyYy9V UkxQYXJzZXIuaApAQCAtMTc1LDEzICsxNzUsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBCYXNlQ2hhcmFjdGVyVHlwZSogYmFzZVN0cmluZ1NwZWMs IGludCBiYXNlU3RyaW5nU3BlY0xlbmd0aCwgY29uc3QgVVJMU2VnbWVudHMmIGJhc2VTdHJpbmdT ZWdtZW50cywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFVSTEJ1ZmZlcjxjaGFy PiZvdXRwdXRCdWZmZXIsIFVSTFNlZ21lbnRzJiBwYXJzZWQpCiAgICAgewotICAgICAgICBVTlVT RURfUEFSQU0oYmFzZVN0cmluZ1NwZWMpOwotICAgICAgICBVTlVTRURfUEFSQU0oYmFzZVN0cmlu Z1NwZWNMZW5ndGgpOwotICAgICAgICBVTlVTRURfUEFSQU0oYmFzZVN0cmluZ1NlZ21lbnRzKTsK LSAgICAgICAgVU5VU0VEX1BBUkFNKHNwZWMpOwotICAgICAgICBVTlVTRURfUEFSQU0oc3BlY0xl bmd0aCk7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShvdXRwdXRCdWZmZXIpOwotICAgICAgICBVTlVT RURfUEFSQU0ocGFyc2VkKTsKKyAgICAgICAgVU5VU0VEX1BBUkFNUyhiYXNlU3RyaW5nU3BlYywg YmFzZVN0cmluZ1NwZWNMZW5ndGgsIGJhc2VTdHJpbmdTZWdtZW50cywgc3BlYywgc3BlY0xlbmd0 aCwgb3V0cHV0QnVmZmVyLCBwYXJzZWQpOwogICAgICAgICAvLyBGSVhNRTogVG8gaW1wbGVtZW50 LgogICAgIH0KIAo=