96975 2012-09-17 20:56:01 -0700 [Gtk] Remove the unused variable warning in GamepadsGtk.cpp using ASSERT_UNUSED macro 2012-09-17 21:37:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage haraken webkit.review.bot oldest_to_newest 722456 0 vivekgalatage 2012-09-17 20:56:01 -0700 The following warning is thrown: ../../Source/WebCore/platform/gtk/GamepadsGtk.cpp: In static member function ‘static gboolean WebCore::GamepadDeviceGtk::readCallback(GObject*, gpointer)’: ../../Source/WebCore/platform/gtk/GamepadsGtk.cpp:85:12: warning: unused variable ‘len’ [-Wunused-variable] This warning can be avoided using the ASSERT_UNUSED macro. Patch to follow. 722460 1 164487 vivekgalatage 2012-09-17 21:06:36 -0700 Created attachment 164487 Patch 722462 2 164487 haraken 2012-09-17 21:17:56 -0700 Comment on attachment 164487 Patch rs=me 722465 3 vivekgalatage 2012-09-17 21:23:39 -0700 (In reply to comment #2) > (From update of attachment 164487 [details]) > rs=me Thank you! 722468 4 164487 webkit.review.bot 2012-09-17 21:37:28 -0700 Comment on attachment 164487 Patch Clearing flags on attachment: 164487 Committed r128848: <http://trac.webkit.org/changeset/128848> 722469 5 webkit.review.bot 2012-09-17 21:37:31 -0700 All reviewed patches have been landed. Closing bug. 164487 2012-09-17 21:06:36 -0700 2012-09-17 21:37:28 -0700 Patch bug-96975-20120918093525.patch text/plain 1392 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODg0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFtHdGtdIFJlbW92 ZSB0aGUgdW51c2VkIHZhcmlhYmxlIHdhcm5pbmcgaW4gR2FtZXBhZHNHdGsuY3BwIHVzaW5nIEFT U0VSVF9VTlVTRUQgbWFjcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk2OTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVwbGFjaW5nIGEgc2ltcGxlIEFTU0VSVCB3aXRoIEFTU0VSVF9VTlVTRUQgdG8g YXZvaWQgdGhlIHdhcm5pbmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHJlZmFjdG9yaW5n IGRvbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvR2FtZXBhZHNHdGsuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6R2FtZXBhZERldmljZUd0azo6cmVhZENhbGxiYWNrKToKKwogMjAxMi0wOS0x NyAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIE51 bGwgY2hlY2sgdGltaW5nIGZ1bmN0aW9uIHJlY2VpdmVkIGZyb20gQ29yZUFuaW1hdGlvbiB3aGVu IGNhbGxpbmcgQ0FDRkFuaW1hdGlvbkdldFRpbWluZ0Z1bmN0aW9uLgpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0dhbWVwYWRzR3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvR2FtZXBhZHNHdGsuY3BwCShyZXZpc2lvbiAxMjg4NDYpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR2FtZXBhZHNHdGsuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05MSw3ICs5MSw3IEBAIGdib29sZWFuIEdhbWVwYWREZXZpY2VHdGs6OnJlYWRDYWxs YmFjaygKICAgICBpZiAoZXJyb3IpCiAgICAgICAgIHJldHVybiBnX2Vycm9yX21hdGNoZXMoZXJy b3IuZ2V0KCksIEdfSU9fRVJST1IsIEdfSU9fRVJST1JfV09VTERfQkxPQ0spOwogCi0gICAgQVNT RVJUKGxlbiA9PSBzaXplb2YoZXZlbnQpKTsKKyAgICBBU1NFUlRfVU5VU0VEKGxlbiwgbGVuID09 IHNpemVvZihldmVudCkpOwogICAgIGdhbWVwYWREZXZpY2UtPnVwZGF0ZUZvckV2ZW50KGV2ZW50 KTsKICAgICByZXR1cm4gVFJVRTsKIH0K