<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96974</bug_id>
          
          <creation_ts>2012-09-17 20:25:58 -0700</creation_ts>
          <short_desc>[EFL][WK2] Add setting to toggle developer extensions</short_desc>
          <delta_ts>2012-09-23 23:27:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Seokju Kwon">seokju.kwon</reporter>
          <assigned_to name="Seokju Kwon">seokju.kwon</assigned_to>
          <cc>cdumez</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>722452</commentid>
    <comment_count>0</comment_count>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-17 20:25:58 -0700</bug_when>
    <thetext>This is required to allow inspecting page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>722471</commentid>
    <comment_count>1</comment_count>
      <attachid>164490</attachid>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-17 21:44:53 -0700</bug_when>
    <thetext>Created attachment 164490
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>722709</commentid>
    <comment_count>2</comment_count>
      <attachid>164490</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-09-18 06:00:28 -0700</bug_when>
    <thetext>Comment on attachment 164490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164490&amp;action=review

&gt; Source/WebKit2/ChangeLog:3
&gt; +        [EFL][WK2] Add APIs to enable or disable developerExtraEnabled

How about &quot;Add setting to toggle developer extensions&quot; ?

&gt; Source/WebKit2/ChangeLog:8
&gt; +        This is required to allow inspecting page.

&quot;inspecting page&quot; ? Web Inspector page?

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:113
&gt; +/**

You&apos;re adding public API, please add unit tests for this.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:118
&gt; + *

We should indicate the default value for this setting.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:130
&gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_get(const Ewk_Settings *settings);

We should indicate the default value for this setting.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>722712</commentid>
    <comment_count>3</comment_count>
      <attachid>164490</attachid>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-09-18 06:06:01 -0700</bug_when>
    <thetext>Comment on attachment 164490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164490&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:87
&gt; +Eina_Bool ewk_settings_enable_developer_extras_set(const Ewk_Settings* settings, Eina_Bool enable)

s/const Ewk_Settings* settings/Ewk_Settings *settings

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:121
&gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_set(const Ewk_Settings *settings, Eina_Bool enable);

s/const Ewk_Settings/Ewk_Settings</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>723369</commentid>
    <comment_count>4</comment_count>
      <attachid>164684</attachid>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-19 01:09:07 -0700</bug_when>
    <thetext>Created attachment 164684
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>723373</commentid>
    <comment_count>5</comment_count>
      <attachid>164684</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-09-19 01:14:23 -0700</bug_when>
    <thetext>Comment on attachment 164684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164684&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:123
&gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_set(Ewk_Settings *settings, Eina_Bool enable);

I think &quot;ewk_settings_developer_extras_enabled_set&quot; is consistent with existing WK2&apos;s ewk_settings API naming.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:134
&gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_get(const Ewk_Settings *settings);

ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>723967</commentid>
    <comment_count>6</comment_count>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-19 16:46:41 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 164684 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=164684&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:123
&gt; &gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_set(Ewk_Settings *settings, Eina_Bool enable);
&gt; 
&gt; I think &quot;ewk_settings_developer_extras_enabled_set&quot; is consistent with existing WK2&apos;s ewk_settings API naming.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:134
&gt; &gt; +EAPI Eina_Bool ewk_settings_enable_developer_extras_get(const Ewk_Settings *settings);
&gt; 
&gt; ditto.

Ok. I will rename it for consistency</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724107</commentid>
    <comment_count>7</comment_count>
      <attachid>164830</attachid>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-19 20:09:11 -0700</bug_when>
    <thetext>Created attachment 164830
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724131</commentid>
    <comment_count>8</comment_count>
      <attachid>164830</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-09-19 21:44:26 -0700</bug_when>
    <thetext>Comment on attachment 164830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164830&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:116
&gt; + * Default value for developer extensions setting is @c EINA_FALSE.

Looks better to follow WK1&apos;s comment style,

 * By default, the value is @c ~/.webkit
 * By default, this value is 1MB.
 * By default, applications are allowed unlimited storage space.
 * By default, the cache is enabled.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:128
&gt; + * Default value for developer extensions setting is @c EINA_FALSE.

ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724933</commentid>
    <comment_count>9</comment_count>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-20 15:45:21 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 164830 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=164830&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:116
&gt; &gt; + * Default value for developer extensions setting is @c EINA_FALSE.
&gt; 
&gt; Looks better to follow WK1&apos;s comment style,
&gt; 
&gt;  * By default, the value is @c ~/.webkit
&gt;  * By default, this value is 1MB.
&gt;  * By default, applications are allowed unlimited storage space.
&gt;  * By default, the cache is enabled.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:128
&gt; &gt; + * Default value for developer extensions setting is @c EINA_FALSE.
&gt; 
&gt; ditto.

All done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>724938</commentid>
    <comment_count>10</comment_count>
      <attachid>165003</attachid>
    <who name="Seokju Kwon">seokju.kwon</who>
    <bug_when>2012-09-20 15:47:40 -0700</bug_when>
    <thetext>Created attachment 165003
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>725180</commentid>
    <comment_count>11</comment_count>
      <attachid>165003</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-09-20 23:15:27 -0700</bug_when>
    <thetext>Comment on attachment 165003
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165003&amp;action=review

&gt; Source/WebKit2/UIProcess/API/efl/ewk_settings.h:123
&gt; + * @return @c EINA_TRUE on success or @EINA_FALSE on failure
&gt; + */
&gt; +EAPI Eina_Bool ewk_settings_developer_extras_enabled_set(Ewk_Settings *settings, Eina_Bool enable);

I know this is consistent with the rest of the api, but it actually only retursn false when the API is *used wrongly*. A crash or assert would even be better. I think we should change all these _set apis to not return anything</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726397</commentid>
    <comment_count>12</comment_count>
      <attachid>165003</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2012-09-23 23:22:21 -0700</bug_when>
    <thetext>Comment on attachment 165003
Patch

Personally, I have same opinion with kenneth about returning of _set api.

But, I think that we can land this and need to discuss in mailing lists for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726398</commentid>
    <comment_count>13</comment_count>
      <attachid>165003</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-23 23:27:29 -0700</bug_when>
    <thetext>Comment on attachment 165003
Patch

Clearing flags on attachment: 165003

Committed r129327: &lt;http://trac.webkit.org/changeset/129327&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726399</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-23 23:27:33 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>164490</attachid>
            <date>2012-09-17 21:44:53 -0700</date>
            <delta_ts>2012-09-19 01:09:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96974-20120918134425.patch</filename>
            <type>text/plain</type>
            <size>3105</size>
            <attacher name="Seokju Kwon">seokju.kwon</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2YxY2RlNTI4MWY0ZmM3
MmJkYzJmZDU1MmQ2NGM2MTAwOTlkOWJjZi4uNGExYWY0MjE0OWIyN2E3MDY4NzU0NmQ0MDNmNDFh
YjNkZDNiNmM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE3ICBTZW9r
anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g
QWRkIEFQSXMgdG8gZW5hYmxlIG9yIGRpc2FibGUgZGV2ZWxvcGVyRXh0cmFFbmFibGVkCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3NAorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgcmVxdWly
ZWQgdG8gYWxsb3cgaW5zcGVjdGluZyBwYWdlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3NldHRpbmdzLmNwcDoKKyAgICAgICAgKGV3a19zZXR0aW5nc19lbmFibGVfZGV2ZWxv
cGVyX2V4dHJhc19zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdzX2VuYWJsZV9kZXZlbG9wZXJf
ZXh0cmFzX2dldCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmg6
CisKIDIwMTItMDktMTcgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEu
Y29tPgogCiAgICAgICAgIFtRdF0gUmVtb3ZlICd1c2luZyBuYW1lc3BhY2UgV2ViQ29yZScgZnJv
bSBoZWFkZXIgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a19zZXR0aW5ncy5jcHAKaW5kZXggOTA1NWNlN2ViNzgwNDViZmY1NzEyODE4OWM2YmMxZmYxYTQ5
M2YxOC4uOGE0NmYwMmRjYjViNGQzOGE1MGY2NjNiMmNmNTBjNDljMWM4OWQzMCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcAorKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwCkBAIC04
MywzICs4MywxOSBAQCBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0
aWNhbGx5X2dldChjb25zdCBFd2tfU2V0dGluZ3MqIHNldHRpbgogCiAgICAgcmV0dXJuIFdLUHJl
ZmVyZW5jZXNHZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkoc2V0dGluZ3MtPnByZWZlcmVuY2Vz
LmdldCgpKTsKIH0KKworRWluYV9Cb29sIGV3a19zZXR0aW5nc19lbmFibGVfZGV2ZWxvcGVyX2V4
dHJhc19zZXQoY29uc3QgRXdrX1NldHRpbmdzKiBzZXR0aW5ncywgRWluYV9Cb29sIGVuYWJsZSkK
K3sKKyAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwoc2V0dGluZ3MsIGZhbHNlKTsK
KworICAgIFdLUHJlZmVyZW5jZXNTZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKHNldHRpbmdzLT5w
cmVmZXJlbmNlcy5nZXQoKSwgZW5hYmxlKTsKKworICAgIHJldHVybiB0cnVlOworfQorCitFaW5h
X0Jvb2wgZXdrX3NldHRpbmdzX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX2dldChjb25zdCBFd2tf
U2V0dGluZ3MqIHNldHRpbmdzKQoreworICAgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZB
TChzZXR0aW5ncywgZmFsc2UpOworCisgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXREZXZlbG9w
ZXJFeHRyYXNFbmFibGVkKHNldHRpbmdzLT5wcmVmZXJlbmNlcy5nZXQoKSk7Cit9CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaCBiL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5oCmluZGV4IGEyOGQ0
MGJlMjUyNDIzNTZmYTBjZmNmNjcwZTBkZjFhNjRmNDJlNWMuLmNkMTg2NzgwYTI2YTZkMTQ4ZTVk
NGU5OGYxZmRlYzE5Mjg2ZDRkNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvZWZsL2V3a19zZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B
UEkvZWZsL2V3a19zZXR0aW5ncy5oCkBAIC0xMTAsNiArMTEwLDI1IEBAIEVBUEkgRWluYV9Cb29s
IGV3a19zZXR0aW5nc19sb2Fkc19pbWFnZXNfYXV0b21hdGljYWxseV9zZXQoRXdrX1NldHRpbmdz
ICpzZXR0aW5nCiAgKi8KIEVBUEkgRWluYV9Cb29sIGV3a19zZXR0aW5nc19sb2Fkc19pbWFnZXNf
YXV0b21hdGljYWxseV9nZXQoY29uc3QgRXdrX1NldHRpbmdzICpzZXR0aW5ncyk7CiAKKy8qKgor
ICogRW5hYmxlcy9kaXNhYmxlcyBkZXZlbG9wZXIgZXh0ZW5zaW9ucy4KKyAqCisgKiBAcGFyYW0g
c2V0dGluZ3Mgc2V0dGluZ3Mgb2JqZWN0IHRvIHNldCBkZXZlbG9wZXIgZXh0ZW5zaW9ucworICog
QHBhcmFtIGVuYWJsZSBAYyBFSU5BX1RSVUUgdG8gZW5hYmxlIGRldmVsb3BlciBleHRyYXMsIEBj
IEVJTkFfRkFMU0UgdG8gZGlzYWJsZQorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIG9uIHN1
Y2Nlc3Mgb3IgQEVJTkFfRkFMU0Ugb24gZmFpbHVyZQorICovCitFQVBJIEVpbmFfQm9vbCBld2tf
c2V0dGluZ3NfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfc2V0KGNvbnN0IEV3a19TZXR0aW5ncyAq
c2V0dGluZ3MsIEVpbmFfQm9vbCBlbmFibGUpOworCisvKioKKyAqIFF1ZXJpZXMgaWYgZGV2ZWxv
cGVyIGV4dGVuc2lvbnMgYXJlIGVuYWJsZWQuCisgKgorICogQHBhcmFtIHNldHRpbmdzIHNldHRp
bmdzIG9iamVjdCB0byBzZXQgZGV2ZWxvcGVyIGV4dGVuc2lvbnMKKyAqCisgKiBAcmV0dXJuIEBj
IEVJTkFfVFJVRSBpZiBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBhcmUgZW5hYmxlZCwgQGMgRUlOQV9G
QUxTRSBvdGhlcndpc2UKKyAqLworRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2VuYWJsZV9k
ZXZlbG9wZXJfZXh0cmFzX2dldChjb25zdCBFd2tfU2V0dGluZ3MgKnNldHRpbmdzKTsKKwogI2lm
ZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>164684</attachid>
            <date>2012-09-19 01:09:07 -0700</date>
            <delta_ts>2012-09-19 20:09:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96974-20120919170839.patch</filename>
            <type>text/plain</type>
            <size>4529</size>
            <attacher name="Seokju Kwon">seokju.kwon</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQzNzg3NzVkNWIyMzJk
MWIxNjBmZGVkODAxY2Q4OGNhOTc1ZGQ5ZS4uMjc4NmRmM2ZhOTQ0ZWUwNjEyMDQ2OGU1NDU1ZGM4
NTVkZjI1ODJmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE5ICBTZW9r
anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g
QWRkIHNldHRpbmcgdG8gdG9nZ2xlIGRldmVsb3BlciBleHRlbnNpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgcmVxdWlyZWQgdG8gYWxs
b3cgdGhlIHVzZXIgdG8gaW5zcGVjdCBwYWdlcy4gKFdlYiBpbnNwZWN0b3IpCisKKyAgICAgICAg
KiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRp
bmdzX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX3NldCk6CisgICAgICAgIChld2tfc2V0dGluZ3Nf
ZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfZ2V0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm
bC9ld2tfc2V0dGluZ3MuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0
X2V3azJfc2V0dGluZ3MuY3BwOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxMi0wOS0xOCAgQ2Fy
bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g
U2V0IHRoZSBhcmVhIG9mIHRvb2x0aXBzIGluIFdlYktpdDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwCmluZGV4IDkwNTVjZTdlYjc4MDQ1
YmZmNTcxMjgxODljNmJjMWZmMWE0OTNmMTguLjQyNTgzZDdkYzdhYTg0YjhjY2RiYmFhMTMxMWFi
ZDEyMjg2MzIzZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs
L2V3a19zZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv
ZXdrX3NldHRpbmdzLmNwcApAQCAtODMsMyArODMsMTkgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5n
c19sb2Fkc19pbWFnZXNfYXV0b21hdGljYWxseV9nZXQoY29uc3QgRXdrX1NldHRpbmdzKiBzZXR0
aW4KIAogICAgIHJldHVybiBXS1ByZWZlcmVuY2VzR2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5
KHNldHRpbmdzLT5wcmVmZXJlbmNlcy5nZXQoKSk7CiB9CisKK0VpbmFfQm9vbCBld2tfc2V0dGlu
Z3NfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfc2V0KEV3a19TZXR0aW5ncyogc2V0dGluZ3MsIEVp
bmFfQm9vbCBlbmFibGUpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKHNl
dHRpbmdzLCBmYWxzZSk7CisKKyAgICBXS1ByZWZlcmVuY2VzU2V0RGV2ZWxvcGVyRXh0cmFzRW5h
YmxlZChzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0KCksIGVuYWJsZSk7CisKKyAgICByZXR1cm4g
dHJ1ZTsKK30KKworRWluYV9Cb29sIGV3a19zZXR0aW5nc19lbmFibGVfZGV2ZWxvcGVyX2V4dHJh
c19nZXQoY29uc3QgRXdrX1NldHRpbmdzKiBzZXR0aW5ncykKK3sKKyAgICBFSU5BX1NBRkVUWV9P
Tl9OVUxMX1JFVFVSTl9WQUwoc2V0dGluZ3MsIGZhbHNlKTsKKworICAgIHJldHVybiBXS1ByZWZl
cmVuY2VzR2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0
KCkpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr
X3NldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGlu
Z3MuaAppbmRleCBhMjhkNDBiZTI1MjQyMzU2ZmEwY2ZjZjY3MGUwZGYxYTY0ZjQyZTVjLi5mM2Nm
NDAxYWQ4MmYyNzlkNTliM2UxNDMyYzhjZGUyYjQwNTNmMjQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuaApAQCAtMTEwLDYgKzExMCwyOSBA
QCBFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfbG9hZHNfaW1hZ2VzX2F1dG9tYXRpY2FsbHlf
c2V0KEV3a19TZXR0aW5ncyAqc2V0dGluZwogICovCiBFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGlu
Z3NfbG9hZHNfaW1hZ2VzX2F1dG9tYXRpY2FsbHlfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAqc2V0
dGluZ3MpOwogCisvKioKKyAqIEVuYWJsZXMvZGlzYWJsZXMgZGV2ZWxvcGVyIGV4dGVuc2lvbnMu
CisgKgorICogRGVmYXVsdCB2YWx1ZSBmb3IgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgc2V0dGluZyBp
cyBAYyBFSU5BX0ZBTFNFLgorICoKKyAqIEBwYXJhbSBzZXR0aW5ncyBzZXR0aW5ncyBvYmplY3Qg
dG8gc2V0IGRldmVsb3BlciBleHRlbnNpb25zCisgKiBAcGFyYW0gZW5hYmxlIEBjIEVJTkFfVFJV
RSB0byBlbmFibGUgZGV2ZWxvcGVyIGV4dGVuc2lvbnMsIEBjIEVJTkFfRkFMU0UgdG8gZGlzYWJs
ZQorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIG9uIHN1Y2Nlc3Mgb3IgQEVJTkFfRkFMU0Ug
b24gZmFpbHVyZQorICovCitFQVBJIEVpbmFfQm9vbCBld2tfc2V0dGluZ3NfZW5hYmxlX2RldmVs
b3Blcl9leHRyYXNfc2V0KEV3a19TZXR0aW5ncyAqc2V0dGluZ3MsIEVpbmFfQm9vbCBlbmFibGUp
OworCisvKioKKyAqIFF1ZXJpZXMgaWYgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgYXJlIGVuYWJsZWQu
CisgKgorICogRGVmYXVsdCB2YWx1ZSBmb3IgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgc2V0dGluZyBp
cyBAYyBFSU5BX0ZBTFNFLgorICoKKyAqIEBwYXJhbSBzZXR0aW5ncyBzZXR0aW5ncyBvYmplY3Qg
dG8gc2V0IGRldmVsb3BlciBleHRlbnNpb25zCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUg
aWYgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgYXJlIGVuYWJsZWQsIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3
aXNlCisgKi8KK0VBUEkgRWluYV9Cb29sIGV3a19zZXR0aW5nc19lbmFibGVfZGV2ZWxvcGVyX2V4
dHJhc19nZXQoY29uc3QgRXdrX1NldHRpbmdzICpzZXR0aW5ncyk7CisKICNpZmRlZiBfX2NwbHVz
cGx1cwogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcAppbmRleCBkZDBhNmU3MjIy
ZGNiNjhmNzg5Yjg3MTM5ODJmOTNhZGQ0OTcxNDg3Li5lZTA2YmRjZTc0ZjFmMjUwNGMzNGY0NDQ5
ZmZkZjEwNTFjMzJiNjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9zZXR0aW5ncy5jcHAKQEAgLTgxLDMgKzgx
LDE3IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc2V0dGluZ3NfbG9hZHNfaW1hZ2Vz
X2F1dG9tYXRpY2FsbHkpCiAgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdl
c19hdXRvbWF0aWNhbGx5X3NldChzZXR0aW5ncywgRUlOQV9GQUxTRSkpOwogICAgIEFTU0VSVF9G
QUxTRShld2tfc2V0dGluZ3NfbG9hZHNfaW1hZ2VzX2F1dG9tYXRpY2FsbHlfZ2V0KHNldHRpbmdz
KSk7CiB9CisKK1RFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc2V0dGluZ3NfZW5hYmxlX2Rl
dmVsb3Blcl9leHRyYXMpCit7CisgICAgRXdrX1NldHRpbmdzKiBzZXR0aW5ncyA9IGV3a192aWV3
X3NldHRpbmdzX2dldCh3ZWJWaWV3KCkpOworCisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdz
X2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX3NldChzZXR0aW5ncywgRUlOQV9UUlVFKSk7CisgICAg
QVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX2dldChzZXR0
aW5ncykpOworCisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2VuYWJsZV9kZXZlbG9wZXJf
ZXh0cmFzX3NldChzZXR0aW5ncywgMikpOworICAgIEFTU0VSVF9UUlVFKGV3a19zZXR0aW5nc19l
bmFibGVfZGV2ZWxvcGVyX2V4dHJhc19nZXQoc2V0dGluZ3MpKTsKKworICAgIEFTU0VSVF9UUlVF
KGV3a19zZXR0aW5nc19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19zZXQoc2V0dGluZ3MsIEVJTkFf
RkFMU0UpKTsKKyAgICBBU1NFUlRfRkFMU0UoZXdrX3NldHRpbmdzX2VuYWJsZV9kZXZlbG9wZXJf
ZXh0cmFzX2dldChzZXR0aW5ncykpOworfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>164830</attachid>
            <date>2012-09-19 20:09:11 -0700</date>
            <delta_ts>2012-09-20 15:47:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96974-20120920120843.patch</filename>
            <type>text/plain</type>
            <size>4564</size>
            <attacher name="Seokju Kwon">seokju.kwon</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQzNzg3NzVkNWIyMzJk
MWIxNjBmZGVkODAxY2Q4OGNhOTc1ZGQ5ZS4uNDQ3Y2FmZWE3Y2NmMTQ1NzAyODBkMTcxNmMzZjg3
N2NkZTNmODkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE5ICBTZW9r
anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g
QWRkIHNldHRpbmcgdG8gdG9nZ2xlIGRldmVsb3BlciBleHRlbnNpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgcmVxdWlyZWQgdG8gYWxs
b3cgdGhlIHVzZXIgdG8gaW5zcGVjdCBwYWdlcy4gKFdlYiBpbnNwZWN0b3IpCisKKyAgICAgICAg
KiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRp
bmdzX2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdz
X2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9nZXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv
ZWZsL2V3a19zZXR0aW5ncy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rl
c3RfZXdrMl9zZXR0aW5ncy5jcHA6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEyLTA5LTE4ICBD
YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL
XSBTZXQgdGhlIGFyZWEgb2YgdG9vbHRpcHMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggOTA1NWNlN2ViNzgw
NDViZmY1NzEyODE4OWM2YmMxZmYxYTQ5M2YxOC4uYTFmNTFiOGJjYjViZTA5ZTcwMzU5ZmI1MDlk
NDFmYjIxZDg4MmU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm
bC9ld2tfc2V0dGluZ3MuY3BwCkBAIC04MywzICs4MywxOSBAQCBFaW5hX0Jvb2wgZXdrX3NldHRp
bmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNhbGx5X2dldChjb25zdCBFd2tfU2V0dGluZ3MqIHNl
dHRpbgogCiAgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2Fs
bHkoc2V0dGluZ3MtPnByZWZlcmVuY2VzLmdldCgpKTsKIH0KKworRWluYV9Cb29sIGV3a19zZXR0
aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfc2V0KEV3a19TZXR0aW5ncyogc2V0dGluZ3Ms
IEVpbmFfQm9vbCBlbmFibGUpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFM
KHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICBXS1ByZWZlcmVuY2VzU2V0RGV2ZWxvcGVyRXh0cmFz
RW5hYmxlZChzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0KCksIGVuYWJsZSk7CisKKyAgICByZXR1
cm4gdHJ1ZTsKK30KKworRWluYV9Cb29sIGV3a19zZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2Vu
YWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyogc2V0dGluZ3MpCit7CisgICAgRUlOQV9TQUZF
VFlfT05fTlVMTF9SRVRVUk5fVkFMKHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICByZXR1cm4gV0tQ
cmVmZXJlbmNlc0dldERldmVsb3BlckV4dHJhc0VuYWJsZWQoc2V0dGluZ3MtPnByZWZlcmVuY2Vz
LmdldCgpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs
L2V3a19zZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Nl
dHRpbmdzLmgKaW5kZXggYTI4ZDQwYmUyNTI0MjM1NmZhMGNmY2Y2NzBlMGRmMWE2NGY0MmU1Yy4u
ZDdjMzMwOTcwNWY4N2Y3YmUzNGFlMGFkZjM2ZmIyODRmY2IzN2E3YyAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKQEAgLTExMCw2ICsxMTAs
MzAgQEAgRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNh
bGx5X3NldChFd2tfU2V0dGluZ3MgKnNldHRpbmcKICAqLwogRUFQSSBFaW5hX0Jvb2wgZXdrX3Nl
dHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNhbGx5X2dldChjb25zdCBFd2tfU2V0dGluZ3Mg
KnNldHRpbmdzKTsKIAorLyoqCisgKiBFbmFibGVzL2Rpc2FibGVzIGRldmVsb3BlciBleHRlbnNp
b25zLgorICoKKyAqIERlZmF1bHQgdmFsdWUgZm9yIGRldmVsb3BlciBleHRlbnNpb25zIHNldHRp
bmcgaXMgQGMgRUlOQV9GQUxTRS4KKyAqCisgKiBAcGFyYW0gc2V0dGluZ3Mgc2V0dGluZ3Mgb2Jq
ZWN0IHRvIHNldCBkZXZlbG9wZXIgZXh0ZW5zaW9ucworICogQHBhcmFtIGVuYWJsZSBAYyBFSU5B
X1RSVUUgdG8gZW5hYmxlIGRldmVsb3BlciBleHRlbnNpb25zLCBAYyBFSU5BX0ZBTFNFIHRvIGRp
c2FibGUKKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBvbiBzdWNjZXNzIG9yIEBFSU5BX0ZB
TFNFIG9uIGZhaWx1cmUKKyAqLworRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2RldmVsb3Bl
cl9leHRyYXNfZW5hYmxlZF9zZXQoRXdrX1NldHRpbmdzICpzZXR0aW5ncywgRWluYV9Cb29sIGVu
YWJsZSk7CisKKy8qKgorICogUXVlcmllcyBpZiBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBhcmUgZW5h
YmxlZC4KKyAqCisgKiBEZWZhdWx0IHZhbHVlIGZvciBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBzZXR0
aW5nIGlzIEBjIEVJTkFfRkFMU0UuCisgKgorICogQHBhcmFtIHNldHRpbmdzIHNldHRpbmdzIG9i
amVjdCB0byBzZXQgZGV2ZWxvcGVyIGV4dGVuc2lvbnMKKyAqCisgKiBAcmV0dXJuIEBjIEVJTkFf
VFJVRSBpZiBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBhcmUgZW5hYmxlZAorICAgICAgICAgICBAYyBF
SU5BX0ZBTFNFIGlmIG5vdCBvciBvbiBmYWlsdXJlCisgKi8KK0VBUEkgRWluYV9Cb29sIGV3a19z
ZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyAq
c2V0dGluZ3MpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdz
LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9z
ZXR0aW5ncy5jcHAKaW5kZXggZGQwYTZlNzIyMmRjYjY4Zjc4OWI4NzEzOTgyZjkzYWRkNDk3MTQ4
Ny4uOTg4OWJiYWU3YmFkNzFmZWFiNzA5ODhjZWVjMDk0MmZhMjhkYjE2NCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdz
LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3
azJfc2V0dGluZ3MuY3BwCkBAIC04MSwzICs4MSwxNyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFz
ZSwgZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNhbGx5KQogICAgIEFTU0VSVF9U
UlVFKGV3a19zZXR0aW5nc19sb2Fkc19pbWFnZXNfYXV0b21hdGljYWxseV9zZXQoc2V0dGluZ3Ms
IEVJTkFfRkFMU0UpKTsKICAgICBBU1NFUlRfRkFMU0UoZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdl
c19hdXRvbWF0aWNhbGx5X2dldChzZXR0aW5ncykpOwogfQorCitURVNUX0YoRVdLMlVuaXRUZXN0
QmFzZSwgZXdrX3NldHRpbmdzX2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZCkKK3sKKyAgICBFd2tf
U2V0dGluZ3MqIHNldHRpbmdzID0gZXdrX3ZpZXdfc2V0dGluZ3NfZ2V0KHdlYlZpZXcoKSk7CisK
KyAgICBBU1NFUlRfVFJVRShld2tfc2V0dGluZ3NfZGV2ZWxvcGVyX2V4dHJhc19lbmFibGVkX3Nl
dChzZXR0aW5ncywgRUlOQV9UUlVFKSk7CisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2Rl
dmVsb3Blcl9leHRyYXNfZW5hYmxlZF9nZXQoc2V0dGluZ3MpKTsKKworICAgIEFTU0VSVF9UUlVF
KGV3a19zZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfc2V0KHNldHRpbmdzLCAyKSk7
CisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9n
ZXQoc2V0dGluZ3MpKTsKKworICAgIEFTU0VSVF9UUlVFKGV3a19zZXR0aW5nc19kZXZlbG9wZXJf
ZXh0cmFzX2VuYWJsZWRfc2V0KHNldHRpbmdzLCBFSU5BX0ZBTFNFKSk7CisgICAgQVNTRVJUX0ZB
TFNFKGV3a19zZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfZ2V0KHNldHRpbmdzKSk7
Cit9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>165003</attachid>
            <date>2012-09-20 15:47:40 -0700</date>
            <delta_ts>2012-09-23 23:27:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96974-20120921074712.patch</filename>
            <type>text/plain</type>
            <size>4536</size>
            <attacher name="Seokju Kwon">seokju.kwon</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODQzNzg3NzVkNWIyMzJk
MWIxNjBmZGVkODAxY2Q4OGNhOTc1ZGQ5ZS4uNDQ3Y2FmZWE3Y2NmMTQ1NzAyODBkMTcxNmMzZjg3
N2NkZTNmODkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE5ICBTZW9r
anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g
QWRkIHNldHRpbmcgdG8gdG9nZ2xlIGRldmVsb3BlciBleHRlbnNpb25zCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3NAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgcmVxdWlyZWQgdG8gYWxs
b3cgdGhlIHVzZXIgdG8gaW5zcGVjdCBwYWdlcy4gKFdlYiBpbnNwZWN0b3IpCisKKyAgICAgICAg
KiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRp
bmdzX2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9zZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdz
X2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9nZXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv
ZWZsL2V3a19zZXR0aW5ncy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rl
c3RfZXdrMl9zZXR0aW5ncy5jcHA6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEyLTA5LTE4ICBD
YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RL
XSBTZXQgdGhlIGFyZWEgb2YgdG9vbHRpcHMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAKaW5kZXggOTA1NWNlN2ViNzgw
NDViZmY1NzEyODE4OWM2YmMxZmYxYTQ5M2YxOC4uYTFmNTFiOGJjYjViZTA5ZTcwMzU5ZmI1MDlk
NDFmYjIxZDg4MmU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm
bC9ld2tfc2V0dGluZ3MuY3BwCkBAIC04MywzICs4MywxOSBAQCBFaW5hX0Jvb2wgZXdrX3NldHRp
bmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNhbGx5X2dldChjb25zdCBFd2tfU2V0dGluZ3MqIHNl
dHRpbgogCiAgICAgcmV0dXJuIFdLUHJlZmVyZW5jZXNHZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2Fs
bHkoc2V0dGluZ3MtPnByZWZlcmVuY2VzLmdldCgpKTsKIH0KKworRWluYV9Cb29sIGV3a19zZXR0
aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfc2V0KEV3a19TZXR0aW5ncyogc2V0dGluZ3Ms
IEVpbmFfQm9vbCBlbmFibGUpCit7CisgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFM
KHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICBXS1ByZWZlcmVuY2VzU2V0RGV2ZWxvcGVyRXh0cmFz
RW5hYmxlZChzZXR0aW5ncy0+cHJlZmVyZW5jZXMuZ2V0KCksIGVuYWJsZSk7CisKKyAgICByZXR1
cm4gdHJ1ZTsKK30KKworRWluYV9Cb29sIGV3a19zZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2Vu
YWJsZWRfZ2V0KGNvbnN0IEV3a19TZXR0aW5ncyogc2V0dGluZ3MpCit7CisgICAgRUlOQV9TQUZF
VFlfT05fTlVMTF9SRVRVUk5fVkFMKHNldHRpbmdzLCBmYWxzZSk7CisKKyAgICByZXR1cm4gV0tQ
cmVmZXJlbmNlc0dldERldmVsb3BlckV4dHJhc0VuYWJsZWQoc2V0dGluZ3MtPnByZWZlcmVuY2Vz
LmdldCgpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs
L2V3a19zZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Nl
dHRpbmdzLmgKaW5kZXggYTI4ZDQwYmUyNTI0MjM1NmZhMGNmY2Y2NzBlMGRmMWE2NGY0MmU1Yy4u
MWQ4YjIxM2QwZWE1NGMzMGM5ZDFhNDZkNDVkNjNiZWY2YmIyMTVkMCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKKysrIGIvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmgKQEAgLTExMCw2ICsxMTAs
MzAgQEAgRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNh
bGx5X3NldChFd2tfU2V0dGluZ3MgKnNldHRpbmcKICAqLwogRUFQSSBFaW5hX0Jvb2wgZXdrX3Nl
dHRpbmdzX2xvYWRzX2ltYWdlc19hdXRvbWF0aWNhbGx5X2dldChjb25zdCBFd2tfU2V0dGluZ3Mg
KnNldHRpbmdzKTsKIAorLyoqCisgKiBFbmFibGVzL2Rpc2FibGVzIGRldmVsb3BlciBleHRlbnNp
b25zLgorICoKKyAqIEJ5IGRlZmF1bHQsIHRoZSBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBhcmUgZGlz
YWJsZWQuCisgKgorICogQHBhcmFtIHNldHRpbmdzIHNldHRpbmdzIG9iamVjdCB0byBzZXQgZGV2
ZWxvcGVyIGV4dGVuc2lvbnMKKyAqIEBwYXJhbSBlbmFibGUgQGMgRUlOQV9UUlVFIHRvIGVuYWJs
ZSBkZXZlbG9wZXIgZXh0ZW5zaW9ucywgQGMgRUlOQV9GQUxTRSB0byBkaXNhYmxlCisgKgorICog
QHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3VjY2VzcyBvciBARUlOQV9GQUxTRSBvbiBmYWlsdXJl
CisgKi8KK0VBUEkgRWluYV9Cb29sIGV3a19zZXR0aW5nc19kZXZlbG9wZXJfZXh0cmFzX2VuYWJs
ZWRfc2V0KEV3a19TZXR0aW5ncyAqc2V0dGluZ3MsIEVpbmFfQm9vbCBlbmFibGUpOworCisvKioK
KyAqIFF1ZXJpZXMgaWYgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgYXJlIGVuYWJsZWQuCisgKgorICog
QnkgZGVmYXVsdCwgdGhlIGRldmVsb3BlciBleHRlbnNpb25zIGFyZSBkaXNhYmxlZC4KKyAqCisg
KiBAcGFyYW0gc2V0dGluZ3Mgc2V0dGluZ3Mgb2JqZWN0IHRvIHNldCBkZXZlbG9wZXIgZXh0ZW5z
aW9ucworICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIGlmIGRldmVsb3BlciBleHRlbnNpb25z
IGFyZSBlbmFibGVkCisgICAgICAgICAgIEBjIEVJTkFfRkFMU0UgaWYgbm90IG9yIG9uIGZhaWx1
cmUKKyAqLworRUFQSSBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2RldmVsb3Blcl9leHRyYXNfZW5h
YmxlZF9nZXQoY29uc3QgRXdrX1NldHRpbmdzICpzZXR0aW5ncyk7CisKICNpZmRlZiBfX2NwbHVz
cGx1cwogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3NldHRpbmdzLmNwcAppbmRleCBkZDBhNmU3MjIy
ZGNiNjhmNzg5Yjg3MTM5ODJmOTNhZGQ0OTcxNDg3Li45ODg5YmJhZTdiYWQ3MWZlYWI3MDk4OGNl
ZWMwOTQyZmEyOGRiMTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L2VmbC90ZXN0cy90ZXN0X2V3azJfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9zZXR0aW5ncy5jcHAKQEAgLTgxLDMgKzgx
LDE3IEBAIFRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc2V0dGluZ3NfbG9hZHNfaW1hZ2Vz
X2F1dG9tYXRpY2FsbHkpCiAgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2xvYWRzX2ltYWdl
c19hdXRvbWF0aWNhbGx5X3NldChzZXR0aW5ncywgRUlOQV9GQUxTRSkpOwogICAgIEFTU0VSVF9G
QUxTRShld2tfc2V0dGluZ3NfbG9hZHNfaW1hZ2VzX2F1dG9tYXRpY2FsbHlfZ2V0KHNldHRpbmdz
KSk7CiB9CisKK1RFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc2V0dGluZ3NfZGV2ZWxvcGVy
X2V4dHJhc19lbmFibGVkKQoreworICAgIEV3a19TZXR0aW5ncyogc2V0dGluZ3MgPSBld2tfdmll
d19zZXR0aW5nc19nZXQod2ViVmlldygpKTsKKworICAgIEFTU0VSVF9UUlVFKGV3a19zZXR0aW5n
c19kZXZlbG9wZXJfZXh0cmFzX2VuYWJsZWRfc2V0KHNldHRpbmdzLCBFSU5BX1RSVUUpKTsKKyAg
ICBBU1NFUlRfVFJVRShld2tfc2V0dGluZ3NfZGV2ZWxvcGVyX2V4dHJhc19lbmFibGVkX2dldChz
ZXR0aW5ncykpOworCisgICAgQVNTRVJUX1RSVUUoZXdrX3NldHRpbmdzX2RldmVsb3Blcl9leHRy
YXNfZW5hYmxlZF9zZXQoc2V0dGluZ3MsIDIpKTsKKyAgICBBU1NFUlRfVFJVRShld2tfc2V0dGlu
Z3NfZGV2ZWxvcGVyX2V4dHJhc19lbmFibGVkX2dldChzZXR0aW5ncykpOworCisgICAgQVNTRVJU
X1RSVUUoZXdrX3NldHRpbmdzX2RldmVsb3Blcl9leHRyYXNfZW5hYmxlZF9zZXQoc2V0dGluZ3Ms
IEVJTkFfRkFMU0UpKTsKKyAgICBBU1NFUlRfRkFMU0UoZXdrX3NldHRpbmdzX2RldmVsb3Blcl9l
eHRyYXNfZW5hYmxlZF9nZXQoc2V0dGluZ3MpKTsKK30K
</data>

          </attachment>
      

    </bug>

</bugzilla>