96973 2012-09-17 20:19:27 -0700 DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac 2012-09-17 23:34:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki ddkilzer psolanki oldest_to_newest 722446 0 psolanki 2012-09-17 20:19:27 -0700 We should pass -Wundef to DRT builds. 722451 1 164486 psolanki 2012-09-17 20:25:42 -0700 Created attachment 164486 Patch 722453 2 164486 mitz 2012-09-17 20:27:10 -0700 Comment on attachment 164486 Patch What about WebKitTestRunner? 722487 3 psolanki 2012-09-17 22:12:41 -0700 (In reply to comment #2) > (From update of attachment 164486 [details]) > What about WebKitTestRunner? Yeah we should add -Wundef there as well. I'll post an updated patch. 722493 4 164494 psolanki 2012-09-17 22:22:39 -0700 Created attachment 164494 Patch 722511 5 psolanki 2012-09-17 23:34:57 -0700 Committed r128852: <http://trac.webkit.org/changeset/128852> 164486 2012-09-17 20:25:42 -0700 2012-09-17 22:22:37 -0700 Patch bug-96973-20120917202509.patch text/plain 1335 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTkzYTc2MzkzNjJhZjMyMjYwZTYyOTE4YjAyNjY5NTEz MjE5NzA2NC4uMmY2NTYxMDhiYjc2ZDYwZTdjZWUzNDdlNzQ5ZTEzMTdiNTM3Yjk2MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTA5LTE3ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKwor ICAgICAgICBEdW1wUmVuZGVyVHJlZSBzaG91bGQgY29tcGlsZSB3aXRoIC1XdW5kZWYgb24gTWFj CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6CisKIDIwMTItMDktMTcg IERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVt XSBBU0FOIGJvdCBpcyBjcmFzaGluZyBhdCB0aGUgZW5kIG9mIHRoZSBydW4KZGlmZiAtLWdpdCBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5k ZXggYjZmZTc1YTNmOTMxYzEwMGJlMzU1OWVhY2NhNDczNTEyZTU5YzRlNi4uMTQwNzE0ZWFjMDdj YTk0Nzg4Njk3MmU2YzA5MGQwNmQxMDFhYjJkNCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAgLTM3LDcgKzM3LDcg QEAgR0NDX1RSRUFUX1dBUk5JTkdTX0FTX0VSUk9SUyA9IFlFUwogR0NDX1dBUk5fQUJPVVRfREVQ UkVDQVRFRF9GVU5DVElPTlMgPSBOTwogR0NDX1dBUk5fVU5VU0VEX0ZVTkNUSU9OID0gWUVTCiBH Q0NfV0FSTl9VTlVTRURfVkFSSUFCTEUgPSBZRVMKLVdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVcg LVduby11bnVzZWQtcGFyYW1ldGVyCitXQVJOSU5HX0NGTEFHUyA9IC1XYWxsIC1XIC1Xbm8tdW51 c2VkLXBhcmFtZXRlciAtV3VuZGVmCiBMSU5LRVJfRElTUExBWVNfTUFOR0xFRF9OQU1FUyA9IFlF UzsKIAogQ0xBTkdfQ1hYX0xJQlJBUlkgPSAkKENMQU5HX0NYWF9MSUJSQVJZXyQoVEFSR0VUX01B Q19PU19YX1ZFUlNJT05fTUFKT1IpKTsK 164494 2012-09-17 22:22:39 -0700 2012-09-17 23:20:58 -0700 Patch bug-96973-20120917222206.patch text/plain 2730 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTkzYTc2MzkzNjJhZjMyMjYwZTYyOTE4YjAyNjY5NTEz MjE5NzA2NC4uZDJmYzQxNGNhMDJmMDY2OWRjZGNmYzc0OGQ0YTdmNjdhMDVlMzgwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA5LTE3ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKwor ICAgICAgICBEdW1wUmVuZGVyVHJlZSBhbmQgV2ViS2l0VGVzdFJ1bm5lciBzaG91bGQgY29tcGls ZSB3aXRoIC1XdW5kZWYgb24gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05Njk3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNj b25maWc6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9CYXNlLnhj Y29uZmlnOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3Lmg6IFVz ZSAjaWZkZWYgX19PQkpDX18gYW5kIG5vdCAjaWYuCisKIDIwMTItMDktMTcgIERpcmsgUHJhbmtl ICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBU0FOIGJvdCBp cyBjcmFzaGluZyBhdCB0aGUgZW5kIG9mIHRoZSBydW4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggYjZmZTc1YTNm OTMxYzEwMGJlMzU1OWVhY2NhNDczNTEyZTU5YzRlNi4uMTQwNzE0ZWFjMDdjYTk0Nzg4Njk3MmU2 YzA5MGQwNmQxMDFhYjJkNCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0Nv bmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAgLTM3LDcgKzM3LDcgQEAgR0NDX1RSRUFU X1dBUk5JTkdTX0FTX0VSUk9SUyA9IFlFUwogR0NDX1dBUk5fQUJPVVRfREVQUkVDQVRFRF9GVU5D VElPTlMgPSBOTwogR0NDX1dBUk5fVU5VU0VEX0ZVTkNUSU9OID0gWUVTCiBHQ0NfV0FSTl9VTlVT RURfVkFSSUFCTEUgPSBZRVMKLVdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVcgLVduby11bnVzZWQt cGFyYW1ldGVyCitXQVJOSU5HX0NGTEFHUyA9IC1XYWxsIC1XIC1Xbm8tdW51c2VkLXBhcmFtZXRl ciAtV3VuZGVmCiBMSU5LRVJfRElTUExBWVNfTUFOR0xFRF9OQU1FUyA9IFlFUzsKIAogQ0xBTkdf Q1hYX0xJQlJBUlkgPSAkKENMQU5HX0NYWF9MSUJSQVJZXyQoVEFSR0VUX01BQ19PU19YX1ZFUlNJ T05fTUFKT1IpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJh dGlvbnMvQmFzZS54Y2NvbmZpZyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ29uZmlndXJhdGlv bnMvQmFzZS54Y2NvbmZpZwppbmRleCA5ZjU0MDU5NjdhYzM1ZWM2OTY2MjM1Yzg1YmEyNjU5MmVl YTFjZDBkLi44YmRlZWUyYzVlNDEyMmRkYjZiNjMxNmRkODlkZGM2Mjk5ODQ2ODNmIDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcK KysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmln CkBAIC0zNyw3ICszNyw3IEBAIEdDQ19UUkVBVF9XQVJOSU5HU19BU19FUlJPUlMgPSBZRVMKIEdD Q19XQVJOX0FCT1VUX0RFUFJFQ0FURURfRlVOQ1RJT05TID0gTk8KIEdDQ19XQVJOX1VOVVNFRF9G VU5DVElPTiA9IFlFUwogR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0gWUVTCi1XQVJOSU5HX0NG TEFHUyA9IC1XYWxsIC1XIC1Xbm8tdW51c2VkLXBhcmFtZXRlcgorV0FSTklOR19DRkxBR1MgPSAt V2FsbCAtVyAtV25vLXVudXNlZC1wYXJhbWV0ZXIgLVd1bmRlZgogTElOS0VSX0RJU1BMQVlTX01B TkdMRURfTkFNRVMgPSBZRVM7CiBWQUxJRF9BUkNIUyA9IGkzODYgeDg2XzY0OwogR0NDX1BSRUZJ WF9IRUFERVIgPSBXZWJLaXRUZXN0UnVubmVyUHJlZml4LmgKZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3LmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1BsYXRmb3JtV2ViVmlldy5oCmluZGV4IGQzYWQyMWE5ZTQzYTljOGUyZWYyYThiY2E1ZDZmYzUz ZTJlNjc4MjYuLjQzYjc5YzMzZTAxMjZmOTI0ODBhNDNiNjg2ODVkNzJjOTVhZDk3MzMgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaApAQCAtMzcsNyArMzcsNyBAQCBj bGFzcyBRUXVpY2tXZWJWaWV3OwogdHlwZWRlZiBRUXVpY2tXZWJWaWV3KiBQbGF0Zm9ybVdLVmll dzsKIHR5cGVkZWYgUVF1aWNrVmlldyogUGxhdGZvcm1XaW5kb3c7CiAjZWxpZiBkZWZpbmVkKF9f QVBQTEVfXykgJiYgX19BUFBMRV9fCi0jaWYgX19PQkpDX18KKyNpZmRlZiBfX09CSkNfXwogQGNs YXNzIFdLVmlldzsKIEBjbGFzcyBXZWJLaXRUZXN0UnVubmVyV2luZG93OwogI2Vsc2UK