96972 2012-09-17 19:44:37 -0700 [Win] Null check timing function received from CoreAnimation when calling CACFAnimationGetTimingFunction. 2012-09-17 22:33:25 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 roger_fong webkit-unassigned simon.fraser thorton oldest_to_newest 722431 0 roger_fong 2012-09-17 19:44:37 -0700 When paused, some CSS animations cause CoreAnimation to pass back a null timing function when calling CACFAnimationGetTimingFunction. This patch fixes this simply by ensuring that if the output of this method is null, it does not get passed into CACFAnimationSetTimingFunction via the PlatformCAAnimation::copyTimingFunctionFrom method. This is a workaround. There is most likely a more appropriate fix in CoreAnimation to deal with the null return. 722434 1 164482 roger_fong 2012-09-17 19:59:16 -0700 Created attachment 164482 patch 722440 2 roger_fong 2012-09-17 20:05:47 -0700 Note that the CACFAnimationSetTimingFunction will always crash when null is passed in for the timingFunc parameter. 722441 3 164485 roger_fong 2012-09-17 20:07:34 -0700 Created attachment 164485 patch 722445 4 thorton 2012-09-17 20:17:54 -0700 <rdar://problem/12088487> 722447 5 roger_fong 2012-09-17 20:20:09 -0700 http://trac.webkit.org/changeset/128845 722448 6 thorton 2012-09-17 20:22:27 -0700 You seem to have killed the "Reviewed by" part of the review line :\ 722450 7 roger_fong 2012-09-17 20:24:56 -0700 oops, i will fix 164482 2012-09-17 19:59:16 -0700 2012-09-17 20:09:06 -0700 patch 96972_patch.txt text/plain 1886 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODg0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gTnVsbCBjaGVjayB0 aW1pbmcgZnVuY3Rpb24gcmVjZWl2ZWQgZnJvbSBDb3JlQW5pbWF0aW9uIHdoZW4gY2FsbGluZyBD QUNGQW5pbWF0aW9uR2V0VGltaW5nRnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcGF1c2VkLCBzb21lIENTUyBhbmltYXRpb25zIGNh dXNlIENvcmVBbmltYXRpb24gdG8gcGFzcyBiYWNrIGEgbnVsbCB0aW1pbmcgZnVuY3Rpb24gd2hl biBjYWxsaW5nIENBQ0ZBbmltYXRpb25HZXRUaW1pbmdGdW5jdGlvbi4KKyAgICAgICAgVGhpcyBw YXRjaCBmaXhlcyB0aGlzIHNpbXBseSBieSBlbnN1cmluZyB0aGF0IGlmIHRoZSBvdXRwdXQgb2Yg dGhpcyBtZXRob2QgaXMgbnVsbCwgaXQgZG9lcyBub3QgZ2V0IHBhc3NlZCBpbnRvIENBQ0ZBbmlt YXRpb25TZXRUaW1pbmdGdW5jdGlvbgorICAgICAgICB2aWEgdGhlIFBsYXRmb3JtQ0FBbmltYXRp b246OmNvcHlUaW1pbmdGdW5jdGlvbkZyb20gbWV0aG9kLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FBbmltYXRpb25XaW4uY3BwOgorICAgICAgICAoUGxh dGZvcm1DQUFuaW1hdGlvbjo6Y29weVRpbWluZ0Z1bmN0aW9uRnJvbSk6CisKIDIwMTItMDktMTcg IERhdmlkIEJhcnRvbiAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgQ29udmVy dCBNYXRoTUwgdG8gdXNlIGZsZXhib3hlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FBbmltYXRpb25XaW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9QbGF0Zm9ybUNBQW5pbWF0 aW9uV2luLmNwcAkocmV2aXNpb24gMTI4ODQwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Evd2luL1BsYXRmb3JtQ0FBbmltYXRpb25XaW4uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yOTYsNyArMjk2LDkgQEAgdm9pZCBQbGF0Zm9ybUNBQW5pbWF0aW9uOjpzZXRUaW1pbmdG dW5jdAogCiB2b2lkIFBsYXRmb3JtQ0FBbmltYXRpb246OmNvcHlUaW1pbmdGdW5jdGlvbkZyb20o Y29uc3QgUGxhdGZvcm1DQUFuaW1hdGlvbiogdmFsdWUpCiB7Ci0gICAgQ0FDRkFuaW1hdGlvblNl dFRpbWluZ0Z1bmN0aW9uKG1fYW5pbWF0aW9uLmdldCgpLCBDQUNGQW5pbWF0aW9uR2V0VGltaW5n RnVuY3Rpb24odmFsdWUtPm1fYW5pbWF0aW9uLmdldCgpKSk7CisgICAgQ0FDRlRpbWluZ0Z1bmN0 aW9uUmVmIHRpbWluZ0Z1bmMgPSBDQUNGQW5pbWF0aW9uR2V0VGltaW5nRnVuY3Rpb24odmFsdWUt Pm1fYW5pbWF0aW9uLmdldCgpKTsKKyAgICBpZiAodGltaW5nRnVuYykKKyAgICAgICAgQ0FDRkFu aW1hdGlvblNldFRpbWluZ0Z1bmN0aW9uKG1fYW5pbWF0aW9uLmdldCgpLCB0aW1pbmdGdW5jKTsK IH0KIAogYm9vbCBQbGF0Zm9ybUNBQW5pbWF0aW9uOjppc1JlbW92ZWRPbkNvbXBsZXRpb24oKSBj b25zdAo= 164485 2012-09-17 20:07:34 -0700 2012-09-17 20:08:43 -0700 patch 96972_patch.txt text/plain 1979 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODg0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE3ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gTnVsbCBjaGVjayB0 aW1pbmcgZnVuY3Rpb24gcmVjZWl2ZWQgZnJvbSBDb3JlQW5pbWF0aW9uIHdoZW4gY2FsbGluZyBD QUNGQW5pbWF0aW9uR2V0VGltaW5nRnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcGF1c2VkLCBzb21lIENTUyBhbmltYXRpb25zIGNh dXNlIENvcmVBbmltYXRpb24gdG8gcGFzcyBiYWNrIGEgbnVsbCB0aW1pbmcgZnVuY3Rpb24gd2hl biBjYWxsaW5nIENBQ0ZBbmltYXRpb25HZXRUaW1pbmdGdW5jdGlvbi4KKyAgICAgICAgVGhpcyBw YXRjaCBmaXhlcyB0aGlzIHNpbXBseSBieSBlbnN1cmluZyB0aGF0IGlmIHRoZSBvdXRwdXQgb2Yg dGhpcyBtZXRob2QgaXMgbnVsbCwgaXQgZG9lcyBub3QgZ2V0IHBhc3NlZCBpbnRvIENBQ0ZBbmlt YXRpb25TZXRUaW1pbmdGdW5jdGlvbgorICAgICAgICB2aWEgdGhlIFBsYXRmb3JtQ0FBbmltYXRp b246OmNvcHlUaW1pbmdGdW5jdGlvbkZyb20gbWV0aG9kLiBDQUNGQW5pbWF0aW9uU2V0VGltaW5n RnVuY3Rpb24gd2lsbCBjcmFzaCBpZiBudWxsIGlzIHBhc3NlZCBpbiBmb3IgaXRzIHRpbWluZ0Z1 bmMgcGFyYW1ldGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRm b3JtQ0FBbmltYXRpb25XaW4uY3BwOgorICAgICAgICAoUGxhdGZvcm1DQUFuaW1hdGlvbjo6Y29w eVRpbWluZ0Z1bmN0aW9uRnJvbSk6CisKIDIwMTItMDktMTcgIERhdmlkIEJhcnRvbiAgPGRiYXJ0 b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgQ29udmVydCBNYXRoTUwgdG8gdXNlIGZsZXhi b3hlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRm b3JtQ0FBbmltYXRpb25XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhL3dpbi9QbGF0Zm9ybUNBQW5pbWF0aW9uV2luLmNwcAkocmV2aXNpb24g MTI4ODQwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL1BsYXRm b3JtQ0FBbmltYXRpb25XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTYsNyArMjk2LDkgQEAg dm9pZCBQbGF0Zm9ybUNBQW5pbWF0aW9uOjpzZXRUaW1pbmdGdW5jdAogCiB2b2lkIFBsYXRmb3Jt Q0FBbmltYXRpb246OmNvcHlUaW1pbmdGdW5jdGlvbkZyb20oY29uc3QgUGxhdGZvcm1DQUFuaW1h dGlvbiogdmFsdWUpCiB7Ci0gICAgQ0FDRkFuaW1hdGlvblNldFRpbWluZ0Z1bmN0aW9uKG1fYW5p bWF0aW9uLmdldCgpLCBDQUNGQW5pbWF0aW9uR2V0VGltaW5nRnVuY3Rpb24odmFsdWUtPm1fYW5p bWF0aW9uLmdldCgpKSk7CisgICAgQ0FDRlRpbWluZ0Z1bmN0aW9uUmVmIHRpbWluZ0Z1bmMgPSBD QUNGQW5pbWF0aW9uR2V0VGltaW5nRnVuY3Rpb24odmFsdWUtPm1fYW5pbWF0aW9uLmdldCgpKTsK KyAgICBpZiAodGltaW5nRnVuYykKKyAgICAgICAgQ0FDRkFuaW1hdGlvblNldFRpbWluZ0Z1bmN0 aW9uKG1fYW5pbWF0aW9uLmdldCgpLCB0aW1pbmdGdW5jKTsKIH0KIAogYm9vbCBQbGF0Zm9ybUNB QW5pbWF0aW9uOjppc1JlbW92ZWRPbkNvbXBsZXRpb24oKSBjb25zdAo=