96948 2012-09-17 13:08:29 -0700 [chromium] Enable shouldGesturesTriggerActive for Android 2013-02-05 14:06:14 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rbyers yusufo aelias jamesr klobag leviw rbyers skyostil webkit.review.bot yusufo oldest_to_newest 722207 0 rbyers 2012-09-17 13:08:29 -0700 In https://bugs.webkit.org/show_bug.cgi?id=96060 chromium got support for triggering the 'active' state via gesture events. This is disabled on Android for now due to lack of GestureTapCancel support in the gesture recognizer there. Once it's added and plumbed into WebKit, shouldGesturesTriggerActive in EventHandler.cpp should be updated to enable the support in Android as well. 758519 1 rbyers 2012-11-05 07:32:56 -0800 Note that this will fix the performance problem with touchstart triggering hover/active states (makes the touchstart hit-test a readonly test). 790918 2 179331 yusufo 2012-12-13 14:17:27 -0800 Created attachment 179331 Patch 791027 3 rbyers 2012-12-13 15:42:28 -0800 Have you already done the work elsewhere to send GestureTapCancel such that TapDown is always followed by either Tap or TapCancel? It was the lack of any GestureTapCancel event that led me to have this be disabled on Android. 791039 4 yusufo 2012-12-13 15:52:05 -0800 (In reply to comment #3) > Have you already done the work elsewhere to send GestureTapCancel such that TapDown is always followed by either Tap or TapCancel? It was the lack of any GestureTapCancel event that led me to have this be disabled on Android. In gesture_event_filter, we have added gestureLongPress and gestureDoubleTap to the gestures that can follow a gestureTapDown. So right now TapDown is always folled by Tap, DoubleTap or DoubleTap for us. I think it is still OK even if we don't introduce TapCancel, right? 791051 5 rbyers 2012-12-13 16:00:41 -0800 No, I don't think that's enough. EventHandler::handleGestureEvent assumes that TapDown is followed by either a Tap or TapCancel. Otherwise you may find 'active' states getting stuck on (i.e. a missing Release hit test). We thought about just looking for some set of specific events rather than introducing TapCancel, but we decided that would be too brittle - different platforms may have different events that follow and it's a pain to update them. So figured it was better to require the platform to explicitly tell us when a Tap is no longer possible. 791723 6 179331 jamesr 2012-12-14 11:18:56 -0800 Comment on attachment 179331 Patch R- for now based on rbyer's comments that this won't work yet 825622 7 179331 yusufo 2013-02-05 10:40:29 -0800 Comment on attachment 179331 Patch We have landed all the changes necessary to handle this properly on Android. All TapDown are followed by a Tap or TapCancel right now. 825634 8 179331 jamesr 2013-02-05 10:49:15 -0800 Comment on attachment 179331 Patch Any way to test this? 825639 9 yusufo 2013-02-05 10:55:04 -0800 I think the original bug that introduced this change https://bugs.webkit.org/show_bug.cgi?id=96060 has the related tests. I will verify that those tests are running for us and then flip the cq flag. 825664 10 179331 yusufo 2013-02-05 11:23:48 -0800 Comment on attachment 179331 Patch Verified that these tests are not disabled for us in TestExpectations chromium and chromium-android. After the change they should start running with the right behavior. 825687 11 179331 webkit.review.bot 2013-02-05 12:03:24 -0800 Comment on attachment 179331 Patch Rejecting attachment 179331 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 179331, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13563 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 53>At revision 13563. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/16365947 825763 12 186690 yusufo 2013-02-05 13:18:25 -0800 Created attachment 186690 Patch 825766 13 yusufo 2013-02-05 13:20:16 -0800 Sorry, it looks I had to fix the Changelog. Fixed it and added the test related info on the Changelog. Can you review again and push it to CQ if it looks good? 825794 14 186690 webkit.review.bot 2013-02-05 14:06:09 -0800 Comment on attachment 186690 Patch Clearing flags on attachment: 186690 Committed r141929: <http://trac.webkit.org/changeset/141929> 825795 15 webkit.review.bot 2013-02-05 14:06:14 -0800 All reviewed patches have been landed. Closing bug. 179331 2012-12-13 14:17:27 -0800 2013-02-05 13:18:23 -0800 Patch bug-96948-20121213141447.patch text/plain 1561 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQyY2ZhNmNiODVhNDdm MmM4MzA3NTdlZjdhNDNmMmRlZTY4MTE2OC4uMDRjOGVlMzA2MTAwYjdiMzZjY2NhMzgzMjE1NTdj M2YxYjgyMWY5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTEzICBZdXN1 ZiBPenV5c2FsICA8eXVzdWZvQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBFbmFi bGUgc2hvdWxkR2VzdHVyZXNUcmlnZ2VyQWN0aXZlIGZvciBBbmRyb2lkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk0OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdGhpcyB0byBmaXggcGVy Zm9ybWFuY2UgaXNzdWVzIHdlIGFyZSBnZXR0aW5nIGJlY2F1c2Ugb2YgdG91Y2hzdGFydAorICAg ICAgICB0cmlnZ2VyaW5nIGhvdmVyL2FjdGl2ZSBzdGF0ZXMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpzaG91bGRHZXN0dXJlc1RyaWdnZXJBY3RpdmUpOgorCiAyMDEyLTEyLTA3ICBM ZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9y dCBmb3IgdHJhY2tpbmcgaGl0IHRlc3QgcmVjdGFuZ2xlcyB0byBlbmFibGUgZmFzdCBldmVudCBy ZWplY3Rpb24gaW4gdGhlIGNvbXBvc2l0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAppbmRleCAyZjQyOWE3NTg4ZDRkMTVhYjkzMjAwNjRlODhmMzRiNDZhMmY0Njc2Li43MGM1Zjc0 ZWE5NmY4Zjk2NjQ0NzU0NWZkNTA1MDYzZGRmZGEzODQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCkBAIC0yOTYsNyArMjk2LDcgQEAgc3RhdGljIGlubGluZSBib29sIHNob3Vs ZEdlc3R1cmVzVHJpZ2dlckFjdGl2ZSgpCiAgICAgLy8gSWYgdGhlIHBsYXRmb3JtIHdlJ3JlIG9u IHN1cHBvcnRzIEdlc3R1cmVUYXBEb3duIGFuZCBHZXN0dXJlVGFwQ2FuY2VsIHRoZW4gd2UnbGwK ICAgICAvLyByZWx5IG9uIHRoZW0gdG8gc2V0IHRoZSBhY3RpdmUgc3RhdGUuIFVuZm9ydHVuYXRl bHkgdGhlcmUncyBubyBnZW5lcmljIHdheSB0bwogICAgIC8vIGtub3cgaW4gYWR2YW5jZSB3aGF0 IGV2ZW50IHR5cGVzIGFyZSBzdXBwb3J0ZWQuCi0jaWYgUExBVEZPUk0oQ0hST01JVU0pICYmICFP UyhBTkRST0lEKQorI2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgIHJldHVybiB0cnVlOwogI2Vs c2UKICAgICByZXR1cm4gZmFsc2U7Cg== 186690 2013-02-05 13:18:25 -0800 2013-02-05 14:06:08 -0800 Patch bug-96948-20130205131503.patch text/plain 1648 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQxODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTdlM2MwNjcwODNmYzlk YWJmNDUxMzI3ZjNhMjQzZjM0NGJjMDdiYS4uZjA1YjA3YTlhNjkzOTczNWQzMTRhMzhlNGQ2NmQ0 YmFjODUwOTQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTA1ICBZdXN1 ZiBPenV5c2FsICA8eXVzdWZvQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBFbmFi bGUgc2hvdWxkR2VzdHVyZXNUcmlnZ2VyQWN0aXZlIGZvciBBbmRyb2lkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njk0OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdGhpcyB0byBmaXggcGVy Zm9ybWFuY2UgaXNzdWVzIHdlIGFyZSBnZXR0aW5nIGJlY2F1c2Ugb2YgdG91Y2hzdGFydCAKKyAg ICAgICAgdHJpZ2dlcmluZyBob3Zlci9hY3RpdmUgc3RhdGVzLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gVGhlIHRlc3RzIGludHJvZHVjZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2MDYwCisgICAgICAgIHNob3VsZCBydW4gd2l0aCB0aGUgY29ycmVjdGVk IGJlaGF2aW9yIGFuZCB3b3VsZCBjb3ZlciB0aGlzIGNoYW5nZSBhcyB3ZWxsLgorCisgICAgICAg ICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkR2VzdHVy ZXNUcmlnZ2VyQWN0aXZlKToKKwogMjAxMy0wMi0wNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0MTg2NS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBhYjcwMjI3MmRmZDQ4ZmE4MmQx NzFiMGJiNzE1NjNjYWM2MzBiYzg4Li42ODZlMjVjZWZhZjFmNjlkNWY4YWNjMThmZWY2NDI3OWE5 N2Q1ODQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yODIsNyArMjgy LDcgQEAgc3RhdGljIGlubGluZSBib29sIHNob3VsZEdlc3R1cmVzVHJpZ2dlckFjdGl2ZSgpCiAg ICAgLy8gSWYgdGhlIHBsYXRmb3JtIHdlJ3JlIG9uIHN1cHBvcnRzIEdlc3R1cmVUYXBEb3duIGFu ZCBHZXN0dXJlVGFwQ2FuY2VsIHRoZW4gd2UnbGwKICAgICAvLyByZWx5IG9uIHRoZW0gdG8gc2V0 IHRoZSBhY3RpdmUgc3RhdGUuIFVuZm9ydHVuYXRlbHkgdGhlcmUncyBubyBnZW5lcmljIHdheSB0 bwogICAgIC8vIGtub3cgaW4gYWR2YW5jZSB3aGF0IGV2ZW50IHR5cGVzIGFyZSBzdXBwb3J0ZWQu Ci0jaWYgUExBVEZPUk0oQ0hST01JVU0pICYmICFPUyhBTkRST0lEKQorI2lmIFBMQVRGT1JNKENI Uk9NSVVNKQogICAgIHJldHVybiB0cnVlOwogI2Vsc2UKICAgICByZXR1cm4gZmFsc2U7Cg==