96941 2012-09-17 12:24:31 -0700 Make CSS.PrefixUsage histogram smaller to save memory 2012-09-17 14:10:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth cmarcelo jamesr macpherson menard ojan webkit.review.bot oldest_to_newest 722160 0 tony 2012-09-17 12:24:31 -0700 Make CSS.PrefixUsage histogram smaller to save memory 722163 1 164439 tony 2012-09-17 12:29:16 -0700 Created attachment 164439 Patch 722166 2 tony 2012-09-17 12:30:02 -0700 jar was unhappy about the memory usage of this histogram. This improves on the situation. 722169 3 164439 ojan 2012-09-17 12:31:51 -0700 Comment on attachment 164439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164439&action=review > Source/WebCore/css/CSSParser.cpp:10421 > + static const int CSSPropertyHistogramSize = numCSSProperties; cssPropertyHistogramSize ? 722225 4 164447 tony 2012-09-17 13:38:03 -0700 Created attachment 164447 Patch for landing 722261 5 164447 webkit.review.bot 2012-09-17 14:10:40 -0700 Comment on attachment 164447 Patch for landing Clearing flags on attachment: 164447 Committed r128804: <http://trac.webkit.org/changeset/128804> 722262 6 webkit.review.bot 2012-09-17 14:10:44 -0700 All reviewed patches have been landed. Closing bug. 164439 2012-09-17 12:29:16 -0700 2012-09-17 13:38:00 -0700 Patch bug-96941-20120917122844.patch text/plain 2570 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI3ZjJmNTBmYWRhMjkx ZDFhZTZiZTcxN2QzM2RkYTc2MzI2NGM0OC4uMWRmOTBjMzNmMjU0YWM4ODhlNTY2ZWI1NWQ4MjJh NDViNTJjMTA1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTE3ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBDU1MuUHJlZml4VXNh Z2UgaGlzdG9ncmFtIHNtYWxsZXIgdG8gc2F2ZSBtZW1vcnkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2OTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFjaCBidWNrZXQgY29zdHMgYWJvdXQgMTIgYnl0 ZXMuIFRoaXMgcmVkdWNlcyB0aGUgc2l6ZSBvZiB0aGUgaGlzdG9ncmFtCisgICAgICAgIGZyb20g NjAwIHRvIDM4NCwgd2hpY2ggd2lsbCBzYXZlIGFib3V0IDIuNWsgcGVyIHJlbmRlcmVyIGFuZCBi cm93c2VyCisgICAgICAgIHByb2Nlc3MuCisKKyAgICAgICAgSW4gdGhlIGxvbmcgcnVuLCB3ZSBj b3VsZCBwcm9iYWJseSBnZW5lcmF0ZSBhIHRhYmxlIGluIG1ha2Vwcm9wLnBsIHRoYXQKKyAgICAg ICAgb25seSBoYXMgdGhlIHdlYmtpdCBwcmVmaXggdmFsdWVzIHRvIHNhdmUgZXZlbiBtb3JlIG1l bW9yeSAodGhlcmUgYXJlCisgICAgICAgIDE5NCBwcm9wZXJ0aWVzIHRoYXQgc3RhcnQgd2l0aCAt d2Via2l0KS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3JpbmcuCisKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNzc1Byb3BlcnR5 SUQpOgorCiAyMDEyLTA5LTE3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgV2Ugc2hvdWxkIG1ha2UgY29sbGVjdGluZyBtZXRyaWNzIGVhc2llciBieSBhZGRpbmcg YW4gSURMIGF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCBkNWU1YjdkZmY1 MGQzZTIyMGIwNjkyM2EzNjk5MmM1MzMyMjlmZmUyLi43ZTdiYzRiMWNkY2JlYzliMjI5Njk4MjE4 OWUyNDA3YWQ5OTEwMDU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMTA0MTgsMTIg KzEwNDE4LDEyIEBAIHN0YXRpYyBDU1NQcm9wZXJ0eUlEIGNzc1Byb3BlcnR5SUQoY29uc3QgQ2hh cmFjdGVyVHlwZSogcHJvcGVydHlOYW1lLCB1bnNpZ25lZCBsCiAgICAgY29uc3QgUHJvcGVydHkq IGhhc2hUYWJsZUVudHJ5ID0gZmluZFByb3BlcnR5KG5hbWUsIGxlbmd0aCk7CiAgICAgY29uc3Qg Q1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEID0gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxD U1NQcm9wZXJ0eUlEPihoYXNoVGFibGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOwog Ci0gICAgLy8gNjAwIGlzIGNvbWZvcnRhYmx5IGxhcmdlciB0aGFuIG51bUNTU1Byb3BlcnRpZXMg dG8gYWxsb3cgZm9yIGdyb3d0aAotICAgIHN0YXRpYyBjb25zdCBpbnQgQ1NTUHJvcGVydHlIaXN0 b2dyYW1TaXplID0gNjAwOwotICAgIENPTVBJTEVfQVNTRVJUKENTU1Byb3BlcnR5SGlzdG9ncmFt U2l6ZSA+IG51bUNTU1Byb3BlcnRpZXMsIG51bWJlcl9vZl9jc3NfcHJvcGVydGllc19leGNlZWRf Q1NTUHJvcGVydHlIaXN0b2dyYW1TaXplKTsKLQotICAgIGlmIChoYXNQcmVmaXgoYnVmZmVyLCBs ZW5ndGgsICItd2Via2l0LSIpICYmIHByb3BlcnR5SUQgIT0gQ1NTUHJvcGVydHlJbnZhbGlkKQot ICAgICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiQ1NTLlByZWZp eFVzYWdlIiwgbWF4KDEsIHByb3BlcnR5SUQgLSBmaXJzdENTU1Byb3BlcnR5KSwgQ1NTUHJvcGVy dHlIaXN0b2dyYW1TaXplKTsKKyAgICBzdGF0aWMgY29uc3QgaW50IENTU1Byb3BlcnR5SGlzdG9n cmFtU2l6ZSA9IG51bUNTU1Byb3BlcnRpZXM7CisgICAgaWYgKGhhc1ByZWZpeChidWZmZXIsIGxl bmd0aCwgIi13ZWJraXQtIikgJiYgcHJvcGVydHlJRCAhPSBDU1NQcm9wZXJ0eUludmFsaWQpIHsK KyAgICAgICAgaW50IGhpc3RvZ3JhbVZhbHVlID0gcHJvcGVydHlJRCAtIGZpcnN0Q1NTUHJvcGVy dHk7CisgICAgICAgIEFTU0VSVCgwIDw9IGhpc3RvZ3JhbVZhbHVlICYmIGhpc3RvZ3JhbVZhbHVl IDwgQ1NTUHJvcGVydHlIaXN0b2dyYW1TaXplKTsKKyAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6 aGlzdG9ncmFtRW51bWVyYXRpb24oIkNTUy5QcmVmaXhVc2FnZSIsIGhpc3RvZ3JhbVZhbHVlLCBD U1NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUpOworICAgIH0KIAogICAgIHJldHVybiBwcm9wZXJ0eUlE OwogfQo= 164447 2012-09-17 13:38:03 -0700 2012-09-17 14:10:40 -0700 Patch for landing bug-96941-20120917133731.patch text/plain 2566 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI3ZjJmNTBmYWRhMjkx ZDFhZTZiZTcxN2QzM2RkYTc2MzI2NGM0OC4uMjc2NGFkZDc5ZWRmYTFhOTBmZGQ2YmRjOTc4ZTEw ZDA2NjJiOWU5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTE3ICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBDU1MuUHJlZml4VXNh Z2UgaGlzdG9ncmFtIHNtYWxsZXIgdG8gc2F2ZSBtZW1vcnkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2OTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg T2phbiBWYWZhaS4KKworICAgICAgICBFYWNoIGJ1Y2tldCBjb3N0cyBhYm91dCAxMiBieXRlcy4g VGhpcyByZWR1Y2VzIHRoZSBzaXplIG9mIHRoZSBoaXN0b2dyYW0KKyAgICAgICAgZnJvbSA2MDAg dG8gMzg0LCB3aGljaCB3aWxsIHNhdmUgYWJvdXQgMi41ayBwZXIgcmVuZGVyZXIgYW5kIGJyb3dz ZXIKKyAgICAgICAgcHJvY2Vzcy4KKworICAgICAgICBJbiB0aGUgbG9uZyBydW4sIHdlIGNvdWxk IHByb2JhYmx5IGdlbmVyYXRlIGEgdGFibGUgaW4gbWFrZXByb3AucGwgdGhhdAorICAgICAgICBv bmx5IGhhcyB0aGUgd2Via2l0IHByZWZpeCB2YWx1ZXMgdG8gc2F2ZSBldmVuIG1vcmUgbWVtb3J5 ICh0aGVyZSBhcmUKKyAgICAgICAgMTk0IHByb3BlcnRpZXMgdGhhdCBzdGFydCB3aXRoIC13ZWJr aXQpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywganVzdCByZWZhY3RvcmluZy4KKworICAgICAg ICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3NzUHJvcGVydHlJRCk6 CisKIDIwMTItMDktMTcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBXZSBzaG91bGQgbWFrZSBjb2xsZWN0aW5nIG1ldHJpY3MgZWFzaWVyIGJ5IGFkZGluZyBhbiBJ REwgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGQ1ZTViN2RmZjUwZDNl MjIwYjA2OTIzYTM2OTkyYzUzMzIyOWZmZTIuLmVmZDliYWUzYTA2OGRkZTVlZDE5ZWY4M2NhNzU0 Yzc2MjZlODE4MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC0xMDQxOCwxMiArMTA0 MTgsMTIgQEAgc3RhdGljIENTU1Byb3BlcnR5SUQgY3NzUHJvcGVydHlJRChjb25zdCBDaGFyYWN0 ZXJUeXBlKiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGwKICAgICBjb25zdCBQcm9wZXJ0eSogaGFz aFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsKICAgICBjb25zdCBDU1NQ cm9wZXJ0eUlEIHByb3BlcnR5SUQgPSBoYXNoVGFibGVFbnRyeSA/IHN0YXRpY19jYXN0PENTU1By b3BlcnR5SUQ+KGhhc2hUYWJsZUVudHJ5LT5pZCkgOiBDU1NQcm9wZXJ0eUludmFsaWQ7CiAKLSAg ICAvLyA2MDAgaXMgY29tZm9ydGFibHkgbGFyZ2VyIHRoYW4gbnVtQ1NTUHJvcGVydGllcyB0byBh bGxvdyBmb3IgZ3Jvd3RoCi0gICAgc3RhdGljIGNvbnN0IGludCBDU1NQcm9wZXJ0eUhpc3RvZ3Jh bVNpemUgPSA2MDA7Ci0gICAgQ09NUElMRV9BU1NFUlQoQ1NTUHJvcGVydHlIaXN0b2dyYW1TaXpl ID4gbnVtQ1NTUHJvcGVydGllcywgbnVtYmVyX29mX2Nzc19wcm9wZXJ0aWVzX2V4Y2VlZF9DU1NQ cm9wZXJ0eUhpc3RvZ3JhbVNpemUpOwotCi0gICAgaWYgKGhhc1ByZWZpeChidWZmZXIsIGxlbmd0 aCwgIi13ZWJraXQtIikgJiYgcHJvcGVydHlJRCAhPSBDU1NQcm9wZXJ0eUludmFsaWQpCi0gICAg ICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhpc3RvZ3JhbUVudW1lcmF0aW9uKCJDU1MuUHJlZml4VXNh Z2UiLCBtYXgoMSwgcHJvcGVydHlJRCAtIGZpcnN0Q1NTUHJvcGVydHkpLCBDU1NQcm9wZXJ0eUhp c3RvZ3JhbVNpemUpOworICAgIHN0YXRpYyBjb25zdCBpbnQgY3NzUHJvcGVydHlIaXN0b2dyYW1T aXplID0gbnVtQ1NTUHJvcGVydGllczsKKyAgICBpZiAoaGFzUHJlZml4KGJ1ZmZlciwgbGVuZ3Ro LCAiLXdlYmtpdC0iKSAmJiBwcm9wZXJ0eUlEICE9IENTU1Byb3BlcnR5SW52YWxpZCkgeworICAg ICAgICBpbnQgaGlzdG9ncmFtVmFsdWUgPSBwcm9wZXJ0eUlEIC0gZmlyc3RDU1NQcm9wZXJ0eTsK KyAgICAgICAgQVNTRVJUKDAgPD0gaGlzdG9ncmFtVmFsdWUgJiYgaGlzdG9ncmFtVmFsdWUgPCBj c3NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUpOworICAgICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0 b2dyYW1FbnVtZXJhdGlvbigiQ1NTLlByZWZpeFVzYWdlIiwgaGlzdG9ncmFtVmFsdWUsIGNzc1By b3BlcnR5SGlzdG9ncmFtU2l6ZSk7CisgICAgfQogCiAgICAgcmV0dXJuIHByb3BlcnR5SUQ7CiB9 Cg==