96937 2012-09-17 11:56:41 -0700 OpenGL building issue when compiling for Harmattan 2012-09-18 05:24:27 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 lpapp lauro.neto dino hausmann lauro.neto noam webkit.review.bot oldest_to_newest 722134 0 lpapp 2012-09-17 11:56:41 -0700 There are two issues: 1) PFNGL* 2) GLchar not typedef'd for Harmattan so a workaround needs to be added in here, just like it was done for the QtBase project. In file included from platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:37: platform/graphics/opengl/Extensions3DOpenGLES.h:110: error: 'PFNGLFRAMEBUFFERTEXTURE2DMULTISAMPLEIMG' does not name a type platform/graphics/opengl/Extensions3DOpenGLES.h:111: error: 'PFNGLRENDERBUFFERSTORAGEMULTISAMPLEIMG' does not name a type platform/graphics/opengl/Extensions3DOpenGLES.h:112: error: 'PFNGLBINDVERTEXARRAYOESPROC' does not name a type platform/graphics/opengl/Extensions3DOpenGLES.h:113: error: 'PFNGLDELETEVERTEXARRAYSOESPROC' does not name a type platform/graphics/opengl/Extensions3DOpenGLES.h:114: error: 'PFNGLGENVERTEXARRAYSOESPROC' does not name a type platform/graphics/opengl/Extensions3DOpenGLES.h:115: error: 'PFNGLISVERTEXARRAYOESPROC' does not name a type platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'void WebCore::GraphicsContext3D::compileShader(Platform3DObject)': platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: 'GLchar' was not declared in this scope platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: template argument 1 is invalid platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: invalid type in declaration before '=' token platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: expected type-specifier before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: expected ')' before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:479: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:480: error: request for member 'get' in 'info', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:482: error: request for member 'get' in 'info', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'bool WebCore::GraphicsContext3D::getActiveAttrib(Platform3DObject, GC3Duint, WebCore::ActiveInfo&)': platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: 'GLchar' was not declared in this scope platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: template argument 1 is invalid platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: invalid type in declaration before '=' token platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: expected type-specifier before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: expected ')' before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:632: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:636: error: request for member 'get' in 'name', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:639: error: request for member 'get' in 'name', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'bool WebCore::GraphicsContext3D::getActiveUniform(Platform3DObject, GC3Duint, WebCore::ActiveInfo&)': platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: 'GLchar' was not declared in this scope platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: template argument 1 is invalid platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: invalid type in declaration before '=' token platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: expected type-specifier before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: expected ')' before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:656: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:660: error: request for member 'get' in 'name', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:664: error: request for member 'get' in 'name', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getProgramInfoLog(Platform3DObject)': platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: 'GLchar' was not declared in this scope platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: template argument 1 is invalid platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: invalid type in declaration before '=' token platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: expected type-specifier before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: expected ')' before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1118: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1119: error: request for member 'get' in 'info', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1121: error: request for member 'get' in 'info', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: In member function 'WTF::String WebCore::GraphicsContext3D::getShaderInfoLog(Platform3DObject)': platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: 'GLchar' was not declared in this scope platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: template argument 1 is invalid platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: invalid type in declaration before '=' token platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: expected type-specifier before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: expected ')' before 'GLchar' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1185: error: cannot convert 'WTF::PassOwnArrayPtr<int>' to 'int' in initialization platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1186: error: request for member 'get' in 'info', which is of non-class type 'int' platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1188: error: request for member 'get' in 'info', which is of non-class type 'int' make[3]: *** [obj/release/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.o] Error 1 make[3]: Leaving directory `/home/lpapp/qt5-beta1/qt5-webkit/qt5-webkit/Source/WebCore' make[2]: *** [sub-Target-pri-make_first-ordered] Error 2 make[2]: Leaving directory `/home/lpapp/qt5-beta1/qt5-webkit/qt5-webkit/Source/WebCore' make[1]: *** [sub-Source-WebCore-WebCore-pro-make_first-ordered] Error 2 make[1]: Leaving directory `/home/lpapp/qt5-beta1/qt5-webkit/qt5-webkit' dh_auto_build: make -j1 returned exit code 2 make: *** [build] Error 9 722369 1 164474 lauro.neto 2012-09-17 16:38:54 -0700 Created attachment 164474 Initial fixes 722370 2 lauro.neto 2012-09-17 16:41:47 -0700 As suggested by Simon over IRC, including qopengles2ext.h from Extensions3DOpenGLES.h helped solve the issue, but just including it causes the build to fail like in https://bugs.webkit.org/show_bug.cgi?id=91030. This is due to qopengles2ext.h defining two of the PFN* extension functions with a PROC suffix (like Khrono's version) while WebKit's own ANGLE copy does not. So, in the first patch are the initial changes to make it past this problem. 722589 3 lpapp 2012-09-18 01:37:31 -0700 Wouldn't a qopengl.h include be enough? That would already have the typedef for the GLchar, and would also include the qopengles2ext.h header. 722655 4 hausmann 2012-09-18 04:27:14 -0700 Part of the problem is that the qopengles2ext.h header has what I believe is a bug. See also https://codereview.qt-project.org/#change,35004 This can be worked around though by avoiding the inclusion of gl2ext.h. 722661 5 164532 hausmann 2012-09-18 04:42:02 -0700 Created attachment 164532 Patch 722688 6 164532 webkit.review.bot 2012-09-18 05:24:23 -0700 Comment on attachment 164532 Patch Clearing flags on attachment: 164532 Committed r128877: <http://trac.webkit.org/changeset/128877> 722689 7 webkit.review.bot 2012-09-18 05:24:27 -0700 All reviewed patches have been landed. Closing bug. 164474 2012-09-17 16:38:54 -0700 2012-09-18 04:41:56 -0700 Initial fixes bug-96937-20120917203830.patch text/plain 1724 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzhlN2JkODM2NDMwZTE5 OGE3N2Y5MWVkNTBmZDg0NWE2YzkxYzJjYS4uOGFlNzg2NzJmYTI4MTVkNGNhM2RkZWNiZWM3NTY4 OTBlYWYxZDE2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE3ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIE9wZW5HTCBidWls ZGluZyBpc3N1ZSB3aGVuIGNvbXBpbGluZyBmb3IgSGFybWF0dGFuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjkzNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZpeGVzIGZvciBIYXJtYXR0YW4u CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdM RVMuaDoKKyAgICAgICAgICAgIEFkZCB0eXBlZGVmIGZvciBHTGNoYXIuCisgICAgICAgICAgICBJ bmNsdWRlIHFvcGVuZ2xlczJleHQuaAorICAgICAgICAgICAgVXNlIHNvbWUgZnVuY3Rpb24gdHlw ZWRlZnMgd2hlbiB1c2luZyB0aGUgaGVhZGVyIGFib3ZlLgorCiAyMDEyLTA5LTE3ICBBbmRyZWkg UG9lbmFydSAgPHBvZW5hcnVAYWRvYmUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERp c3BsYXkgTmFtZWQgRmxvd3MgaW4gdGhlIFRhYmJlZCBQYW5lIG9mIHRoZSAiQ1NTIE5hbWVkIEZs b3dzIiBEcmF3ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmgKaW5kZXggZDUwOGE3Njg0MTA2 OGY2ZjcyMzg1YmI5ZDBhY2ZhZTc2Y2Y5Zjk0ZS4uZjA2NWI3YzMwYTM3ZGY2MGMzY2E4ZjRkZjJi NDIwYmEzZWE3Njk0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmgKQEAgLTMwLDkgKzMw LDEzIEBACiAjaW5jbHVkZSAiRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmgiCiAKICNpbmNsdWRl IDxHTEVTMi9nbDIuaD4KKyNpZiBQTEFURk9STShRVCkKK3R5cGVkZWYgY2hhciAgICAgICAgICAg ICBHTGNoYXI7CisjaW5jbHVkZSA8cW9wZW5nbGVzMmV4dC5oPgorI2VuZGlmCiAjaW5jbHVkZSA8 R0xFUzIvZ2wyZXh0Lmg+CiAKLSNpZiBPUyhRTlgpCisjaWYgT1MoUU5YKSB8fCBQTEFURk9STShR VCkKIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEwMzAu CiAjZGVmaW5lIFBGTkdMRlJBTUVCVUZGRVJURVhUVVJFMkRNVUxUSVNBTVBMRUlNRyBQRk5HTEZS QU1FQlVGRkVSVEVYVFVSRTJETVVMVElTQU1QTEVJTUdQUk9DCiAjZGVmaW5lIFBGTkdMUkVOREVS QlVGRkVSU1RPUkFHRU1VTFRJU0FNUExFSU1HIFBGTkdMUkVOREVSQlVGRkVSU1RPUkFHRU1VTFRJ U0FNUExFSU1HUFJPQwo= 164532 2012-09-18 04:42:02 -0700 2012-09-18 05:24:23 -0700 Patch bug-96937-20120918134354.patch text/plain 1978 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRlMmE2MTA5YmI3MzRj ZjExNjk3MjA0ZWI3NGFmOTlhNjc3ZDA1Ni4uYjcwOTJlYmE1YzVlMTIzN2Q4MzFhMmJjMjY4Njg5 YTM2NWY3YzdmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTE4ICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQGRpZ2lhLmNvbT4KKworICAgICAgICBGaXggY29t cGlsYXRpb24gd2l0aCBRdCA1IG9uIE1lZUdvIDEuMiBIYXJtYXR0YW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2OTM3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGdsMmV4dC5oIGhlYWRlciBmaWxl IG9uIHRoZSBwbGF0Zm9ybSBpcyBvdXRkYXRlZC4gSW5zdGVhZCB1c2UgdGhlIG5ld2VyIGNvcHkg ZnJvbSBRdAorICAgICAgICB0aHJvdWdoIGltcGxpY2l0IGluY2x1c2lvbiBvZiBxb3BlbmdsLmgu IFNpbmNlIFF0J3MgZGVjbGFyYXRpb25zIGFyZSBiYXNlZCBvbiBuZXdlciBLaHJvbm9zCisgICAg ICAgIGhlYWRlcnMsIHRoZSBtdWx0aSBzYW1wbGluZyBleHRlbnNpb25zIGRvIGhhdmUgdGhlIFBS T0Mgc3VmZml4LCB3ZSBuZWVkIHRoZSBzYW1lIHdvcmthcm91bmQKKyAgICAgICAgYXMgUU5YLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVT Lmg6CisKIDIwMTItMDktMTkgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IHIxMjc0NTcgYW5kIGZvbGxvd2luZyBmaXhlcyBk dWUgdG8gc2V2ZXJhbCBoaXQtdGVzdGluZyByZWdyZXNzaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTEVTLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3Bl bkdMRVMuaAppbmRleCBkNTA4YTc2ODQxMDY4ZjZmNzIzODViYjlkMGFjZmFlNzZjZjlmOTRlLi5h NzBlYWE3Y2RiZGJiYTJlM2EzYWFkNTc4ZTViYTFjYzNiMGFjY2M1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMRVMu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9u czNET3BlbkdMRVMuaApAQCAtMjksMTEgKzI5LDE3IEBACiAKICNpbmNsdWRlICJFeHRlbnNpb25z M0RPcGVuR0xDb21tb24uaCIKIAorI2lmIFBMQVRGT1JNKFFUKQorLy8gVGFrZXMgY2FyZSBvZiBk ZWNsYXJpbmcgdGhlIEdMRVMgZXh0ZW5zaW9ucy4KKyNpbmNsdWRlIDxxb3BlbmdsLmg+CisjZWxz ZQogI2luY2x1ZGUgPEdMRVMyL2dsMi5oPgogI2luY2x1ZGUgPEdMRVMyL2dsMmV4dC5oPgorI2Vu ZGlmCiAKLSNpZiBPUyhRTlgpCisjaWYgT1MoUU5YKSB8fCBQTEFURk9STShRVCkKIC8vIFNlZSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEwMzAuCisvLyBOZXdlciBL aG9yb25zIGhlYWRlcnMgZG8gZGVmaW5lIHRoZXNlIHdpdGggYSBQUk9DIHN1ZmZpeCwgYnV0IG9s ZGVyIGhlYWRlcnMgZG9uJ3QuCiAjZGVmaW5lIFBGTkdMRlJBTUVCVUZGRVJURVhUVVJFMkRNVUxU SVNBTVBMRUlNRyBQRk5HTEZSQU1FQlVGRkVSVEVYVFVSRTJETVVMVElTQU1QTEVJTUdQUk9DCiAj ZGVmaW5lIFBGTkdMUkVOREVSQlVGRkVSU1RPUkFHRU1VTFRJU0FNUExFSU1HIFBGTkdMUkVOREVS QlVGRkVSU1RPUkFHRU1VTFRJU0FNUExFSU1HUFJPQwogI2VuZGlmCg==