96936 2012-09-17 11:37:20 -0700 Opt into layers for fixed positioned elements for TiledDrawingArea 2012-10-14 21:20:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin mitz thorton oldest_to_newest 722112 0 bdakin 2012-09-17 11:37:20 -0700 In https://bugs.webkit.org/show_bug.cgi?id=96846 I enabled layer for fixed position elements for DrawingAreaImpls (which is good) but accidentally un-enabled them for TiledCoreAnimationDrawingAreas. We need that code in both classes. 722114 1 164424 bdakin 2012-09-17 11:39:36 -0700 Created attachment 164424 Patch 722122 2 bdakin 2012-09-17 11:49:36 -0700 Thanks Tim! http://trac.webkit.org/changeset/128787 736461 3 mitz 2012-10-07 19:46:03 -0700 (In reply to comment #2) > Thanks Tim! > > http://trac.webkit.org/changeset/128787 This change caused the text in the bottom bar at <https://bugs.webkit.org/attachment.cgi?id=167493&action=review> to lose its subpixel antialiasing. Perhaps this is expected, but it’s worrisome that ever since the “ugly text” issue was introduced, it seems to have only gotten worse. 736891 4 ap 2012-10-08 11:57:57 -0700 This also caused bug 98578 and bug 98579. 741719 5 mitz 2012-10-14 21:20:43 -0700 (In reply to comment #2) > http://trac.webkit.org/changeset/128787 This change also caused bug 99290. 164424 2012-09-17 11:39:36 -0700 2012-09-17 11:41:30 -0700 Patch for-review.txt text/plain 2096 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODc4NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTE3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTY5MzYKKyAgICAgICAgT3B0IGludG8gbGF5ZXJzIGZvciBmaXhl ZCBwb3NpdGlvbmVkIGVsZW1lbnRzIGZvciBUaWxlZERyYXdpbmdBcmVhCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjb2RlIGFscmVhZHkgZXhp c3RzIGluIERyYXdpbmdBcmVhSW1wbCwgYW5kIHdlIG5lZWQgaXQgZm9yIAorICAgICAgICBUaWxl ZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYSBhcyB3ZWxsLgorICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW06CisgICAgICAgIChX ZWJLaXQ6OlRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjp1cGRhdGVQcmVmZXJlbmNlcyk6 CisKIDIwMTItMDktMTcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBEb24ndCBsb2FkIGEgYmxvY2tlZCBwbHVnLWluIGlmIGEgbm9uLWJsb2NrZWQgdmVy c2lvbiBvZiB0aGUgc2FtZSBwbHVnLWluIGV4aXN0cwpJbmRleDogU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29y ZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCShyZXZpc2lvbiAxMjg2NzgpCisrKyBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVh Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDgsNiArMjA4LDEyIEBAIHZvaWQgVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWE6OnVwZGEKICAgICBib29sIHNjcm9sbGluZ1BlcmZvcm1hbmNlTG9n Z2luZ0VuYWJsZWQgPSBtX3dlYlBhZ2UtPnNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJs ZWQoKTsKICAgICBTY3JvbGxpbmdUaHJlYWQ6OmRpc3BhdGNoKGJpbmQoJlNjcm9sbGluZ1RyZWU6 OnNldFNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQsIG1fd2ViUGFnZS0+Y29yZVBh Z2UoKS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKS0+c2Nyb2xsaW5nVHJlZSgpLCBzY3JvbGxpbmdQ ZXJmb3JtYW5jZUxvZ2dpbmdFbmFibGVkKSk7CiAKKyAgICAvLyBTb29uIHdlIHdhbnQgcGFnZXMg d2l0aCBmaXhlZCBwb3NpdGlvbmVkIGVsZW1lbnRzIHRvIGJlIGFibGUgdG8gYmUgc2Nyb2xsZWQg YnkgdGhlIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLgorICAgIC8vIEFzIGEgcGFydCBvZiB0aGF0IHdv cmssIHdlIGhhdmUgdG8gY29tcG9zaXRlIGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzLCBhbmQgd2Ug aGF2ZSB0byBhbGxvdyB0aG9zZQorICAgIC8vIGVsZW1lbnRzIHRvIGNyZWF0ZSBhIHN0YWNraW5n IGNvbnRleHQuCisgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBY2Nl bGVyYXRlZENvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQodHJ1ZSk7CisgICAgbV93 ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0 YWNraW5nQ29udGV4dCh0cnVlKTsKKwogICAgIGJvb2wgc2hvd0RlYnVnQm9yZGVycyA9IG1fd2Vi UGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS0+c2hvd0RlYnVnQm9yZGVycygpOwogCiAgICAg aWYgKHNob3dEZWJ1Z0JvcmRlcnMgPT0gISFtX2RlYnVnSW5mb0xheWVyKQo=