96921 2012-09-17 07:49:43 -0700 [Qt] Use UndoStep::editingAction() to set the text of undo/redo actions 2012-09-18 07:04:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo kenneth vestbo oldest_to_newest 721922 0 cmarcelo 2012-09-17 07:49:43 -0700 [Qt] Use UndoStep::editingAction() to set the text of undo/redo actions 721928 1 164395 cmarcelo 2012-09-17 07:55:27 -0700 Created attachment 164395 Patch 722251 2 164395 rniwa 2012-09-17 13:57:43 -0700 Comment on attachment 164395 Patch rs=me. 722748 3 cmarcelo 2012-09-18 07:04:54 -0700 Committed r128889: <http://trac.webkit.org/changeset/128889> 164395 2012-09-17 07:55:27 -0700 2012-09-17 13:57:42 -0700 Patch bug-96921-20120917115455.patch text/plain 6391 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDg3NGM5OWRlZWM0 NjVmM2FkYWZjZGFmNzBlZmE5M2M5ZDc2YTRiMzAuLjQwZjMxYzg3YjU3ZGExYjI3ZTI4OTA5ZDQ1 ZWI2YmQ1ZGNhYzkwNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDkt MTcgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJv c3NhLm9yZz4KKworICAgICAgICBbUXRdIFVzZSBVbmRvU3RlcDo6ZWRpdGluZ0FjdGlvbigpIHRv IHNldCB0aGUgdGV4dCBvZiB1bmRvL3JlZG8gYWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY5MjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIHRleHQgb2YgUVVuZG9Db21tYW5kcyB3 ZSBjcmVhdGUgZm9yIHVuZG8vcmVkbyBhY3Rpb25zIGJhc2VkIG9uIHRoZQorICAgICAgICBlZGl0 aW5nIGFjdGlvbiBmcm9tIFVuZG9TdGVwLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIHZpc2li bGUgdXNpbmcgUXRUZXN0QnJvd3NlciwgYW5kIGxvb2tpbmcgYXQgdGhlIEVkaXQgbWVudSBhZnRl cgorICAgICAgICBkb2luZyBIVE1MIGVkaXRpbmcgY2hhbmdlcy4gSSd2ZSB1c2VkIGh0dHA6Ly9z aW1wbGUtcnRlLnJuaXdhLmNvbSBmb3IgdGVzdGluZy4KKworICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L1VuZG9TdGVwUXQuY3BwOgorICAgICAgICAodW5kb05hbWVGb3JFZGl0QWN0aW9uKTogVGhp cyBmdW5jdGlvbiByZXR1cm5zIGEgbG9jYWxpemVkIG5hbWUgb2YgdGhlIGFjdGlvbi4KKyAgICAg ICAgKFVuZG9TdGVwUXQ6OlVuZG9TdGVwUXQpOiBTZXQgdGhlIHRleHQgYmFzZWQgb24gVW5kb1N0 ZXA6OmVkaXRpbmdBY3Rpb24uCisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdl LmNwcDoKKyAgICAgICAgKHRzdF9RV2ViUGFnZSk6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OnVu ZG9BY3Rpb25IYXZlQ3VzdG9tVGV4dCk6IENyZWF0ZSBhIG5ldyB0ZXN0IHRvIHZlcmlmeSB0aGF0 IHRoZSB0ZXh0CisgICAgICAgIGRlc2NyaWJpbmcgdGhlIHVuZG8gYWN0aW9uIGFmdGVyIGluc2Vy dGluZyBhIHRleHQgYW5kIGluZGVudGluZyB0aGUgdGV4dCBpcyBkaWZmZXJlbnQuCisKIDIwMTIt MDktMTcgIExlbyBGcmFuY2hpICA8bGZyYW5jaGlAa2RlLm9yZz4KIAogICAgICAgICBbUXRdIElu c3BlY3RvciBXZWJTb2NrZXQgYmFja2VuZCBwcm90b2NvbCB1cGRhdGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvVW5kb1N0ZXBRdC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L1VuZG9TdGVwUXQuY3BwCmluZGV4IDRmNDc4ZWI2MWQ4Yzc2 ZjQ5YmIxYTI2NmVkMzhmZjEzMjM5MjRiZTYuLjE1ZGYyZWU1MDJjNjFmMWMxNDhkYmNlNzMwYTQz OTA5ZDY5MjZlZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv VW5kb1N0ZXBRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9VbmRv U3RlcFF0LmNwcApAQCAtMjMsMTEgKzIzLDk1IEBACiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK IAogI2lmbmRlZiBRVF9OT19VTkRPQ09NTUFORAorc3RhdGljIFFTdHJpbmcgdW5kb05hbWVGb3JF ZGl0QWN0aW9uKGNvbnN0IEVkaXRBY3Rpb24gZWRpdEFjdGlvbikKK3sKKyAgICBzd2l0Y2ggKGVk aXRBY3Rpb24pIHsKKyAgICBjYXNlIEVkaXRBY3Rpb25VbnNwZWNpZmllZDoKKyAgICAgICAgcmV0 dXJuIFFTdHJpbmcoKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25TZXRDb2xvcjoKKyAgICAgICAgcmV0 dXJuIFFPYmplY3Q6OnRyKCJTZXQgQ29sb3IiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25TZXRCYWNr Z3JvdW5kQ29sb3I6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiU2V0IEJhY2tncm91bmQg Q29sb3IiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25UdXJuT2ZmS2VybmluZzoKKyAgICAgICAgcmV0 dXJuIFFPYmplY3Q6OnRyKCJUdXJuIE9mZiBLZXJuaW5nIik7CisgICAgY2FzZSBFZGl0QWN0aW9u VGlnaHRlbktlcm5pbmc6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiVGlnaHRlbiBLZXJu aW5nIik7CisgICAgY2FzZSBFZGl0QWN0aW9uTG9vc2VuS2VybmluZzoKKyAgICAgICAgcmV0dXJu IFFPYmplY3Q6OnRyKCJMb29zZW4gS2VybmluZyIpOworICAgIGNhc2UgRWRpdEFjdGlvblVzZVN0 YW5kYXJkS2VybmluZzoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJVc2UgU3RhbmRhcmQg S2VybmluZyIpOworICAgIGNhc2UgRWRpdEFjdGlvblR1cm5PZmZMaWdhdHVyZXM6CisgICAgICAg IHJldHVybiBRT2JqZWN0Ojp0cigiVHVybiBPZmYgTGlnYXR1cmVzIik7CisgICAgY2FzZSBFZGl0 QWN0aW9uVXNlU3RhbmRhcmRMaWdhdHVyZXM6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigi VXNlIFN0YW5kYXJkIExpZ2F0dXJlcyIpOworICAgIGNhc2UgRWRpdEFjdGlvblVzZUFsbExpZ2F0 dXJlczoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJVc2UgQWxsIExpZ2F0dXJlcyIpOwor ICAgIGNhc2UgRWRpdEFjdGlvblJhaXNlQmFzZWxpbmU6CisgICAgICAgIHJldHVybiBRT2JqZWN0 Ojp0cigiUmFpc2UgQmFzZWxpbmUiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25Mb3dlckJhc2VsaW5l OgorICAgICAgICByZXR1cm4gUU9iamVjdDo6dHIoIkxvd2VyIEJhc2VsaW5lIik7CisgICAgY2Fz ZSBFZGl0QWN0aW9uU2V0VHJhZGl0aW9uYWxDaGFyYWN0ZXJTaGFwZToKKyAgICAgICAgcmV0dXJu IFFPYmplY3Q6OnRyKCJTZXQgVHJhZGl0aW9uYWwgQ2hhcmFjdGVyIFNoYXBlIik7CisgICAgY2Fz ZSBFZGl0QWN0aW9uU2V0Rm9udDoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJTZXQgRm9u dCIpOworICAgIGNhc2UgRWRpdEFjdGlvbkNoYW5nZUF0dHJpYnV0ZXM6CisgICAgICAgIHJldHVy biBRT2JqZWN0Ojp0cigiQ2hhbmdlIEF0dHJpYnV0ZXMiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25B bGlnbkxlZnQ6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiQWxpZ24gTGVmdCIpOworICAg IGNhc2UgRWRpdEFjdGlvbkFsaWduUmlnaHQ6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigi QWxpZ24gUmlnaHQiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25DZW50ZXI6CisgICAgICAgIHJldHVy biBRT2JqZWN0Ojp0cigiQ2VudGVyIik7CisgICAgY2FzZSBFZGl0QWN0aW9uSnVzdGlmeToKKyAg ICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJKdXN0aWZ5Iik7CisgICAgY2FzZSBFZGl0QWN0aW9u U2V0V3JpdGluZ0RpcmVjdGlvbjoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJTZXQgV3Jp dGluZyBEaXJlY3Rpb24iKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25TdWJzY3JpcHQ6CisgICAgICAg IHJldHVybiBRT2JqZWN0Ojp0cigiU3Vic2NyaXB0Iik7CisgICAgY2FzZSBFZGl0QWN0aW9uU3Vw ZXJzY3JpcHQ6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiU3VwZXJzY3JpcHQiKTsKKyAg ICBjYXNlIEVkaXRBY3Rpb25VbmRlcmxpbmU6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigi VW5kZXJsaW5lIik7CisgICAgY2FzZSBFZGl0QWN0aW9uT3V0bGluZToKKyAgICAgICAgcmV0dXJu IFFPYmplY3Q6OnRyKCJPdXRsaW5lIik7CisgICAgY2FzZSBFZGl0QWN0aW9uVW5zY3JpcHQ6Cisg ICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiVW5zY3JpcHQiKTsKKyAgICBjYXNlIEVkaXRBY3Rp b25EcmFnOgorICAgICAgICByZXR1cm4gUU9iamVjdDo6dHIoIkRyYWciKTsKKyAgICBjYXNlIEVk aXRBY3Rpb25DdXQ6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiQ3V0Iik7CisgICAgY2Fz ZSBFZGl0QWN0aW9uUGFzdGU6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiUGFzdGUiKTsK KyAgICBjYXNlIEVkaXRBY3Rpb25QYXN0ZUZvbnQ6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0 cigiUGFzdGUgRm9udCIpOworICAgIGNhc2UgRWRpdEFjdGlvblBhc3RlUnVsZXI6CisgICAgICAg IHJldHVybiBRT2JqZWN0Ojp0cigiUGFzdGUgUnVsZXIiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25U eXBpbmc6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiVHlwaW5nIik7CisgICAgY2FzZSBF ZGl0QWN0aW9uQ3JlYXRlTGluazoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJDcmVhdGUg TGluayIpOworICAgIGNhc2UgRWRpdEFjdGlvblVubGluazoKKyAgICAgICAgcmV0dXJuIFFPYmpl Y3Q6OnRyKCJVbmxpbmsiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25JbnNlcnRMaXN0OgorICAgICAg ICByZXR1cm4gUU9iamVjdDo6dHIoIkluc2VydCBMaXN0Iik7CisgICAgY2FzZSBFZGl0QWN0aW9u Rm9ybWF0QmxvY2s6CisgICAgICAgIHJldHVybiBRT2JqZWN0Ojp0cigiRm9ybWF0dGluZyIpOwor ICAgIGNhc2UgRWRpdEFjdGlvbkluZGVudDoKKyAgICAgICAgcmV0dXJuIFFPYmplY3Q6OnRyKCJJ bmRlbnQiKTsKKyAgICBjYXNlIEVkaXRBY3Rpb25PdXRkZW50OgorICAgICAgICByZXR1cm4gUU9i amVjdDo6dHIoIk91dGRlbnQiKTsKKyAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICByZXR1cm4gUVN0cmluZygpOworfQorCiBVbmRvU3RlcFF0OjpVbmRvU3RlcFF0KFdURjo6 UmVmUHRyPFVuZG9TdGVwPiBzdGVwLCBRVW5kb0NvbW1hbmQgKnBhcmVudCkKICAgICA6IFFVbmRv Q29tbWFuZChwYXJlbnQpCiAgICAgLCBtX3N0ZXAoc3RlcCkKICAgICAsIG1fZmlyc3QodHJ1ZSkK IHsKKyAgICBzZXRUZXh0KHVuZG9OYW1lRm9yRWRpdEFjdGlvbihzdGVwLT5lZGl0aW5nQWN0aW9u KCkpKTsKIH0KICNlbHNlCiBVbmRvU3RlcFF0OjpVbmRvU3RlcFF0KFdURjo6UmVmUHRyPFVuZG9T dGVwPiBzdGVwKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90 c3RfcXdlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdl YnBhZ2UuY3BwCmluZGV4IDAwOTlkNDEwYWRkYTQwOWM5MmYwOTFkYTQ1MTlmYTJiNjc0OWY2Y2Uu LjBlZGUzNzRlMDg1ZDEwMWUwZTRjYjI0ODFiNmUzMWUwNDZiZDUyODkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAgLTEzOSw2ICsx MzksNyBAQCBwcml2YXRlIFFfU0xPVFM6CiAgICAgdm9pZCBlcnJvclBhZ2VFeHRlbnNpb25Mb2Fk RmluaXNoZWQoKTsKICAgICB2b2lkIHVzZXJBZ2VudEFwcGxpY2F0aW9uTmFtZSgpOwogICAgIHZv aWQgdXNlckFnZW50TmV3bGluZVN0cmlwcGluZygpOworICAgIHZvaWQgdW5kb0FjdGlvbkhhdmVD dXN0b21UZXh0KCk7CiAKICAgICB2b2lkIHZpZXdNb2RlcygpOwogCkBAIC0zMjYwLDUgKzMyNjEs MTkgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmxvYWRTaWduYWxzT3JkZXIoKQogICAgIFFUUllfVkVS SUZZKGxvYWRTcHkuaXNGaW5pc2hlZCgpKTsKIH0KIAordm9pZCB0c3RfUVdlYlBhZ2U6OnVuZG9B Y3Rpb25IYXZlQ3VzdG9tVGV4dCgpCit7CisgICAgbV9wYWdlLT5tYWluRnJhbWUoKS0+c2V0SHRt bCgiPGRpdiBpZD10ZXN0IGNvbnRlbnRlZGl0YWJsZT48L2Rpdj4iKTsKKyAgICBtX3BhZ2UtPm1h aW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0 ZXN0JykuZm9jdXMoKSIpOworCisgICAgbV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZh U2NyaXB0KCJkb2N1bWVudC5leGVjQ29tbWFuZCgnaW5zZXJ0VGV4dCcsIHRydWUsICdUZXN0Jyk7 Iik7CisgICAgUVN0cmluZyB0eXBpbmdBY3Rpb25UZXh0ID0gbV9wYWdlLT5hY3Rpb24oUVdlYlBh Z2U6OlVuZG8pLT50ZXh0KCk7CisKKyAgICBtX3BhZ2UtPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUph dmFTY3JpcHQoImRvY3VtZW50LmV4ZWNDb21tYW5kKCdpbmRlbnQnLCB0cnVlKTsiKTsKKyAgICBR U3RyaW5nIGFsaWduQWN0aW9uVGV4dCA9IG1fcGFnZS0+YWN0aW9uKFFXZWJQYWdlOjpVbmRvKS0+ dGV4dCgpOworCisgICAgUVZFUklGWSh0eXBpbmdBY3Rpb25UZXh0ICE9IGFsaWduQWN0aW9uVGV4 dCk7Cit9CisKIFFURVNUX01BSU4odHN0X1FXZWJQYWdlKQogI2luY2x1ZGUgInRzdF9xd2VicGFn ZS5tb2MiCg==