9692 2006-07-02 05:44:07 -0700 Warning about Safari extensions on every launch is obnoxious 2006-07-02 06:00:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mrowe mrowe oldest_to_newest 47995 0 mrowe 2006-07-02 05:44:07 -0700 It would be much nicer if this warning could be displayed in a more subtle way. A warning inline on the nightly start page would be one option, as would displaying the warning only after a crash has been detected. 47996 1 9146 mrowe 2006-07-02 05:49:51 -0700 Created attachment 9146 Only display the warning if WebKit did not exit cleanly on it's last invocation 47997 2 9146 ap 2006-07-02 05:56:23 -0700 Comment on attachment 9146 Only display the warning if WebKit did not exit cleanly on it's last invocation r=me 47998 3 ddkilzer 2006-07-02 06:00:09 -0700 Committed revision 15138. 9146 2006-07-02 05:49:51 -0700 2006-07-02 05:56:23 -0700 Only display the warning if WebKit did not exit cleanly on it's last invocation webkit-bug-9692-v1.patch text/plain 4911 mrowe SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1MTM3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDctMDMgIE1hcmsgUm93ZSAgPG9wZW5k YXJ3aW4ub3JnQGJkYXNoLm5ldC5uej4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWcgOTY5MjogV2FybmluZyBhYm91dCBTYWZhcmkgZXh0ZW5zaW9u cyBvbiBldmVyeSBsYXVuY2ggaXMgb2Jub3hpb3VzCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY5MgorCisgICAgICAgICogV2ViS2l0TGF1 bmNoZXIvV2ViS2l0TmlnaHRseUVuYWJsZXIubToKKyAgICAgICAgKG15QXBwbGljYXRpb25XaWxs VGVybWluYXRlKTogTm90ZSB0aGF0IHdlIGFyZSBleGl0aW5nIGNsZWFubHkuCisgICAgICAgIChj bGVhblVwQWZ0ZXJPdXJzZWx2ZXMpOiBJbnN0YWxsIGJ1bmRsZSBsb2FkIHRyYWNraW5nIG9ubHkg aWYgd2UgZmFpbGVkCisgICAgICAgICB0byBleGl0IGNsZWFubHkgb24gb3VyIGxhc3QgaW52b2Nh dGlvbi4gIFRoaXMgZG9lc24ndCBwbGF5IG5pY2VseSB3aXRoCisgICAgICAgICBtdWx0aXBsZSBj b25jdXJyZW50IGluc3RhbmNlcyBvZiBXZWJLaXQuYXBwIHNvIGl0IGNhbiBiZSBkaXNhYmxlZCB2 aWEKKyAgICAgICAgIGRlZmF1bHRzIHdyaXRlIGNvbS5hcHBsZS5TYWZhcmkgV0tORVNob3VsZE1v bml0b3JTaHV0ZG93bnMgLWJvb2wgTk8uCisKIDIwMDYtMDctMDIgIE1hcmsgUm93ZSAgPG9wZW5k YXJ3aW4ub3JnQGJkYXNoLm5ldC5uej4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4eSBQcm9z a3VyeWFrb3YuCkluZGV4OiBXZWJLaXRUb29scy9XZWJLaXRMYXVuY2hlci9XZWJLaXROaWdodGx5 RW5hYmxlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1dlYktpdExhdW5jaGVyL1dlYktp dE5pZ2h0bHlFbmFibGVyLm0JKHJldmlzaW9uIDE1MTM3KQorKysgV2ViS2l0VG9vbHMvV2ViS2l0 TGF1bmNoZXIvV2ViS2l0TmlnaHRseUVuYWJsZXIubQkod29ya2luZyBjb3B5KQpAQCAtMzcsNiAr MzcsOSBAQAogc3RhdGljIHZvaWQgY2xlYW5VcEFmdGVyT3Vyc2VsdmVzKHZvaWQpIF9fYXR0cmli dXRlX18gKChjb25zdHJ1Y3RvcikpOwogc3RhdGljIHZvaWQgKnN5bWJvbF9sb29rdXAoY2hhciAq c3ltYm9sKTsKIAorc3RhdGljIE5TU3RyaW5nICpXS05FRGlkU2h1dERvd25DbGVhbmx5ID0gQCJX S05FRGlkU2h1dERvd25DbGVhbmx5IjsKK3N0YXRpYyBOU1N0cmluZyAqV0tORVNob3VsZE1vbml0 b3JTaHV0ZG93bnMgPSBAIldLTkVTaG91bGRNb25pdG9yU2h1dGRvd25zIjsKKwogc3RhdGljIGJv b2wgZXh0ZW5zaW9uQnVuZGxlc1dlcmVMb2FkZWQgPSBOTzsKIHN0YXRpYyBOU1NldCAqZXh0ZW5z aW9uUGF0aHMgPSBuaWw7CiAKQEAgLTgyLDYgKzg1LDEzIEBAIHN0YXRpYyB2b2lkIG15QXBwbGlj YXRpb25XaWxsRmluaXNoTGF1bmMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBAIlNhZmFyaSBleHRlbnNpb25zIHdlcmUgZGV0ZWN0ZWQgb24geW91ciBzeXN0ZW0uIFRoZXkg YXJlIGluY29tcGF0aWJsZSB3aXRoIG5pZ2h0bHkgYnVpbGRzIG9mIFdlYktpdCwgYW5kIG1heSBj YXVzZSBjcmFzaGVzIG9yIGluY29ycmVjdCBiZWhhdmlvci4gIFBsZWFzZSBkaXNhYmxlIHRoZW0g aWYgeW91IGV4cGVyaWVuY2Ugc3VjaCBiZWhhdmlvci4iLCBAIkNvbnRpbnVlIiwgbmlsLCBuaWwp OwogfQogCitzdGF0aWMgdm9pZCBteUFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZShDRk5vdGlmaWNh dGlvbkNlbnRlclJlZiBjZW50ZXIsIHZvaWQgKm9ic2VydmVyLCBDRlN0cmluZ1JlZiBuYW1lLCBj b25zdCB2b2lkICpvYmplY3QsIENGRGljdGlvbmFyeVJlZiB1c2VySW5mbykKK3sKKyAgICBOU1Vz ZXJEZWZhdWx0cyAqdXNlckRlZmF1bHRzID0gW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRl ZmF1bHRzXTsKKyAgICBbdXNlckRlZmF1bHRzIHNldEJvb2w6WUVTIGZvcktleTpXS05FRGlkU2h1 dERvd25DbGVhbmx5XTsKKyAgICBbdXNlckRlZmF1bHRzIHN5bmNocm9uaXplXTsKK30KKwogdm9p ZCBjbGVhblVwQWZ0ZXJPdXJzZWx2ZXModm9pZCkKIHsKICAgICBjaGFyICoqYXJncyA9ICooY2hh cioqKilfTlNHZXRBcmd2KCk7CkBAIC05OCwxMiArMTA4LDI4IEBAIHZvaWQgY2xlYW5VcEFmdGVy T3Vyc2VsdmVzKHZvaWQpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgQCJ+L0xpYnJhcnkvQXBwbGljYXRpb24gRW5oYW5jZXJzLyIsIEAiL0xpYnJh cnkvQXBwbGljYXRpb24gRW5oYW5jZXJzLyIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbmlsXTsKIAotICAgIENGTm90aWZpY2F0aW9uQ2VudGVy QWRkT2JzZXJ2ZXIoQ0ZOb3RpZmljYXRpb25DZW50ZXJHZXRMb2NhbENlbnRlcigpLCAmbXlCdW5k bGVEaWRMb2FkLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXlCdW5kbGVE aWRMb2FkLCAoQ0ZTdHJpbmdSZWYpIE5TQnVuZGxlRGlkTG9hZE5vdGlmaWNhdGlvbiwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsIENGTm90aWZpY2F0aW9uU3VzcGVu c2lvbkJlaGF2aW9yRGVsaXZlckltbWVkaWF0ZWx5KTsKLSAgICBDRk5vdGlmaWNhdGlvbkNlbnRl ckFkZE9ic2VydmVyKENGTm90aWZpY2F0aW9uQ2VudGVyR2V0TG9jYWxDZW50ZXIoKSwgJm15QXBw bGljYXRpb25XaWxsRmluaXNoTGF1bmNoaW5nLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbXlBcHBsaWNhdGlvbldpbGxGaW5pc2hMYXVuY2hpbmcsIChDRlN0cmluZ1JlZikg TlNBcHBsaWNhdGlvbldpbGxGaW5pc2hMYXVuY2hpbmdOb3RpZmljYXRpb24sCisgICAgTlNBdXRv cmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKKyAg ICBOU1VzZXJEZWZhdWx0cyAqdXNlckRlZmF1bHRzID0gW05TVXNlckRlZmF1bHRzIHN0YW5kYXJk VXNlckRlZmF1bHRzXTsKKyAgICBOU0RpY3Rpb25hcnkgKmRlZmF1bHRQcmVmcyA9IFtOU0RpY3Rp b25hcnkgZGljdGlvbmFyeVdpdGhPYmplY3RzQW5kS2V5czpbTlNOdW1iZXIgbnVtYmVyV2l0aEJv b2w6WUVTXSwgV0tORURpZFNodXREb3duQ2xlYW5seSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbTlNO dW1iZXIgbnVtYmVyV2l0aEJvb2w6WUVTXSwgV0tORVNob3VsZE1vbml0b3JTaHV0ZG93bnMsIG5p bF07CisgICAgW3VzZXJEZWZhdWx0cyByZWdpc3RlckRlZmF1bHRzOmRlZmF1bHRQcmVmc107Cisg ICAgaWYgKFt1c2VyRGVmYXVsdHMgYm9vbEZvcktleTpXS05FU2hvdWxkTW9uaXRvclNodXRkb3du c10gJiYgIVt1c2VyRGVmYXVsdHMgYm9vbEZvcktleTpXS05FRGlkU2h1dERvd25DbGVhbmx5XSkK KyAgICB7CisgICAgICAgIE5TTG9nKEAiV2ViS2l0IGZhaWxlZCB0byBzaHV0IGRvd24gY2xlYW5s eS4gIENoZWNraW5nIGZvciBTYWZhcmkgZXh0ZW5zaW9ucy4iKTsKKyAgICAgICAgQ0ZOb3RpZmlj YXRpb25DZW50ZXJBZGRPYnNlcnZlcihDRk5vdGlmaWNhdGlvbkNlbnRlckdldExvY2FsQ2VudGVy KCksICZteUJ1bmRsZURpZExvYWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbXlCdW5kbGVEaWRMb2FkLCAoQ0ZTdHJpbmdSZWYpIE5TQnVuZGxlRGlkTG9hZE5vdGlm aWNhdGlvbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBD Rk5vdGlmaWNhdGlvblN1c3BlbnNpb25CZWhhdmlvckRlbGl2ZXJJbW1lZGlhdGVseSk7CisgICAg ICAgIENGTm90aWZpY2F0aW9uQ2VudGVyQWRkT2JzZXJ2ZXIoQ0ZOb3RpZmljYXRpb25DZW50ZXJH ZXRMb2NhbENlbnRlcigpLCAmbXlBcHBsaWNhdGlvbldpbGxGaW5pc2hMYXVuY2hpbmcsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXlBcHBsaWNhdGlvbldpbGxGaW5p c2hMYXVuY2hpbmcsIChDRlN0cmluZ1JlZikgTlNBcHBsaWNhdGlvbldpbGxGaW5pc2hMYXVuY2hp bmdOb3RpZmljYXRpb24sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg TlVMTCwgQ0ZOb3RpZmljYXRpb25TdXNwZW5zaW9uQmVoYXZpb3JEZWxpdmVySW1tZWRpYXRlbHkp OworICAgIH0KKyAgICBbdXNlckRlZmF1bHRzIHNldEJvb2w6Tk8gZm9yS2V5OldLTkVEaWRTaHV0 RG93bkNsZWFubHldOworICAgIFt1c2VyRGVmYXVsdHMgc3luY2hyb25pemVdOworCisgICAgQ0ZO b3RpZmljYXRpb25DZW50ZXJBZGRPYnNlcnZlcihDRk5vdGlmaWNhdGlvbkNlbnRlckdldExvY2Fs Q2VudGVyKCksICZteUFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIG15QXBwbGljYXRpb25XaWxsVGVybWluYXRlLCAoQ0ZTdHJpbmdS ZWYpIE5TQXBwbGljYXRpb25XaWxsVGVybWluYXRlTm90aWZpY2F0aW9uLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwgQ0ZOb3RpZmljYXRpb25TdXNwZW5zaW9uQmVo YXZpb3JEZWxpdmVySW1tZWRpYXRlbHkpOworICAgIFtwb29sIHJlbGVhc2VdOwogfQogCiAjaWYg X19MUDY0X18K