96912 2012-09-17 06:13:45 -0700 [GStreamer] initial volume events on media elements could happen earlier 2012-12-03 07:56:01 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen eric.carlson feature-media-reviews gustavo menard mrobinson pnormand webkit.review.bot oldest_to_newest 721843 0 jussi.kukkonen 2012-09-17 06:13:45 -0700 playbin2 (when used on a Pulseaudio-running platform) will initialize the stream volume and mute state from pulseaudio at some point in the streams lifetime. this is a useful feature but currently it's slightly annoying as the HTMLAudioElement gets updated with that initial value only after playback starts. This leads to a bad user experience (click play and suddenly the volume changes) and we should be able to fix that. We already set the stream to GST_STATE_PAUSED asap after the url has been set: volume and mute state should be available at that point. I'll cook up a patch. 722602 1 jussi.kukkonen 2012-09-18 02:06:26 -0700 Hmm, I'm seeing a strange playbin issue: updated "volume" property is available on GST_STATE_PAUSED as I mentioned, but "mute" is not. That only happens some milliseconds later (maybe this is related to why bug 36299 includes the timeout hack, but that one is not long enough in this case). So I was wrong, I don't have a good solution for this. Not sure whether I had misunderstood in the first place or because there's a bug in gstreamer 722612 2 pnormand 2012-09-18 02:30:58 -0700 Can you upload your WIP patch? There can totally be a bug in GStreamer, wouldn't be the first time we find an issue when dealing with a WebKit patch ;) 722624 3 jussi.kukkonen 2012-09-18 03:24:52 -0700 (In reply to comment #2) > Can you upload your WIP patch? > There can totally be a bug in GStreamer, wouldn't be the first time we find an issue when dealing with a WebKit patch ;) I actually got it to work by accident: it seems that getting the "mute" property first will not work, but doing anything else first makes it work (as an example it starts to work even if I just do the same g_object_get() call twice). This does not sound like a very probable bug, but it is totally reproducable. So the working patch that I'm uploading in a minute gets volume first and mute second. That works fine for me but doing it the other way round will fail: mute will have the uninitialized value. There's a small issue still: there are two javascript "volumechange" events. This isn't entirely wrong (if both mute and volume changed) but best would be a single event I think. 722625 4 164525 jussi.kukkonen 2012-09-18 03:27:57 -0700 Created attachment 164525 Patch 722629 5 164527 jussi.kukkonen 2012-09-18 03:30:44 -0700 Created attachment 164527 simple test page 722634 6 164525 pnormand 2012-09-18 03:43:26 -0700 Comment on attachment 164525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164525&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1161 > + notifyPlayerOfVolumeChange(); > + notifyPlayerOfMute(); These 2 are meant to be called from idle callbacks. Have you tried calling muteChanged() and volumeChanged() instead? Also this can be done from updateAudioSink() I think. 722638 7 jussi.kukkonen 2012-09-18 03:59:17 -0700 (In reply to comment #6) > These 2 are meant to be called from idle callbacks. Have you tried calling muteChanged() and volumeChanged() instead? I noticed this pattern. I didn't understand the reasoning but I did try it after finding bug 36299: the results are the same, things only work if volumeChanged() is called before muteChanged(). > Also this can be done from updateAudioSink() I think. Yes, that looks like it makes sense. 722672 8 jussi.kukkonen 2012-09-18 05:05:11 -0700 (In reply to comment #6) > These 2 are meant to be called from idle callbacks. Have you tried calling muteChanged() and volumeChanged() instead? Btw, I think not using idle timeouts is fine in this case as the they are called from GstBus "message" signal which is emitted in the main thread. > Also this can be done from updateAudioSink() I think. ...and this isn't actually a good idea as we'd want the initialization to happen if the url is changed as well, right? 722691 9 pnormand 2012-09-18 05:27:45 -0700 (In reply to comment #8) > (In reply to comment #6) > > These 2 are meant to be called from idle callbacks. Have you tried calling muteChanged() and volumeChanged() instead? > > Btw, I think not using idle timeouts is fine in this case as the they are called from GstBus "message" signal which is emitted in the main thread. > Alright. > > Also this can be done from updateAudioSink() I think. > > ...and this isn't actually a good idea as we'd want the initialization to happen if the url is changed as well, right? Oh you reset that new member variable in ::load(). Right. 779955 10 pnormand 2012-11-30 02:10:51 -0800 Jussi would you like to add a ChangeLog and check the media tests with your patch? It'd be nice, I think, to fix this bug. 779996 11 176937 jussi.kukkonen 2012-11-30 04:18:56 -0800 Created attachment 176937 Patch 780001 12 176937 jussi.kukkonen 2012-11-30 04:22:34 -0800 Comment on attachment 176937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176937&action=review > Source/WebCore/ChangeLog:15 > + No new tests: media/event-attributes.html already tests media events. > + Unfortunately this test is flaky on EFL and linux (more specifically > + it is flaky on pulseaudio-using platforms: http://webkit.org/b/83704). Additional comment on this: event-attributes.html result seems to have an addititional durationchange event nowadays (after playing event) but that is unrelated and also happens without this patch. I've run the media tests on EFL and just as before, if the system volume is 100% and mute is off, I get the expected results for all. 780003 13 jussi.kukkonen 2012-11-30 04:27:58 -0800 argh, pressed commit too soon... So, the reason this languished so long was that I was hoping we could get the flakiness of the testing improved, but that turned out to be more difficult to solve. Once pulseaudio module-match actually works on common linux OSes it might be easier but before that it might not be worth it. 780017 14 176943 jussi.kukkonen 2012-11-30 04:53:15 -0800 Created attachment 176943 Improve Changelog 781334 15 176943 webkit.review.bot 2012-12-03 04:38:41 -0800 Comment on attachment 176943 Improve Changelog Clearing flags on attachment: 176943 Committed r136382: <http://trac.webkit.org/changeset/136382> 781335 16 webkit.review.bot 2012-12-03 04:38:46 -0800 All reviewed patches have been landed. Closing bug. 781375 17 jussi.kukkonen 2012-12-03 05:49:31 -0800 There may have been a regression on media/video-volume.html, I'll check that locally and ask for rollback if needed. 781376 18 pnormand 2012-12-03 05:56:10 -0800 (In reply to comment #17) > There may have been a regression on media/video-volume.html, I'll check that locally and ask for rollback if needed. Ok thanks for keeping an eye out! 781458 19 jussi.kukkonen 2012-12-03 07:55:24 -0800 For reference, I filed bug 96912 for this issue: it seems like the bug/functionality has been there all the time, this patch just made the test work better so the problem is now visible. 781459 20 jussi.kukkonen 2012-12-03 07:56:01 -0800 (In reply to comment #19) > For reference, I filed bug 96912 for this issue: it seems like the bug/functionality has been there all the time, this patch just made the test work better so the problem is now visible. bug 103893 actually. 164525 2012-09-18 03:27:57 -0700 2012-11-30 04:18:51 -0800 Patch bug-96912-20120918132723.patch text/plain 2083 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Mjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGFkZjU1NWYwNzNiNGRhNzA0NTI1YzRkOTM5MTk3 ZDIxNjgyYzU2ZjIuLjQwMzBkYWUzOWY2ZTU3YTA0ZDdmZDljNzlmN2I5ZmI5OWU0YzYwMjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0z MTUsNiArMzE1LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmxvYWQoY29u c3QgU3RyaW5nJiB1cmwpCiAgICAgbV9wbGF5ZXItPm5ldHdvcmtTdGF0ZUNoYW5nZWQoKTsKICAg ICBtX3JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZU5vdGhpbmc7CiAgICAgbV9wbGF5ZXIt PnJlYWR5U3RhdGVDaGFuZ2VkKCk7CisgICAgbV92b2x1bWVBbmRNdXRlSW5pdGlhbGl6ZWQgPSBm YWxzZTsKIAogICAgIC8vIEdTdHJlYW1lciBuZWVkcyB0byBoYXZlIHRoZSBwaXBlbGluZSBzZXQg dG8gYSBwYXVzZWQgc3RhdGUgdG8KICAgICAvLyBzdGFydCBwcm92aWRpbmcgYW55dGhpbmcgdXNl ZnVsLgpAQCAtMTE1NCw2ICsxMTU1LDEzIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1BBVVNF RCkgewogICAgICAgICAgICAgaWYgKCFtX3dlYmtpdEF1ZGlvU2luaykKICAgICAgICAgICAgICAg ICB1cGRhdGVBdWRpb1NpbmsoKTsKKworICAgICAgICAgICAgaWYgKCFtX3ZvbHVtZUFuZE11dGVJ bml0aWFsaXplZCkgeworICAgICAgICAgICAgICAgIG5vdGlmeVBsYXllck9mVm9sdW1lQ2hhbmdl KCk7CisgICAgICAgICAgICAgICAgbm90aWZ5UGxheWVyT2ZNdXRlKCk7CisgICAgICAgICAgICAg ICAgbV92b2x1bWVBbmRNdXRlSW5pdGlhbGl6ZWQgPSB0cnVlOworICAgICAgICAgICAgfQorCiAg ICAgICAgICAgICBpZiAobV9idWZmZXJpbmcgJiYgbV9idWZmZXJpbmdQZXJjZW50YWdlID09IDEw MCkgewogICAgICAgICAgICAgICAgIG1fYnVmZmVyaW5nID0gZmFsc2U7CiAgICAgICAgICAgICAg ICAgbV9idWZmZXJpbmdQZXJjZW50YWdlID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuaAppbmRleCBkMTRkMDA0ZjAxNDliY2QzZGE4YWNlOTBkYmJmYjZl NjdhZjg4MjI2Li41OWY1MjhiNzIxZDUzYmNhMGNkMGY3YzM4NTJiZDdhOThkN2RiMDQ1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0xOTMsNiAr MTkzLDcgQEAgY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyIDogcHVibGljIE1lZGlh UGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiAjZW5kaWYKICAgICAgICAgICAgIGd1aW50IG1fdm9s dW1lVGltZXJIYW5kbGVyOwogICAgICAgICAgICAgZ3VpbnQgbV9tdXRlVGltZXJIYW5kbGVyOwor ICAgICAgICAgICAgYm9vbCBtX3ZvbHVtZUFuZE11dGVJbml0aWFsaXplZDsKICAgICAgICAgICAg IGJvb2wgbV9oYXNWaWRlbzsKICAgICAgICAgICAgIGJvb2wgbV9oYXNBdWRpbzsKICAgICAgICAg ICAgIGd1aW50IG1fYXVkaW9UaW1lckhhbmRsZXI7Cg== 164527 2012-09-18 03:30:44 -0700 2012-09-18 03:30:44 -0700 simple test page volumechange.html text/html 665 jussi.kukkonen PGh0bWwgbGFuZz0iZW4iPgo8Ym9keT4KICA8YXVkaW8gaWQ9ImEiIGNvbnRyb2xzPjwvYXVkaW8+ CiAgPGRpdiBpZD0ibG9nIj5Mb2c6IDwvZGl2PgogIDxzY3JpcHQ+CnZhciBhID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImEiKTsKdmFyIGxvZyAgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi bG9nIik7CgpmdW5jdGlvbiBjYW5wbGF5KCkgewogICAgbG9nLmlubmVySFRNTCArPSAiPGJyPiAq IGNhbnBsYXl0aHJvdWdoIGV2ZW50LCBtdXRlIGlzICIgKyBhLm11dGVkICsgIiwgdm9sdW1lIGlz ICIrIGEudm9sdW1lOwp9CgpmdW5jdGlvbiB2b2x1bWVDaGFuZ2VkKCkgewogICAgbG9nLmlubmVy SFRNTCArPSAiPGJyPiAqIHZvbHVtZWNoYW5nZSBldmVudCwgbXV0ZSBpcyAiICsgYS5tdXRlZCAr ICIsIHZvbHVtZSBpcyAiKyBhLnZvbHVtZTsKfQoKYS5hZGRFdmVudExpc3RlbmVyKCJjYW5wbGF5 dGhyb3VnaCIsIGNhbnBsYXksIGZhbHNlKTsKYS5hZGRFdmVudExpc3RlbmVyKCJ2b2x1bWVjaGFu Z2UiLCB2b2x1bWVDaGFuZ2VkLCBmYWxzZSk7Ci8vYS5zcmM9Imh0dHBzOi8vdXBsb2FkLndpa2lt ZWRpYS5vcmcvd2lraXBlZGlhL2NvbW1vbnMvZi9mMi9NZWRpYW5fdGVzdC5vZ2ciCmEuc3JjPSJ0 ZXN0Lm9nZyIKICA8L3NjcmlwdD4KCjwvYm9keT4KPC9odG1sPgo= 176937 2012-11-30 04:18:56 -0800 2012-11-30 04:53:11 -0800 Patch bug-96912-20121130141627.patch text/plain 3457 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OGJhMDZiN2ZkMWU0 ZDNhM2RmZmYxN2ZlNTg0NzQwN2ZkZDU5NS4uZmNkZThmNjE3NjZiZmIwZWIwMTYxMmNkMmJjNmU5 ODI0OWI0MjI0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTMwICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbR1N0cmVh bWVyXSBpbml0aWFsIHZvbHVtZSBldmVudHMgb24gbWVkaWEgZWxlbWVudHMgc2hvdWxkIGhhcHBl biBlYXJsaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjkxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZSBtZWRpYWVsZW1lbnQgdm9sdW1lIGFuZCBtdXRlIHByb3BlcnRpZXMgdG8gd2hhdGV2 ZXIgdmFsdWVzCisgICAgICAgIHBsYXliaW4gaGFzIGFzIHNvb24gYXMgcG9zc2libGUgKHdoZW4g dGhlIHBsYXliaW4gcmVhY2hlcyBQQVVTRUQgc3RhdGUpLgorICAgICAgICBUaGlzIHdpbGwgaW1w cm92ZSB1c2VyIGV4cGVyaWVuY2UgYXMgdGhlIHZvbHVtZSB2aXN1YWxzIHdvbid0IHN1ZGRlbmx5 CisgICAgICAgIGNoYW5nZSB3aGVuIHVzZXIgY2xpY2tzIHBsYXkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzOiBtZWRpYS9ldmVudC1hdHRyaWJ1dGVzLmh0bWwgYWxyZWFkeSB0ZXN0cyBtZWRpYSBl dmVudHMuCisgICAgICAgIFVuZm9ydHVuYXRlbHkgdGhpcyB0ZXN0IGlzIGZsYWt5IG9uIEVGTCBh bmQgbGludXggKG1vcmUgc3BlY2lmaWNhbGx5CisgICAgICAgIGl0IGlzIGZsYWt5IG9uIHB1bHNl YXVkaW8tdXNpbmcgcGxhdGZvcm1zOiBodHRwOi8vd2Via2l0Lm9yZy9iLzgzNzA0KS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy Ojpsb2FkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmg6CisgICAgICAgIChNZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIpOgorCiAyMDEyLTExLTMwICBTYW5rZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtUaW1lbGluZV0gSlMgZXJyb3Igd2hlbiBj bGlja2luZyBpbiBNZW1vcnkgU3RhdGlzdGljcyB2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGYyYmQyOTI1OTAyYmQxZGY4M2RjZDZh MzY1Y2JiNzA0YTE0MDczMjUuLjkyZjVkMWJhNDk2M2YzMmFmYzVjYjIwNjg2ZjE3MmZhOThjZDU2 NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw CkBAIC0zMTYsNiArMzE2LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Omxv YWQoY29uc3QgU3RyaW5nJiB1cmwpCiAgICAgbV9wbGF5ZXItPm5ldHdvcmtTdGF0ZUNoYW5nZWQo KTsKICAgICBtX3JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZU5vdGhpbmc7CiAgICAgbV9w bGF5ZXItPnJlYWR5U3RhdGVDaGFuZ2VkKCk7CisgICAgbV92b2x1bWVBbmRNdXRlSW5pdGlhbGl6 ZWQgPSBmYWxzZTsKIAogICAgIC8vIEdTdHJlYW1lciBuZWVkcyB0byBoYXZlIHRoZSBwaXBlbGlu ZSBzZXQgdG8gYSBwYXVzZWQgc3RhdGUgdG8KICAgICAvLyBzdGFydCBwcm92aWRpbmcgYW55dGhp bmcgdXNlZnVsLgpAQCAtMTE4Niw2ICsxMTg3LDEzIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRF X1BBVVNFRCkgewogICAgICAgICAgICAgaWYgKCFtX3dlYmtpdEF1ZGlvU2luaykKICAgICAgICAg ICAgICAgICB1cGRhdGVBdWRpb1NpbmsoKTsKKworICAgICAgICAgICAgaWYgKCFtX3ZvbHVtZUFu ZE11dGVJbml0aWFsaXplZCkgeworICAgICAgICAgICAgICAgIG5vdGlmeVBsYXllck9mVm9sdW1l Q2hhbmdlKCk7CisgICAgICAgICAgICAgICAgbm90aWZ5UGxheWVyT2ZNdXRlKCk7CisgICAgICAg ICAgICAgICAgbV92b2x1bWVBbmRNdXRlSW5pdGlhbGl6ZWQgPSB0cnVlOworICAgICAgICAgICAg fQorCiAgICAgICAgICAgICBpZiAobV9idWZmZXJpbmcgJiYgbV9idWZmZXJpbmdQZXJjZW50YWdl ID09IDEwMCkgewogICAgICAgICAgICAgICAgIG1fYnVmZmVyaW5nID0gZmFsc2U7CiAgICAgICAg ICAgICAgICAgbV9idWZmZXJpbmdQZXJjZW50YWdlID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAppbmRleCBkMTRkMDA0ZjAxNDliY2QzZGE4YWNlOTBk YmJmYjZlNjdhZjg4MjI2Li41OWY1MjhiNzIxZDUzYmNhMGNkMGY3YzM4NTJiZDdhOThkN2RiMDQ1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0x OTMsNiArMTkzLDcgQEAgY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyIDogcHVibGlj IE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiAjZW5kaWYKICAgICAgICAgICAgIGd1aW50 IG1fdm9sdW1lVGltZXJIYW5kbGVyOwogICAgICAgICAgICAgZ3VpbnQgbV9tdXRlVGltZXJIYW5k bGVyOworICAgICAgICAgICAgYm9vbCBtX3ZvbHVtZUFuZE11dGVJbml0aWFsaXplZDsKICAgICAg ICAgICAgIGJvb2wgbV9oYXNWaWRlbzsKICAgICAgICAgICAgIGJvb2wgbV9oYXNBdWRpbzsKICAg ICAgICAgICAgIGd1aW50IG1fYXVkaW9UaW1lckhhbmRsZXI7Cg== 176943 2012-11-30 04:53:15 -0800 2012-12-03 04:38:41 -0800 Improve Changelog bug-96912-20121130145047.patch text/plain 3465 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OGJhMDZiN2ZkMWU0 ZDNhM2RmZmYxN2ZlNTg0NzQwN2ZkZDU5NS4uNjczY2RjOTQ1N2E0YTNhYzhjZWQzOGVjNTE0NzQy OTZhZTQ2NjJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTMwICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbR1N0cmVh bWVyXSBpbml0aWFsIHZvbHVtZSBldmVudHMgb24gbWVkaWEgZWxlbWVudHMgc2hvdWxkIGhhcHBl biBlYXJsaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjkxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZSBtZWRpYWVsZW1lbnQgdm9sdW1lIGFuZCBtdXRlIHByb3BlcnRpZXMgdG8gd2hhdGV2 ZXIgdmFsdWVzCisgICAgICAgIHBsYXliaW4gaGFzIGFzIHNvb24gYXMgcG9zc2libGUgKHdoZW4g dGhlIHBsYXliaW4gcmVhY2hlcyBQQVVTRUQgc3RhdGUpLgorICAgICAgICBUaGlzIHdpbGwgaW1w cm92ZSB1c2VyIGV4cGVyaWVuY2UgYXMgdGhlIHZvbHVtZSB2aXN1YWxzIHdvbid0IHN1ZGRlbmx5 CisgICAgICAgIGNoYW5nZSB3aGVuIHVzZXIgY2xpY2tzIHBsYXkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzOiBtZWRpYS9ldmVudC1hdHRyaWJ1dGVzLmh0bWwgYWxyZWFkeSB0ZXN0cyBtZWRpYSBl dmVudHMuCisgICAgICAgIFVuZm9ydHVuYXRlbHkgdGhpcyB0ZXN0IGlzIGZsYWt5IG9uIEVGTCBh bmQgR1RLIChtb3JlIHNwZWNpZmljYWxseQorICAgICAgICBpdCBpcyBmbGFreSBvbiBwdWxzZWF1 ZGlvLXVzaW5nIGdzdHJlYW1lciBwbGF0Zm9ybXM6IGh0dHA6Ly93ZWJraXQub3JnL2IvODM3MDQp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXI6OmxvYWQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaDoKKyAgICAgICAgKE1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lcik6CisKIDIwMTItMTEtMzAgIFNhbmtlZXJ0aCBWIFMgIDxzYW5rZWVydGgudnNA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1RpbWVsaW5lXSBKUyBlcnJv ciB3aGVuIGNsaWNraW5nIGluIE1lbW9yeSBTdGF0aXN0aWNzIHZpZXcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggZjJiZDI5MjU5MDJiZDFk ZjgzZGNkNmEzNjVjYmI3MDRhMTQwNzMyNS4uOTJmNWQxYmE0OTYzZjMyYWZjNWNiMjA2ODZmMTcy ZmE5OGNkNTY1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHAKQEAgLTMxNiw2ICszMTYsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lcjo6bG9hZChjb25zdCBTdHJpbmcmIHVybCkKICAgICBtX3BsYXllci0+bmV0d29ya1N0YXRl Q2hhbmdlZCgpOwogICAgIG1fcmVhZHlTdGF0ZSA9IE1lZGlhUGxheWVyOjpIYXZlTm90aGluZzsK ICAgICBtX3BsYXllci0+cmVhZHlTdGF0ZUNoYW5nZWQoKTsKKyAgICBtX3ZvbHVtZUFuZE11dGVJ bml0aWFsaXplZCA9IGZhbHNlOwogCiAgICAgLy8gR1N0cmVhbWVyIG5lZWRzIHRvIGhhdmUgdGhl IHBpcGVsaW5lIHNldCB0byBhIHBhdXNlZCBzdGF0ZSB0bwogICAgIC8vIHN0YXJ0IHByb3ZpZGlu ZyBhbnl0aGluZyB1c2VmdWwuCkBAIC0xMTg2LDYgKzExODcsMTMgQEAgdm9pZCBNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgIGlmIChzdGF0ZSA9PSBH U1RfU1RBVEVfUEFVU0VEKSB7CiAgICAgICAgICAgICBpZiAoIW1fd2Via2l0QXVkaW9TaW5rKQog ICAgICAgICAgICAgICAgIHVwZGF0ZUF1ZGlvU2luaygpOworCisgICAgICAgICAgICBpZiAoIW1f dm9sdW1lQW5kTXV0ZUluaXRpYWxpemVkKSB7CisgICAgICAgICAgICAgICAgbm90aWZ5UGxheWVy T2ZWb2x1bWVDaGFuZ2UoKTsKKyAgICAgICAgICAgICAgICBub3RpZnlQbGF5ZXJPZk11dGUoKTsK KyAgICAgICAgICAgICAgICBtX3ZvbHVtZUFuZE11dGVJbml0aWFsaXplZCA9IHRydWU7CisgICAg ICAgICAgICB9CisKICAgICAgICAgICAgIGlmIChtX2J1ZmZlcmluZyAmJiBtX2J1ZmZlcmluZ1Bl cmNlbnRhZ2UgPT0gMTAwKSB7CiAgICAgICAgICAgICAgICAgbV9idWZmZXJpbmcgPSBmYWxzZTsK ICAgICAgICAgICAgICAgICBtX2J1ZmZlcmluZ1BlcmNlbnRhZ2UgPSAwOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCmluZGV4IGQxNGQwMDRmMDE0OWJjZDNk YThhY2U5MGRiYmZiNmU2N2FmODgyMjYuLjU5ZjUyOGI3MjFkNTNiY2EwY2QwZjdjMzg1MmJkN2E5 OGQ3ZGIwNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmgKQEAgLTE5Myw2ICsxOTMsNyBAQCBjbGFzcyBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIg OiBwdWJsaWMgTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNlIHsKICNlbmRpZgogICAgICAgICAg ICAgZ3VpbnQgbV92b2x1bWVUaW1lckhhbmRsZXI7CiAgICAgICAgICAgICBndWludCBtX211dGVU aW1lckhhbmRsZXI7CisgICAgICAgICAgICBib29sIG1fdm9sdW1lQW5kTXV0ZUluaXRpYWxpemVk OwogICAgICAgICAgICAgYm9vbCBtX2hhc1ZpZGVvOwogICAgICAgICAgICAgYm9vbCBtX2hhc0F1 ZGlvOwogICAgICAgICAgICAgZ3VpbnQgbV9hdWRpb1RpbWVySGFuZGxlcjsK