96907 2012-09-17 04:42:54 -0700 [Qt]REGRESSION(r128699): It made 2 fast/js/dfg tests assert 2012-10-08 23:35:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 79668 96872 1 jbadics webkit-unassigned fpizlo oliver ossy webkit.review.bot oldest_to_newest 721802 0 jbadics 2012-09-17 04:42:54 -0700 Modifications in r128699 made fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html and fast/js/dfg-inline-arguments-use-from-all-the-places.html assert. These asserts can be found at http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r128699%20(25176)/fast/js/dfg-inline-arguments-use-from-all-the-places-broken-crash-log.txt and http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r128699%20(25176)/fast/js/dfg-inline-arguments-use-from-all-the-places-crash-log.txt You can see the original bug at: https://bugs.webkit.org/show_bug.cgi?id=96872 These tests will be skipped until the proper fix. 721979 1 ossy 2012-09-17 09:11:59 -0700 GDB backtrace - fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html -------------------------------------------------------------------------------- $ gdb WebKitBuild/Debug/bin/WebKitTestRunner GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner...done. (gdb) run LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html [Thread debugging using libthread_db enabled] [New Thread 0x7fffa62a0700 (LWP 31187)] [New Thread 0x7fffa609f700 (LWP 31188)] [New Thread 0x7fffa5e9e700 (LWP 31189)] [New Thread 0x7ffff7ff8700 (LWP 31190)] [New Thread 0x7fffa5a9b700 (LWP 31191)] [New Thread 0x7fffa589a700 (LWP 31193)] ASSERTION FAILED: modeAlreadyChecked(m_state.forNode(node.child1()), Array::String) /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp(1636) : void JSC::DFG::SpeculativeJIT::compileGetByValOnString(JSC::DFG::Node&) 1 0x7ffff6200d1e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2013d1e) [0x7ffff6200d1e] 2 0x7ffff622d5d8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20405d8) [0x7ffff622d5d8] 3 0x7ffff61ffb47 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2012b47) [0x7ffff61ffb47] 4 0x7ffff62002d9 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20132d9) [0x7ffff62002d9] 5 0x7ffff61d03b8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe33b8) [0x7ffff61d03b8] 6 0x7ffff61d1431 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe4431) [0x7ffff61d1431] 7 0x7ffff61c41a2 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd71a2) [0x7ffff61c41a2] 8 0x7ffff61c3683 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd6683) [0x7ffff61c3683] 9 0x7ffff632fd29 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2142d29) [0x7ffff632fd29] 10 0x7ffff6330061 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2143061) [0x7ffff6330061] 11 0x7ffff632d976 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2140976) [0x7ffff632d976] 12 0x7ffff632cb62 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x213fb62) [0x7ffff632cb62] 13 0x7ffff60c6001 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed9001) [0x7ffff60c6001] 14 0x7ffff60c2b0e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed5b0e) [0x7ffff60c2b0e] 15 0x7ffff6294acf /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a7acf) [0x7ffff6294acf] 16 0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4] 17 0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0] 18 0x7ffff62647d3 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20777d3) [0x7ffff62647d3] 19 0x7ffff625e235 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2071235) [0x7ffff625e235] 20 0x7ffff6299815 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20ac815) [0x7ffff6299815] 21 0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4] 22 0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0] 23 0x7ffff6262342 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2075342) [0x7ffff6262342] 24 0x7ffff6321d37 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_+0x1e3) [0x7ffff6321d37] 25 0x7ffff4b05544 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x918544) [0x7ffff4b05544] 26 0x7ffff4b26b89 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939b89) [0x7ffff4b26b89] 27 0x7ffff4b26cec /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939cec) [0x7ffff4b26cec] 28 0x7ffff4e95abc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xca8abc) [0x7ffff4e95abc] 29 0x7ffff509a243 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead243) [0x7ffff509a243] 30 0x7ffff509a046 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead046) [0x7ffff509a046] 31 0x7ffff509a64e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead64e) [0x7ffff509a64e] #CRASHED - WebProcess [Thread 0x7fffa5a9b700 (LWP 31191) exited] LEAK: 1 WebContext LEAK: 1 WebPageProxy [Thread 0x7ffff7ff8700 (LWP 31190) exited] [Thread 0x7fffa589a700 (LWP 31193) exited] [Thread 0x7fffa5e9e700 (LWP 31189) exited] [Thread 0x7fffa609f700 (LWP 31188) exited] [Thread 0x7fffa62a0700 (LWP 31187) exited] Program exited with code 01. GDB backtrace - fast/js/dfg-inline-arguments-use-from-all-the-places.html -------------------------------------------------------------------------- $ gdb WebKitBuild/Debug/bin/WebKitTestRunner GNU gdb (GDB) 7.0.1-debian Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>... Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner...done. (gdb) run LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places.html Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/WebKitTestRunner LayoutTests/fast/js/dfg-inline-arguments-use-from-all-the-places.html [Thread debugging using libthread_db enabled] [New Thread 0x7fffa62a0700 (LWP 505)] [New Thread 0x7fff9ffff700 (LWP 506)] [New Thread 0x7fffa609f700 (LWP 507)] [New Thread 0x7ffff7ff8700 (LWP 508)] [New Thread 0x7fffa5c9c700 (LWP 509)] [New Thread 0x7fffa5a9b700 (LWP 511)] ASSERTION FAILED: modeAlreadyChecked(m_state.forNode(node.child1()), Array::String) /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp(1636) : void JSC::DFG::SpeculativeJIT::compileGetByValOnString(JSC::DFG::Node&) 1 0x7ffff6200d1e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2013d1e) [0x7ffff6200d1e] 2 0x7ffff622d5d8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20405d8) [0x7ffff622d5d8] 3 0x7ffff61ffb47 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2012b47) [0x7ffff61ffb47] 4 0x7ffff62002d9 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20132d9) [0x7ffff62002d9] 5 0x7ffff61d03b8 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe33b8) [0x7ffff61d03b8] 6 0x7ffff61d1431 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fe4431) [0x7ffff61d1431] 7 0x7ffff61c41a2 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd71a2) [0x7ffff61c41a2] 8 0x7ffff61c3683 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1fd6683) [0x7ffff61c3683] 9 0x7ffff632fd29 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2142d29) [0x7ffff632fd29] 10 0x7ffff6330061 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2143061) [0x7ffff6330061] 11 0x7ffff632d976 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2140976) [0x7ffff632d976] 12 0x7ffff632cb62 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x213fb62) [0x7ffff632cb62] 13 0x7ffff60c6001 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed9001) [0x7ffff60c6001] 14 0x7ffff60c2b0e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1ed5b0e) [0x7ffff60c2b0e] 15 0x7ffff6294acf /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a7acf) [0x7ffff6294acf] 16 0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4] 17 0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0] 18 0x7ffff62647d3 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20777d3) [0x7ffff62647d3] 19 0x7ffff625e235 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2071235) [0x7ffff625e235] 20 0x7ffff6299815 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20ac815) [0x7ffff6299815] 21 0x7ffff6290ab4 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x20a3ab4) [0x7ffff6290ab4] 22 0x7ffff6265be0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2078be0) [0x7ffff6265be0] 23 0x7ffff6262342 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x2075342) [0x7ffff6262342] 24 0x7ffff6321d37 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_+0x1e3) [0x7ffff6321d37] 25 0x7ffff4b05544 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x918544) [0x7ffff4b05544] 26 0x7ffff4b26b89 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939b89) [0x7ffff4b26b89] 27 0x7ffff4b26cec /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x939cec) [0x7ffff4b26cec] 28 0x7ffff4e95abc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xca8abc) [0x7ffff4e95abc] 29 0x7ffff509a243 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead243) [0x7ffff509a243] 30 0x7ffff509a046 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead046) [0x7ffff509a046] 31 0x7ffff509a64e /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0xead64e) [0x7ffff509a64e] #CRASHED - WebProcess [Thread 0x7fffa5c9c700 (LWP 509) exited] LEAK: 1 WebContext LEAK: 1 WebPageProxy [Thread 0x7ffff7ff8700 (LWP 508) exited] [Thread 0x7fffa609f700 (LWP 507) exited] [Thread 0x7fff9ffff700 (LWP 506) exited] [Thread 0x7fffa62a0700 (LWP 505) exited] [Thread 0x7fffa5a9b700 (LWP 511) exited] Program exited with code 01. 721992 2 ossy 2012-09-17 09:24:00 -0700 We skipped them to paint the bot green - https://trac.webkit.org/changeset/128768 Please unskip them with the proper fix. 737140 3 167635 tullio.lucena 2012-10-08 15:43:52 -0700 Created attachment 167635 Patch Unskipping tests 737442 4 167635 ossy 2012-10-08 23:16:28 -0700 Comment on attachment 167635 Patch r=me. 737457 5 167635 ossy 2012-10-08 23:35:47 -0700 Comment on attachment 167635 Patch Clearing flags on attachment: 167635 Committed r130722: <http://trac.webkit.org/changeset/130722> 737458 6 ossy 2012-10-08 23:35:53 -0700 All reviewed patches have been landed. Closing bug. 167635 2012-10-08 15:43:52 -0700 2012-10-08 23:35:47 -0700 Patch patch.diff text/plain 1406 tullio.lucena ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZDVhZjRiLi4wZWVlODZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAt MDggIFR1bGxpbyBMdWNlbmEgIDx0dWxsaW8ubHVjZW5hQG9wZW5ib3NzYS5vcmc+CisKKyAgICAg ICAgW1F0XVJFR1JFU1NJT04ocjEyODY5OSk6IEl0IG1hZGUgMiBmYXN0L2pzL2RmZyB0ZXN0cyBh c3NlcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5z a2lwcGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnM6 CisKIDIwMTItMTAtMDggIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CiAKICAgICAg ICAgW0NTUyBFeGNsdXNpb25zXSBBZGQgc3VwcG9ydCBmb3IgcG9seWdvbmFsIHNoYXBlcwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMzY5OTgxMC4uOWNiOTRh ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCkBAIC0yNzUyLDEx ICsyNzUyLDYgQEAgZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1pbWFnZW1hcC1vdmVybGFw cGVkLWFyZWFzLmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk2MzYwCiBmYXN0L2NhbnZhcy9jYW52YXMtbGluZURhc2guaHRtbAogCi0jIFtRdF1SRUdSRVNT SU9OKHIxMjg2OTkpOiBJdCBtYWRlIDIgZmFzdC9qcy9kZmcgdGVzdHMgYXNzZXJ0Ci0jIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjkwNwotZmFzdC9qcy9kZmctaW5s aW5lLWFyZ3VtZW50cy11c2UtZnJvbS1hbGwtdGhlLXBsYWNlcy1icm9rZW4uaHRtbAotZmFzdC9q cy9kZmctaW5saW5lLWFyZ3VtZW50cy11c2UtZnJvbS1hbGwtdGhlLXBsYWNlcy5odG1sCi0KICMg W1F0XSBSRUdSRVNTSU9OKHIxMjg3NDkpOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL25l dHdvcmsteGhyLXNhbWUtdXJsLWFzLW1haW4tcmVzb3VyY2UuaHRtbCBjcmFzaGVzCiAjIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjkzMQogaHR0cC90ZXN0cy9pbnNw ZWN0b3IvbmV0d29yay9uZXR3b3JrLXhoci1yZXBsYXkuaHRtbAo=