96905 2012-09-17 04:17:26 -0700 [EFL] Remove background view on EWebLauncher and MiniBrowser 2012-09-18 05:05:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 seokju.kwon webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 721795 0 seokju.kwon 2012-09-17 04:17:26 -0700 The background view doesn't display properly on test browsers after adding url bar. And Remove unnecessary codes. 721799 1 164367 seokju.kwon 2012-09-17 04:33:34 -0700 Created attachment 164367 Patch 721854 2 164367 rakuco 2012-09-17 06:24:13 -0700 Comment on attachment 164367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > Tools/ChangeLog:9 > + The background view doesn't display properly on test browsers after adding url bar. > + And Remove unnecessary codes. The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one. 721918 3 seokju.kwon 2012-09-17 07:46:46 -0700 (In reply to comment #2) > (From update of attachment 164367 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164367&action=review > > > Tools/ChangeLog:9 > > + The background view doesn't display properly on test browsers after adding url bar. > > + And Remove unnecessary codes. > > The changes themselves look OK, but what kind of display failures were you experiencing? Plus, you only seem to be removing code related to the background view, not unnecessary one. I couldn't see the pink background any more after adding url bar. Plus Could you explain why it is necessary? 722608 4 rakuco 2012-09-18 02:22:16 -0700 (In reply to comment #3) > I couldn't see the pink background any more after adding url bar. Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > Plus Could you explain why it is necessary? ? 722620 5 seokju.kwon 2012-09-18 03:09:09 -0700 (In reply to comment #4) > (In reply to comment #3) > > I couldn't see the pink background any more after adding url bar. > > Makes sense, since r126419 changed the evas_object_{move,resize} calls. I would just say in the ChangeLog that having the background view is not necessary anymore, since it was used for debugging back in the day. > > > Plus Could you explain why it is necessary? > > ? I was just wondering whether background view is necessary or not now. 722622 6 164523 seokju.kwon 2012-09-18 03:23:08 -0700 Created attachment 164523 Patch 722627 7 164523 rakuco 2012-09-18 03:29:26 -0700 Comment on attachment 164523 Patch Looks good, thanks. 722671 8 164523 webkit.review.bot 2012-09-18 05:05:09 -0700 Comment on attachment 164523 Patch Clearing flags on attachment: 164523 Committed r128876: <http://trac.webkit.org/changeset/128876> 722673 9 webkit.review.bot 2012-09-18 05:05:16 -0700 All reviewed patches have been landed. Closing bug. 164367 2012-09-17 04:33:34 -0700 2012-09-18 03:23:03 -0700 Patch bug-96905-20120917203307.patch text/plain 4490 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMzYWZiMTY1ZjU0ZDM1ZWZlZWE1Yjc4M2FiYThlYzgx MjUwNDQ0My4uOGNjODEwMjVjOTc0YjljMzA5NzRlZTA3Zjc5Yzg4NGQzNmRlZjExZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA5LTE3ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIFJlbW92ZSBiYWNrZ3JvdW5kIHZpZXcgb24gRVdlYkxhdW5jaGVyIGFu ZCBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTY5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgYmFja2dyb3VuZCB2aWV3IGRvZXNuJ3QgZGlzcGxheSBwcm9wZXJseSBvbiB0ZXN0 IGJyb3dzZXJzIGFmdGVyIGFkZGluZyB1cmwgYmFyLgorICAgICAgICBBbmQgUmVtb3ZlIHVubmVj ZXNzYXJ5IGNvZGVzLgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAgICAg KF9FTGF1bmNoZXIpOgorICAgICAgICAob25fZWNvcmVfZXZhc19yZXNpemUpOgorICAgICAgICAo YnJvd3NlckNyZWF0ZSk6CisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAg ICAgKF9NaW5pQnJvd3Nlcik6CisgICAgICAgIChvbl9lY29yZV9ldmFzX3Jlc2l6ZSk6CisgICAg ICAgIChicm93c2VyQ3JlYXRlKToKKwogMjAxMi0wOS0xNCAgRGlyayBQcmFua2UgIDxkcHJhbmtl QGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0OiAtLWFkZGl0aW9uYWwtcGxhdGZvcm0tZGly IGlzIGJyb2tlbiBvbiBjaHJvbWl1bSBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdlYkxhdW5j aGVyL21haW4uYyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggOGU2YWUwMDI3ZDU0 Y2Q0ZDgyZjRiOTY1OTU5OTNkZDg2N2ZjNDU0Ny4uZGQzOTJlNGUxOGIwOWEwNmU4NDFjNWU3MjU1 NjBhMzEzNDI3OGVlOSAxMDA2NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYworKysg Yi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCkBAIC0xNTUsNyArMTU1LDYgQEAgdHlwZWRlZiBz dHJ1Y3QgX1VzZXJfQXJndW1lbnRzIHsKIHR5cGVkZWYgc3RydWN0IF9FTGF1bmNoZXIgewogICAg IEVjb3JlX0V2YXMgKmVlOwogICAgIEV2YXMgKmV2YXM7Ci0gICAgRXZhc19PYmplY3QgKmJnOwog ICAgIEV2YXNfT2JqZWN0ICpicm93c2VyOwogICAgIFVybF9CYXIgKnVybF9iYXI7CiAgICAgVXNl cl9Bcmd1bWVudHMgKnVzZXJBcmdzOwpAQCAtMjQyLDcgKzI0MSw2IEBAIG9uX2Vjb3JlX2V2YXNf cmVzaXplKEVjb3JlX0V2YXMgKmVlKQogewogICAgIEVMYXVuY2hlciAqYXBwOwogICAgIEV2YXNf T2JqZWN0ICp3ZWJ2aWV3OwotICAgIEV2YXNfT2JqZWN0ICpiZzsKICAgICBpbnQgdywgaDsKIAog ICAgIGVjb3JlX2V2YXNfZ2VvbWV0cnlfZ2V0KGVlLCBOVUxMLCBOVUxMLCAmdywgJmgpOwpAQCAt MjUxLDEwICsyNDksNiBAQCBvbl9lY29yZV9ldmFzX3Jlc2l6ZShFY29yZV9FdmFzICplZSkKICAg ICBhcHAgPSBmaW5kX2FwcF9mcm9tX2VlKGVlKTsKICAgICB1cmxfYmFyX3dpZHRoX3NldChhcHAt PnVybF9iYXIsIHcpOwogCi0gICAgYmcgPSBldmFzX29iamVjdF9uYW1lX2ZpbmQoZWNvcmVfZXZh c19nZXQoZWUpLCAiYmciKTsKLSAgICBldmFzX29iamVjdF9tb3ZlKGJnLCAwLCAwKTsKLSAgICBl dmFzX29iamVjdF9yZXNpemUoYmcsIHcsIGgpOwotCiAgICAgd2VidmlldyA9IGV2YXNfb2JqZWN0 X25hbWVfZmluZChlY29yZV9ldmFzX2dldChlZSksICJicm93c2VyIik7CiAgICAgZXZhc19vYmpl Y3RfbW92ZSh3ZWJ2aWV3LCAwLCBVUkxfQkFSX0hFSUdIVCk7CiAgICAgZXZhc19vYmplY3RfcmVz aXplKHdlYnZpZXcsIHcsIGggLSBVUkxfQkFSX0hFSUdIVCk7CkBAIC02OTEsMTQgKzY4NSw2IEBA IGJyb3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBVc2VyX0FyZ3VtZW50cyAqdXNlckFyZ3Mp CiAgICAgaWYgKCFhcHAtPmV2YXMpCiAgICAgICAgIHJldHVybiBxdWl0KEVJTkFfRkFMU0UsICJF UlJPUjogY291bGQgbm90IGdldCBldmFzIGZyb20gZXZhcy1lY29yZVxuIik7CiAKLSAgICBhcHAt PmJnID0gZXZhc19vYmplY3RfcmVjdGFuZ2xlX2FkZChhcHAtPmV2YXMpOwotICAgIGV2YXNfb2Jq ZWN0X25hbWVfc2V0KGFwcC0+YmcsICJiZyIpOwotICAgIGV2YXNfb2JqZWN0X2NvbG9yX3NldChh cHAtPmJnLCAyNTUsIDAsIDI1NSwgMjU1KTsKLSAgICBldmFzX29iamVjdF9tb3ZlKGFwcC0+Ymcs IDAsIDApOwotICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZShhcHAtPmJnLCBnZW9tZXRyeS53LCBnZW9t ZXRyeS5oKTsKLSAgICBldmFzX29iamVjdF9sYXllcl9zZXQoYXBwLT5iZywgRVZBU19MQVlFUl9N SU4pOwotICAgIGV2YXNfb2JqZWN0X3Nob3coYXBwLT5iZyk7Ci0KICAgICBpZiAodXNlckFyZ3Mt PmJhY2tpbmdTdG9yZSAmJiAhc3RyY2FzZWNtcCh1c2VyQXJncy0+YmFja2luZ1N0b3JlLCAidGls ZWQiKSkgewogICAgICAgICBhcHAtPmJyb3dzZXIgPSBld2tfdmlld190aWxlZF9hZGQoYXBwLT5l dmFzKTsKICAgICAgICAgaW5mbygiYmFja2luZyBzdG9yZTogdGlsZWRcbiIpOwpkaWZmIC0tZ2l0 IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9t YWluLmMKaW5kZXggZTNjMTkyOWQ1NjJmNGI0MDUyMzFjMzk3Mzg2ZDIyZTM5OWRjMDE5Yy4uYjQ0 ZTUxNGExMGRjNjI0MTBmYmJjMGQ0OGY5N2RhMDcxYjNjYjU0OSAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CkBAIC00MSw3ICs0MSw2IEBAIHN0YXRpYyBpbnQgdmVyYm9zZSA9IDA7CiB0eXBlZGVmIHN0cnVj dCBfTWluaUJyb3dzZXIgewogICAgIEVjb3JlX0V2YXMgKmVlOwogICAgIEV2YXMgKmV2YXM7Ci0g ICAgRXZhc19PYmplY3QgKmJnOwogICAgIEV2YXNfT2JqZWN0ICpicm93c2VyOwogICAgIFVybF9C YXIgKnVybF9iYXI7CiB9IE1pbmlCcm93c2VyOwpAQCAtODUsNyArODQsNiBAQCBzdGF0aWMgdm9p ZCBjbG9zZVdpbmRvdyhFY29yZV9FdmFzICplZSkKIHN0YXRpYyB2b2lkIG9uX2Vjb3JlX2V2YXNf cmVzaXplKEVjb3JlX0V2YXMgKmVlKQogewogICAgIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3OwotICAg IEV2YXNfT2JqZWN0ICpiZzsKICAgICBpbnQgdywgaDsKIAogICAgIGVjb3JlX2V2YXNfZ2VvbWV0 cnlfZ2V0KGVlLCBOVUxMLCBOVUxMLCAmdywgJmgpOwpAQCAtOTMsMTAgKzkxLDYgQEAgc3RhdGlj IHZvaWQgb25fZWNvcmVfZXZhc19yZXNpemUoRWNvcmVfRXZhcyAqZWUpCiAgICAgLyogUmVzaXpl IFVSTCBiYXIgKi8KICAgICB1cmxfYmFyX3dpZHRoX3NldChicm93c2VyLT51cmxfYmFyLCB3KTsK IAotICAgIGJnID0gZXZhc19vYmplY3RfbmFtZV9maW5kKGVjb3JlX2V2YXNfZ2V0KGVlKSwgImJn Iik7Ci0gICAgZXZhc19vYmplY3RfbW92ZShiZywgMCwgMCk7Ci0gICAgZXZhc19vYmplY3RfcmVz aXplKGJnLCB3LCBoKTsKLQogICAgIHdlYnZpZXcgPSBldmFzX29iamVjdF9uYW1lX2ZpbmQoZWNv cmVfZXZhc19nZXQoZWUpLCAiYnJvd3NlciIpOwogICAgIGV2YXNfb2JqZWN0X21vdmUod2Vidmll dywgMCwgVVJMX0JBUl9IRUlHSFQpOwogICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZSh3ZWJ2aWV3LCB3 LCBoIC0gVVJMX0JBUl9IRUlHSFQpOwpAQCAtMjMzLDE1ICsyMjcsNiBAQCBzdGF0aWMgTWluaUJy b3dzZXIgKmJyb3dzZXJDcmVhdGUoY29uc3QgY2hhciAqdXJsLCBjb25zdCBjaGFyICplbmdpbmUp CiAKICAgICBhcHAtPmV2YXMgPSBlY29yZV9ldmFzX2dldChhcHAtPmVlKTsKIAotICAgIGFwcC0+ YmcgPSBldmFzX29iamVjdF9yZWN0YW5nbGVfYWRkKGFwcC0+ZXZhcyk7Ci0gICAgZXZhc19vYmpl Y3RfbmFtZV9zZXQoYXBwLT5iZywgImJnIik7Ci0gICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X3dl aWdodF9zZXQoYXBwLT5iZywgRVZBU19ISU5UX0VYUEFORCwgRVZBU19ISU5UX0VYUEFORCk7Ci0K LSAgICBldmFzX29iamVjdF9tb3ZlKGFwcC0+YmcsIDAsIDApOwotICAgIGV2YXNfb2JqZWN0X3Jl c2l6ZShhcHAtPmJnLCBERUZBVUxUX1dJRFRILCBERUZBVUxUX0hFSUdIVCk7Ci0gICAgZXZhc19v YmplY3RfY29sb3Jfc2V0KGFwcC0+YmcsIDI1NSwgMTUwLCAxNTAsIDI1NSk7Ci0gICAgZXZhc19v YmplY3Rfc2hvdyhhcHAtPmJnKTsKLQogICAgIC8qIENyZWF0ZSB3ZWJ2aWV3ICovCiAgICAgYXBw LT5icm93c2VyID0gZXdrX3ZpZXdfYWRkKGFwcC0+ZXZhcyk7CiAgICAgZXdrX3ZpZXdfdGhlbWVf c2V0KGFwcC0+YnJvd3NlciwgVEhFTUVfRElSIi9kZWZhdWx0LmVkaiIpOwo= 164523 2012-09-18 03:23:08 -0700 2012-09-18 05:05:09 -0700 Patch bug-96905-20120918192240.patch text/plain 4529 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMzYWZiMTY1ZjU0ZDM1ZWZlZWE1Yjc4M2FiYThlYzgx MjUwNDQ0My4uOTNhNjVlNjMwNzQyNzQ2NjRmYjJhMGI1M2ZhM2I3NTZmYTJkMzRjMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA5LTE3ICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIFJlbW92ZSBiYWNrZ3JvdW5kIHZpZXcgb24gRVdlYkxhdW5jaGVyIGFu ZCBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTY5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgc2l6ZSBvZiB3ZWJ2aWV3IHdhcyBjaGFuZ2VkIGFmdGVyIGFkZGluZyB1cmwgYmFy LgorICAgICAgICBBbmQgdGhlIGJhY2tncm91bmQgdmlldyBpcyBub3QgbmVjZXNzYXJ5IGFueW1v cmUsIHNpbmNlIGl0IHdhcyB1c2VkIGZvciBkZWJ1Z2dpbmcgYmFjayBpbiB0aGUgZGF5LgorCisg ICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKF9FTGF1bmNoZXIpOgorICAg ICAgICAob25fZWNvcmVfZXZhc19yZXNpemUpOgorICAgICAgICAoYnJvd3NlckNyZWF0ZSk6Cisg ICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKF9NaW5pQnJvd3Nlcik6 CisgICAgICAgIChvbl9lY29yZV9ldmFzX3Jlc2l6ZSk6CisgICAgICAgIChicm93c2VyQ3JlYXRl KToKKwogMjAxMi0wOS0xNCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBucnd0OiAtLWFkZGl0aW9uYWwtcGxhdGZvcm0tZGlyIGlzIGJyb2tlbiBvbiBjaHJv bWl1bSBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYyBiL1Rvb2xz L0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggOGU2YWUwMDI3ZDU0Y2Q0ZDgyZjRiOTY1OTU5OTNk ZDg2N2ZjNDU0Ny4uZGQzOTJlNGUxOGIwOWEwNmU4NDFjNWU3MjU1NjBhMzEzNDI3OGVlOSAxMDA2 NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYworKysgYi9Ub29scy9FV2ViTGF1bmNo ZXIvbWFpbi5jCkBAIC0xNTUsNyArMTU1LDYgQEAgdHlwZWRlZiBzdHJ1Y3QgX1VzZXJfQXJndW1l bnRzIHsKIHR5cGVkZWYgc3RydWN0IF9FTGF1bmNoZXIgewogICAgIEVjb3JlX0V2YXMgKmVlOwog ICAgIEV2YXMgKmV2YXM7Ci0gICAgRXZhc19PYmplY3QgKmJnOwogICAgIEV2YXNfT2JqZWN0ICpi cm93c2VyOwogICAgIFVybF9CYXIgKnVybF9iYXI7CiAgICAgVXNlcl9Bcmd1bWVudHMgKnVzZXJB cmdzOwpAQCAtMjQyLDcgKzI0MSw2IEBAIG9uX2Vjb3JlX2V2YXNfcmVzaXplKEVjb3JlX0V2YXMg KmVlKQogewogICAgIEVMYXVuY2hlciAqYXBwOwogICAgIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3Owot ICAgIEV2YXNfT2JqZWN0ICpiZzsKICAgICBpbnQgdywgaDsKIAogICAgIGVjb3JlX2V2YXNfZ2Vv bWV0cnlfZ2V0KGVlLCBOVUxMLCBOVUxMLCAmdywgJmgpOwpAQCAtMjUxLDEwICsyNDksNiBAQCBv bl9lY29yZV9ldmFzX3Jlc2l6ZShFY29yZV9FdmFzICplZSkKICAgICBhcHAgPSBmaW5kX2FwcF9m cm9tX2VlKGVlKTsKICAgICB1cmxfYmFyX3dpZHRoX3NldChhcHAtPnVybF9iYXIsIHcpOwogCi0g ICAgYmcgPSBldmFzX29iamVjdF9uYW1lX2ZpbmQoZWNvcmVfZXZhc19nZXQoZWUpLCAiYmciKTsK LSAgICBldmFzX29iamVjdF9tb3ZlKGJnLCAwLCAwKTsKLSAgICBldmFzX29iamVjdF9yZXNpemUo YmcsIHcsIGgpOwotCiAgICAgd2VidmlldyA9IGV2YXNfb2JqZWN0X25hbWVfZmluZChlY29yZV9l dmFzX2dldChlZSksICJicm93c2VyIik7CiAgICAgZXZhc19vYmplY3RfbW92ZSh3ZWJ2aWV3LCAw LCBVUkxfQkFSX0hFSUdIVCk7CiAgICAgZXZhc19vYmplY3RfcmVzaXplKHdlYnZpZXcsIHcsIGgg LSBVUkxfQkFSX0hFSUdIVCk7CkBAIC02OTEsMTQgKzY4NSw2IEBAIGJyb3dzZXJDcmVhdGUoY29u c3QgY2hhciAqdXJsLCBVc2VyX0FyZ3VtZW50cyAqdXNlckFyZ3MpCiAgICAgaWYgKCFhcHAtPmV2 YXMpCiAgICAgICAgIHJldHVybiBxdWl0KEVJTkFfRkFMU0UsICJFUlJPUjogY291bGQgbm90IGdl dCBldmFzIGZyb20gZXZhcy1lY29yZVxuIik7CiAKLSAgICBhcHAtPmJnID0gZXZhc19vYmplY3Rf cmVjdGFuZ2xlX2FkZChhcHAtPmV2YXMpOwotICAgIGV2YXNfb2JqZWN0X25hbWVfc2V0KGFwcC0+ YmcsICJiZyIpOwotICAgIGV2YXNfb2JqZWN0X2NvbG9yX3NldChhcHAtPmJnLCAyNTUsIDAsIDI1 NSwgMjU1KTsKLSAgICBldmFzX29iamVjdF9tb3ZlKGFwcC0+YmcsIDAsIDApOwotICAgIGV2YXNf b2JqZWN0X3Jlc2l6ZShhcHAtPmJnLCBnZW9tZXRyeS53LCBnZW9tZXRyeS5oKTsKLSAgICBldmFz X29iamVjdF9sYXllcl9zZXQoYXBwLT5iZywgRVZBU19MQVlFUl9NSU4pOwotICAgIGV2YXNfb2Jq ZWN0X3Nob3coYXBwLT5iZyk7Ci0KICAgICBpZiAodXNlckFyZ3MtPmJhY2tpbmdTdG9yZSAmJiAh c3RyY2FzZWNtcCh1c2VyQXJncy0+YmFja2luZ1N0b3JlLCAidGlsZWQiKSkgewogICAgICAgICBh cHAtPmJyb3dzZXIgPSBld2tfdmlld190aWxlZF9hZGQoYXBwLT5ldmFzKTsKICAgICAgICAgaW5m bygiYmFja2luZyBzdG9yZTogdGlsZWRcbiIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggZTNjMTky OWQ1NjJmNGI0MDUyMzFjMzk3Mzg2ZDIyZTM5OWRjMDE5Yy4uYjQ0ZTUxNGExMGRjNjI0MTBmYmJj MGQ0OGY5N2RhMDcxYjNjYjU0OSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h aW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC00MSw3ICs0MSw2IEBA IHN0YXRpYyBpbnQgdmVyYm9zZSA9IDA7CiB0eXBlZGVmIHN0cnVjdCBfTWluaUJyb3dzZXIgewog ICAgIEVjb3JlX0V2YXMgKmVlOwogICAgIEV2YXMgKmV2YXM7Ci0gICAgRXZhc19PYmplY3QgKmJn OwogICAgIEV2YXNfT2JqZWN0ICpicm93c2VyOwogICAgIFVybF9CYXIgKnVybF9iYXI7CiB9IE1p bmlCcm93c2VyOwpAQCAtODUsNyArODQsNiBAQCBzdGF0aWMgdm9pZCBjbG9zZVdpbmRvdyhFY29y ZV9FdmFzICplZSkKIHN0YXRpYyB2b2lkIG9uX2Vjb3JlX2V2YXNfcmVzaXplKEVjb3JlX0V2YXMg KmVlKQogewogICAgIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3OwotICAgIEV2YXNfT2JqZWN0ICpiZzsK ICAgICBpbnQgdywgaDsKIAogICAgIGVjb3JlX2V2YXNfZ2VvbWV0cnlfZ2V0KGVlLCBOVUxMLCBO VUxMLCAmdywgJmgpOwpAQCAtOTMsMTAgKzkxLDYgQEAgc3RhdGljIHZvaWQgb25fZWNvcmVfZXZh c19yZXNpemUoRWNvcmVfRXZhcyAqZWUpCiAgICAgLyogUmVzaXplIFVSTCBiYXIgKi8KICAgICB1 cmxfYmFyX3dpZHRoX3NldChicm93c2VyLT51cmxfYmFyLCB3KTsKIAotICAgIGJnID0gZXZhc19v YmplY3RfbmFtZV9maW5kKGVjb3JlX2V2YXNfZ2V0KGVlKSwgImJnIik7Ci0gICAgZXZhc19vYmpl Y3RfbW92ZShiZywgMCwgMCk7Ci0gICAgZXZhc19vYmplY3RfcmVzaXplKGJnLCB3LCBoKTsKLQog ICAgIHdlYnZpZXcgPSBldmFzX29iamVjdF9uYW1lX2ZpbmQoZWNvcmVfZXZhc19nZXQoZWUpLCAi YnJvd3NlciIpOwogICAgIGV2YXNfb2JqZWN0X21vdmUod2VidmlldywgMCwgVVJMX0JBUl9IRUlH SFQpOwogICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZSh3ZWJ2aWV3LCB3LCBoIC0gVVJMX0JBUl9IRUlH SFQpOwpAQCAtMjMzLDE1ICsyMjcsNiBAQCBzdGF0aWMgTWluaUJyb3dzZXIgKmJyb3dzZXJDcmVh dGUoY29uc3QgY2hhciAqdXJsLCBjb25zdCBjaGFyICplbmdpbmUpCiAKICAgICBhcHAtPmV2YXMg PSBlY29yZV9ldmFzX2dldChhcHAtPmVlKTsKIAotICAgIGFwcC0+YmcgPSBldmFzX29iamVjdF9y ZWN0YW5nbGVfYWRkKGFwcC0+ZXZhcyk7Ci0gICAgZXZhc19vYmplY3RfbmFtZV9zZXQoYXBwLT5i ZywgImJnIik7Ci0gICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X3dlaWdodF9zZXQoYXBwLT5iZywg RVZBU19ISU5UX0VYUEFORCwgRVZBU19ISU5UX0VYUEFORCk7Ci0KLSAgICBldmFzX29iamVjdF9t b3ZlKGFwcC0+YmcsIDAsIDApOwotICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZShhcHAtPmJnLCBERUZB VUxUX1dJRFRILCBERUZBVUxUX0hFSUdIVCk7Ci0gICAgZXZhc19vYmplY3RfY29sb3Jfc2V0KGFw cC0+YmcsIDI1NSwgMTUwLCAxNTAsIDI1NSk7Ci0gICAgZXZhc19vYmplY3Rfc2hvdyhhcHAtPmJn KTsKLQogICAgIC8qIENyZWF0ZSB3ZWJ2aWV3ICovCiAgICAgYXBwLT5icm93c2VyID0gZXdrX3Zp ZXdfYWRkKGFwcC0+ZXZhcyk7CiAgICAgZXdrX3ZpZXdfdGhlbWVfc2V0KGFwcC0+YnJvd3Nlciwg VEhFTUVfRElSIi9kZWZhdWx0LmVkaiIpOwo=