96890 2012-09-16 13:47:09 -0700 REGRESSION (r126763): css1/pseudo/firstline.html fails when using the complex text code path 2012-09-16 16:39:37 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Normal --- 1 mitz mitz eric ned webkit.review.bot oldest_to_newest 721629 0 mitz 2012-09-16 13:47:09 -0700 To reproduce: 1. run-webkit-tests --complex css1/pseudo/firstline.html —or— 1. Open the test in Safari 2. Select Always Use Complex Text Code Path in Debug > Miscellaneous 3. Reload This was caused by <http://trac.webkit.org/r126763>, the fix for bug 83045. 721631 1 mitz 2012-09-16 14:03:45 -0700 This happens because the same RenderText is rendered with two different fonts on different lines. I think the solution is to add a Font* to RenderTextInfo. 721632 2 164324 mitz 2012-09-16 14:13:52 -0700 Created attachment 164324 Proposed fix (no change log or test yet) 721636 3 164325 mitz 2012-09-16 16:09:04 -0700 Created attachment 164325 Invalidate the TextLayout on font change 721639 4 164325 eric 2012-09-16 16:36:14 -0700 Comment on attachment 164325 Invalidate the TextLayout on font change View in context: https://bugs.webkit.org/attachment.cgi?id=164325&action=review > Source/WebCore/ChangeLog:10 > + When a first-line style specifies a font, different pieces of the same RednerText can be RenderText > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2440 > + renderTextInfo.m_font = &f; Do we ever need to clear this pointer? 721640 5 164325 eric 2012-09-16 16:36:32 -0700 Comment on attachment 164325 Invalidate the TextLayout on font change Sorry, didn't mean to clear Sam's review. 721641 6 mitz 2012-09-16 16:39:37 -0700 Fixed in <http://trac.webkit.org/r128713>. (In reply to comment #4) > (From update of attachment 164325 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164325&action=review > > > Source/WebCore/ChangeLog:10 > > + When a first-line style specifies a font, different pieces of the same RednerText can be > > RenderText Fixed in <http://trac.webkit.org/r128714>. > > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2440 > > + renderTextInfo.m_font = &f; > > Do we ever need to clear this pointer? No, the RenderTextInfo gets destroyed at the end of line layout. 164324 2012-09-16 14:13:52 -0700 2012-09-16 16:09:00 -0700 Proposed fix (no change log or test yet) 96890_r0.diff text/plain 1733 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCShyZXZpc2lvbiAxMjg3 MTEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkod29ya2luZyBj b3B5KQpAQCAtNzE1LDYgKzcxNSw3IEBAIHByaXZhdGU6CiAgICAgICAgIFJlbmRlclRleHQqIG1f dGV4dDsKICAgICAgICAgT3duUHRyPFRleHRMYXlvdXQ+IG1fbGF5b3V0OwogICAgICAgICBMYXp5 TGluZUJyZWFrSXRlcmF0b3IgbV9saW5lQnJlYWtJdGVyYXRvcjsKKyAgICAgICAgY29uc3QgRm9u dCogbV9mb250OwogICAgIH07CiAKICAgICBjbGFzcyBMaW5lQnJlYWtlciB7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAko cmV2aXNpb24gMTI4NzExKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr TGluZUxheW91dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNzUsNiArMTI3NSw3IEBAIHZvaWQg UmVuZGVyQmxvY2s6OmxheW91dFJ1bnNBbmRGbG9hdHMoTGkKIAogUmVuZGVyQmxvY2s6OlJlbmRl clRleHRJbmZvOjpSZW5kZXJUZXh0SW5mbygpCiAgICAgOiBtX3RleHQoMCkKKyAgICAsIG1fZm9u dCgwKQogewogfQogCkBAIC0yNDM2LDkgKzI0MzcsMTQgQEAgSW5saW5lSXRlcmF0b3IgUmVuZGVy QmxvY2s6OkxpbmVCcmVha2VyOgogICAgICAgICAgICAgaWYgKHJlbmRlclRleHRJbmZvLm1fdGV4 dCAhPSB0KSB7CiAgICAgICAgICAgICAgICAgdC0+dXBkYXRlVGV4dElmTmVlZGVkKCk7CiAgICAg ICAgICAgICAgICAgcmVuZGVyVGV4dEluZm8ubV90ZXh0ID0gdDsKKyAgICAgICAgICAgICAgICBy ZW5kZXJUZXh0SW5mby5tX2ZvbnQgPSAmZjsKICAgICAgICAgICAgICAgICByZW5kZXJUZXh0SW5m by5tX2xheW91dCA9IGYuY3JlYXRlTGF5b3V0KHQsIHdpZHRoLmN1cnJlbnRXaWR0aCgpLCBjb2xs YXBzZVdoaXRlU3BhY2UpOwogICAgICAgICAgICAgICAgIHJlbmRlclRleHRJbmZvLm1fbGluZUJy ZWFrSXRlcmF0b3IucmVzZXQodC0+Y2hhcmFjdGVycygpLCB0LT50ZXh0TGVuZ3RoKCksIHN0eWxl LT5sb2NhbGUoKSk7CisgICAgICAgICAgICB9IGVsc2UgaWYgKHJlbmRlclRleHRJbmZvLm1fbGF5 b3V0ICYmIHJlbmRlclRleHRJbmZvLm1fZm9udCAhPSAmZikgeworICAgICAgICAgICAgICAgIHJl bmRlclRleHRJbmZvLm1fZm9udCA9ICZmOworICAgICAgICAgICAgICAgIHJlbmRlclRleHRJbmZv Lm1fbGF5b3V0ID0gZi5jcmVhdGVMYXlvdXQodCwgd2lkdGguY3VycmVudFdpZHRoKCksIGNvbGxh cHNlV2hpdGVTcGFjZSk7CiAgICAgICAgICAgICB9CisKICAgICAgICAgICAgIFRleHRMYXlvdXQq IHRleHRMYXlvdXQgPSByZW5kZXJUZXh0SW5mby5tX2xheW91dC5nZXQoKTsKIAogICAgICAgICAg ICAgZm9yICg7IGN1cnJlbnQubV9wb3MgPCB0LT50ZXh0TGVuZ3RoKCk7IGN1cnJlbnQuZmFzdElu Y3JlbWVudEluVGV4dE5vZGUoKSkgewo= 164325 2012-09-16 16:09:04 -0700 2012-09-16 16:36:31 -0700 Invalidate the TextLayout on font change bug-96890-20120916160846.patch text/plain 4767 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODcxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTE2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyNjc2Myk6 IGNzczEvcHNldWRvL2ZpcnN0bGluZS5odG1sIGZhaWxzIHdoZW4gdXNpbmcgdGhlIGNvbXBsZXgg dGV4dCBjb2RlIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVzdDogZmFzdC90ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1maXJzdC1saW5lLmh0 bWwKKworICAgICAgICBXaGVuIGEgZmlyc3QtbGluZSBzdHlsZSBzcGVjaWZpZXMgYSBmb250LCBk aWZmZXJlbnQgcGllY2VzIG9mIHRoZSBzYW1lIFJlZG5lclRleHQgY2FuIGJlCisgICAgICAgIGxh aWQgb3V0IHVzaW5nIGRpZmZlcmVudCBmb250cywgcmVxdWlyaW5nIGEgZGlmZmVyZXQgVGV4dExh eW91dCBmb3IgZWFjaCBwaWVjZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5o OgorICAgICAgICAoUmVuZGVyVGV4dEluZm8pOiBBZGRlZCBtX2ZvbnQgZGF0YSBtZW1iZXIuCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJCbG9jazo6UmVuZGVyVGV4dEluZm86OlJlbmRlclRleHRJbmZvKTogQWRk ZWQgaW5pdGlhbGl6ZXIgZm9yIG5ldyBkYXRhIG1lbWJlci4KKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJsb2NrOjpMaW5lQnJlYWtlcjo6bmV4dExpbmVCcmVhayk6IEFkZGVkIGNvZGUgdG8gdXBk YXRlIHRoZSB0ZXh0IGxheW91dCBpbgorICAgICAgICByZW5kZXJUZXh0SW5mbyBpZiB0aGUgZm9u dCBoYXMgY2hhbmdlZC4KKwogMjAxMi0wOS0xNiAgS2FsZXYgTGVtYmVyICA8a2FsZXZsZW1iZXJA Z21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIE1pc3NpbmcgZGxsZXhwb3J0IGNhdXNpbmcgbGlu a2luZyBlcnJvcnMgb24gV2luZG93cyBwbGF0Zm9ybQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmgJKHJldmlzaW9uIDEyODcxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC03MTUsNiArNzE1LDcgQEAg cHJpdmF0ZToKICAgICAgICAgUmVuZGVyVGV4dCogbV90ZXh0OwogICAgICAgICBPd25QdHI8VGV4 dExheW91dD4gbV9sYXlvdXQ7CiAgICAgICAgIExhenlMaW5lQnJlYWtJdGVyYXRvciBtX2xpbmVC cmVha0l0ZXJhdG9yOworICAgICAgICBjb25zdCBGb250KiBtX2ZvbnQ7CiAgICAgfTsKIAogICAg IGNsYXNzIExpbmVCcmVha2VyIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9ja0xpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCShyZXZpc2lvbiAxMjg3MTEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTI3NSw2ICsxMjc1LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0UnVuc0Fu ZEZsb2F0cyhMaQogCiBSZW5kZXJCbG9jazo6UmVuZGVyVGV4dEluZm86OlJlbmRlclRleHRJbmZv KCkKICAgICA6IG1fdGV4dCgwKQorICAgICwgbV9mb250KDApCiB7CiB9CiAKQEAgLTI0MzYsOSAr MjQzNywxNCBAQCBJbmxpbmVJdGVyYXRvciBSZW5kZXJCbG9jazo6TGluZUJyZWFrZXI6CiAgICAg ICAgICAgICBpZiAocmVuZGVyVGV4dEluZm8ubV90ZXh0ICE9IHQpIHsKICAgICAgICAgICAgICAg ICB0LT51cGRhdGVUZXh0SWZOZWVkZWQoKTsKICAgICAgICAgICAgICAgICByZW5kZXJUZXh0SW5m by5tX3RleHQgPSB0OworICAgICAgICAgICAgICAgIHJlbmRlclRleHRJbmZvLm1fZm9udCA9ICZm OwogICAgICAgICAgICAgICAgIHJlbmRlclRleHRJbmZvLm1fbGF5b3V0ID0gZi5jcmVhdGVMYXlv dXQodCwgd2lkdGguY3VycmVudFdpZHRoKCksIGNvbGxhcHNlV2hpdGVTcGFjZSk7CiAgICAgICAg ICAgICAgICAgcmVuZGVyVGV4dEluZm8ubV9saW5lQnJlYWtJdGVyYXRvci5yZXNldCh0LT5jaGFy YWN0ZXJzKCksIHQtPnRleHRMZW5ndGgoKSwgc3R5bGUtPmxvY2FsZSgpKTsKKyAgICAgICAgICAg IH0gZWxzZSBpZiAocmVuZGVyVGV4dEluZm8ubV9sYXlvdXQgJiYgcmVuZGVyVGV4dEluZm8ubV9m b250ICE9ICZmKSB7CisgICAgICAgICAgICAgICAgcmVuZGVyVGV4dEluZm8ubV9mb250ID0gJmY7 CisgICAgICAgICAgICAgICAgcmVuZGVyVGV4dEluZm8ubV9sYXlvdXQgPSBmLmNyZWF0ZUxheW91 dCh0LCB3aWR0aC5jdXJyZW50V2lkdGgoKSwgY29sbGFwc2VXaGl0ZVNwYWNlKTsKICAgICAgICAg ICAgIH0KKwogICAgICAgICAgICAgVGV4dExheW91dCogdGV4dExheW91dCA9IHJlbmRlclRleHRJ bmZvLm1fbGF5b3V0LmdldCgpOwogCiAgICAgICAgICAgICBmb3IgKDsgY3VycmVudC5tX3BvcyA8 IHQtPnRleHRMZW5ndGgoKTsgY3VycmVudC5mYXN0SW5jcmVtZW50SW5UZXh0Tm9kZSgpKSB7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjg3MTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wOS0xNiAgRGFuIEJlcm5zdGVpbiAgPG1p dHpAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMjY3NjMpOiBjc3MxL3BzZXVk by9maXJzdGxpbmUuaHRtbCBmYWlscyB3aGVuIHVzaW5nIHRoZSBjb21wbGV4IHRleHQgY29kZSBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njg5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFz dC90ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1maXJzdC1saW5lLWV4cGVjdGVkLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9zdGFsZS1UZXh0TGF5b3V0LWZyb20tZmlyc3QtbGlu ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wOS0xNiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9w aGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFNraXAgZmFzdC9sb2FkZXIvZGlz cGxheS1pbWFnZS11bnNldC1jYW4tYmxvY2staW1hZ2UtYW5kLWNhbi1yZWxvYWQtaW4tcGxhY2Uu aHRtbApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1m aXJzdC1saW5lLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1maXJzdC1saW5lLWV4cGVjdGVkLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc3RhbGUtVGV4dExheW91dC1mcm9tLWZp cnN0LWxpbmUtZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPHN0 eWxlPgorICAgIGRpdiB7CisgICAgICAgIHdpZHRoOiAxMmV4OworICAgICAgICBib3JkZXI6IHNv bGlkIGJsdWU7CisgICAgfQorCisgICAgZGl2OjpmaXJzdC1saW5lIHsKKyAgICAgICAgZm9udC1z aXplOiAyMDAlOworICAgIH0KKzwvc3R5bGU+Cis8ZGl2PgorICAgIHh4eHggeHh4eCB4eHh4IHh4 eHggeHh4eCB4eHh4PCEtLSAtLT4gJiN4MDMwMDsKKzwvZGl2PgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1maXJzdC1saW5lLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3N0YWxlLVRleHRMYXlvdXQtZnJvbS1maXJzdC1s aW5lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc3RhbGUtVGV4 dExheW91dC1mcm9tLWZpcnN0LWxpbmUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBA QAorPHN0eWxlPgorICAgIGRpdiB7CisgICAgICAgIHdpZHRoOiAxMmV4OworICAgICAgICBib3Jk ZXI6IHNvbGlkIGJsdWU7CisgICAgfQorCisgICAgZGl2OjpmaXJzdC1saW5lIHsKKyAgICAgICAg Zm9udC1zaXplOiAyMDAlOworICAgIH0KKzwvc3R5bGU+Cis8ZGl2PgorICAgIHh4eHggeHh4eCB4 eHh4IHh4eHggeHh4eCB4eHh4ICYjeDAzMDA7Cis8L2Rpdj4K