96878 2012-09-15 22:26:51 -0700 JSObject.cpp and JSArray.cpp have inconsistent tests for the invalid array index case 2012-09-16 00:22:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo sam webkit.review.bot oldest_to_newest 721549 0 fpizlo 2012-09-15 22:26:51 -0700 The UNLIKELY() macro buys us nothing here anyway so we should probably kill off our use of it. Though I'm all for surgical uses of UNLIKELY() in places where it matters, I don't like using it in places where we know it does nothing. 721550 1 fpizlo 2012-09-15 22:29:29 -0700 As well, JSArray.cpp has one place where it does the same test but by comparing directly against 0xFFFFFFFF. It should really be comparing against MAX_ARRAY_INDEX. 721551 2 164308 fpizlo 2012-09-15 22:35:33 -0700 Created attachment 164308 the patch 721560 3 164308 webkit.review.bot 2012-09-16 00:22:24 -0700 Comment on attachment 164308 the patch Clearing flags on attachment: 164308 Committed r128706: <http://trac.webkit.org/changeset/128706> 721561 4 webkit.review.bot 2012-09-16 00:22:27 -0700 All reviewed patches have been landed. Closing bug. 164308 2012-09-15 22:35:33 -0700 2012-09-16 00:22:24 -0700 the patch maxarrayindex_patch_1.diff text/plain 3293 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4NzAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTA5LTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNPYmplY3QuY3BwIGFuZCBKU0FycmF5LmNwcCBoYXZlIGluY29uc2lzdGVudCB0ZXN0cyBmb3Ig dGhlIGludmFsaWQgYXJyYXkgaW5kZXggY2FzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY4NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHRoZSB1c2VzIG9mIFVOTElLRUxZKCkgYmVjYXVz ZSBJIGRvbid0IGJlbGlldmUgdGhleSBhcmUgYnV5aW5nIHVzIGFueXRoaW5nLAorICAgICAgICBz aW5jZSB3ZSdyZSBhbHJlYWR5IG9uIHRoZSBzbG93IHBhdGguIEFsc28gZm91bmQgb3RoZXIgcGxh Y2VzIHdoZXJlIHdlJ3JlIHRlc3RpbmcgZm9yCisgICAgICAgIHRoZSBpbnZhbGlkIGFycmF5IGlu ZGV4IGNhc2UgdXNpbmcgdW51c3VhbCBwcmVkaWNhdGVzIHJhdGhlciB0aGFuIGp1c3QgdXNpbmcK KyAgICAgICAgTUFYX0FSUkFZX0lOREVYLiBXaXRoIHRoaXMgY2hhbmdlLCBJIGJlbGlldmUgdGhh dCBhbGwgb2Ygb3VyIHRlc3RzIGZvciBpbnZhbGlkCisgICAgICAgIGFycmF5IGluZGljZXMgKGku ZS4gaW5kaWNlcyB0aGF0IHNob3VsZCBiZSB0cmVhdGVkIGFzIG5vbi1pbmRleGVkIHByb3BlcnRp ZXMpCisgICAgICAgIHVuaWZvcm1seSB1c2UgTUFYX0FSUkFZX0lOREVYIGFuZCBQcm9wZXJ0eU5h bWU6Ok5vdEFuSW5kZXguCisKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgorICAgICAg ICAoSlNDOjpKU0FycmF5OjpwdXNoKToKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoK KyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OnB1dEJ5SW5kZXgpOgorICAgICAgICAoSlNDOjpKU09i amVjdDo6ZGVmaW5lT3duSW5kZXhlZFByb3BlcnR5KToKKwogMjAxMi0wOS0xNSAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFN0cnVjdHVyZSBjaGVjayBob2lzdGlu ZyBmYWlscyB0byBjb25zaWRlciB0aGUgcG9zc2liaWxpdHkgb2YgY29uZmxpY3RpbmcgY2hlY2tz IG9uIHRoZSBzb3VyY2Ugb2YgdGhlIGZpcnN0IGFzc2lnbm1lbnQgdG8gdGhlIGhvaXN0ZWQgdmFy aWFibGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCShy ZXZpc2lvbiAxMjg2OTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDc3LDggKzQ3Nyw4IEBAIHZvaWQgSlNBcnJheTo6cHVz aChFeGVjU3RhdGUqIGV4ZWMsIEpTVmEKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQog Ci0gICAgICAgIC8vIFB1c2hpbmcgdG8gYW4gYXJyYXkgb2YgbGVuZ3RoIDJeMzItMSBzdG9yZXMg dGhlIHByb3BlcnR5LCBidXQgdGhyb3dzIGEgcmFuZ2UgZXJyb3IuCi0gICAgICAgIGlmIChVTkxJ S0VMWShzdG9yYWdlLT5sZW5ndGgoKSA9PSAweEZGRkZGRkZGdSkpIHsKKyAgICAgICAgLy8gUHVz aGluZyB0byBhbiBhcnJheSBvZiBpbnZhbGlkIGxlbmd0aCAoMl4zMS0xKSBzdG9yZXMgdGhlIHBy b3BlcnR5LCBidXQgdGhyb3dzIGEgcmFuZ2UgZXJyb3IuCisgICAgICAgIGlmIChzdG9yYWdlLT5s ZW5ndGgoKSA+IE1BWF9BUlJBWV9JTkRFWCkgewogICAgICAgICAgICAgbWV0aG9kVGFibGUoKS0+ cHV0QnlJbmRleCh0aGlzLCBleGVjLCBzdG9yYWdlLT5sZW5ndGgoKSwgdmFsdWUsIHRydWUpOwog ICAgICAgICAgICAgLy8gUGVyIEVTNS4xIDE1LjQuNC43IHN0ZXAgNiAmIDE1LjQuNS4xIHN0ZXAg My5kLgogICAgICAgICAgICAgaWYgKCFleGVjLT5oYWRFeGNlcHRpb24oKSkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHJldmlzaW9uIDEyODY5MSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzQ2LDcgKzM0Niw3IEBAIHZvaWQgSlNPYmplY3Q6OnB1dEJ5SW5kZXgoSlNDZWxs KiBjZWxsLCAKICAgICBKU09iamVjdCogdGhpc09iamVjdCA9IGpzQ2FzdDxKU09iamVjdCo+KGNl bGwpOwogICAgIHRoaXNPYmplY3QtPmNoZWNrSW5kZXhpbmdDb25zaXN0ZW5jeSgpOwogICAgIAot ICAgIGlmIChVTkxJS0VMWShwcm9wZXJ0eU5hbWUgPiBNQVhfQVJSQVlfSU5ERVgpKSB7CisgICAg aWYgKHByb3BlcnR5TmFtZSA+IE1BWF9BUlJBWV9JTkRFWCkgewogICAgICAgICBQdXRQcm9wZXJ0 eVNsb3Qgc2xvdChzaG91bGRUaHJvdyk7CiAgICAgICAgIHRoaXNPYmplY3QtPm1ldGhvZFRhYmxl KCktPnB1dCh0aGlzT2JqZWN0LCBleGVjLCBJZGVudGlmaWVyOjpmcm9tKGV4ZWMsIHByb3BlcnR5 TmFtZSksIHZhbHVlLCBzbG90KTsKICAgICAgICAgcmV0dXJuOwpAQCAtOTc5LDcgKzk3OSw3IEBA IHZvaWQgSlNPYmplY3Q6OnB1dEluZGV4ZWREZXNjcmlwdG9yKEV4ZWMKIC8vIERlZmluZWQgaW4g RVM1LjEgOC4xMi45CiBib29sIEpTT2JqZWN0OjpkZWZpbmVPd25JbmRleGVkUHJvcGVydHkoRXhl Y1N0YXRlKiBleGVjLCB1bnNpZ25lZCBpbmRleCwgUHJvcGVydHlEZXNjcmlwdG9yJiBkZXNjcmlw dG9yLCBib29sIHRocm93RXhjZXB0aW9uKQogewotICAgIEFTU0VSVChpbmRleCAhPSAweEZGRkZG RkZGKTsKKyAgICBBU1NFUlQoaW5kZXggPD0gTUFYX0FSUkFZX0lOREVYKTsKIAogICAgIGlmICgh aW5TcGFyc2VJbmRleGluZ01vZGUoKSkgewogICAgICAgICAvLyBGYXN0IGNhc2U6IHdlJ3JlIHB1 dHRpbmcgYSByZWd1bGFyIHByb3BlcnR5IHRvIGEgcmVndWxhciBhcnJheQo=