96874 2012-09-15 18:26:35 -0700 Teach style checker about #ifdef/#ifndef/#else/etc indentation rules 2012-09-17 11:26:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr abarth dpranke levin ojan webkit.review.bot oldest_to_newest 721514 0 pdr 2012-09-15 18:26:35 -0700 Our codebase has no instances of indented #ifdef/#ifndef. We should teach the style checker to enforce this. 721521 1 164302 pdr 2012-09-15 19:52:17 -0700 Created attachment 164302 Teach style checker about preprocessor directive indentation rules 722100 2 164302 webkit.review.bot 2012-09-17 11:25:57 -0700 Comment on attachment 164302 Teach style checker about preprocessor directive indentation rules Clearing flags on attachment: 164302 Committed r128782: <http://trac.webkit.org/changeset/128782> 722101 3 webkit.review.bot 2012-09-17 11:26:01 -0700 All reviewed patches have been landed. Closing bug. 164302 2012-09-15 19:52:17 -0700 2012-09-17 11:25:57 -0700 Teach style checker about preprocessor directive indentation rules 96874.1.patch text/plain 5334 pdr SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyODY5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDM2IEBACisyMDEyLTA5LTE1ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisK KyAgICAgICAgVGVhY2ggc3R5bGUgY2hlY2tlciBhYm91dCBwcmVwcm9jZXNzb3IgZGlyZWN0aXZl IGluZGVudGF0aW9uIHJ1bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05Njg3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFByZXByb2Nlc3NvciBkaXJlY3RpdmVzICgjaWZkZWYsICNpbmNsdWRlLCAjZGVm aW5lLCBldGMuKSBzaG91bGQgbm90IGJlIGluZGVudGVkLgorICAgICAgICBUaGlzIGlzIG5vdCBl eHBsaWNpdCBpbiBvdXIgc3R5bGUgZ3VpZGUgYnV0IGlzIGdlbmVyYWxseSBmb2xsb3dlZCBpbiBv dXIgY29kZS4KKyAgICAgICAgU2VhcmNoaW5nIGZvciB2aW9sYXRpb25zIGluIG91ciBjb2RlYmFz ZSBzaG93cyB0aGVzZSBhcmUgcmFyZWx5IGluZGVudGVkOgorICAgICAgICAgICAgI2luY2x1ZGUg LSBpbmRlbnRlZCBpbiA2IGZpbGVzCisgICAgICAgICAgICAjaWZkZWYgLSBpbmRlbnRlZCBpbiAw IGZpbGVzCisgICAgICAgICAgICAjaWZuZGVmIC0gaW5kZW50ZWQgaW4gMSBmaWxlCisgICAgICAg ICAgICAjZGVmaW5lIC0gaW5kZW50ZWQgaW4gMTEgZmlsZXMKKyAgICAgICAgICAgICNpZiAtIGlu ZGVudGVkIGluIDcgZmlsZXMKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfZGlyZWN0aXZlX2luZGVudGF0aW9uKToKKwor ICAgICAgICAgICAgVGhpcyBpcyB0aGUgc2ltcGxlIHRlc3Qgd2hlcmUgd2UgbG9vayBmb3Igc3Bh Y2VzIGZvbGxvd2VkIGJ5IGEgIy4KKworICAgICAgICAoY2hlY2tfc3R5bGUpOgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorCisgICAg ICAgICAgICBBIGZldyB0ZXN0cyBuZWVkZWQgdG8gYmUgbW9kaWZpZWQgYmVjYXVzZSB0aGV5IGhh ZCB1bmludGVudGlvbmFsbHkgaW5kZW50ZWQKKyAgICAgICAgICAgIHByZXByb2Nlc3NvciBkaXJl Y3RpdmVzLgorCisgICAgICAgIChDcHBTdHlsZVRlc3QudGVzdF9idWlsZF9jbGFzcy5Gb28pOgor ICAgICAgICAoQ3BwU3R5bGVUZXN0LnRlc3RfYnVpbGRfY2xhc3MpOgorICAgICAgICAoQ3BwU3R5 bGVUZXN0LnRlc3RfYnVpbGRfY2xhc3MuREVSSVZFX0ZST01fR09PKToKKyAgICAgICAgKFdlYktp dFN0eWxlVGVzdC50ZXN0X2xpbmVfYnJlYWtpbmcpOgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0 LnRlc3RfZGlyZWN0aXZlX2luZGVudGF0aW9uKToKKwogMjAxMi0wOS0xNCAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0OiAtLWFkZGl0aW9uYWwtcGxh dGZvcm0tZGlyIGlzIGJyb2tlbiBvbiBjaHJvbWl1bSBwb3J0cwpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkJKHJldmlzaW9uIDEyODY5MykKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CSh3b3JraW5nIGNv cHkpCkBAIC0yMDQwLDYgKzIwNDAsMjYgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlv bihjbGVhbl9saQogICAgICAgICAgICAgYnJlYWs7CiAKIAorZGVmIGNoZWNrX2RpcmVjdGl2ZV9p bmRlbnRhdGlvbihjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToK KyAgICAiIiJMb29rcyBmb3IgaW5kZW50YXRpb24gb2YgcHJlcHJvY2Vzc29yIGRpcmVjdGl2ZXMu CisKKyAgICBBcmdzOgorICAgICAgY2xlYW5fbGluZXM6IEEgQ2xlYW5zZWRMaW5lcyBpbnN0YW5j ZSBjb250YWluaW5nIHRoZSBmaWxlLgorICAgICAgbGluZV9udW1iZXI6IFRoZSBudW1iZXIgb2Yg dGhlIGxpbmUgdG8gY2hlY2suCisgICAgICBmaWxlX3N0YXRlOiBBIF9GaWxlU3RhdGUgaW5zdGFu Y2Ugd2hpY2ggbWFpbnRhaW5zIGluZm9ybWF0aW9uIGFib3V0CisgICAgICAgICAgICAgICAgICB0 aGUgc3RhdGUgb2YgdGhpbmdzIGluIHRoZSBmaWxlLgorICAgICAgZXJyb3I6IFRoZSBmdW5jdGlv biB0byBjYWxsIHdpdGggYW55IGVycm9ycyBmb3VuZC4KKyAgICAiIiIKKworICAgIGxpbmUgPSBj bGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICAjIEdldCByaWQgb2YgY29tbWVudHMgYW5k IHN0cmluZ3MuCisKKyAgICBpbmRlbnRlZF9wcmVwcm9jZXNzb3JfZGlyZWN0aXZlcyA9IG1hdGNo KHInXHMrIycsIGxpbmUpCisgICAgaWYgbm90IGluZGVudGVkX3ByZXByb2Nlc3Nvcl9kaXJlY3Rp dmVzOgorICAgICAgICByZXR1cm4KKworICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFj ZS9pbmRlbnQnLCA0LCAncHJlcHJvY2Vzc29yIGRpcmVjdGl2ZXMgKGUuZy4sICNpZmRlZiwgI2Rl ZmluZSwgI2ltcG9ydCkgc2hvdWxkIG5ldmVyIGJlIGluZGVudGVkLicpCisKKwogZGVmIGNoZWNr X3VzaW5nX3N0ZChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfc3RhdGUsIGVycm9yKToK ICAgICAiIiJMb29rcyBmb3IgJ3VzaW5nIHN0ZDo6Zm9vOycgc3RhdGVtZW50cyB3aGljaCBzaG91 bGQgYmUgcmVwbGFjZWQgd2l0aCAndXNpbmcgbmFtZXNwYWNlIHN0ZDsnLgogCkBAIC0yNTgxLDYg KzI2MDEsNyBAQCBkZWYgY2hlY2tfc3R5bGUoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyCiAKICAg ICAjIFNvbWUgbW9yZSBzdHlsZSBjaGVja3MKICAgICBjaGVja19uYW1lc3BhY2VfaW5kZW50YXRp b24oY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgZmlsZV9zdGF0ZSwg ZXJyb3IpCisgICAgY2hlY2tfZGlyZWN0aXZlX2luZGVudGF0aW9uKGNsZWFuX2xpbmVzLCBsaW5l X251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfdXNpbmdfc3RkKGNsZWFuX2xp bmVzLCBsaW5lX251bWJlciwgZmlsZV9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfbWF4X21pbl9t YWNyb3MoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRlLCBlcnJvcikKICAgICBj aGVja19jdHlwZV9mdW5jdGlvbnMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX3N0YXRl LCBlcnJvcikKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxMjg2OTMpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMjA4NiwxMyArMjA4NiwxMyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0 QmFzZSk6CiAgICAgICAgICMgSGVyZSBpcyBhbiBleGFtcGxlIHdoZXJlIHRoZSBsaW50ZXIgZ2V0 cyBjb25mdXNlZCwgZXZlbiB0aG91Z2gKICAgICAgICAgIyB0aGUgY29kZSBkb2Vzbid0IHZpb2xh dGUgdGhlIHN0eWxlIGd1aWRlLgogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQo Ci0gICAgICAgICAgICAnJydjbGFzcyBGb28KLSAgICAgICAgICAgICNpZmRlZiBERVJJVkVfRlJP TV9HT08KLSAgICAgICAgICAgICAgOiBwdWJsaWMgR29vIHsKLSAgICAgICAgICAgICNlbHNlCi0g ICAgICAgICAgICAgIDogcHVibGljIEhvbyB7Ci0gICAgICAgICAgICAjZW5kaWYKLSAgICAgICAg ICAgICAgfTsnJycsCisgICAgICAgICAgICAnY2xhc3MgRm9vXG4nCisgICAgICAgICAgICAnI2lm ZGVmIERFUklWRV9GUk9NX0dPT1xuJworICAgICAgICAgICAgJyAgICA6IHB1YmxpYyBHb28ge1xu JworICAgICAgICAgICAgJyNlbHNlXG4nCisgICAgICAgICAgICAnICAgIDogcHVibGljIEhvbyB7 XG4nCisgICAgICAgICAgICAnI2VuZGlmXG4nCisgICAgICAgICAgICAnfTsnLAogICAgICAgICAg ICAgJ0ZhaWxlZCB0byBmaW5kIGNvbXBsZXRlIGRlY2xhcmF0aW9uIG9mIGNsYXNzIEZvbycKICAg ICAgICAgICAgICcgIFtidWlsZC9jbGFzc10gWzVdJykKIApAQCAtMzgyMSw3ICszODIxLDcgQEAg Y2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ01v cmUgdGhhbiBvbmUgY29tbWFuZCBvbiB0aGUgc2FtZSBsaW5lICBbd2hpdGVzcGFjZS9uZXdsaW5l XSBbNF0nKQogICAgICAgICAjIElnbm9yZSBwcmVwcm9jZXNzb3IgaWYncy4KICAgICAgICAgc2Vs Zi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAotICAgICAgICAgICAgJyAgICAjaWYgKGNvbmRpdGlv bikgfHwgKGNvbmRpdGlvbjIpXG4nLAorICAgICAgICAgICAgJyNpZiAoY29uZGl0aW9uKSB8fCAo Y29uZGl0aW9uMilcbicsCiAgICAgICAgICAgICAnJykKIAogICAgICAgICAjIDIuIEFuIGVsc2Ug c3RhdGVtZW50IHNob3VsZCBnbyBvbiB0aGUgc2FtZSBsaW5lIGFzIGEgcHJlY2VkaW5nCkBAIC00 MzkxLDYgKzQzOTEsMTIgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2Up OgogICAgICAgICAgICAgJ2lmIChVTkxJS0VMWShmb28gPT0gTlVMTCkpJywKICAgICAgICAgICAg ICdVc2UgMCBpbnN0ZWFkIG9mIE5VTEwuICBbcmVhZGFiaWxpdHkvbnVsbF0gWzVdJykKIAorICAg IGRlZiB0ZXN0X2RpcmVjdGl2ZV9pbmRlbnRhdGlvbihzZWxmKToKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgKKyAgICAgICAgICAgICIgICAgI2lmIEZPTyIsCisgICAgICAgICAgICAicHJlcHJv Y2Vzc29yIGRpcmVjdGl2ZXMgKGUuZy4sICNpZmRlZiwgI2RlZmluZSwgI2ltcG9ydCkgc2hvdWxk IG5ldmVyIGJlIGluZGVudGVkLiIKKyAgICAgICAgICAgICIgIFt3aGl0ZXNwYWNlL2luZGVudF0g WzRdIiwKKyAgICAgICAgICAgICJmb28uY3BwIikKIAogICAgIGRlZiB0ZXN0X3VzaW5nX3N0ZChz ZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgK