96873 2012-09-15 18:20:52 -0700 Including HexNumber.h fails build if hexDigitsForMode is not referenced 2012-09-17 17:39:44 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96749 1 glenn glenn benjamin seikwon.kim webkit.review.bot oldest_to_newest 721513 0 glenn 2012-09-15 18:20:52 -0700 If HexNumber.h is included without expanding one of the templates that references hexDigitsForMode, then some release builds fail due to presence of unneeded internal declaration. For example, see [1]. Source/WTF/wtf/HexNumber.h:34:20: error: function 'hexDigitsForMode' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration,12] static const char* hexDigitsForMode(HexConversionMode mode) ^ 1 error generated. [1] http://build.webkit.org/builders/Apple%20Lion%20Release%20%28Build%29/builds/3900/steps/compile-webkit/logs/stdio 721515 1 164299 glenn 2012-09-15 18:28:11 -0700 Created attachment 164299 Patch 721534 2 164304 glenn 2012-09-15 21:34:43 -0700 Created attachment 164304 Patch 722385 3 164304 webkit.review.bot 2012-09-17 17:39:41 -0700 Comment on attachment 164304 Patch Clearing flags on attachment: 164304 Committed r128829: <http://trac.webkit.org/changeset/128829> 722386 4 webkit.review.bot 2012-09-17 17:39:44 -0700 All reviewed patches have been landed. Closing bug. 164299 2012-09-15 18:28:11 -0700 2012-09-15 21:34:38 -0700 Patch bug-96873-20120916092742.patch text/plain 1383 glenn U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Njc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDEzODljNWRiNjlkYzBlZjg1ZGE2ZTc2 M2Y3MjA2ZTRhNjYzOGE0YWIuLmIxZDBmOTAyNTczMWNlODJhZTMzNjcxYTg5ZGZmZWMyNzA2NWNi MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMTUgIEdsZW5uIEFkYW1zICA8Z2xlbm5A c2t5bmF2LmNvbT4KKworICAgICAgICBJbmNsdWRpbmcgSGV4TnVtYmVyLmggZmFpbHMgYnVpbGQg aWYgaGV4RGlnaXRzRm9yTW9kZSBpcyBub3QgcmVmZXJlbmNlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY4NzMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgcmVsZWFzZSBidWlsZCBpcyBwb3Nz aWJsZSB3aGVuIGhleERpZ2l0c0Zvck1vZGUgaXMgbm90IHJlZmVyZW5jZWQgYnkKKyAgICAgICAg dGVtcGxhdGUgZXhwYW5zaW9uLgorCisgICAgICAgICogd3RmL0hleE51bWJlci5oOgorICAgICAg ICAoV1RGOjpJbnRlcm5hbDo6aGV4RGlnaXRzRm9yTW9kZSk6CisgICAgICAgIENoYW5nZSBoZXhE aWdpdHNGb3JNb2RlIHRvIGlubGluZSAocmF0aGVyIHRoYW4gc3RhdGljKS4KKwogMjAxMi0wOS0x NCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBNaW5pbWl6 ZSBjb2xsaXNpb25zIHdoZW4gaGFzaGluZyBwYWlycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvSGV4TnVtYmVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9IZXhOdW1iZXIuaAppbmRleCA4ZmQ2MDMy M2IxMzU5OTA4ZGJlZjYzNTRlN2E0MzYxMWExNTFlM2QxLi4yZjM5OGYxMjBhMjE3ZDkyZDYxNmRj NjRjNTQ5YzA0ODIwZjlkZDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IZXhOdW1iZXIu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IZXhOdW1iZXIuaApAQCAtMzEsNyArMzEsNyBAQCBlbnVt IEhleENvbnZlcnNpb25Nb2RlIHsKIAogbmFtZXNwYWNlIEludGVybmFsIHsKIAotc3RhdGljIGNv bnN0IGNoYXIqIGhleERpZ2l0c0Zvck1vZGUoSGV4Q29udmVyc2lvbk1vZGUgbW9kZSkKK2lubGlu ZSBjb25zdCBjaGFyKiBoZXhEaWdpdHNGb3JNb2RlKEhleENvbnZlcnNpb25Nb2RlIG1vZGUpCiB7 CiAgICAgc3RhdGljIGNvbnN0IGNoYXIgbG93ZXJIZXhEaWdpdHNbMTddID0gIjAxMjM0NTY3ODlh YmNkZWYiOwogICAgIHN0YXRpYyBjb25zdCBjaGFyIHVwcGVySGV4RGlnaXRzWzE3XSA9ICIwMTIz NDU2Nzg5QUJDREVGIjsK 164304 2012-09-15 21:34:43 -0700 2012-09-17 17:39:41 -0700 Patch bug-96873-20120916123414.patch text/plain 1728 glenn U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Njc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDEzODljNWRiNjlkYzBlZjg1ZGE2ZTc2 M2Y3MjA2ZTRhNjYzOGE0YWIuLjkwN2FiN2MwOTNkMmJmY2M1OWY0ZDA1YzRmZjk2OWU0YmI4YzM2 NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDktMTUgIEdsZW5uIEFkYW1zICA8Z2xlbm5A c2t5bmF2LmNvbT4KKworICAgICAgICBJbmNsdWRpbmcgSGV4TnVtYmVyLmggZmFpbHMgYnVpbGQg aWYgaGV4RGlnaXRzRm9yTW9kZSBpcyBub3QgcmVmZXJlbmNlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY4NzMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgcmVsZWFzZSBidWlsZCBpcyBwb3Nz aWJsZSB3aGVuIGhleERpZ2l0c0Zvck1vZGUgaXMgbm90IHJlZmVyZW5jZWQgYnkKKyAgICAgICAg dGVtcGxhdGUgZXhwYW5zaW9uLgorCisgICAgICAgICogd3RmL0hleE51bWJlci5oOgorICAgICAg ICAoV1RGOjpJbnRlcm5hbDo6aGV4RGlnaXRzRm9yTW9kZSk6CisgICAgICAgIENoYW5nZSBoZXhE aWdpdHNGb3JNb2RlIHRvIGlubGluZSAocmF0aGVyIHRoYW4gc3RhdGljKS4gTWFrZSBzdHJpbmcg bGl0ZXJhbHMKKyAgICAgICAge2xvd2VyLHVwcGVyfUhleERpZ2l0cyBub24tbG9jYWwgYW5kIG5v bi1zdGF0aWMsIGJ1dCBjb25zdCwgdG8gd2hpY2ggdGhlIGxpbmtlcgorICAgICAgICBzaG91bGQg bWVyZ2UgcmVmZXJlbmNlcyBpbiB0aGUgUk8gZGF0YSBzZWdtZW50LgorCiAyMDEyLTA5LTE0ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE1pbmltaXplIGNv bGxpc2lvbnMgd2hlbiBoYXNoaW5nIHBhaXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9I ZXhOdW1iZXIuaCBiL1NvdXJjZS9XVEYvd3RmL0hleE51bWJlci5oCmluZGV4IDhmZDYwMzIzYjEz NTk5MDhkYmVmNjM1NGU3YTQzNjExYTE1MWUzZDEuLmExOThiOTJjZGUzNTMwOWFmMjRmNzE1Zjlk NmEzYzA4NTIyOWFjNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0hleE51bWJlci5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL0hleE51bWJlci5oCkBAIC0zMSwxMCArMzEsMTAgQEAgZW51bSBI ZXhDb252ZXJzaW9uTW9kZSB7CiAKIG5hbWVzcGFjZSBJbnRlcm5hbCB7CiAKLXN0YXRpYyBjb25z dCBjaGFyKiBoZXhEaWdpdHNGb3JNb2RlKEhleENvbnZlcnNpb25Nb2RlIG1vZGUpCitjb25zdCBj aGFyIGxvd2VySGV4RGlnaXRzWzE3XSA9ICIwMTIzNDU2Nzg5YWJjZGVmIjsKK2NvbnN0IGNoYXIg dXBwZXJIZXhEaWdpdHNbMTddID0gIjAxMjM0NTY3ODlBQkNERUYiOworaW5saW5lIGNvbnN0IGNo YXIqIGhleERpZ2l0c0Zvck1vZGUoSGV4Q29udmVyc2lvbk1vZGUgbW9kZSkKIHsKLSAgICBzdGF0 aWMgY29uc3QgY2hhciBsb3dlckhleERpZ2l0c1sxN10gPSAiMDEyMzQ1Njc4OWFiY2RlZiI7Ci0g ICAgc3RhdGljIGNvbnN0IGNoYXIgdXBwZXJIZXhEaWdpdHNbMTddID0gIjAxMjM0NTY3ODlBQkNE RUYiOwogICAgIHJldHVybiBtb2RlID09IExvd2VyY2FzZSA/IGxvd2VySGV4RGlnaXRzIDogdXBw ZXJIZXhEaWdpdHM7CiB9CiAK