9687 2006-07-01 22:40:05 -0700 WebKit needs to log CSS errors (like FireFox & FireBug do) 2014-01-13 09:06:42 -0800 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 19236 1 eric webkit-unassigned ap aroben bburg dev+webkit hyatt mrowe nickshanks simon.fraser oldest_to_newest 47952 0 eric 2006-07-01 22:40:05 -0700 WebKit needs to be able to log CSS errors (like FireFox & FireBug do) These should be logged any time a declaration is dropped, or a value is ignored. 55875 1 eric 2006-09-18 20:33:02 -0700 I looked at this very briefly. I would need to talk to hyatt to better understand where we might hook in. There are several places where you might want to throw CSS-related error messages, not all of which should have the same error information. Two examples: 1. parsing a stylesheet for a page. 2. setting a style value via javascript. Firefox handles case 1 quite nicely, but case 2 very poorly (it shows a useless error message). Ideally we would design a system to work across most if not all of the cases where the CSS parser should "throw errors". 55879 2 hyatt 2006-09-18 21:48:48 -0700 Errors basically break down into two classes I think... (1) Errors that bison would catch, e.g., bad tokens, bad combinations, etc. (2) Errors that cssparser.cpp would catch, i.e., grammatically well-formed properties that are simply illegal (wrong unit types, wrong # of arguments, etc.) (1) is pretty hard, since we often don't even handle those errors well for real. :) (2) is easier and probably where you'd get more bang for your buck anyway. 41742 3 mitz 2006-12-16 14:12:07 -0800 See also bug 7296. 39933 4 12000 eric 2006-12-24 07:40:54 -0800 Created attachment 12000 A hack to make this possible I don't really expect anyone to take this patch seriously. However it does address the issue at hand (and hopefully could start some small dialog on the subject). 39927 5 ap 2006-12-24 07:56:08 -0800 Do we also want to distinguish errors, warnings and messages, as Firefox does? 39921 6 ap 2006-12-24 08:22:43 -0800 Actually, this patch seems to match bug 10361 better. 39900 7 ggaren 2006-12-24 13:18:10 -0800 Doesn't this patch mean "only log JS errors?" 39864 8 eric 2006-12-24 16:36:40 -0800 Personally, I find Firefox's logging system a bit overly geeky. The point of only logging JS errors in my hack-patch, was to maintain the status-quo, as logging more than that might be a "UI decision". 39304 9 12000 darin 2006-12-27 22:38:29 -0800 Comment on attachment 12000 A hack to make this possible This doesn't seem necessary. I suggest we start logging more on the console, and later add levels and/or types based on our experience using the console. 86428 10 timothy 2008-07-19 14:26:03 -0700 *** Bug 14358 has been marked as a duplicate of this bug. *** 967044 11 bburg 2014-01-12 15:03:05 -0800 CSS errors and warnings are logged to console and highlighted in the CSS text editor in the current inspector. 967150 12 simon.fraser 2014-01-12 22:13:52 -0800 But not nearly enough of them. I think we only log syntax errors, right, and then only property names? What about: * invalid values * meaningless combinations of properties (e.g. z-index on non-positioned) * things with perf impact (negative text-indent without overflow:hidden) 967356 13 bburg 2014-01-13 09:06:42 -0800 Some invalid values are shown as crossed out in the CSS details sidebar, IIRC. The other things sound like audits to me. (I agree we need new audits, but each one in a separate bug.) In any case, I'm not sure that blasting the console with these errors/warnings is the right thing to do. Even with just parse errors today, the console gets filled with junk on popular websites. 12000 2006-12-24 07:40:54 -0800 2007-10-01 08:40:13 -0700 A hack to make this possible hack.patch text/plain 2110 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMTIt MjQgIEVyaWMgU2VpZGVsICA8ZXJpY0Blc2VpZGVsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05Njg3CisgICAgICAgIEFkZCBhYmlsaXR5IHRvIGxvZyBDU1MgZXJyb3JzIChs aWtlIEZpcmVmb3gvRmlyZWJ1ZyBkbykKKworICAgICAgICBBZGQgYSBoYWNrIHRvIG1ha2Ugbm9u LUpTIGxvZ2dpbmcgcG9zc2libGUuCisKKyAgICAgICAgKiBwYWdlL0Nocm9tZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDaHJvbWU6OmFkZE1lc3NhZ2VUb0NvbnNvbGUpOgorICAgICAgICAqIHBh Z2UvQ2hyb21lLmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWU6Oik6CisKIDIwMDYtMTItMjMg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEdlb2ZmLgpJbmRleDogcGFnZS9DaHJvbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvQ2hy b21lLmNwcAkocmV2aXNpb24gMTg0MDgpCisrKyBwYWdlL0Nocm9tZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE3NSw5ICsxNzUsMTAgQEAgdm9pZCBDaHJvbWU6OnNldFJlc2l6YWJsZShib29sIGIp IGNvbnN0CiAgICAgbV9jbGllbnQtPnNldFJlc2l6YWJsZShiKTsKIH0KIAotdm9pZCBDaHJvbWU6 OmFkZE1lc3NhZ2VUb0NvbnNvbGUoY29uc3QgU3RyaW5nICZtZXNzYWdlLCB1bnNpZ25lZCBsaW5l TnVtYmVyLCBjb25zdCBTdHJpbmcgJnNvdXJjZVVSTCkKK3ZvaWQgQ2hyb21lOjphZGRNZXNzYWdl VG9Db25zb2xlKGNvbnN0IFN0cmluZyAmbWVzc2FnZSwgdW5zaWduZWQgbGluZU51bWJlciwgY29u c3QgU3RyaW5nICZzb3VyY2VVUkwsIEVycm9yVHlwZSkKIHsKLSAgICBtX2NsaWVudC0+YWRkTWVz c2FnZVRvQ29uc29sZShtZXNzYWdlLCBsaW5lTnVtYmVyLCBzb3VyY2VVUkwpOworICAgIGlmIChF cnJvclR5cGUgPT0gSlNFcnJvcikKKyAgICAgICAgbV9jbGllbnQtPmFkZE1lc3NhZ2VUb0NvbnNv bGUobWVzc2FnZSwgbGluZU51bWJlciwgc291cmNlVVJMKTsKIH0KIAogYm9vbCBDaHJvbWU6OmNh blJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbCgpCkluZGV4OiBwYWdlL0Nocm9tZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHBhZ2UvQ2hyb21lLmgJKHJldmlzaW9uIDE4NDA4KQorKysgcGFnZS9DaHJvbWUu aAkod29ya2luZyBjb3B5KQpAQCAtNzIsOCArNzIsMTQgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICBib29sIG1lbnViYXJWaXNpYmxlKCkgY29uc3Q7CiAgICAgICAgIAogICAgICAgICB2 b2lkIHNldFJlc2l6YWJsZShib29sKSBjb25zdDsKKyAgICAgICAgCisgICAgICAgIGVudW0gRXJy b3JUeXBlIHsKKyAgICAgICAgICAgIEpTRXJyb3IsCisgICAgICAgICAgICBDU1NFcnJvciwKKyAg ICAgICAgICAgIFBhcnNlRXJyb3IKKyAgICAgICAgfTsKIAotICAgICAgICB2b2lkIGFkZE1lc3Nh Z2VUb0NvbnNvbGUoY29uc3QgU3RyaW5nJiBtZXNzYWdlLCB1bnNpZ25lZCBpbnQgbGluZU51bWJl ciwgY29uc3QgU3RyaW5nJiBzb3VyY2VJRCk7CisgICAgICAgIHZvaWQgYWRkTWVzc2FnZVRvQ29u c29sZShjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIHVuc2lnbmVkIGludCBsaW5lTnVtYmVyLCBjb25z dCBTdHJpbmcmIHNvdXJjZUlELCBFcnJvclR5cGUgPSBKU0Vycm9yKTsKIAogICAgICAgICBib29s IGNhblJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbCgpOwogICAgICAgICBib29sIHJ1bkJlZm9y ZVVubG9hZENvbmZpcm1QYW5lbChjb25zdCBTdHJpbmcmIG1lc3NhZ2UsIEZyYW1lKiBmcmFtZSk7 Cg==