96858 2012-09-15 01:07:24 -0700 JSC: Windows port needs a proper JSLock implementation 2012-09-15 23:31:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam levin+threading webkit.review.bot oldest_to_newest 721399 0 mark.lam 2012-09-15 01:07:24 -0700 Currently, the JSLock methods are implemented for platforms that support pthreads. As a result, the Windows port is only using a stub JSLock that does nothing. This stub implementation causes ASSERT(!m_apiLock.currentThreadIsHoldingLock()) (in JSGlobalData::~JSGlobalData()) to always fail. In addition, the stub JSLock implementation does not provide the needed synchronization, and as a result, the Windows port crashes or fails in intermittent ways when running the layout tests. 721401 1 mark.lam 2012-09-15 01:09:11 -0700 <rdar://problem/12297283> 721548 2 164307 mark.lam 2012-09-15 22:25:32 -0700 Created attachment 164307 Fix. 721557 3 mark.lam 2012-09-15 23:31:43 -0700 Committed r128704: <http://trac.webkit.org/changeset/128704> 164307 2012-09-15 22:25:32 -0700 2012-09-15 22:57:15 -0700 Fix. bug-96858.patch text/plain 5355 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4NzAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEyLTA5LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXhlZCBKU0xvY2sgdG8gdXNlIHRoZSBwbGF0Zm9ybSBhYnN0cmFjdGlvbiBmb3IgTXV0ZXggaW5z dGVhZCBvZgorICAgICAgICBkZXBlbmRpbmcgb24gcHRocmVhZHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njg1OC4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIGEgc3luY2hyb25pemF0 aW9uIHByb2JsZW0gb24gdGhlIFdpbmRvd3MgcG9ydCBhbmQgbWFrZXMKKyAgICAgICAgaXQgbW9y ZSByZWxpYWJsZSB3aGVuIHJ1bm5pbmcgdGhlIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHJ1 bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5jcHA6CisgICAgICAgIChKU0M6OmluaXRpYWxpemVU aHJlYWRpbmdPbmNlKToKKyAgICAgICAgKiBydW50aW1lL0pTTG9jay5jcHA6CisgICAgICAgIChK U0MpOgorICAgICAgICAoSlNDOjpHbG9iYWxKU0xvY2s6Okdsb2JhbEpTTG9jayk6CisgICAgICAg IChKU0M6Okdsb2JhbEpTTG9jazo6fkdsb2JhbEpTTG9jayk6CisgICAgICAgIChKU0M6Okdsb2Jh bEpTTG9jazo6aW5pdGlhbGl6ZSk6CisgICAgICAgICogcnVudGltZS9KU0xvY2suaDoKKyAgICAg ICAgKEdsb2JhbEpTTG9jayk6CisgICAgICAgIChKU0xvY2spOgorCiAyMDEyLTA5LTE1ICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgU3RydWN0dXJlIGNoZWNrIGhv aXN0aW5nIGZhaWxzIHRvIGNvbnNpZGVyIHRoZSBwb3NzaWJpbGl0eSBvZiBjb25mbGljdGluZyBj aGVja3Mgb24gdGhlIHNvdXJjZSBvZiB0aGUgZmlyc3QgYXNzaWdubWVudCB0byB0aGUgaG9pc3Rl ZCB2YXJpYWJsZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW5pdGlhbGl6 ZVRocmVhZGluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSW5pdGlhbGl6ZVRocmVhZGluZy5jcHAJKHJldmlzaW9uIDEyODcwMikKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSAiSWRlbnRpZmllci5oIgogI2luY2x1ZGUg IkpTRGF0ZU1hdGguaCIKICNpbmNsdWRlICJKU0dsb2JhbE9iamVjdC5oIgorI2luY2x1ZGUgIkpT TG9jay5oIgogI2luY2x1ZGUgIkxMSW50RGF0YS5oIgogI2luY2x1ZGUgIldyaXRlQmFycmllci5o IgogI2luY2x1ZGUgPHd0Zi9kdG9hLmg+CkBAIC01Myw2ICs1NCw3IEBAIHN0YXRpYyB2b2lkIGlu aXRpYWxpemVUaHJlYWRpbmdPbmNlKCkKIHsKICAgICBXVEY6OmRvdWJsZV9jb252ZXJzaW9uOjpp bml0aWFsaXplKCk7CiAgICAgV1RGOjppbml0aWFsaXplVGhyZWFkaW5nKCk7CisgICAgR2xvYmFs SlNMb2NrOjppbml0aWFsaXplKCk7CiAgICAgT3B0aW9uczo6aW5pdGlhbGl6ZSgpOwogI2lmIEVO QUJMRShXUklURV9CQVJSSUVSX1BST0ZJTElORykKICAgICBXcml0ZUJhcnJpZXJDb3VudGVyczo6 aW5pdGlhbGl6ZSgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNMb2Nr LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2su Y3BwCShyZXZpc2lvbiAxMjg3MDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0xvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMywyMSArMzMsMjEgQEAKIAogbmFtZXNwYWNl IEpTQyB7CiAKLS8vIEpTTG9jayBpcyBvbmx5IG5lZWRlZCB0byBzdXBwb3J0IGFuIG9ic29sZXRl IGV4ZWN1dGlvbiBtb2RlbCB3aGVyZSBKYXZhU2NyaXB0Q29yZQotLy8gYXV0b21hdGljYWxseSBw cm90ZWN0ZWQgYWdhaW5zdCBjb25jdXJyZW50IGFjY2VzcyBmcm9tIG11bHRpcGxlIHRocmVhZHMu Ci0vLyBTbyBpdCdzIHNhZmUgdG8gZGlzYWJsZSBpdCBvbiBub24tbWFjIHBsYXRmb3JtcyB3aGVy ZSB3ZSBkb24ndCBoYXZlIG5hdGl2ZSBwdGhyZWFkcy4KLSNpZiAoT1MoREFSV0lOKSB8fCBVU0Uo UFRIUkVBRFMpKQotCi1zdGF0aWMgcHRocmVhZF9tdXRleF90IHNoYXJlZEluc3RhbmNlTG9jayA9 IFBUSFJFQURfTVVURVhfSU5JVElBTElaRVI7CitNdXRleCogR2xvYmFsSlNMb2NrOjpzX3NoYXJl ZEluc3RhbmNlTG9jayA9IDA7CiAKIEdsb2JhbEpTTG9jazo6R2xvYmFsSlNMb2NrKCkKIHsKLSAg ICBwdGhyZWFkX211dGV4X2xvY2soJnNoYXJlZEluc3RhbmNlTG9jayk7CisgICAgc19zaGFyZWRJ bnN0YW5jZUxvY2stPmxvY2soKTsKIH0KIAogR2xvYmFsSlNMb2NrOjp+R2xvYmFsSlNMb2NrKCkK IHsKLSAgICBwdGhyZWFkX211dGV4X3VubG9jaygmc2hhcmVkSW5zdGFuY2VMb2NrKTsKKyAgICBz X3NoYXJlZEluc3RhbmNlTG9jay0+dW5sb2NrKCk7Cit9CisKK3ZvaWQgR2xvYmFsSlNMb2NrOjpp bml0aWFsaXplKCkKK3sKKyAgICBzX3NoYXJlZEluc3RhbmNlTG9jayA9IG5ldyBNdXRleCgpOwog fQogCiBKU0xvY2tIb2xkZXI6OkpTTG9ja0hvbGRlcihFeGVjU3RhdGUqIGV4ZWMpCkBAIC0yMTYs OTUgKzIxNiw0IEBAIEpTTG9jazo6RHJvcEFsbExvY2tzOjp+RHJvcEFsbExvY2tzKCkKICAgICBt X2dsb2JhbERhdGEtPmFwaUxvY2soKS5ncmFiQWxsTG9ja3MobV9sb2NrQ291bnQpOwogfQogCi0j ZWxzZSAvLyAoT1MoREFSV0lOKSB8fCBVU0UoUFRIUkVBRFMpKQotCi1HbG9iYWxKU0xvY2s6Okds b2JhbEpTTG9jaygpCi17Ci19Ci0KLUdsb2JhbEpTTG9jazo6fkdsb2JhbEpTTG9jaygpCi17Ci19 Ci0KLUpTTG9ja0hvbGRlcjo6SlNMb2NrSG9sZGVyKEpTR2xvYmFsRGF0YSopCi17Ci19Ci0KLUpT TG9ja0hvbGRlcjo6SlNMb2NrSG9sZGVyKEpTR2xvYmFsRGF0YSYpCi17Ci19Ci0KLUpTTG9ja0hv bGRlcjo6SlNMb2NrSG9sZGVyKEV4ZWNTdGF0ZSopCi17Ci19Ci0KLUpTTG9ja0hvbGRlcjo6fkpT TG9ja0hvbGRlcigpCi17Ci19Ci0KLUpTTG9jazo6SlNMb2NrKCkKLXsKLX0KLQotSlNMb2NrOjp+ SlNMb2NrKCkKLXsKLX0KLQotYm9vbCBKU0xvY2s6OmN1cnJlbnRUaHJlYWRJc0hvbGRpbmdMb2Nr KCkKLXsKLSAgICByZXR1cm4gdHJ1ZTsKLX0KLQotdm9pZCBKU0xvY2s6OmxvY2soKQotewotfQot Ci12b2lkIEpTTG9jazo6dW5sb2NrKCkKLXsKLX0KLQotdm9pZCBKU0xvY2s6OmxvY2soRXhlY1N0 YXRlKikKLXsKLX0KLQotdm9pZCBKU0xvY2s6OnVubG9jayhFeGVjU3RhdGUqKQotewotfQotCi12 b2lkIEpTTG9jazo6bG9jayhKU0dsb2JhbERhdGEmKQotewotfQotCi12b2lkIEpTTG9jazo6dW5s b2NrKEpTR2xvYmFsRGF0YSYpCi17Ci19Ci0KLXVuc2lnbmVkIEpTTG9jazo6ZHJvcEFsbExvY2tz KCkKLXsKLSAgICByZXR1cm4gMDsKLX0KLQotdW5zaWduZWQgSlNMb2NrOjpkcm9wQWxsTG9ja3NV bmNvbmRpdGlvbmFsbHkoKQotewotICAgIHJldHVybiAwOwotfQotCi12b2lkIEpTTG9jazo6Z3Jh YkFsbExvY2tzKHVuc2lnbmVkKQotewotfQotCi1KU0xvY2s6OkRyb3BBbGxMb2Nrczo6RHJvcEFs bExvY2tzKEV4ZWNTdGF0ZSopCi17Ci19Ci0KLUpTTG9jazo6RHJvcEFsbExvY2tzOjpEcm9wQWxs TG9ja3MoSlNHbG9iYWxEYXRhKikKLXsKLX0KLQotSlNMb2NrOjpEcm9wQWxsTG9ja3M6On5Ecm9w QWxsTG9ja3MoKQotewotfQotCi0jZW5kaWYgLy8gKE9TKERBUldJTikgfHwgVVNFKFBUSFJFQURT KSkKLQogfSAvLyBuYW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0xvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0xvY2suaAkocmV2aXNpb24gMTI4NzAyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNMb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDEwIEBAIG5hbWVzcGFj ZSBKU0MgewogICAgIHB1YmxpYzoKICAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgR2xvYmFsSlNM b2NrKCk7CiAgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIH5HbG9iYWxKU0xvY2soKTsKKworICAg ICAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplKCk7CisgICAgcHJpdmF0ZToKKyAgICAgICAgc3Rh dGljIE11dGV4KiBzX3NoYXJlZEluc3RhbmNlTG9jazsKICAgICB9OwogCiAgICAgY2xhc3MgSlNM b2NrSG9sZGVyIHsKQEAgLTkxLDEyICs5NSw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB1 bnNpZ25lZCBkcm9wQWxsTG9ja3NVbmNvbmRpdGlvbmFsbHkoKTsKICAgICAgICAgdm9pZCBncmFi QWxsTG9ja3ModW5zaWduZWQgbG9ja0NvdW50KTsKIAotICAgICAgICBTcGluTG9jayBtX3NwaW5M b2NrOwotICAgICAgICBNdXRleCBtX2xvY2s7Ci0gICAgICAgIFRocmVhZElkZW50aWZpZXIgbV9v d25lclRocmVhZDsKLSAgICAgICAgaW50cHRyX3QgbV9sb2NrQ291bnQ7Ci0gICAgICAgIHVuc2ln bmVkIG1fbG9ja0Ryb3BEZXB0aDsKLQogICAgICAgICBjbGFzcyBEcm9wQWxsTG9ja3MgewogICAg ICAgICAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRHJvcEFsbExvY2tzKTsKICAgICAgICAgcHVi bGljOgpAQCAtMTA4LDYgKzEwNiwxMyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIGlu dHB0cl90IG1fbG9ja0NvdW50OwogICAgICAgICAgICAgUmVmUHRyPEpTR2xvYmFsRGF0YT4gbV9n bG9iYWxEYXRhOwogICAgICAgICB9OworCisgICAgcHJpdmF0ZToKKyAgICAgICAgU3BpbkxvY2sg bV9zcGluTG9jazsKKyAgICAgICAgTXV0ZXggbV9sb2NrOworICAgICAgICBUaHJlYWRJZGVudGlm aWVyIG1fb3duZXJUaHJlYWQ7CisgICAgICAgIGludHB0cl90IG1fbG9ja0NvdW50OworICAgICAg ICB1bnNpZ25lZCBtX2xvY2tEcm9wRGVwdGg7CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UK