96846 2012-09-14 18:30:45 -0700 Tests failing on WK2 bots after giving fixed positioning its own stacking context 2012-09-17 12:52:27 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified OS X 10.8 RESOLVED FIXED P2 Normal --- 1 bdakin bdakin bdakin thorton webkit.review.bot oldest_to_newest 721299 0 bdakin 2012-09-14 18:30:45 -0700 Tests are failing on the WK2 bots after this change: https://bugs.webkit.org/show_bug.cgi?id=96688 http://trac.webkit.org/changeset/128652 They are failing because I checked in updated results that expect fixed positioning to create a stacking context. However, WebKitTestRunner does not enable ScrollingCoordinator, so the code that I added to enable stacking contexts for fixedPos is never actually running. 721301 1 164259 bdakin 2012-09-14 18:33:15 -0700 Created attachment 164259 Patch 721302 2 webkit.review.bot 2012-09-14 18:34:32 -0700 Attachment 164259 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:275: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 721305 3 164259 ggaren 2012-09-14 18:36:06 -0700 Comment on attachment 164259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164259&action=review r=me > Source/WebKit2/ChangeLog:13 > + actually running. This patch moves that code to a place where is will is => it > Source/WebKit2/ChangeLog:14 > + run for the testing tools, which matches the match for WK1. "the match for" 721308 4 bdakin 2012-09-14 18:38:01 -0700 Thank you! I fixed the typos and style problem: http://trac.webkit.org/changeset/128678 721406 5 thorton 2012-09-15 01:42:29 -0700 Beth, is it possible this broke the functionality of http://trac.webkit.org/changeset/128652? I see layers for position: fixed stuff on Google+ between 128652 and this patch, but not afterwards... 722191 6 ap 2012-09-17 12:52:27 -0700 This appears to have made other tests fail, bug 96945. Unlike what Tim is seeing, there are extra layers on the tests. 164259 2012-09-14 18:33:15 -0700 2012-09-14 18:36:06 -0700 Patch for-review.txt text/plain 3900 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODY3NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTY4NDYKKyAgICAgICAgVGVzdHMgZmFpbGluZyBvbiBXSzIgYm90 cyBhZnRlciBnaXZpbmcgZml4ZWQgcG9zaXRpb25pbmcgaXRzIG93biAKKyAgICAgICAgc3RhY2tp bmcgY29udGV4dAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3RzIGFyZSBmYWlsaW5nIGJlY2F1c2UgSSBjaGVja2VkIGluIHVwZGF0ZWQgcmVzdWx0 cyB0aGF0IGV4cGVjdCAKKyAgICAgICAgZml4ZWQgcG9zaXRpb25pbmcgdG8gY3JlYXRlIGEgc3Rh Y2tpbmcgY29udGV4dC4gSG93ZXZlciwgCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgZG9lcyBu b3QgZW5hYmxlIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLCBzbyB0aGUgY29kZSAKKyAgICAgICAgdGhh dCBJIGFkZGVkIHRvIGVuYWJsZSBzdGFja2luZyBjb250ZXh0cyBmb3IgZml4ZWRQb3MgaXMgbmV2 ZXIgCisgICAgICAgIGFjdHVhbGx5IHJ1bm5pbmcuIFRoaXMgcGF0Y2ggbW92ZXMgdGhhdCBjb2Rl IHRvIGEgcGxhY2Ugd2hlcmUgaXMgd2lsbCAKKyAgICAgICAgcnVuIGZvciB0aGUgdGVzdGluZyB0 b29scywgd2hpY2ggbWF0Y2hlcyB0aGUgbWF0Y2ggZm9yIFdLMS4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2lu Z0FyZWFJbXBsOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbToKKyAgICAgICAgKFdlYktp dDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OlRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhKToKKwogMjAxMi0wOS0xNCAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjEyNzQ1NyBhbmQgZm9sbG93aW5nIGZpeGVzIGR1 ZSB0byBzZXZlcmFsIGhpdC10ZXN0aW5nIHJlZ3Jlc3Npb25zCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcAkocmV2 aXNpb24gMTI4NjQ3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdp bmdBcmVhSW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2MSwxMiArMjYxLDE4IEBAIHZvaWQg RHJhd2luZ0FyZWFJbXBsOjpzZXRQYWludGluZ0VuYWJsZWQKIAogdm9pZCBEcmF3aW5nQXJlYUlt cGw6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0b3JlKQog eworI2lmIFBMQVRGT1JNKE1BQykKKyAgICAvLyBTb29uIHdlIHdhbnQgcGFnZXMgd2l0aCBmaXhl ZCBwb3NpdGlvbmVkIGVsZW1lbnRzIHRvIGJlIGFibGUgdG8gYmUgc2Nyb2xsZWQgYnkgdGhlIFNj cm9sbGluZ0Nvb3JkaW5hdG9yLgorICAgIC8vIEFzIGEgcGFydCBvZiB0aGF0IHdvcmssIHdlIGhh dmUgdG8gY29tcG9zaXRlIGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzLCBhbmQgd2UgaGF2ZSB0byBh bGxvdyB0aG9zZQorICAgIC8vIGVsZW1lbnRzIHRvIGNyZWF0ZSBhIHN0YWNraW5nIGNvbnRleHQu CisgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBY2NlbGVyYXRlZENv bXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQodHJ1ZSk7CisgICAgbV93ZWJQYWdlLT5j b3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29u dGV4dCh0cnVlKTsKKwogICAgIC8vIDxyZGFyOi8vcHJvYmxlbS8xMDY5NzQxNz46IEl0IGlzIG5l Y2Vzc2FyeSB0byBmb3JjZSBjb21wb3NpdGluZyB3aGVuIGFjY2VsZXJhdGUgZHJhd2luZwogICAg IC8vIGlzIGVuYWJsZWQgb24gTWFjIHNvIHRoYXQgc2Nyb2xsYmFycyBhcmUgYWx3YXlzIGluIHRo ZWlyIG93biBsYXllcnMuCi0jaWYgUExBVEZPUk0oTUFDKQotICAgIGlmIChtX3dlYlBhZ2UtPmNv cmVQYWdlKCktPnNldHRpbmdzKCktPmFjY2VsZXJhdGVkRHJhd2luZ0VuYWJsZWQoKSkKKyAgICBp ZiAobV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5hY2NlbGVyYXRlZERyYXdpbmdF bmFibGVkKCkpIHsKICAgICAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5z ZXRGb3JjZUNvbXBvc2l0aW5nTW9kZShMYXllclRyZWVIb3N0OjpzdXBwb3J0c0FjY2VsZXJhdGVk Q29tcG9zaXRpbmcoKSk7Ci0gICAgZWxzZQorICAgIH0gZWxzZQogI2VuZGlmCiAgICAgICAgIG1f d2ViUGFnZS0+Y29yZVBhZ2UoKS0+c2V0dGluZ3MoKS0+c2V0Rm9yY2VDb21wb3NpdGluZ01vZGUo c3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5Ojpmb3JjZUNvbXBvc2l0 aW5nTW9kZUtleSgpKSAmJiBMYXllclRyZWVIb3N0OjpzdXBwb3J0c0FjY2VsZXJhdGVkQ29tcG9z aXRpbmcoKSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0Fy ZWEubW0JKHJldmlzaW9uIDEyODY1MikKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0JKHdvcmtpbmcgY29weSkK QEAgLTc2LDEyICs3Niw2IEBAIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpUaWxlZENv cmUKICAgICBwYWdlLT5zZXR0aW5ncygpLT5zZXRTY3JvbGxpbmdDb29yZGluYXRvckVuYWJsZWQo dHJ1ZSk7CiAgICAgcGFnZS0+c2V0dGluZ3MoKS0+c2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1 ZSk7CiAKLSAgICAvLyBTb29uIHdlIHdhbnQgcGFnZXMgd2l0aCBmaXhlZCBwb3NpdGlvbmVkIGVs ZW1lbnRzIHRvIGJlIGFibGUgdG8gYmUgc2Nyb2xsZWQgYnkgdGhlIFNjcm9sbGluZ0Nvb3JkaW5h dG9yLgotICAgIC8vIEFzIGEgcGFydCBvZiB0aGF0IHdvcmssIHdlIGhhdmUgdG8gY29tcG9zaXRl IGZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzLCBhbmQgd2UgaGF2ZSB0byBhbGxvdyB0aG9zZQotICAg IC8vIGVsZW1lbnRzIHRvIGNyZWF0ZSBhIHN0YWNraW5nIGNvbnRleHQuCi0gICAgcGFnZS0+c2V0 dGluZ3MoKS0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvckZpeGVkUG9zaXRpb25FbmFibGVk KHRydWUpOwotICAgIHBhZ2UtPnNldHRpbmdzKCktPnNldEZpeGVkUG9zaXRpb25DcmVhdGVzU3Rh Y2tpbmdDb250ZXh0KHRydWUpOwotCiAgICAgV2ViUHJvY2Vzczo6c2hhcmVkKCkuZXZlbnREaXNw YXRjaGVyKCkuYWRkU2Nyb2xsaW5nVHJlZUZvclBhZ2Uod2ViUGFnZSk7CiAKICAgICBtX3Jvb3RM YXllciA9IFtDQUxheWVyIGxheWVyXTsK